From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 12:33:00 2018 Received: (at submit) by debbugs.gnu.org; 14 Apr 2018 16:33:00 +0000 Received: from localhost ([127.0.0.1]:52538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7O6l-0002nE-Rc for submit@debbugs.gnu.org; Sat, 14 Apr 2018 12:33:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7O6j-0002n2-MB for submit@debbugs.gnu.org; Sat, 14 Apr 2018 12:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7O6d-00049g-Ac for submit@debbugs.gnu.org; Sat, 14 Apr 2018 12:32:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35981) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f7O6d-00049X-6x for submit@debbugs.gnu.org; Sat, 14 Apr 2018 12:32:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7O6b-0008Pe-PS for guix-patches@gnu.org; Sat, 14 Apr 2018 12:32:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7O6X-00046W-R5 for guix-patches@gnu.org; Sat, 14 Apr 2018 12:32:49 -0400 Received: from mout01.posteo.de ([185.67.36.65]:46904) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f7O6X-000414-Ei for guix-patches@gnu.org; Sat, 14 Apr 2018 12:32:45 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id B68A2210A4 for ; Sat, 14 Apr 2018 18:32:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1523723555; bh=cL06rWLHSwTenrDOIhYVZ52YiEokyAxMpprl31h9fGI=; h=From:To:Cc:Subject:Date:From; b=rz2qOvizH4hcP1QBNvB2TWDB3DeT8bJp7QRe2kaLdiDQUqlpzKXaf3UBhNAJs/Riu AYAr/g+q6VNBTk+HGtE/VIhxLDqqh5u873NgEVgUY32LKwwsTXoN1MYgaWcSpjWrf6 YkfQkY9SDt9oXrt6cBZzJe/UciVNyUjIG1osy9qMa0vg7MFMbZ2RkJ/cp8nky9Pmq8 sxKDJfZGjC+cbDOCy2rGytXW0kH6DyvoboXUn9T6exsSwXr1HxqVXNtAPSmEqsFVdg hsY00aE4v20hCmjaVxHRN8oZTCOq8HVQvxVKLqOmmzvOTRBdUWl9Rz+/LYvNv3DP2h oRHfucxfpfC+Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 40NgD243Nzz9rxQ; Sat, 14 Apr 2018 18:32:34 +0200 (CEST) From: Kei Kebreau To: guix-patches@gnu.org Subject: [PATCH] gnu: nestopia-ue: Update to 1.48. Date: Sat, 14 Apr 2018 12:32:26 -0400 Message-Id: <20180414163226.20403-1-kkebreau@posteo.net> X-Mailer: git-send-email 2.16.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48. [source]: Simplify snippet. [build-system]: Switch to cmake-build-system. [inputs]: Remove glu and mesa. Add libepoxy. [arguments]: Remove modified phases. --- gnu/packages/emulators.scm | 31 ++++++------------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm index 1784111cd..2e825d930 100644 --- a/gnu/packages/emulators.scm +++ b/gnu/packages/emulators.scm @@ -992,7 +992,7 @@ towards a working Mupen64Plus for casual users.") (define-public nestopia-ue (package (name "nestopia-ue") - (version "1.47") + (version "1.48") (source (origin (method url-fetch) (uri (string-append @@ -1001,43 +1001,24 @@ towards a working Mupen64Plus for casual users.") (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "1dzrrjmvyqks64q5l5pfly80jb6qcsbj5b3dm40fijd5xnpbapci")) + "184y05z4k4a4m4022niy625kan0rklh8gcxyynxli1fss2sjjrpv")) (modules '((guix build utils))) (snippet '(begin ;; We don't need libretro for the GNU/Linux build. - (delete-file-recursively "libretro") - ;; Use system zlib. - (delete-file-recursively "source/zlib") - (substitute* "source/core/NstZlib.cpp" - (("#include \"../zlib/zlib.h\"") "#include ")))))) - (build-system gnu-build-system) + (delete-file-recursively "libretro"))))) + (build-system cmake-build-system) (native-inputs `(("pkg-config" ,pkg-config))) (inputs `(("ao" ,ao) - ("glu" ,glu) ("gtk+" ,gtk+) ("libarchive" ,libarchive) - ("mesa" ,mesa) + ("libepoxy" ,libepoxy) ("sdl2" ,sdl2) ("zlib" ,zlib))) (arguments - '(#:phases - (modify-phases %standard-phases - ;; The Nestopia build system consists solely of a Makefile. - (delete 'configure) - (add-before 'build 'remove-xdg-desktop-menu-call - (lambda _ - (substitute* "Makefile" - (("xdg-desktop-menu install .*") "")))) - (add-before 'build 'remove-gdkwayland-include - (lambda _ - (substitute* "source/unix/gtkui/gtkui.h" - (("#include ") ""))))) - #:make-flags (let ((out (assoc-ref %outputs "out"))) - (list "CC=gcc" "CXX=g++" (string-append "PREFIX=" out))) - ;; There are no tests. + '(;; There are no tests. #:tests? #f)) (home-page "http://0ldsk00l.ca/nestopia/") (synopsis "Nintendo Entertainment System (NES/Famicom) emulator") -- 2.16.3 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 16 18:17:07 2018 Received: (at 31153) by debbugs.gnu.org; 16 Apr 2018 22:17:07 +0000 Received: from localhost ([127.0.0.1]:56375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8CQt-0000Ew-FU for submit@debbugs.gnu.org; Mon, 16 Apr 2018 18:17:07 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8CQr-0000En-KL for 31153@debbugs.gnu.org; Mon, 16 Apr 2018 18:17:05 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5DC7321D56; Mon, 16 Apr 2018 18:17:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 16 Apr 2018 18:17:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=9zYEdur2qPNuenxRQW0l26cyJWeJ/AJ3MCNIhQMHFs0=; b=Iyi9E1qL NRv5eMV0bZMYMhz7JYYHpgqdDKRg9N1X0PXV5fbFe1Ua/G8UPA9nTHFDqF5gJIFZ yAAfEjppxxH8NfZ1JB0cPpd+Z76dVxjYz4x06hCSsMraqKIVpSqbfKMoc/nqjULX Xd69cVwvSXyN3e4I8Z+5LZum26QC+KGaaZjqZs+amAmbQt97pXEEv6Esn/NjNVNZ PcE4MwhPSDytMHOLPlSzPTg7mE89h6lc4umrQprWb0rMW7ZcLJSlaVD9fulC/GX6 U708gQFQvqRhCpR/w9P9pBS6ivIp58pULuhdQb4LHOLEDwWEz+myd0nd7MGstSpy gEuI7l+tQZ9Slw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=9zYEdur2qPNuenxRQW0l26cyJWeJ/ AJ3MCNIhQMHFs0=; b=Hy1uz0309gT6dmk22X+T/4k+PfXos9++y50VG+KYLqCnS DXf86sAd2jW9bHlCrh7rUHPqQUbFMfjolkT35K7XT9tzaXzC+OiTrIq9cBt4fc2j n9Sk0ngMHNbHZGh5Iu1KU9M/voZ3kdkmda0Fr3dyAI6aTlmqHFVfj4Slh6HeOWc3 gsJpgoxrRIf4FwE/qA7ShTMkaSEIlpt3jv5MJZ+rCCmXjHLTrsslVhwnb8XtQ8/i 8F9wfisp2crH6pOUFi0WjuNnqtc4dh6BWukGB1QejejPWdarjrNzzjqcKccTr6A2 ysfnEX8vnuBsE85QrFg4/ny/ITZVlm7+7WC5KVzQA== X-ME-Sender: Received: from localhost (ti0089a400-2222.bb.online.no [88.89.166.190]) by mail.messagingengine.com (Postfix) with ESMTPA id D3D18E4394; Mon, 16 Apr 2018 18:17:04 -0400 (EDT) From: Marius Bakke To: Kei Kebreau , 31153@debbugs.gnu.org Subject: Re: [bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48. In-Reply-To: <20180414163226.20403-1-kkebreau@posteo.net> References: <20180414163226.20403-1-kkebreau@posteo.net> User-Agent: Notmuch/0.26.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Apr 2018 00:17:03 +0200 Message-ID: <87h8oadcf4.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31153 Cc: Kei Kebreau X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Kei Kebreau writes: > * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48. > [source]: Simplify snippet. > [build-system]: Switch to cmake-build-system. > [inputs]: Remove glu and mesa. Add libepoxy. > [arguments]: Remove modified phases. [...] > (modules '((guix build utils))) > (snippet > '(begin > ;; We don't need libretro for the GNU/Linux build. > - (delete-file-recursively "libretro") > - ;; Use system zlib. > - (delete-file-recursively "source/zlib") > - (substitute* "source/core/NstZlib.cpp" > - (("#include \"../zlib/zlib.h\"") "#include ")))))) > - (build-system gnu-build-system) > + (delete-file-recursively "libretro"))))) > + (build-system cmake-build-system) The commit message says 'simplify snippet', but the actual change is to not delete the zlib subfolder. Is zlib no longer bundled? If so, please mention that in the commit message. Apart from that LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlrVIN8ACgkQoqBt8qM6 VPpBLwf+MmfnOm7eK+spQtZX+EHaESwuovf5IRLlPk3aRqygN+l8BGYfmY/0fh9j 6OGeYIZzoWNp0y2Mj0jqHYQ3cJ+jBeSWFT1bNgYQor2JaVIY1IanvO6QjP+FUmr6 M1jAaKLo02EMBZh6cQyQkc0iqLiYdoTQJzwSyKKL+Ecqu4CSoxeLr4DsA2cNWmMI bLvT3zaZOzvB6MG0IVfwZZDyVMsKUJJZHapsuKpkcOCQ4m0JAiLVsufGriwAq/Ds g88EevGqnfSllA2qFORcXWgS1s7ZQfGVQtp1EH0rwHLzZYeZvS3Yv5+SnUId+NTT WG9bOWc+OZNP+s8sk5KBIO/GEtfHgQ== =Y2bu -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 16 23:32:37 2018 Received: (at 31153) by debbugs.gnu.org; 17 Apr 2018 03:32:37 +0000 Received: from localhost ([127.0.0.1]:56532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8HMC-000392-LD for submit@debbugs.gnu.org; Mon, 16 Apr 2018 23:32:37 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8HMA-00038o-0l for 31153@debbugs.gnu.org; Mon, 16 Apr 2018 23:32:34 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 9CB3A20C6C for <31153@debbugs.gnu.org>; Tue, 17 Apr 2018 05:32:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1523935947; bh=J4D2zz1v4MQOXCJxE0T62dhrzhRpU6fpj4t4UzYnkzA=; h=From:To:Cc:Subject:Date:From; b=CwQNqERgq2+1p7ETo6zrPLnSPfYja5GNCqNnN5RoLB5YS5upYX6rWZWN7Pn66DzOD BbBI94fEKEdGQbHay4hgaz0KvIf5bSgbU84gaXSKyb5Z7M+1u3q6nkh8EhKVx7AP2g k4vaLAYAUjGkEJail8pB0dq7X+P1cp6E+QhFaLxtXdzcGG0w0ecmJOj1VKDdwuUBJ+ nSdkQ3Ab/ZkCvREbQdxXc6AjzRnkwHg+w7F5fO2d3HaJ5I02wkr1eW68qlkSstw8OS ++eZDlbifDJUHFI5RGZzS664VQ7I1b+iea6PugZ02MPPqYjRwiLGUM75XijuZK6uHf btQm0PTR0O82A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 40Q9mV1Cl4z9rxG; Tue, 17 Apr 2018 05:32:25 +0200 (CEST) From: Kei Kebreau To: Marius Bakke Subject: Re: [bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48. References: <20180414163226.20403-1-kkebreau@posteo.net> <87h8oadcf4.fsf@fastmail.com> Date: Mon, 16 Apr 2018 23:32:23 -0400 In-Reply-To: <87h8oadcf4.fsf@fastmail.com> (Marius Bakke's message of "Tue, 17 Apr 2018 00:17:03 +0200") Message-ID: <87y3hm4iew.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31153 Cc: 31153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Marius Bakke writes: > Kei Kebreau writes: > >> * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48. >> [source]: Simplify snippet. >> [build-system]: Switch to cmake-build-system. >> [inputs]: Remove glu and mesa. Add libepoxy. >> [arguments]: Remove modified phases. > > [...] > >> (modules '((guix build utils))) >> (snippet >> '(begin >> ;; We don't need libretro for the GNU/Linux build. >> - (delete-file-recursively "libretro") >> - ;; Use system zlib. >> - (delete-file-recursively "source/zlib") >> - (substitute* "source/core/NstZlib.cpp" >> - (("#include \"../zlib/zlib.h\"") "#include ")))))) >> - (build-system gnu-build-system) >> + (delete-file-recursively "libretro"))))) >> + (build-system cmake-build-system) > > The commit message says 'simplify snippet', but the actual change is to > not delete the zlib subfolder. Is zlib no longer bundled? If so, > please mention that in the commit message. > > Apart from that LGTM. Thank you for reviewing this! I've attached a revised patch with some other small but necessary changes that I overlooked the first time around. If the patch below looks good, then I will push it to master. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=0001-gnu-nestopia-ue-Update-to-1.48.patch Content-Transfer-Encoding: quoted-printable From=207738c755edc7dec075090e567a53f1f05df05e53 Mon Sep 17 00:00:00 2001 From: Kei Kebreau Date: Sat, 7 Apr 2018 00:11:39 -0400 Subject: [PATCH] gnu: nestopia-ue: Update to 1.48. To: guix-patches@gnu.org * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48. [source]: Simplify snippet; 3rd-party zlib is no longer bundled. [build-system]: Switch to cmake-build-system. [inputs]: Remove glu and mesa. Add libepoxy. [arguments]: Remove #:make-flags. Re-enable 'configure' phase. Remove 'remove-xdg-desktop-menu-call' and 'remove-gdkwayland-include' phases. Add 'wrap-program' phase. =2D-- gnu/packages/emulators.scm | 36 ++++++++++++++---------------------- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm index 232e14b47..79947059b 100644 =2D-- a/gnu/packages/emulators.scm +++ b/gnu/packages/emulators.scm @@ -993,7 +993,7 @@ towards a working Mupen64Plus for casual users.") (define-public nestopia-ue (package (name "nestopia-ue") =2D (version "1.47") + (version "1.48") (source (origin (method url-fetch) (uri (string-append @@ -1002,42 +1002,34 @@ towards a working Mupen64Plus for casual users.") (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 =2D "1dzrrjmvyqks64q5l5pfly80jb6qcsbj5b3dm40fijd5xnpbapci")) + "184y05z4k4a4m4022niy625kan0rklh8gcxyynxli1fss2sjjrpv")) (modules '((guix build utils))) (snippet '(begin ;; We don't need libretro for the GNU/Linux build. =2D (delete-file-recursively "libretro") =2D ;; Use system zlib. =2D (delete-file-recursively "source/zlib") =2D (substitute* "source/core/NstZlib.cpp" =2D (("#include \"../zlib/zlib.h\"") "#include "= )))))) =2D (build-system gnu-build-system) + (delete-file-recursively "libretro"))))) + (build-system cmake-build-system) (native-inputs `(("pkg-config" ,pkg-config))) (inputs `(("ao" ,ao) =2D ("glu" ,glu) ("gtk+" ,gtk+) ("libarchive" ,libarchive) =2D ("mesa" ,mesa) + ("libepoxy" ,libepoxy) ("sdl2" ,sdl2) ("zlib" ,zlib))) (arguments '(#:phases (modify-phases %standard-phases =2D ;; The Nestopia build system consists solely of a Makefile. =2D (delete 'configure) =2D (add-before 'build 'remove-xdg-desktop-menu-call =2D (lambda _ =2D (substitute* "Makefile" =2D (("xdg-desktop-menu install .*") "")))) =2D (add-before 'build 'remove-gdkwayland-include =2D (lambda _ =2D (substitute* "source/unix/gtkui/gtkui.h" =2D (("#include ") ""))))) =2D #:make-flags (let ((out (assoc-ref %outputs "out"))) =2D (list "CC=3Dgcc" "CXX=3Dg++" (string-append "PREFI= X=3D" out))) + ;; This fixes the file chooser crash that happens with GTK 3. + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (nestopia (string-append out "/bin/nestopia")) + (gtk (assoc-ref inputs "gtk+")) + (gtk-share (string-append gtk "/share"))) + (wrap-program nestopia + `("XDG_DATA_DIRS" ":" prefix (,gtk-share))))))) ;; There are no tests. #:tests? #f)) (home-page "http://0ldsk00l.ca/nestopia/") =2D-=20 2.17.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlrVasgACgkQ5qXuPBlG eg1drxAAoYv4RLptdeYXzjnEbRsFVySp/bDtc3q0siE3lSrOC5aUAEUPmYcDQDcf lTvisIST7FjBGCGrSg9kqG1BeKvZHDt/uNtUPQfaB98rXj4QSuSBoo1h1Xvbuwmo vuYTLE1Tzvhhq4jaF6jfy2ZRjiunEZ1RXMBIvw2H3EaXZ10qR7m/o8vBSrpqfPrb FVTMXcTTXVZI00qaIvC68CgqCyq88kc6U5HS4NkvRVdVmfEcr9ykC6Q/KBSCYyAE 0g7jwwJJ55w5vra+ruuLV/Qkn96IgwLGxm/UsqtWij5ukT6qUPsNzUAE9P63Anqs Dfubjpa15YUoPln4K8gftvYmFL4YQTT7xF5OSrv5PlXowQ6Q3FB1OtBo2zBTua5Y D/xCQ1gocLvBevVT1WNRExKh6wH1GMypL+tEjtpb28VOP1wcsgL/t4jdiUIuJ8XZ XSBv1SVXnv4dr+b7/9YRQWb8mRplfs9GnlMPJ4arif4B70mGEMWt4l7UvX8utD+g c0ODtCKB7LUhMe87WtMiCZc5QCitjsJc5VbF0nteXoUalGaHu91/1TMoPXo8Jwh5 Me+Nj1YUy5XciZst82jw3Y/kP6PmH0xNkqoFcz2f5Lqy7siXR5adRjxsC1hz23Mj bXjK+m/lbe0PthaDBo6ls6YYp6BdWiluwQC5MRKt7RBJA318qps= =kVxl -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 18:37:02 2018 Received: (at 31153) by debbugs.gnu.org; 17 Apr 2018 22:37:02 +0000 Received: from localhost ([127.0.0.1]:58163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZDh-0007Q5-WC for submit@debbugs.gnu.org; Tue, 17 Apr 2018 18:37:02 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ZDg-0007Pl-NY for 31153@debbugs.gnu.org; Tue, 17 Apr 2018 18:37:01 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 034E121F71; Tue, 17 Apr 2018 18:37:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 17 Apr 2018 18:37:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=oSaMPziXNv0QavtE9dxpCkeSqKwwOwnWHRuRvdOny9E=; b=oixzZgnN p6qdTlPeSQikvVlVvApZC74ttvA2tCSwN1AKPQho2b7VmZq+NCI95Do9JDH+4fx7 wr42aQGukCyWwRhgTedKniTl4u3aGrCOpleKLOYId06wTqf12QFOOxK2e/GAo5ii ln44F/T99Mtw8QmzHGYTJ0Zt14YkYdWgAwaEkxsLR6EswNy6JFxoPGH8DIDIWydw cHgLGHYM9WbTsvW3kObVY+NeWLw5dsw1PvAl1QWRilF3Cwdpb33f+tvJGMdNyG7R 9ukxLz3Z89EwClVApsd+V0RwgK2dqsnbmbp5cxU8PPv2boMPeLcc7v3byQYLspPT rlNVtMD6KLV87g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=oSaMPziXNv0QavtE9dxpCkeSqKwwO wnWHRuRvdOny9E=; b=irxKJQNXseG6yTiZQ1EsjvoDfI6qN2Ynyoy5wWMRAhN2E lmcxpssgImvh4THm1u3ohP+mhrV52my10k2HooduSv6ot/RWZbnXC0cAb1fQJI2+ pZRZzs1f1lVWLFulMIObctY66O+TfTfz0aAdO63Z6pWW3q2CTlG7XonJqh0pEnoF GMtYaq6uOMsoQQJfSlM3hHRMiS2M8pyzUQF7mwaMlak/hzzMl6NU2rGRF4BTxlng F2e3yx1xAfVJ8sZqVZNdLF8k0+337poxKMlV+uEqgGsmOSaEYfqaNFIRfo4wDdrz eD4XoWiduaBleh0024i2HIc5cHQsiEHXrrn4c0rMw== X-ME-Sender: Received: from localhost (ti0089a400-2222.bb.online.no [88.89.166.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 95C2DE5094; Tue, 17 Apr 2018 18:36:59 -0400 (EDT) From: Marius Bakke To: Kei Kebreau Subject: Re: [bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48. In-Reply-To: <87y3hm4iew.fsf@posteo.net> References: <20180414163226.20403-1-kkebreau@posteo.net> <87h8oadcf4.fsf@fastmail.com> <87y3hm4iew.fsf@posteo.net> User-Agent: Notmuch/0.26.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Wed, 18 Apr 2018 00:36:58 +0200 Message-ID: <87efjdbgtx.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 31153 Cc: 31153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Kei Kebreau writes: > Marius Bakke writes: > >> Kei Kebreau writes: >> >>> * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48. >>> [source]: Simplify snippet. >>> [build-system]: Switch to cmake-build-system. >>> [inputs]: Remove glu and mesa. Add libepoxy. >>> [arguments]: Remove modified phases. >> >> [...] >> >>> (modules '((guix build utils))) >>> (snippet >>> '(begin >>> ;; We don't need libretro for the GNU/Linux build. >>> - (delete-file-recursively "libretro") >>> - ;; Use system zlib. >>> - (delete-file-recursively "source/zlib") >>> - (substitute* "source/core/NstZlib.cpp" >>> - (("#include \"../zlib/zlib.h\"") "#include ")))))) >>> - (build-system gnu-build-system) >>> + (delete-file-recursively "libretro"))))) >>> + (build-system cmake-build-system) >> >> The commit message says 'simplify snippet', but the actual change is to >> not delete the zlib subfolder. Is zlib no longer bundled? If so, >> please mention that in the commit message. >> >> Apart from that LGTM. > > Thank you for reviewing this! > > I've attached a revised patch with some other small but necessary > changes that I overlooked the first time around. If the patch below > looks good, then I will push it to master. LGTM, thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlrWdwoACgkQoqBt8qM6 VPqgTgf9FVzXe4j6v+4I6vHtuwySH+UzKwaYbdSo8D4yF40Lljta/brVP+EOYFvH ZGUeG5v6ZKaQUfFfxFXTRm8H1BHQ9AvnqiMyoJWygFOZc9wmCsyHL423ULE7HPz+ 0a5t//DfsWCSeY20ad0jJSuUK7Y1m7RIy0Ryhp00JCRfmWzmmUbr6TjXzaTDtalS d47vkPXRcwyHoOfGQFgpyrS7ZWKbnBoygqkUtYcYpIoMa97OwKTZuRtjOiCbSW1x naNmEutDa+DMIQAvNalkmOGbOYnoRq4kvtHyTuKf4xEVUH3CV4eYZD9A2enRWjeW AZlxtY+/f8kZifUCxV1A9Vip3mnm5A== =Ee5E -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 17 20:16:06 2018 Received: (at 31153-done) by debbugs.gnu.org; 18 Apr 2018 00:16:06 +0000 Received: from localhost ([127.0.0.1]:58248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8ala-0008J3-Gi for submit@debbugs.gnu.org; Tue, 17 Apr 2018 20:16:06 -0400 Received: from mout01.posteo.de ([185.67.36.65]:50039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f8alY-0008A7-0P for 31153-done@debbugs.gnu.org; Tue, 17 Apr 2018 20:16:04 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id EDB0520E2A for <31153-done@debbugs.gnu.org>; Wed, 18 Apr 2018 02:15:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1524010558; bh=8PlaN+yXvVecTyTQZXepdEdS/s/QHtgt7nYRii01VkY=; h=From:To:Subject:Date:From; b=YTM21FuU57lsK4JXj/R9ax8G60IHmwXqEAr4sb7JNSXf4JUXr0ZZb9VlXCpx7xOX2 VgfBKEMBa/7UKzJuaI1EfcY4Vj0kf0Bc6vDtE5K6bnD/WhyWZyfQN9/461yNUMUVOM 3+VRnioT9B1nyfDtdgA7KN5OQ3qTPej4O7M0dXSzzN69hnHPtaM55IGKSR+e4qFOlp fVk1LPMN9GwvjkZ8GYfV5vzdK8MKI2NvsYI9HDFixwOAjVgKn7nURcYvk4ZjBsUXa9 c3NTM1J4xZ6HeeLD1C7hUl9gW+E0PRKLFgHb+apeS3//HdckVQM9C46vlwGduLgn0L eZCzLUyZsGuUQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 40QjMJ6SThz9rxH for <31153-done@debbugs.gnu.org>; Wed, 18 Apr 2018 02:15:56 +0200 (CEST) From: Kei Kebreau To: 31153-done@debbugs.gnu.org Subject: Re: [bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48. References: <20180414163226.20403-1-kkebreau@posteo.net> <87h8oadcf4.fsf@fastmail.com> <87y3hm4iew.fsf@posteo.net> <87efjdbgtx.fsf@fastmail.com> Date: Tue, 17 Apr 2018 20:15:54 -0400 In-Reply-To: <87efjdbgtx.fsf@fastmail.com> (Marius Bakke's message of "Wed, 18 Apr 2018 00:36:58 +0200") Message-ID: <87vacp4bet.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 31153-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Done! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlrWjjsACgkQ5qXuPBlG eg3KBw/8CgmcL2Qficmy8rhFC3hRCbFsiYWWX2vE6rS8a/6cWZtBBzGUIiJiBiJg z1HmEDPeCnrjfNKoYK/cCTGsD0dR3V6vBbNrnXMzorXUBI6WkxtCH4R4VPzLJaLy wF3j6yR7GwByvZaMr5N6+zjCmvrhPyOjOulHavxaFT0rg1QGuiANtt5eo4g5LVms ir7OTemmqrls13Yxi5YaNQ3m4wDfKUDzSTFASgWzaN2lSjlOeDIb67JhN2DbsoIz lvXdnXOjhnAbkkYMfQSoZEqQcr/VLw2s7W9p3CS8Ry20n/rEnhwFk1IIllSk7YqX y1JaBnUEKq+0DPBgGSyVdO7tNKuMM6yqUpTrn4oTTYNjwsIghQzT21tvKvpdf+Bb 3oHWdJ72p0PyDOzac89TySFIoWmO2kZukOmdQYkIKCNTn6SVn0/dOwzAOm0Uul23 PQ5xT5CALrdkezh6EBdGsSzowdaNt+9niKOIVDlOBKnYbpVD244Nd0DBMOBSV7Tq XvQyFQNRBU5cMUb0/telw2dmhJKIC3eyyrekOInQ7fWhay7NuMzUHNKGVeqxjkTE Y+J1ERK7RikUieHfUzd3GcVwzYHrTiF3n1Uqv42tbmR1r5B7BEVK8x4SkpWBax7d 4Or78/kHL7VfRR3uf83rSqMKlRWBVHuTP7imzvz6qghuZhycauc= =RDwB -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 14 03:57:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 May 2018 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator