GNU bug report logs - #31121
[PATCH 1/3] gnu: Add python2-urlgrabber

Previous Next

Full log

Message #47 received at 31121 <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31121 <at> debbugs.gnu.org
Subject: Re: [bug#31121] [PATCH 3/3] gnu: Add osc.
Date: Wed, 18 Apr 2018 14:34:46 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Wed, Apr 18, 2018 at 01:21:02PM +0200, Marius Bakke wrote:
>Tomáš Čech <sleep_walker <at> gnu.org> writes:
>
>>  * gnu/packages/build-tools.scm (osc): New variable.
>
>[...]
>
>> +(define-public osc
>> +  (package
>> +    (name "osc")
>      ^
>Indentation off here too.

I'm sorry, I'm a bit confused here. My Emacs indent the code like this
and indent script you pointed in previous mail doesn't change it for me.

You would like me to reduce one space? Like this?

(define-public osc
 (package
  (name "osc")

It seems that this is not unified in the code. Can I somehow teach my
Emacs indentantation rules?

Thanks for your patienece.

>
>> +    (version "0.162.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>         ^
>And here.
>
>> +       (uri (string-append "https://github.com/openSUSE/" name
>> +                           "/archive/" version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32 "0b4kpm96ns4smqyfjysbk2p78d36x44xprpna8zz85q1y5xn57aj"))))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(#:python ,python-2 ;; Module is python2 only.
>                             ^
>Only one semicolon for margin comments.

Ack.

>
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'install 'fix-filename-and-remove-unused
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin/")))
>> +               ;; Main osc tool is renamed in spec file, not setup.py, let's
>> +               ;; do that too.
>> +               (rename-file
>> +                (string-append bin "osc-wrapper.py")
>> +                (string-append bin "osc"))
>> +               ;; Remove unused and broken script.
>> +               (delete-file (string-append bin "osc_hotshot.py"))
>> +             #t))))))
>> +    (inputs
>> +     `(("python2-m2crypto" ,python2-m2crypto)
>> +       ("python2-pycurl" ,python2-pycurl)
>> +       ("python2-urlgrabber" ,python2-urlgrabber)))
>> +    (home-page "https://github.com/openSUSE/osc")
>> +    (synopsis "Open Build Service command line tool")
>> +    (description "@command{osc} is command line interface to Open Build
>                                   ^^^                       ^^^
>                                   "is a"                   "to the"
>Other than that LGTM.

\o/

Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.