Subject: Re: [bug#31121] [PATCH 2/3] gnu: Add python-m2crypto, python2-m2crypto.

From: Marius Bakke <[email-masked]>
Date: Wed, 18 Apr 2018 13:17:20 +0200

Tomáš Čech <[email-masked]> writes:

> * gnu/packages/python-crypto.scm (python-m2crypto): New variable.
> (python2-m2crypto): New variable.

[...]

> +(define-public python-m2crypto
> +  (package
> +    (name "python-m2crypto")
      ^
Indentation is off.

> +    (version "0.29.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "M2Crypto" version))
> +       (sha256
> +        (base32 "1h16gpilrnlzc0iyj1mnd1iqh8wchzjsxjqw9n344glimg2s5zm0"))))
> +    (build-system python-build-system)
> +    (inputs `(("openssl" ,openssl)))
> +    (propagated-inputs `(("python-typing" ,python-typing)))
> +    (home-page "https://gitlab.com/m2crypto/m2crypto")
> +    (synopsis "Python crypto and SSL toolkit")

s/SSL/TLS
(same for description -- SSL is officially an obsolete term)

> +    (description "@code{M2Crypto} is complete Python wrapper for OpenSSL
                                     "is a"
Typo:                                 ^

Other than that LGTM.

> +featuring RSA, DSA, DH, EC, HMACs, message digests, symmetric ciphers
> +(including AES); TLS functionality to implement clients and servers; HTTPS
> +extensions to Python's httplib, urllib, and xmlrpclib; unforgeable HMAC'ing
> +AuthCookies for web session management; FTP/TLS client and server; S/MIME;
> +M2Crypto can also be used to provide SSL for Twisted.  Smartcards supported
> +through the Engine interface.")
> +    (license license:expat)))
> +
> +(define-public python2-m2crypto
> +  (package-with-python2 python-m2crypto))
> -- 
> 2.16.3