GNU bug report logs - #31114
[PATCH] gnu: Add fortune-mod.

Previous Next

Full log

View this message in rfc822 format

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31114-done <at> debbugs.gnu.org
Subject: [bug#31114] [PATCH] gnu: Add fortune-mod.
Date: Thu, 19 Apr 2018 18:04:08 +0530

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi Pierre,
>
> I’ve applied it all after fixing trivial issues reported by ‘guix lint’.
> I was able to get a few fortune cookies already, so thank you.  :-)

I did run `guix lint` if I'm not mistaken, I don't remember any issue.
What were those?

> Pierre Neidhardt <ambrevar <at> gmail.com> skribis:
>
>> +    (native-inputs
>> +     `(("perl" ,perl)
>> +       ;; The following is only needed for tests.
>> +       ("perl-file-find-object" ,perl-file-find-object)
>> +       ("perl-test-differences" ,perl-test-differences)
>> +       ("perl-class-xsaccessor" ,perl-class-xsaccessor)
>> +       ("perl-io-all" ,perl-io-all)
>> +       ("perl-test-runvalgrind" ,perl-test-runvalgrind)
>> +       ("cmake-rules"
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append "https://bitbucket.org/shlomif/shlomif-cmake-modules/"
>> +                               "raw/default/shlomif-cmake-modules/Shlomif_Common.cmake"))
>> +           (sha256
>> +            (base32 "0kx9s1qqhhzprp1w3b67xmsns0n0v506bg5hgrshxaxpy6lqiwb2"))))))
>
> I’m afraid the above URL is referring to the tip of that repository, and
> thus that contents may change over time.  Could you come up with a
> stable URL, i.e., one that includes a commit ID?

Sure, I think

	https://bitbucket.org/shlomif/shlomif-cmake-modules/raw/c505713d7a7cda608f97f01577e5868a711b883e/shlomif-cmake-modules/Shlomif_Common.cmake

should do.

Out of curiosity, why did you close the bug / merge the patch with the
URL issue mentioned above?

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.