Subject: Re: [bug#31114] [PATCH] gnu: Add fortune-mod.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 23 Apr 2018 17:12:36 +0200

Hello,

Pierre Neidhardt <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>> Hi Pierre,
>>
>> I’ve applied it all after fixing trivial issues reported by ‘guix lint’.
>> I was able to get a few fortune cookies already, so thank you.  :-)
>
> I did run `guix lint` if I'm not mistaken, I don't remember any issue.
> What were those?

I think these were two-spaces-after-end-of-sentence-period in the
synopses/descriptions of the Perl packages, things like that.

>> Pierre Neidhardt <[email-masked]> skribis:
>>
>>> +    (native-inputs
>>> +     `(("perl" ,perl)
>>> +       ;; The following is only needed for tests.
>>> +       ("perl-file-find-object" ,perl-file-find-object)
>>> +       ("perl-test-differences" ,perl-test-differences)
>>> +       ("perl-class-xsaccessor" ,perl-class-xsaccessor)
>>> +       ("perl-io-all" ,perl-io-all)
>>> +       ("perl-test-runvalgrind" ,perl-test-runvalgrind)
>>> +       ("cmake-rules"
>>> +        ,(origin
>>> +           (method url-fetch)
>>> +           (uri (string-append "https://bitbucket.org/shlomif/shlomif-cmake-modules/"
>>> +                               "raw/default/shlomif-cmake-modules/Shlomif_Common.cmake"))
>>> +           (sha256
>>> +            (base32 "0kx9s1qqhhzprp1w3b67xmsns0n0v506bg5hgrshxaxpy6lqiwb2"))))))
>>
>> I’m afraid the above URL is referring to the tip of that repository, and
>> thus that contents may change over time.  Could you come up with a
>> stable URL, i.e., one that includes a commit ID?
>
> Sure, I think
>
> 	https://bitbucket.org/shlomif/shlomif-cmake-modules/raw/c505713d7a7cda608f97f01577e5868a711b883e/shlomif-cmake-modules/Shlomif_Common.cmake
>
> should do.

OK, I made the change.

> Out of curiosity, why did you close the bug / merge the patch with the
> URL issue mentioned above?

I didn’t consider it a showstopper, but I can understand arguments both
ways.

Thank you,
Ludo’.