Subject: bug#31089: closed (Re: [bug#31089] [PATCH 3/5] services: cgit: Add support for file-like objects.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 11 Apr 2018 19:28:02 +0000

Your bug report

#31089: cgit service: add support for file-like objects

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
31089: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31089
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#31089] [PATCH 3/5] services: cgit: Add support for file-like objects.
From: Clément Lassieur <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Wed, 11 Apr 2018 21:27:14 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Clément Lassieur <[email-masked]> writes:

> Ludovic Courtès <[email-masked]> writes:
>
>>>           (config-str
>>>            (if opaque-config?
>>>                (opaque-cgit-configuration-cgitrc config)
>>> -              (with-output-to-string
>>> -                (lambda ()
>>> -                  (serialize-configuration config
>>> -                                           cgit-configuration-fields))))))
>>> +              (serialize-configuration config cgit-configuration-fields))))
>>>      #~(begin
>>>          (use-modules (guix build utils))
>>>          (mkdir-p #$(if opaque-config?
>>>                         (opaque-cgit-configuration-cache-root config)
>>>                         (cgit-configuration-cache-root config)))
>>> -        (copy-file #$(plain-file "cgitrc" config-str) "/etc/cgitrc"))))
>>> +        (copy-file #$(mixed-text-file "cgitrc" config-str)
>>> +                   "/etc/cgitrc"))))
>>
>> For clarity, since ‘config-str’ is no longer a string (right?), I’d
>> rename it to just ‘config’ or something.
>>
>> Also, could it be that you’re missing ‘apply’ above, as in:
>>
>>   (apply mixed-text-file "cgitrc" config-str)
>>
>> ?
>
> Yes, config-str is still a string (or a string-valued gexp).  I use
> mixed-text-file because it can take gexps as arguments, whereas
> plain-file can't.
>
>> Otherwise LGTM, thanks!
>
> Thank you for the review!
>
> Clément

Pushed.

Subject: cgit service: add support for file-like objects
From: Clément Lassieur <[email-masked]>
To: [email-masked]
Date: Sat, 07 Apr 2018 19:04:17 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

These patches aim to add support for file-like objects and a few other
things related to the cgit service.

Comments are welcome,
Clément