Subject: Re: [bug#31089] [PATCH 3/5] services: cgit: Add support for file-like objects.

From: Clément Lassieur <[email-masked]>
Date: Wed, 11 Apr 2018 10:35:19 +0200

Ludovic Courtès <[email-masked]> writes:

>>           (config-str
>>            (if opaque-config?
>>                (opaque-cgit-configuration-cgitrc config)
>> -              (with-output-to-string
>> -                (lambda ()
>> -                  (serialize-configuration config
>> -                                           cgit-configuration-fields))))))
>> +              (serialize-configuration config cgit-configuration-fields))))
>>      #~(begin
>>          (use-modules (guix build utils))
>>          (mkdir-p #$(if opaque-config?
>>                         (opaque-cgit-configuration-cache-root config)
>>                         (cgit-configuration-cache-root config)))
>> -        (copy-file #$(plain-file "cgitrc" config-str) "/etc/cgitrc"))))
>> +        (copy-file #$(mixed-text-file "cgitrc" config-str)
>> +                   "/etc/cgitrc"))))
>
> For clarity, since ‘config-str’ is no longer a string (right?), I’d
> rename it to just ‘config’ or something.
>
> Also, could it be that you’re missing ‘apply’ above, as in:
>
>   (apply mixed-text-file "cgitrc" config-str)
>
> ?

Yes, config-str is still a string (or a string-valued gexp).  I use
mixed-text-file because it can take gexps as arguments, whereas
plain-file can't.

> Otherwise LGTM, thanks!

Thank you for the review!

Clément