GNU bug report logs - #31088
Use '@' as version number separator in guix output

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Subject: bug#31088: closed (Re: bug#31088: Use '@' as version number
 separator in guix output)
Date: Wed, 09 May 2018 05:37:05 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#31088: Use '@' as version number separator in guix output

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 31088 <at> debbugs.gnu.org.

-- 
31088: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31088
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chris Marusich <cmmarusich <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès), Mathieu Lirzin
 <mthl <at> gnu.org>,  Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31088-done <at> debbugs.gnu.org
Subject: Re: bug#31088: Use '@' as version number separator in guix output
Date: Tue, 08 May 2018 22:36:28 -0700

[Message part 3 (text/plain, inline)]

Hi everyone!

I've committed this as ede121de426f9c56820852888a0b370f0ccbce49 on the
master branch.  If anything breaks on Hydra or elsewhere, please don't
hesitate to revert it.

ludo <at> gnu.org (Ludovic Courtès) writes:

>> diff --git a/NEWS b/NEWS
>> index 2c898e65f..9769bfc87 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -777,6 +777,7 @@ zynaddsubfx <at> 3.0.2
>>  
>>  ** Programming interfaces
>>  
>> +*** package-full-name (guix packages) now uses "@" instead of "-" as its delimiter.
>
> This is under “Changes in 0.14.0 (since 0.13.0)”, which is probably not
> what you want.  :-)

Ah!  Good catch.  I've added a new section for 0.15.0 - which I'm sure
will be released soon!  ;-)

>> +(define* (package-full-name package #:key (delimiter "@"))>
> +  "Return the full name of PACKAGE--i.e., `NAME <at> VERSION'.  By specifying
>> +DELIMITER (a string), you can customize what will appear between the name and
>> +the version.  By default, DELIMITER is \"@\"."
>
> I’d prefer #:optional instead of #:key, it’d be less verbose.

Sounds good.  I've implemented your suggestion.

> Other than that, please make sure “make check” passes, and make sure
> this doesn’t trigger a full rebuild (from the patch it looks you already
> checked both of these, but who knows ;-)).

I've confirmed the following:

1) It builds, and "make check" passes [1].

2) It does not trigger a full rebuild.  I tested this by first invoking
"./pre-inst-env guix system build gnu/system/examples/desktop.tmpl"
before and after the change.

3) I reconfigured my own system a few days ago, too, using this change.
So far, I have observed no problems.

> OK with this.

Thank you for the review!  And thank you, Pierre, for reporting the bug!

Footnotes: 
[1]  tests/guix-system.sh fails, but it was already failing on the
master branch.  I will open a bug report for that if there is not
already one open.

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: Use '@' as version number separator in guix output
Date: Sat, 07 Apr 2018 22:28:55 +0530

[Message part 6 (text/plain, inline)]

At the moment it seems that there is no syntactic different between the
name and the version number in the output of Guix.

The other day I tried to extract the version number of package
dependencies with "everything after the last '-'", until I stumbled on
the following:

	> guix package --show=ncdu | recsel -R dependencies
	ncurses-6.0-20170930

Here the version number contains a '-'.  Because of this it makes the
problem undecidable I think.

Would it be possible to separate the package name from the version
number with '@' instead?

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.