Subject: bug#31088: Use '@' as version number separator in guix output

From: [email-masked] (Ludovic Courtès)
Date: Tue, 01 May 2018 23:04:37 +0200

Hello Chris,

Thanks for digging into this.

Chris Marusich <[email-masked]> skribis:

> From 67165c95ff9b52b7ae34d7c07778138548013ccd Mon Sep 17 00:00:00 2001
> From: Chris Marusich <[email-masked]>
> Date: Sun, 8 Apr 2018 16:51:42 -0700
> Subject: [PATCH] guix: Separate the package name and version with "@", not
>  "-".
>
> * guix/packages.scm (package-full-name): By default, use "@" to separate
>   the package name and package version.  Add #:delimiter keyword
>   argument so that there is still a way to explicitly use a different
>   delimiter.
> * gnu/packages/commencement.scm (gcc-boot0) <unpack-gmp&co>: Adjust
>   accordingly.
> * tests/graph.scm: Adjust accordingly.
> * tests/profiles.scm: Adjust accordingly.
> * NEWS: Mention the change.
>
> Fixes: <https://bugs.gnu.org/31088>.
> Reported by Pierre Neidhardt <[email-masked]>.

[...]

> diff --git a/NEWS b/NEWS
> index 2c898e65f..9769bfc87 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -777,6 +777,7 @@ [email-masked]
>  
>  ** Programming interfaces
>  
> +*** package-full-name (guix packages) now uses "@" instead of "-" as its delimiter.

This is under “Changes in 0.14.0 (since 0.13.0)”, which is probably not
what you want.  :-)

> +(define* (package-full-name package #:key (delimiter "@"))
> +  "Return the full name of PACKAGE--i.e., `NAME@VERSION'.  By specifying
> +DELIMITER (a string), you can customize what will appear between the name and
> +the version.  By default, DELIMITER is \"@\"."

I’d prefer #:optional instead of #:key, it’d be less verbose.

Other than that, please make sure “make check” passes, and make sure
this doesn’t trigger a full rebuild (from the patch it looks you already
checked both of these, but who knows ;-)).

OK with this.

Thank you!

Ludo’.