GNU bug report logs - #31087
[PATCH] gnu: Add libcgroup.

Previous Next

Full log

Message #16 received at 31087-done <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31087-done <at> debbugs.gnu.org
Subject: Re: [bug#31087] [PATCH] gnu: Add libcgroup.
Date: Tue, 10 Apr 2018 12:05:59 +0200

[Message part 1 (text/plain, inline)]

On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Courtès wrote:
>Hello,
>
>Tomáš Čech <sleep_walker <at> gnu.org> skribis:
>
>>  * gnu/packages/linux.scm (libcgroup): New variable.
>
>[...]
>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         ;; tests try to mount cgroup filesystem and fails because it seems it
>> +         ;; can't be mounted twice
>> +         ;; let's disable it
>> +         (delete 'check))))
>
>Simply write #:tests? #f.
>
>> +    (native-inputs
>> +     `(("bison" ,bison)
>> +       ("flex" ,flex)
>> +       ("linux-pam" ,linux-pam)))
>
>Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?
>
>Otherwise LGTM, thanks!

Both things addressed, result pushed.

Thanks for review!

S_W

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.