Subject: Re: [bug#31087] [PATCH] gnu: Add libcgroup.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 09 Apr 2018 22:35:45 +0200

Hello,

Tomáš Čech <[email-masked]> skribis:

>  * gnu/packages/linux.scm (libcgroup): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; tests try to mount cgroup filesystem and fails because it seems it
> +         ;; can't be mounted twice
> +         ;; let's disable it
> +         (delete 'check))))

Simply write #:tests? #f.

> +    (native-inputs
> +     `(("bison" ,bison)
> +       ("flex" ,flex)
> +       ("linux-pam" ,linux-pam)))

Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?

Otherwise LGTM, thanks!

Ludo’.