GNU bug report logs - #31083
[PATCH 1/2] gnu: libtorrent-rasterbar: Add CXXFLAGS.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31083 in the body.
You can then email your comments to 31083 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fis Trivial <ybbs.daans <at> hotmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: libtorrent-rasterbar: Add CXXFLAGS.
Date: Fri, 6 Apr 2018 20:06:52 +0000

* gnu/packages/bittorrent.scm (libtorrent-rasterbar): Add CXXFLAGS.
---
 gnu/packages/bittorrent.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index dc051e262..b168f88e0 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -391,7 +391,8 @@ and will take advantage of multiple processor cores where possible.")
                             (assoc-ref %build-inputs "boost")
                             "/lib")
              "--enable-python-binding"
-             "--enable-tests")
+             "--enable-tests"
+             "CXXFLAGS=-std=c++11")     ; Use std::chrono instead of boost
        #:make-flags (list
                      (string-append "LDFLAGS=-Wl,-rpath="
                                     (assoc-ref %outputs "out") "/lib"))))
-- 
2.14.3

Message #8 received at 31083 <at> debbugs.gnu.org (full text, mbox):

From: Fis Trivial <ybbs.daans <at> hotmail.com>
To: Fis Trivial <ybbs.daans <at> hotmail.com>
Cc: "31083 <at> debbugs.gnu.org" <31083 <at> debbugs.gnu.org>
Subject: Re: [bug#31083] [PATCH 1/2] gnu: libtorrent-rasterbar: Add CXXFLAGS.
Date: Fri, 6 Apr 2018 20:16:30 +0000

Fis Trivial writes:

> * gnu/packages/bittorrent.scm (libtorrent-rasterbar): Add CXXFLAGS.
> ---
>  gnu/packages/bittorrent.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index dc051e262..b168f88e0 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -391,7 +391,8 @@ and will take advantage of multiple processor cores where possible.")
>                              (assoc-ref %build-inputs "boost")
>                              "/lib")
>               "--enable-python-binding"
> -             "--enable-tests")
> +             "--enable-tests"
> +             "CXXFLAGS=-std=c++11")     ; Use std::chrono instead of boost
>         #:make-flags (list
>                       (string-append "LDFLAGS=-Wl,-rpath="
>                                      (assoc-ref %outputs "out") "/lib"))))

This is for adding qBittorrent.

Message #11 received at 31083 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Fis Trivial <ybbs.daans <at> hotmail.com>
Cc: 31083 <at> debbugs.gnu.org
Subject: Re: [bug#31083] [PATCH 1/2] gnu: libtorrent-rasterbar: Add CXXFLAGS.
Date: Mon, 09 Apr 2018 22:59:30 +0200

Hi,

Fis Trivial <ybbs.daans <at> hotmail.com> skribis:

> * gnu/packages/bittorrent.scm (libtorrent-rasterbar): Add CXXFLAGS.
> ---
>  gnu/packages/bittorrent.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index dc051e262..b168f88e0 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -391,7 +391,8 @@ and will take advantage of multiple processor cores where possible.")
>                              (assoc-ref %build-inputs "boost")
>                              "/lib")
>               "--enable-python-binding"
> -             "--enable-tests")
> +             "--enable-tests"
> +             "CXXFLAGS=-std=c++11")     ; Use std::chrono instead of boost

Does that mean we can remove Boost from the dependencies or is it still
needed for other bits?

Thank you,
Ludo’.

Message #14 received at 31083 <at> debbugs.gnu.org (full text, mbox):

From: Fis Trivial <ybbs.daans <at> hotmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "31083 <at> debbugs.gnu.org" <31083 <at> debbugs.gnu.org>,
 Fis Trivial <ybbs.daans <at> hotmail.com>
Subject: Re: [bug#31083] [PATCH 1/2] gnu: libtorrent-rasterbar: Add CXXFLAGS.
Date: Mon, 9 Apr 2018 21:41:35 +0000

>
> Does that mean we can remove Boost from the dependencies or is it still
> needed for other bits?
>
> Thank you,
> Ludo’.

It's still needed. The solution is adopted from project's issue list:

https://github.com/qbittorrent/qBittorrent/issues/8402
https://github.com/qbittorrent/qBittorrent/issues/5265

Message #17 received at 31083 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Fis Trivial <ybbs.daans <at> hotmail.com>
Cc: 31083 <at> debbugs.gnu.org
Subject: Re: [bug#31083] [PATCH 1/2] gnu: libtorrent-rasterbar: Add CXXFLAGS.
Date: Tue, 10 Apr 2018 22:50:22 +0200

Fis Trivial <ybbs.daans <at> hotmail.com> skribis:

>>
>> Does that mean we can remove Boost from the dependencies or is it still
>> needed for other bits?
>>
>> Thank you,
>> Ludo’.
>
> It's still needed. The solution is adopted from project's issue list:
>
> https://github.com/qbittorrent/qBittorrent/issues/8402
> https://github.com/qbittorrent/qBittorrent/issues/5265

OK, thanks for explaining.  Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.