From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 09:37:05 2018 Received: (at submit) by debbugs.gnu.org; 6 Apr 2018 13:37:05 +0000 Received: from localhost ([127.0.0.1]:39958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4RY9-00086U-Gf for submit@debbugs.gnu.org; Fri, 06 Apr 2018 09:37:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4RY7-00085y-07 for submit@debbugs.gnu.org; Fri, 06 Apr 2018 09:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4RY0-00070e-GZ for submit@debbugs.gnu.org; Fri, 06 Apr 2018 09:36:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f4RY0-00070T-An for submit@debbugs.gnu.org; Fri, 06 Apr 2018 09:36:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4RXy-0003Mc-NJ for guix-patches@gnu.org; Fri, 06 Apr 2018 09:36:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4RXv-0006xZ-G4 for guix-patches@gnu.org; Fri, 06 Apr 2018 09:36:54 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52789) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f4RXv-0006uF-0d for guix-patches@gnu.org; Fri, 06 Apr 2018 09:36:51 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E2530212BD for ; Fri, 6 Apr 2018 15:36:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1523021802; bh=bLz9vYyohSMHigSkOEYt1MhyDeS4wKGBl7S142/oqAw=; h=From:To:Subject:Date:From; b=lWeatwnn9us1Su1Yg8oTeO72Hfo8nR9sdYetPtlmK/AC8ucEIAsc7lMVYnn2EGH87 BXSI/+GvyV2T/Ygi9Q5uCAaN/4fPIjx9TAyAr3uwAbfd1pib+avyuuzmyX6byQVZis bJ64dShWDZtxLGJVpsJD4eJ02kwlj9fCxSeKNOeRx7CI4X3sLWRTjWUJYBmoBfk6Fs tK3+r1AkqB49gHdL/EPyTPmiNpUDRLAAfzriAJ3FMfSRckqEt0XpT4SrlV47JULfj2 5s8BimCwnpai0FQnBJx8kL7fdFK3U0jzyX6ZvCRyZnoW1P7c40vyhCQ4rMkIDpJs5a oJ0k6xBfvaY+A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 40Hghp1bG7z9rxG for ; Fri, 6 Apr 2018 15:36:42 +0200 (CEST) From: Diego Nicola Barbato To: guix-patches@gnu.org Subject: [PATCH] gnu: libfive: Add snippet, enable tests and remove obsolete phase. Date: Fri, 06 Apr 2018 15:36:41 +0200 Message-ID: <877epkjw2e.fsf@GlaDOS.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hello Guix I have noticed that the package "ao-cad" has been updated and renamed to "libfive" recently (commit: 28f4d56dd311a3b4c7102394120de05be6937494). I have been working on the same thing for a while but I got stuck when trying to figure out how to correctly install the Guile library so that it could be used as described in the libfive documentation (https://github.com/libfive/libfive/blob/9d857d1923abecb0e5935b9287d22661f6efaac5/doc/guide.md) by running (load-extension "libfive-guile" "scm_init_libfive_modules") in a Guile REPL. I also thought about installing it in such a way that it could be loaded with (use-modules (libfive)). AFAICT this has not been addressed yet so I will continue working on it. The updated package definition is very similar to what I have written so far except for some minor differences. Among these are a snippet which removes the bundled catch.hpp file from the libfive/test directory and the fact that I did not disable the tests. Additionally I removed a phase which does not seem to be necessary as the package is still built and installed correctly without it. This patch adds those changes. Greetings Diego --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-libfive-Add-snippet-enable-tests-and-remove-obso.patch Content-Description: Patch >From 402b75db39ec6778862a5a301cd6a6f520608c60 Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Fri, 6 Apr 2018 13:43:54 +0200 Subject: [PATCH] gnu: libfive: Add snippet, enable tests and remove obsolete phase. * gnu/packages/engineering.scm (libfive)[source]: Add snippet to remove bundled catch. [arguments]: Remove #:tests?. Add #:test-target. Remove phase 'add-eigen-to-search-path'. --- gnu/packages/engineering.scm | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index 1113cafec..2f4e8cef5 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -580,24 +580,19 @@ as well as pick-place files.") (sha256 (base32 "1r40kyx30wz31cwwlfvfh7fgqkxq3n8dxhswpi9qpf4r5h3l8wsn")) - (file-name (git-file-name name version)))) + (file-name (git-file-name name version)) + (snippet + ;; Remove bundled catch since we provide our own. + '(delete-file "libfive/test/catch.hpp")))) (build-system cmake-build-system) (arguments - `(#:tests? #f ; no "test" target + `(#:test-target "libfive-test" #:phases (modify-phases %standard-phases (add-after 'unpack 'remove-native-compilation (lambda _ (substitute* "CMakeLists.txt" (("-march=native") "")) - #t)) - (add-before 'build 'add-eigen-to-search-path - (lambda* (#:key inputs #:allow-other-keys) - ;; Allow things to find our own Eigen and Catch. - (let ((eigen (assoc-ref inputs "eigen"))) - (setenv "CPLUS_INCLUDE_PATH" - (string-append eigen "/include/eigen3:" - (getenv "CPLUS_INCLUDE_PATH"))) - #t)))))) + #t))))) (native-inputs `(("pkg-config" ,pkg-config))) (inputs -- 2.17.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 19 05:42:33 2018 Received: (at 31077-done) by debbugs.gnu.org; 19 Apr 2018 09:42:33 +0000 Received: from localhost ([127.0.0.1]:60098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f965I-0005vH-RY for submit@debbugs.gnu.org; Thu, 19 Apr 2018 05:42:33 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:44580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f965H-0005v9-4H for 31077-done@debbugs.gnu.org; Thu, 19 Apr 2018 05:42:31 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 0DC95125BC; Thu, 19 Apr 2018 11:42:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wmRu-YOHNho0; Thu, 19 Apr 2018 11:42:27 +0200 (CEST) Received: from ribbon (unknown [193.50.110.139]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F12371255F; Thu, 19 Apr 2018 11:42:26 +0200 (CEST) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Diego Nicola Barbato Subject: Re: [bug#31077] [PATCH] gnu: libfive: Add snippet, enable tests and remove obsolete phase. References: <877epkjw2e.fsf@GlaDOS.home> Date: Thu, 19 Apr 2018 11:42:26 +0200 In-Reply-To: <877epkjw2e.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Fri, 06 Apr 2018 15:36:41 +0200") Message-ID: <87fu3rmt19.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 31077-done Cc: 31077-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Diego, Diego Nicola Barbato skribis: >>>From 402b75db39ec6778862a5a301cd6a6f520608c60 Mon Sep 17 00:00:00 2001 > From: Diego Nicola Barbato > Date: Fri, 6 Apr 2018 13:43:54 +0200 > Subject: [PATCH] gnu: libfive: Add snippet, enable tests and remove obsol= ete > phase. > > * gnu/packages/engineering.scm (libfive)[source]: Add snippet to > remove bundled catch. > [arguments]: Remove #:tests?. Add #:test-target. Remove phase > 'add-eigen-to-search-path'. It LGTM and it works for me here, so I went ahead and applied it. Thank you! Ludo=E2=80=99. From unknown Sun Jun 22 17:14:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 May 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator