GNU bug report logs - #31077
[PATCH] gnu: libfive: Add snippet, enable tests and remove obsolete phase.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31077 in the body.
You can then email your comments to 31077 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libfive: Add snippet,
 enable tests and remove obsolete phase.
Date: Fri, 06 Apr 2018 15:36:41 +0200

[Message part 1 (text/plain, inline)]

Hello Guix

I have noticed that the package "ao-cad" has been updated and renamed to
"libfive" recently (commit: 28f4d56dd311a3b4c7102394120de05be6937494).

I have been working on the same thing for a while but I got stuck when
trying to figure out how to correctly install the Guile library so that
it could be used as described in the libfive documentation
(https://github.com/libfive/libfive/blob/9d857d1923abecb0e5935b9287d22661f6efaac5/doc/guide.md)
by running (load-extension "libfive-guile" "scm_init_libfive_modules")
in a Guile REPL.  I also thought about installing it in such a way that
it could be loaded with (use-modules (libfive)).

AFAICT this has not been addressed yet so I will continue working on it.

The updated package definition is very similar to what I have written so
far except for some minor differences.  Among these are a snippet which
removes the bundled catch.hpp file from the libfive/test directory and
the fact that I did not disable the tests.  Additionally I removed a
phase which does not seem to be necessary as the package is still built
and installed correctly without it.

This patch adds those changes.

Greetings

Diego

[0001-gnu-libfive-Add-snippet-enable-tests-and-remove-obso.patch (text/x-patch, attachment)]

Message #10 received at 31077-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Diego Nicola Barbato <dnbarbato <at> posteo.de>
Cc: 31077-done <at> debbugs.gnu.org
Subject: Re: [bug#31077] [PATCH] gnu: libfive: Add snippet,
 enable tests and remove obsolete phase.
Date: Thu, 19 Apr 2018 11:42:26 +0200

Hi Diego,

Diego Nicola Barbato <dnbarbato <at> posteo.de> skribis:

>>From 402b75db39ec6778862a5a301cd6a6f520608c60 Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato <at> posteo.de>
> Date: Fri, 6 Apr 2018 13:43:54 +0200
> Subject: [PATCH] gnu: libfive: Add snippet, enable tests and remove obsolete
>  phase.
>
> * gnu/packages/engineering.scm (libfive)[source]: Add snippet to
> remove bundled catch.
> [arguments]: Remove #:tests?.  Add #:test-target.  Remove phase
> 'add-eigen-to-search-path'.

It LGTM and it works for me here, so I went ahead and applied it.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.