From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 06 01:02:54 2018 Received: (at submit) by debbugs.gnu.org; 6 Apr 2018 05:02:54 +0000 Received: from localhost ([127.0.0.1]:39791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4JWX-0000c1-NC for submit@debbugs.gnu.org; Fri, 06 Apr 2018 01:02:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4JWV-0000bl-Ft for submit@debbugs.gnu.org; Fri, 06 Apr 2018 01:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4JWP-00079A-4g for submit@debbugs.gnu.org; Fri, 06 Apr 2018 01:02:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38411) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f4JWP-000793-0i for submit@debbugs.gnu.org; Fri, 06 Apr 2018 01:02:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4JWN-00057S-IR for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2018 01:02:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4JWK-00077W-FL for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2018 01:02:43 -0400 Received: from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:37377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4JWK-00076s-9G for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2018 01:02:40 -0400 Received: by mail-pf0-x230.google.com with SMTP id x16so5187510pfm.4 for ; Thu, 05 Apr 2018 22:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=sfrf3BWxjr3xY6PMV2R81tV38VbVaVzIQfvPovRKJo4=; b=t0lb55notgZopYtAlfuWVyFMSdhZnW2v/+i/6s/drCJZfKD4iyDSNDTDBgLxgfqsHy 1whw/NjuJbAfwaGntcxz20ekn0DeNyPS1WWlpCphIrK7lNZ/IopEfefaUd+Jp0vZSZ2I +QqPRnOFNmICFE9A1S66aKIMzHiHxBrhIruiwl36PGJ9iaFM0rznWik9AiUeAiEJqifM 6s1io6c7T4QsCoReAfLgftLPgDf4lOmcINKbeH1X2t9Q3MhHjJmlWm1xju+SAR22JH2D WdpyrA0CDgB3rSw9DgVgBjID2vEWdPHxZe27jqy/Tps6Mva+6r6AcXhzbDIteYLCumhq 98iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=sfrf3BWxjr3xY6PMV2R81tV38VbVaVzIQfvPovRKJo4=; b=Z9ll62vIaEBRl7uqYPvOZNgVBrhkpEwD29t/awtJVdM1VU0pHHDCErTa2F9tEmdJqO H6oqACIekHfnYmXqGYeYsbH7s11l7K2JbIYg8WIQS1fKjISfgEA0Si2/CRJYNH8fmRN6 R8hYPYii/hom5yUyYjPDFwRQG+NzKphjSMHPPGRd2Y5kxJ0FAZnH/Izxoh0QpMMbLwcW Cq0mAJaMuhAzCHjYhRF7ySfvdewG6a2NvM16jd5Hv6oHOLQHy0ar9ezS29NGgfM1LTEK GtqOQtWjPUxigFaTMctmfd7jPQ3/cRnKRIFD+Jj9NenwSo6s/8xBsurdfMltXUaecarK 2ewg== X-Gm-Message-State: AElRT7EioiBs74pUgGZmKnXQq60+4lPGH148p/Be0J0jy5DiacKnMzTJ LY0C6yAzamEgL4IFakwESbZ95JLA X-Google-Smtp-Source: AIpwx4/EgAM2VhO1L9onKH2uOdDvZxlpJYRJqPZIr15IGOYAHj3EZ4IS+IvT2QirHr6ybWxVLsG/iQ== X-Received: by 10.99.3.144 with SMTP id 138mr16904358pgd.364.1522990958750; Thu, 05 Apr 2018 22:02:38 -0700 (PDT) Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id l10sm14126080pgp.35.2018.04.05.22.02.36 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Apr 2018 22:02:37 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 27.0.50; query-replace undo might change the word case Date: Fri, 06 Apr 2018 14:02:31 +0900 Message-ID: <87efjtdj14.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) X-Debbugs-CC: Juri Linkov The undo feature shouldn't change the case; it must return to the original words. emacs -Q < M-% t RET FOO RET SPC SPC SPC SPC U ;; The first line shows upcase 'T' at several positions, for instance ;; it shows 'TexT', originally shown as 'text'. --8<-----------------------------cut here---------------start------------->8--- commit 6fcb746c4efcbc2afce6a520f4a8b67a8d40cdd1 Author: Tino Calancha Date: Fri Apr 6 13:40:06 2018 +0900 Preserve case in query-replace undo If the user query and replaces 'foo' with 'BAR', then undo must comeback to 'foo', not to 'FOO'. * lisp/replace.el (perform-replace): Bind nocasify to non-nil value during undo/undo-all actions. * test/lisp/replace-tests.el (query-replace-undo-bug31073): Add test. diff --git a/lisp/replace.el b/lisp/replace.el index c28c9b36f0..a147c8dd86 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -2619,6 +2619,7 @@ perform-replace (let ((stack-idx 0) (stack-len (length stack)) (num-replacements 0) + (nocasify t) ; Bug#31073. search-string next-replacement) (while (and (< stack-idx stack-len) diff --git a/test/lisp/replace-tests.el b/test/lisp/replace-tests.el index 66c6842660..d6043e297c 100644 --- a/test/lisp/replace-tests.el +++ b/test/lisp/replace-tests.el @@ -380,4 +380,24 @@ replace-tests--query-replace-undo (should (string= "211" (replace-tests--query-replace-undo))) (should (string= "211" (replace-tests--query-replace-undo 'comma)))) +(ert-deftest query-replace-undo-bug31073 () + "Test for https://debbugs.gnu.org/31073 ." + (let ((text "The teeth must be cleaned after every meal.") + (count 0)) + (with-temp-buffer + (insert text) + (goto-char 1) + (cl-letf (((symbol-function 'read-event) + (lambda (&rest args) + (cl-incf count) + (let ((val (pcase count + ('4 ?U) ; undo-all + ('5 ?q) ; exit + (_ ?\s)))) ; replace current and go next + val)))) + (perform-replace "t" "FOO" t nil nil)) + ;; After undo text must be the same. + (should (string= text (buffer-string)))))) + + ;;; replace-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 27.0.50 (build 25, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2018-04-03 built on calancha-pc Repository revision: 10ef466a9eb621a3752de69930fcb14bf1af4887 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 07 16:51:21 2018 Received: (at 31073) by debbugs.gnu.org; 7 Apr 2018 20:51:21 +0000 Received: from localhost ([127.0.0.1]:41594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4unw-0001fc-OO for submit@debbugs.gnu.org; Sat, 07 Apr 2018 16:51:20 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:45149 helo=homiemail-a18.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4unu-0001fU-S4 for 31073@debbugs.gnu.org; Sat, 07 Apr 2018 16:51:19 -0400 Received: from homiemail-a18.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTP id BE492258068; Sat, 7 Apr 2018 13:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version: content-type; s=jurta.org; bh=U/E4T+E6Y/yJd5cdAT1vLxSkdw0=; b=ah DFrHJ0HgZIaPl/PuZ0Kowzgv8oLkksZ/oLvKDn/ZXFCb854L5J1CofjpHIezn90Y kz2/yOOjyfiYt+uS/WEzd7kHQ2KrXDBOL+D9eEAeOWWjfvgOPTDjTB9ZsSZqIawk Yb0jE5K66AMziMOivEhLfsiZ8Hh1DlKhzGPtZudrg= Received: from localhost.linkov.net (m91-129-105-236.cust.tele2.ee [91.129.105.236]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a18.g.dreamhost.com (Postfix) with ESMTPSA id E1710258067; Sat, 7 Apr 2018 13:51:16 -0700 (PDT) From: Juri Linkov To: Tino Calancha Subject: Re: bug#31073: 27.0.50; query-replace undo might change the word case Organization: LINKOV.NET References: <87efjtdj14.fsf@gmail.com> Date: Sat, 07 Apr 2018 23:42:48 +0300 In-Reply-To: <87efjtdj14.fsf@gmail.com> (Tino Calancha's message of "Fri, 06 Apr 2018 14:02:31 +0900") Message-ID: <87370621fb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 31073 Cc: 31073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > The undo feature shouldn't change the case; it must return > to the original words. > > emacs -Q > < > M-% t RET FOO RET SPC SPC SPC SPC U > ;; The first line shows upcase 'T' at several positions, for instance > ;; it shows 'TexT', originally shown as 'text'. Good catch! This means we should have more test coverage. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 07 21:14:17 2018 Received: (at 31073) by debbugs.gnu.org; 8 Apr 2018 01:14:17 +0000 Received: from localhost ([127.0.0.1]:41654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4yuO-0007ng-TL for submit@debbugs.gnu.org; Sat, 07 Apr 2018 21:14:17 -0400 Received: from mail-pl0-f52.google.com ([209.85.160.52]:46420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4yuM-0007nS-QN for 31073@debbugs.gnu.org; Sat, 07 Apr 2018 21:14:15 -0400 Received: by mail-pl0-f52.google.com with SMTP id 59-v6so2936296plc.13 for <31073@debbugs.gnu.org>; Sat, 07 Apr 2018 18:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=swtAa8HIhIvrH8aBGFfpEfAaq+vv84pb47esUD15yWo=; b=WuG8u18XyetHA0E5qVMokwW2s9YpFivcnskKIStuHMYn0EooIc0WBX+mLl/w6rxvOw f/FpYqssMjOzUaT9kxa2EzrsCjOnV36jueBItYGc0+jX9FyIkRkxyByH4ITNE9rr8Gjz EOkm8zxza8FIMwCCQ0M64pefxjyJqNTIIAgAYSSUnIqI2NJ++Kpp8OMLuDJyJgbMU2vx l1TmXV3BtdJXCCEzw83esX82OB+wnuAUXcQpVlHDBtIdkSiiwXwkcAAnpSOY0TczyLgr DMgc1UwxCOp7CbDlnU6HgdMcRamEuqZuudzFOAqlC893WcU3DvamyIvfbV9iy0K7YTaL aXHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=swtAa8HIhIvrH8aBGFfpEfAaq+vv84pb47esUD15yWo=; b=CSi0Qtq7eG5hRM0eK7pNq5GfCjZiiGRFHaTW1ykXdu15RhoKAoM0uZBxzqpz+mP1B0 nz2QG31XtWVv4zMEy3oqd7hCBaFtuifVChFf0pGyyiFQ4Tz+ttZDkC7a7px7B/vd1Ijp Z4+9L9bdPKsU/GwSAm9NIU5cimN3Y5LazfsiwbDRZF7Jj2PaDoUNPWEV1XBzClOxD3F8 DqkAjJrPigcDOI6Kl/PwOr6RhPbBRFmcT08eoEo3J3obPGg1O3dqp6o3LO2uYF4/6R0k 4RWAVU17QIuf2C7GZPWhnHU5wnTNPJN2bYwFgnt+G6kMTV9PNCcoWTbz97+t+6fm/FYl Xz4g== X-Gm-Message-State: AElRT7GtoycMI5Eak0gJO66w9Z1qVEoZ8A8jWMqBESqjcjvMm41I/RXU zY2AS9Xu4gMxEir19QGmbZk= X-Google-Smtp-Source: AIpwx49zPJjOoqyhYAITa6GuvpO+SnM55jvD7lwpoaVrNDkm2PYj5phqFACq0ZNwy0Agw9qo1kQmyA== X-Received: by 2002:a17:902:8f84:: with SMTP id z4-v6mr33053657plo.210.1523150049095; Sat, 07 Apr 2018 18:14:09 -0700 (PDT) Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id l64sm22022758pga.33.2018.04.07.18.14.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Apr 2018 18:14:08 -0700 (PDT) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#31073: 27.0.50; query-replace undo might change the word case References: <87efjtdj14.fsf@gmail.com> <87370621fb.fsf@mail.linkov.net> Date: Sun, 08 Apr 2018 10:14:01 +0900 In-Reply-To: <87370621fb.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 07 Apr 2018 23:42:48 +0300") Message-ID: <87a7ueebza.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31073 Cc: Juri Linkov , 31073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> The undo feature shouldn't change the case; it must return >> to the original words. >> >> emacs -Q >> < >> M-% t RET FOO RET SPC SPC SPC SPC U >> ;; The first line shows upcase 'T' at several positions, for instance >> ;; it shows 'TexT', originally shown as 'text'. > > Good catch! This means we should have more test coverage. Thanks. Eli, this feature was introduced for Emacs-26 release. Should the fix go into that branch (Emacs-26)? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 07 22:33:49 2018 Received: (at 31073) by debbugs.gnu.org; 8 Apr 2018 02:33:49 +0000 Received: from localhost ([127.0.0.1]:41681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f509N-0001AG-1Y for submit@debbugs.gnu.org; Sat, 07 Apr 2018 22:33:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f509K-0001A3-UF for 31073@debbugs.gnu.org; Sat, 07 Apr 2018 22:33:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f509E-0007ky-Pn for 31073@debbugs.gnu.org; Sat, 07 Apr 2018 22:33:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5098-0007gK-3q; Sat, 07 Apr 2018 22:33:34 -0400 Received: from [176.228.60.248] (port=2773 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f5097-0007fm-Hn; Sat, 07 Apr 2018 22:33:33 -0400 Date: Sun, 08 Apr 2018 05:33:34 +0300 Message-Id: <83tvsmzatd.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87a7ueebza.fsf@gmail.com> (message from Tino Calancha on Sun, 08 Apr 2018 10:14:01 +0900) Subject: Re: bug#31073: 27.0.50; query-replace undo might change the word case References: <87efjtdj14.fsf@gmail.com> <87370621fb.fsf@mail.linkov.net> <87a7ueebza.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31073 Cc: juri@jurta.org, 31073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Tino Calancha > Cc: 31073@debbugs.gnu.org, Juri Linkov > Date: Sun, 08 Apr 2018 10:14:01 +0900 > > Juri Linkov writes: > > >> The undo feature shouldn't change the case; it must return > >> to the original words. > >> > >> emacs -Q > >> < > >> M-% t RET FOO RET SPC SPC SPC SPC U > >> ;; The first line shows upcase 'T' at several positions, for instance > >> ;; it shows 'TexT', originally shown as 'text'. > > > > Good catch! This means we should have more test coverage. Thanks. > Eli, > > this feature was introduced for Emacs-26 release. Should the fix go > into that branch (Emacs-26)? It's too late for Emacs 26.1. For the other 26.x, I'd need to see the patch first. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 07 22:46:26 2018 Received: (at 31073) by debbugs.gnu.org; 8 Apr 2018 02:46:26 +0000 Received: from localhost ([127.0.0.1]:41697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f50La-0001Uq-CE for submit@debbugs.gnu.org; Sat, 07 Apr 2018 22:46:26 -0400 Received: from mail-pl0-f42.google.com ([209.85.160.42]:43953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f50LZ-0001Ua-9q for 31073@debbugs.gnu.org; Sat, 07 Apr 2018 22:46:25 -0400 Received: by mail-pl0-f42.google.com with SMTP id a39-v6so3002975pla.10 for <31073@debbugs.gnu.org>; Sat, 07 Apr 2018 19:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8SVzjnFh2RpRssFEcQB8Moq5/jbEaJu/EUakbK9djEI=; b=iLqVhpNbJzqu7JW37dldmKpVqjXBtomEjvsCc6m1b9n87IQ5IH8Jmp9fSiHi3V4mQB yMsp8Iw+wKXEEquve1bQkVaV0km5NFO+hErwPYSnviyTIdpOhZHXPZalAjrAuWzgv4fA PH44XPiUfyFplSTva7OPEDHwNNaWV42Tqp2N8r6u/LVkUq7i6uk2o8WIViDE+pkom88v IRH6PCXwt2obF4dLmS+UAxq3Pm9Mj+35QlAk2ECGKKLJwsU9r7z0V7XQVFaI50mIjXeB kVUWMA++s0r9eTijfU5WgmllLkbTLnnTH/g3Qs/x+e9agDjeHKF175FHupWaLCQJkDTU 3L5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8SVzjnFh2RpRssFEcQB8Moq5/jbEaJu/EUakbK9djEI=; b=qPJsriRaksGg/OP8Ya1OeTrNKkUnHe9FfaSzS37fROdDGMqFb+F6Lb8PtkHf0iiMVO wVtxewkWF5UzJej4Au3SiVbCMfYZimlmQuh8lxnOsLav/XP2ossaRpu/Ihtmwiyzy4qV BN+632OXljZHj/4iroSG9vumUEo3sKTL5xwdyPYXoKx6a9HZ5RZFfxxr2fmKKB3lsC2h aYAuY/6TyN0p2UnR7mpZA4ncpatC8LTN+JRNH5bXyNgtq4+KuDja9qoaMLE7ikK010eO b2RtsAKPvBX0cJJ9qSgEKlBxRnW8MOi4tgeHsVGlvGs/xrNqi0FG5ALa2Tkz6+PWGq+/ te8Q== X-Gm-Message-State: AElRT7E6n3aqhXNDadXmeD0J9EMJbrMqkAEqgtyfVuiLcD3DUX5vGIyY 1VcZ+rtM+UH2FhSGEfTHWHxRSFa6 X-Google-Smtp-Source: AIpwx4/IdSMjiNNI59J6rJ+3JFh7lOXKMYPTTyoOD6B8d9w+g3RjEBdpW3LKqHjm6BeSIMY5LLCCmg== X-Received: by 2002:a17:902:5681:: with SMTP id j1-v6mr33565682pli.383.1523155579330; Sat, 07 Apr 2018 19:46:19 -0700 (PDT) Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id w26sm29694438pfi.17.2018.04.07.19.46.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Apr 2018 19:46:18 -0700 (PDT) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#31073: 27.0.50; query-replace undo might change the word case References: <87efjtdj14.fsf@gmail.com> <87370621fb.fsf@mail.linkov.net> <87a7ueebza.fsf@gmail.com> <83tvsmzatd.fsf@gnu.org> Date: Sun, 08 Apr 2018 11:46:15 +0900 In-Reply-To: <83tvsmzatd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Apr 2018 05:33:34 +0300") Message-ID: <876052e7pk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31073 Cc: juri@jurta.org, 31073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> this feature was introduced for Emacs-26 release. Should the fix go >> into that branch (Emacs-26)? > > It's too late for Emacs 26.1. For the other 26.x, I'd need to see the > patch first. I see. The patch is pretty obvious: just 1 line: --8<-----------------------------cut here---------------start------------->8--- commit a70414e82048f425cdb00e3cd30c15fcb9fbab86 Author: Tino Calancha Date: Fri Apr 6 14:03:55 2018 +0900 Preserve case in query-replace undo If the user query and replaces 'foo' with 'BAR', then undo must comeback to 'foo', not to 'FOO' (Bug#31073). * lisp/replace.el (perform-replace): Bind nocasify to non-nil value during undo/undo-all actions. diff --git a/lisp/replace.el b/lisp/replace.el index c28c9b36f0..2b0555d580 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -2619,6 +2619,7 @@ perform-replace (let ((stack-idx 0) (stack-len (length stack)) (num-replacements 0) + (nocasify t) ; Bug#31073. search-string next-replacement) (while (and (< stack-idx stack-len) --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 27.0.50 (build 25, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) Repository revision: 8df23a82042fa7dbaaa4377bc376d705595b073f From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 08 08:53:53 2018 Received: (at 31073) by debbugs.gnu.org; 8 Apr 2018 12:53:53 +0000 Received: from localhost ([127.0.0.1]:41996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f59pQ-0000y9-Qp for submit@debbugs.gnu.org; Sun, 08 Apr 2018 08:53:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f59pP-0000xx-Dg for 31073@debbugs.gnu.org; Sun, 08 Apr 2018 08:53:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f59pH-0001YF-43 for 31073@debbugs.gnu.org; Sun, 08 Apr 2018 08:53:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f59pH-0001Y9-0B; Sun, 08 Apr 2018 08:53:43 -0400 Received: from [176.228.60.248] (port=3098 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f59pG-0005ea-5y; Sun, 08 Apr 2018 08:53:42 -0400 Date: Sun, 08 Apr 2018 15:53:44 +0300 Message-Id: <83sh85zwo7.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <876052e7pk.fsf@gmail.com> (message from Tino Calancha on Sun, 08 Apr 2018 11:46:15 +0900) Subject: Re: bug#31073: 27.0.50; query-replace undo might change the word case References: <87efjtdj14.fsf@gmail.com> <87370621fb.fsf@mail.linkov.net> <87a7ueebza.fsf@gmail.com> <83tvsmzatd.fsf@gnu.org> <876052e7pk.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 31073 Cc: juri@jurta.org, 31073@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Tino Calancha > Cc: juri@jurta.org, 31073@debbugs.gnu.org > Date: Sun, 08 Apr 2018 11:46:15 +0900 > > Eli Zaretskii writes: > > >> this feature was introduced for Emacs-26 release. Should the fix go > >> into that branch (Emacs-26)? > > > > It's too late for Emacs 26.1. For the other 26.x, I'd need to see the > > patch first. > I see. > The patch is pretty obvious: just 1 line: Thanks. This is indeed OK for the emacs-26 branch, but please wait with pushing this until Emacs 26.1 is released, hopefully soon enough. Alternatively, feel free to push to master and cherry-pick to emacs-26 later, after the 26.1 release. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 08 22:55:15 2018 Received: (at 31073-done) by debbugs.gnu.org; 9 Apr 2018 02:55:16 +0000 Received: from localhost ([127.0.0.1]:43005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f5Mxf-0002lo-O0 for submit@debbugs.gnu.org; Sun, 08 Apr 2018 22:55:15 -0400 Received: from mail-pl0-f52.google.com ([209.85.160.52]:36638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f5Mxd-0002lb-Fp for 31073-done@debbugs.gnu.org; Sun, 08 Apr 2018 22:55:13 -0400 Received: by mail-pl0-f52.google.com with SMTP id 91-v6so4277939pld.3 for <31073-done@debbugs.gnu.org>; Sun, 08 Apr 2018 19:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=EXyJUXBIYo81sQEb0yRCmXRLgW26qlUasyhcXU6qhnQ=; b=VkuhJALMuk2MrZNgoKejPhoke9WzSd2LgziZSdRGpHHVc3ZH3xDYUFFIu33/SGNc+s 2I+f2St4ofLq1GXj5gPcdzsC5wg/fbJsDwJe69zoRC5Wt326psKpU5Wuv+g6aASm2jwd Nljz0hcYJfNBUI0Pj9X/+hiaBXXumb3TLyaPQAaazMS44FM1XV+ttkISGzj59xYoaWgv rxIfbcVCEf0pA/albw/N90igOVtw+e8gWvbTgZ7Nq2oNq88FVmipZAX3f9GFWCEaUFHl kx9qshygqqX2dVR7L08yj0uCIAhGcFvlBrgGDKoh0JFidTy/dO4v98VHHHofXzldxwjk QrRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EXyJUXBIYo81sQEb0yRCmXRLgW26qlUasyhcXU6qhnQ=; b=OH0Hych2Z4Ev7tNRCGIAukq1KyU08S/7CLQaxUIGY4+yds09Whs+Y2rMe4XFj6autI FxhjDVRki9akF5vsfxdy9ldvg1IvwLw3FWXamcgVttbTgy2sCS5sajvwKSXpHDxk7SVh a25/f/N1Z8s69f/HPA+knAEweOIf5I27KHucVbiphGz2FmrUvf8jnprxVwtJwOV303Eh bhcjoi7rUlwQvEKE30MvET4HCZiKpB9DR6Tfj3Y2vxbbeSmRAwvZGRdNTUsp6mFHbyfX DR7iiiMsrMUor3GlytNw5NyoXYTD+vvw3Ggr8unZJhoANaRYh+2vznmWQz0FOpTb+Qqv 8bLQ== X-Gm-Message-State: AElRT7EF1Pdt7SaBIaIt8vwjVfyxQA/+DEM296zGbnpa67sMZ31BGrWb 8DQhmPDnkax7I/6nkgaOXBS4UQ== X-Google-Smtp-Source: AIpwx4968/eP6G4YPZQn3ykYM/1uJHkMxNx5AVYhDzQw6MTyjz0nX6ACYkQTQFtfVm9HAhS9Iwccug== X-Received: by 2002:a17:902:8501:: with SMTP id bj1-v6mr37640038plb.239.1523242507390; Sun, 08 Apr 2018 19:55:07 -0700 (PDT) Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id s14sm23727670pgc.28.2018.04.08.19.55.05 for <31073-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Apr 2018 19:55:06 -0700 (PDT) From: Tino Calancha To: 31073-done@debbugs.gnu.org Subject: Re: bug#31073: 27.0.50; query-replace undo might change the word case References: <87efjtdj14.fsf@gmail.com> <87370621fb.fsf@mail.linkov.net> <87a7ueebza.fsf@gmail.com> <83tvsmzatd.fsf@gnu.org> <876052e7pk.fsf@gmail.com> <83sh85zwo7.fsf@gnu.org> Date: Mon, 09 Apr 2018 11:55:00 +0900 In-Reply-To: <83sh85zwo7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 Apr 2018 15:53:44 +0300") Message-ID: <873705dr7f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 31073-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> The patch is pretty obvious: just 1 line: > > Thanks. This is indeed OK for the emacs-26 branch, but please wait > with pushing this until Emacs 26.1 is released, hopefully soon enough. > > Alternatively, feel free to push to master and cherry-pick to emacs-26 > later, after the 26.1 release. Pushed fix into master branch as commit "Preserve case in query-replace undo" (32dc0cb1b5ae895d237c7118ccaeb084715934fd). I will backport the fix to emacs-26 after 26.1 release. From unknown Sat Jun 21 02:59:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 May 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator