GNU bug report logs - #31066
[PATCH] gnu: xapers: Fix man page and xapers-adder installation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31066 in the body.
You can then email your comments to 31066 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Massmann <massmannak <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: xapers: Fix man page and xapers-adder installation
Date: Wed, 04 Apr 2018 19:10:08 -0400

[Message part 1 (text/plain, inline)]

Hi,

I found a bug in my recent contribution of xapers
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31007); my use of
"install-file" placed the man pages and xaper-adder in the wrong
directories. I am not sure how this made it past my tests, but I will be
much more careful in the future. I'm sorry for any inconvenience. A
patch to fix is attached.

Best,
Adam

[0001-gnu-xapers-Fix-man-page-and-xapers-adder-installatio.patch (text/x-diff, inline)]

From edaca7682afa090a0ae056e4db7d68573915d98c Mon Sep 17 00:00:00 2001
From: Adam Massmann <massmannak <at> gmail.com>
Date: Wed, 4 Apr 2018 18:14:11 -0400
Subject: [PATCH] gnu: xapers: Fix man page and xapers-adder installation

---
 gnu/packages/search.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/search.scm b/gnu/packages/search.scm
index 64846cffe..02deb5c4a 100644
--- a/gnu/packages/search.scm
+++ b/gnu/packages/search.scm
@@ -344,12 +344,9 @@ search the generated indexes.")
              (let* ((out (assoc-ref outputs "out"))
                     (bin (string-append out "/bin"))
                     (man1 (string-append out "/share/man/man1")))
-               (install-file "man/man1/xapers.1"
-                             (string-append man1 "/xapers.1"))
-               (install-file "man/man1/xapers-adder.1"
-                             (string-append man1 "/xapers-adder.1"))
-               (install-file "bin/xapers-adder"
-                             (string-append bin "/xapers-adder"))))))))
+               (install-file "man/man1/xapers.1"  man1)
+               (install-file "man/man1/xapers-adder.1" man1)
+               (install-file "bin/xapers-adder" bin)))))))
     (home-page "https://finestructure.net/xapers/")
     (synopsis "Personal document indexing system")
     (description
-- 
2.11.0

Message #10 received at 31066-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Adam Massmann <massmannak <at> gmail.com>
Cc: 31066-done <at> debbugs.gnu.org
Subject: Re: [bug#31066] [PATCH] gnu: xapers: Fix man page and xapers-adder
 installation
Date: Wed, 4 Apr 2018 21:32:15 -0500

[Message part 1 (text/plain, inline)]

On Wed, 04 Apr 2018 19:10:08 -0400
Adam Massmann <massmannak <at> gmail.com> wrote:

> Hi,
> 
> I found a bug in my recent contribution of xapers
> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31007); my use of
> "install-file" placed the man pages and xaper-adder in the wrong
> directories. I am not sure how this made it past my tests, but I will be
> much more careful in the future. I'm sorry for any inconvenience. A
> patch to fix is attached.
> 
> Best,
> Adam
> 

Thank you for the quick fix.
Pushed in b357ccdd8b6824a49f750e0f6b1afb87683adb82

Happy Hacking,
`~Eric

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.