From unknown Sun Aug 17 09:08:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#31063 <31063@debbugs.gnu.org> To: bug#31063 <31063@debbugs.gnu.org> Subject: Status: 27.0.50; improve help for advised functions Reply-To: bug#31063 <31063@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:08:53 +0000 retitle 31063 27.0.50; improve help for advised functions reassign 31063 emacs submitter 31063 charles@aurox.ch (Charles A. Roelli) severity 31063 wishlist tag 31063 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 04 14:42:55 2018 Received: (at submit) by debbugs.gnu.org; 4 Apr 2018 18:42:55 +0000 Received: from localhost ([127.0.0.1]:38628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3nN1-0008R5-KK for submit@debbugs.gnu.org; Wed, 04 Apr 2018 14:42:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3nN0-0008Qu-UR for submit@debbugs.gnu.org; Wed, 04 Apr 2018 14:42:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3nMv-00020O-8G for submit@debbugs.gnu.org; Wed, 04 Apr 2018 14:42:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f3nMv-00020J-4W for submit@debbugs.gnu.org; Wed, 04 Apr 2018 14:42:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3nMu-000060-3M for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 14:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3nMp-0001zG-84 for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 14:42:48 -0400 Received: from [2a03:2040:2:1b::1] (port=55888 helo=sinyavsky.aurox.ch) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f3nMp-0001z6-0Z for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 14:42:43 -0400 Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 6DA94226FB for ; Wed, 4 Apr 2018 18:43:46 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-transfer-encoding:content-type:content-type:mime-version :subject:subject:to:from:from:message-id:date:date; s=dkim; t= 1522867426; x=1523731427; bh=vKw1Bh8NnsM/UsdAnTmxNjrwc2KoFmLKSxL rNNhwLmI=; b=DcnXoakZKSikRlh8NTgp8q20kBmO3gho2NvzBKh61OHCek6BHRk ExkhI0W/SklKDcW0nq5YXEIUcXVf8fQwxlRkzTZzt8GOstobZf8vMhqH9EdD6XaR ieWxsIxn9hwcQEc9GEkRp0Rnol8FuK4jctVlwQg7EAY/dh4Zw/aiU1ag= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2MoM3lhCOCDq for ; Wed, 4 Apr 2018 18:43:46 +0000 (UTC) Received: from gray (202.100.1.85.dynamic.wline.res.cust.swisscom.ch [85.1.100.202]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id EC818226F6 for ; Wed, 4 Apr 2018 18:43:45 +0000 (UTC) Date: Wed, 04 Apr 2018 20:43:36 +0200 Message-Id: From: charles@aurox.ch (Charles A. Roelli) To: bug-gnu-emacs@gnu.org Subject: 27.0.50; improve help for advised functions MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Getting help on an advised function looks like this: > eval-defun is an interactive compiled Lisp function in > =E2=80=98elisp-mode.el=E2=80=99. >=20 > (eval-defun EDEBUG-IT) >=20 > :override advice: =E2=80=98edebug-eval-defun=E2=80=99 (where ":override advice:" is highlighted in orange) Could we please remove (or amend) the orange color for readability, make the indication of advice a full sentence, and possibly explain the meaning of the different advices? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 11:50:29 2019 Received: (at 31063) by debbugs.gnu.org; 13 Jul 2019 15:50:29 +0000 Received: from localhost ([127.0.0.1]:43209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmKI9-00051s-91 for submit@debbugs.gnu.org; Sat, 13 Jul 2019 11:50:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:36252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmKI8-00051k-3g for 31063@debbugs.gnu.org; Sat, 13 Jul 2019 11:50:28 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmKI4-0001z8-7b; Sat, 13 Jul 2019 17:50:26 +0200 From: Lars Ingebrigtsen To: charles@aurox.ch (Charles A. Roelli) Subject: Re: bug#31063: 27.0.50; improve help for advised functions References: Date: Sat, 13 Jul 2019 17:50:23 +0200 In-Reply-To: (Charles A. Roelli's message of "Wed, 04 Apr 2018 20:43:36 +0200") Message-ID: <87muhiszls.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: charles@aurox.ch (Charles A. Roelli) writes: > Getting help on an advised function looks like this: > >> eval-defun is an interactive compiled Lisp function in >> ‘elisp-mode.el’. >> >> (eval-defun EDEBUG-IT) >> >> :override advice: ‘edebu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31063 Cc: 31063@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) charles@aurox.ch (Charles A. Roelli) writes: > Getting help on an advised function looks like this: > >> eval-defun is an interactive compiled Lisp function in >> =E2=80=98elisp-mode.el=E2=80=99. >>=20 >> (eval-defun EDEBUG-IT) >>=20 >> :override advice: =E2=80=98edebug-eval-defun=E2=80=99 > > (where ":override advice:" is highlighted in orange) > > Could we please remove (or amend) the orange color for readability, > make the indication of advice a full sentence, and possibly explain > the meaning of the different advices? I've now made it into a complete sentence on the Emacs trunk. I think it's probably beyond the scope of the doc function to explain what the advices mean in detail... I also removed the warning face, but feel free to put that back if somebody thinks that this deserves a warning. It seemed a bit too dramatic to me. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 11:50:34 2019 Received: (at control) by debbugs.gnu.org; 13 Jul 2019 15:50:35 +0000 Received: from localhost ([127.0.0.1]:43212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmKIE-00052G-JX for submit@debbugs.gnu.org; Sat, 13 Jul 2019 11:50:34 -0400 Received: from quimby.gnus.org ([80.91.231.51]:36266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmKIC-000528-PT for control@debbugs.gnu.org; Sat, 13 Jul 2019 11:50:33 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmKIA-0001zF-8F for control@debbugs.gnu.org; Sat, 13 Jul 2019 17:50:32 +0200 Date: Sat, 13 Jul 2019 17:50:29 +0200 Message-Id: <87lfx2szlm.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #31063 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 31063 fixed close 31063 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 31063 fixed close 31063 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 16:02:50 2019 Received: (at 31063) by debbugs.gnu.org; 14 Jul 2019 20:02:50 +0000 Received: from localhost ([127.0.0.1]:46024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmkhu-0006Tr-2X for submit@debbugs.gnu.org; Sun, 14 Jul 2019 16:02:50 -0400 Received: from caracal.birch.relay.mailchannels.net ([23.83.209.30]:33538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmkhr-0006Th-Kf for 31063@debbugs.gnu.org; Sun, 14 Jul 2019 16:02:48 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 84D052C18F7; Sun, 14 Jul 2019 20:02:46 +0000 (UTC) Received: from pdx1-sub0-mail-a64.g.dreamhost.com (100-96-35-167.trex.outbound.svc.cluster.local [100.96.35.167]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 136CD2C152D; Sun, 14 Jul 2019 20:02:46 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a64.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Sun, 14 Jul 2019 20:02:46 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Suffer-Illegal: 30822ba409f79662_1563134566374_1008058437 X-MC-Loop-Signature: 1563134566374:2882008754 X-MC-Ingress-Time: 1563134566374 Received: from pdx1-sub0-mail-a64.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTP id C7DD17FD7C; Sun, 14 Jul 2019 13:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=NBCzU3 Y8FjIASSjDMGIXCXyOPjk=; b=gfaAN7j2cbZ3BdpXFVGJMK857ujRV1ioKwKmxY jqmoWbGBzOo4eoxzYJLnpdNSkmOWJ7cUDnG6KTtklpebi7rr9wX41m3deGT36qFd elscNlqX4SGZhGUpm+YRZhW7Km8YleTG0zjQEqJ3g9xHvl8vv+Xa9dUoA8d+BcXi LI9ig= Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTPSA id BA1797FDFA; Sun, 14 Jul 2019 13:02:38 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a64 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#31063: 27.0.50; improve help for advised functions Organization: LINKOV.NET References: <87muhiszls.fsf@mouse.gnus.org> Date: Sun, 14 Jul 2019 22:55:50 +0300 In-Reply-To: <87muhiszls.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 13 Jul 2019 17:50:23 +0200") Message-ID: <874l3otmpl.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrheehgddugeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrudefgeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrddufeegpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheplhgrrhhsihesghhnuhhsrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31063 Cc: "Charles A. Roelli" , 31063@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Getting help on an advised function looks like this: >> >>> eval-defun is an interactive compiled Lisp function in >>> =E2=80=98elisp-mode.el=E2=80=99. >>>=20 >>> (eval-defun EDEBUG-IT) >>>=20 >>> :override advice: =E2=80=98edebug-eval-defun=E2=80=99 >> >> (where ":override advice:" is highlighted in orange) >> >> Could we please remove (or amend) the orange color for readability, > > I also removed the warning face, but feel free to put that back if > somebody thinks that this deserves a warning. It seemed a bit too > dramatic to me. It could have a link on ":override advice:" clicking on which will visit the advice definition. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 16:07:41 2019 Received: (at 31063) by debbugs.gnu.org; 14 Jul 2019 20:07:41 +0000 Received: from localhost ([127.0.0.1]:46032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmkmb-0006bN-3Z for submit@debbugs.gnu.org; Sun, 14 Jul 2019 16:07:41 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmkmZ-0006bF-5Z for 31063@debbugs.gnu.org; Sun, 14 Jul 2019 16:07:39 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmkmV-0005Zd-NR; Sun, 14 Jul 2019 22:07:38 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#31063: 27.0.50; improve help for advised functions References: <87muhiszls.fsf@mouse.gnus.org> <874l3otmpl.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEWpqanFxMTh39wLCAnV 1NL5+PTr6eVaWVnn90ycAAACTklEQVQ4jV3UO2/jMAwAYKpJ49Uq3Hp1CFVde/DQNfYpl7UpIs+t 4bBrjNxVf/9IyXEfHAKEHySSsmyov8fjmAOEUNfwI08fxFEx/Gotmc0F7mg1g6UB1ENdP4UTBBpm GLEH//AawtiiG+ktwprhr829fy4AVIv6g6oCe6I3Abz2/rBk2ABHJj82QrX1fi+gW7T2HdHSSmCs jt4PAkuHFitEmiA/+pet4g2uEFsBpJUUH5dHjx4SbHjoEEDx2KBW1G19w3DT446zUHMD5xr0VWuQ 9gKIjUU0i0znDFyaY59WNJZ6s8u0Zrj/BMK1JeobBq6xndI63NgI5MoIt3wgyr9Qn6lGax5imIAP ZPS+I1osneMhsJ3hmXfrjlQWEUzr8gj//KsX8Afpb3AcF1hxvuMO7vdbBl1M4NocwvlRWntX1wfX 6AlQnlhf8lb8WLYDg55AWkfDPQDkK95qBlmC98t4AP7QzNAmeL0dZEujvwAKeFi6Fo2L0CToqWfo nOERJO9m6AVIRvsOxH3x4XPZQvK6SDB1FSHl3dfiHAx3FONBfYO1Lv6kYX7LvZ+64hvVQPjwnQDf lXNa0SPP0KjLil2AhRTHXnYyDOli+BJOCWwUBnuBkCCGqU4TUAnZQmqYJg62Brjj9PET+IXJQeeV cvJoqGOIxQ2clFY63+gizUepuJG3S8465+JyOmizuGLNb7HiPOS66Pl8ea4E1SkLIPmSt+ILYLRL IA+T77TKS1XEtl2eTUdi5F+jF3UdYpzjx+PykXma/s/x4+vzGf8BOODpa1MsxUwAAAAASUVORK5C YII= Date: Sun, 14 Jul 2019 22:07:35 +0200 In-Reply-To: <874l3otmpl.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 14 Jul 2019 22:55:50 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >>>> (eval-defun EDEBUG-IT) >>>> >>>> :override advice: ‘edebug-eval-defun’ >>> >>> (where ":override advice:" is highlighted in orange) >>> >>> Could we please remove (or amend) the orange color [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31063 Cc: "Charles A. Roelli" , 31063@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >>>> (eval-defun EDEBUG-IT) >>>>=20 >>>> :override advice: =E2=80=98edebug-eval-defun=E2=80=99 >>> >>> (where ":override advice:" is highlighted in orange) >>> >>> Could we please remove (or amend) the orange color for readability, >> >> I also removed the warning face, but feel free to put that back if >> somebody thinks that this deserves a warning. It seemed a bit too >> dramatic to me. > > It could have a link on ":override advice:" clicking on which will > visit the advice definition. That would be nice. Do we have that information? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 16:57:38 2019 Received: (at 31063) by debbugs.gnu.org; 14 Jul 2019 20:57:38 +0000 Received: from localhost ([127.0.0.1]:46084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmlYw-0007u3-DU for submit@debbugs.gnu.org; Sun, 14 Jul 2019 16:57:38 -0400 Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:16768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmlYu-0007tu-Il for 31063@debbugs.gnu.org; Sun, 14 Jul 2019 16:57:37 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2AA6C1415BC; Sun, 14 Jul 2019 20:57:35 +0000 (UTC) Received: from pdx1-sub0-mail-a64.g.dreamhost.com (100-96-92-226.trex.outbound.svc.cluster.local [100.96.92.226]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A97361416B5; Sun, 14 Jul 2019 20:57:34 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a64.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Sun, 14 Jul 2019 20:57:35 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Occur-Trade: 5c117b7f324db391_1563137854985_64503314 X-MC-Loop-Signature: 1563137854985:1938629306 X-MC-Ingress-Time: 1563137854985 Received: from pdx1-sub0-mail-a64.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTP id E3C438305C; Sun, 14 Jul 2019 13:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=20zw8E Doji0qllY0VSgmCehAnuA=; b=Q8jFtp49iLSWAd/dJQWD1qwY+Or3XGu4P10AMX THPUFc5JrodVeJQANxjwLiO5gk0e143FULwcNPsV45nQnPCkUIJpwl+7TomUl+zN FBX6ehe+JcutgIL2kQ0AbCmSOj08rpZmZ9UBXa1w21+xqaCMsxicYttdVzPL5c4V 5C/fQ= Received: from mail.jurta.org (m91-129-103-134.cust.tele2.ee [91.129.103.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a64.g.dreamhost.com (Postfix) with ESMTPSA id E5B6D807DA; Sun, 14 Jul 2019 13:57:28 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a64 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#31063: 27.0.50; improve help for advised functions Organization: LINKOV.NET References: <87muhiszls.fsf@mouse.gnus.org> <874l3otmpl.fsf@mail.linkov.net> Date: Sun, 14 Jul 2019 23:55:33 +0300 In-Reply-To: (Lars Ingebrigtsen's message of "Sun, 14 Jul 2019 22:07:35 +0200") Message-ID: <87ftn8qqt6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrheehgdduheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrudefgeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrddufeegpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtoheplhgrrhhsihesghhnuhhsrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31063 Cc: "Charles A. Roelli" , 31063@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> (eval-defun EDEBUG-IT) >>>>> >>>>> :override advice: =E2=80=98edebug-eval-defun=E2=80=99 >>>> >>>> (where ":override advice:" is highlighted in orange) >>>> >>>> Could we please remove (or amend) the orange color for readability, >>> >>> I also removed the warning face, but feel free to put that back if >>> somebody thinks that this deserves a warning. It seemed a bit too >>> dramatic to me. >> >> It could have a link on ":override advice:" clicking on which will >> visit the advice definition. > > That would be nice. Do we have that information? I remember that old defadvice had some link in the Help buffer, but now I can't confirm this. But for new nadvice maybe this will work: if a piece of advice is at least a function defined by `defun' then maybe it's possible to display the body of advice with a link to the function defined by `defun'? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 15 06:12:48 2019 Received: (at 31063) by debbugs.gnu.org; 15 Jul 2019 10:12:48 +0000 Received: from localhost ([127.0.0.1]:46458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmxyS-0005Xv-7A for submit@debbugs.gnu.org; Mon, 15 Jul 2019 06:12:48 -0400 Received: from quimby.gnus.org ([80.91.231.51]:39952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmxyQ-0005Xm-6e for 31063@debbugs.gnu.org; Mon, 15 Jul 2019 06:12:46 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmxyL-0005cf-MK; Mon, 15 Jul 2019 12:12:44 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#31063: 27.0.50; improve help for advised functions References: <87muhiszls.fsf@mouse.gnus.org> <874l3otmpl.fsf@mail.linkov.net> <87ftn8qqt6.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEUUFBrS1cq1sIwMChAK CA4DAgdmXTbo6t1FRz1/dDsqMTqUiEJ+LDMUAAACNElEQVQ4jXXTT4vaQBgG8LfEFsmpSWG3y17W FLZaL8JIWbya/QTtQksvoYep4sm9DG0vaUtDjJeshWD0MrAgOnuRHsQ/X67vZKKJrn1AjM+PN5k4 CRj5lAzDiiIad+gI8r1lWRGlER2PF6GEbtqbVuBRGq/am81iDgbDpGQJj7bjOIVTKbsJbzxedbIJ NbKmrudh299slmtgKnKgdMYlrCSMcnDC2EuPdlb7gFJlrDyh/QTWebjslpaPAa9ufq+AgtVmHuaA sVsnhfEenLJy6El4OIDz7gVQhMUhnFhhg9LeYzCscsNr9eLFw+IAvmn6MTB/doFP/dk+GEaZF5l7 T4oI/aUC3LjIFwBguBqpzeKhgkvfF4EQHOHLxf0OHPB9rIXACp48f0XILBr21wp8BaBdvfiVQG89 DnMTmD8aIZNo1FvHCNMgAY2keYYQShDiAKizBbEHb1v/A5xwjsFVy/GctrODbU8aLbfn0h3wDPCp C45BjXJPUMdNoJwDokMG5qCqSukNmBQTmApxx5gCuTahCV1C9KOi00EpO5UA3pgi4Evntq0qaRJi K+BaDYCDUX0Dn/+u6jaxFehcflwwK+3OYBnWbZkEcAf0wIXz4euvxambAeAKdNxq4/aOzQEU2KTe lFDUOT4lZoWndZKavH28uFlxCzdJ3qdnw/UBrivQbrIg+JrdxBvVYNu9S8fEAXywnqoDIHazRmo7 +Gj+VgfNggTQgFwnvz+V1fe1jf8BECj8A+pZr0hZcFA2AAAAAElFTkSuQmCC Date: Mon, 15 Jul 2019 12:12:41 +0200 In-Reply-To: <87ftn8qqt6.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 14 Jul 2019 23:55:33 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >>>>>> (eval-defun EDEBUG-IT) >>>>>> >>>>>> :override advice: ‘edebug-eval-defun’ >>>>> >>>>> (where ":override advice:" is highlighted in orange) >>>>> >>>>> Could we please remove (or amend) the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 31063 Cc: "Charles A. Roelli" , 31063@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >>>>>> (eval-defun EDEBUG-IT) >>>>>> >>>>>> :override advice: =E2=80=98edebug-eval-defun=E2=80=99 >>>>> >>>>> (where ":override advice:" is highlighted in orange) >>>>> >>>>> Could we please remove (or amend) the orange color for readability, >>>> >>>> I also removed the warning face, but feel free to put that back if >>>> somebody thinks that this deserves a warning. It seemed a bit too >>>> dramatic to me. >>> >>> It could have a link on ":override advice:" clicking on which will >>> visit the advice definition. >> >> That would be nice. Do we have that information? > > I remember that old defadvice had some link in the Help buffer, but > now I can't confirm this. But for new nadvice maybe this will work: > if a piece of advice is at least a function defined by `defun' then > maybe it's possible to display the body of advice with a link to the > function defined by `defun'? Hm... isn't that what that `edebug-eval-defun' thing up there is, though? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Aug 17 09:08:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Aug 2019 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator