Subject: bug#31046: closed (Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 04 Apr 2018 11:57:02 +0000

Your bug report

#31046: [PATCH] gnu: chromaprint: Build fpcalc

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
31046: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31046
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
From: [email-masked] (Ludovic Courtès)
To: Pierre Neidhardt <[email-masked]>
Cc: [email-masked]
Date: Wed, 04 Apr 2018 13:56:02 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Pierre Neidhardt <[email-masked]> skribis:

> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
>  gnu/packages/mp3.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
>      (arguments
>       `(#:tests? #f ; tests require googletest *sources*
>         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc

[...]

> It's less than 40kb and does not require additional dependencies.
> The size of the closure (as returned by ~guix size chromaprint~) is
> 510.3 MB, just like before the patch.
>
> Considering how light it is, I don't think it's worth making a separate
> output.

Agreed.

I slightly adjusted the commit log to match the conventions and
committed.  Thank you!

Ludo’.

Subject: [PATCH] gnu: chromaprint: Build fpcalc
From: Pierre Neidhardt <[email-masked]>
To: [email-masked]
Date: Tue, 3 Apr 2018 19:53:56 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/mp3.scm (chromaprint): Build fpcalc
---
 gnu/packages/mp3.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 6dc58e2cc..f57ebf575 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -508,6 +508,7 @@ command-line tool.")
     (arguments
      `(#:tests? #f ; tests require googletest *sources*
        ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
+       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
        #:test-target "check"))
     (inputs
      ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
-- 
2.16.3