GNU bug report logs - #31039
27.0.50; allow silencing auto-save

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31039 in the body.
You can then email your comments to 31039 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; allow silencing auto-save
Date: Tue, 03 Apr 2018 02:06:22 -0700

Currently, keyboard.c calls do-auto-save directly and passes nil to the
NO-MESSAGE arg. It would be nice if there was a way to pass t in these
situations in order to suppress the message. Perhaps a new var to
suppress the auto-save message in all cases?

This has been asked about and/or hacked around (by disabling the normal
auto-save mechanisms and adding an idle timer) a number of times:

https://www.reddit.com/r/emacs/comments/63gmhd/silencing_autosave_messages/
https://emacs.stackexchange.com/questions/12556/disabling-the-auto-saving-done-message
http://pragmaticemacs.com/emacs/make-emacs-a-bit-quieter/

Message #8 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Federico <federicotedin <at> gmail.com>
To: aaronjensen <at> gmail.com
Cc: 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Fri, 3 Aug 2018 21:51:53 -0300

[Message part 1 (text/plain, inline)]

I've prepared a patch to add this feature (see attached file). Since
this is my first contribution to this project (and also my first time
sending a patch via email), it's possible I've made some mistakes
along the way. Any feedback is appreciated.

[auto-save-quiet.patch (text/x-diff, attachment)]

Message #11 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Federico <federicotedin <at> gmail.com>
Cc: aaronjensen <at> gmail.com, 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Sun, 05 Aug 2018 22:43:16 -0400

tags 31039 + patch
quit

Federico <federicotedin <at> gmail.com> writes:

> I've prepared a patch to add this feature (see attached file). Since
> this is my first contribution to this project (and also my first time
> sending a patch via email), it's possible I've made some mistakes
> along the way. Any feedback is appreciated.

If you can add a NEWS entry mentioning the new variable, it should be
just about ready.

By the way, this patch is small enough to be added regardless, but if
you plan to send much more (the limit is about 15 lines, cumulative for
all of your patches), then you might want to think about getting started
on the copyright assignment.

> +  DEFVAR_LISP ("auto-save-quiet", auto_save_quiet,
> +	       doc: /* Non-nil means do not print any message when auto-saving. */);
> +  auto_save_quiet = Qnil;

The C name of the variable should start with V, like the others.

>    DEFVAR_LISP ("auto-save-timeout", Vauto_save_timeout,
>  	       doc: /* Number of seconds idle time before auto-save.
>  Zero or nil means disable auto-saving due to idleness.

Message #16 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 31039 <at> debbugs.gnu.org, aaronjensen <at> gmail.com, federicotedin <at> gmail.com
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Mon, 06 Aug 2018 17:56:51 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Sun, 05 Aug 2018 22:43:16 -0400
> Cc: aaronjensen <at> gmail.com, 31039 <at> debbugs.gnu.org
> 
> > +  DEFVAR_LISP ("auto-save-quiet", auto_save_quiet,
> > +	       doc: /* Non-nil means do not print any message when auto-saving. */);
> > +  auto_save_quiet = Qnil;
> 
> The C name of the variable should start with V, like the others.

For a boolean variable, one can use DEFVAR_BOOL, in which case the
"start with V" nuisance can be avoided (and the code will be a tad
more efficient, too).

Message #19 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 31039 <at> debbugs.gnu.org, aaronjensen <at> gmail.com, federicotedin <at> gmail.com
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Mon, 06 Aug 2018 18:05:33 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Sun, 05 Aug 2018 22:43:16 -0400
> Cc: aaronjensen <at> gmail.com, 31039 <at> debbugs.gnu.org
> 
> I've prepared a patch to add this feature (see attached file). Since
> this is my first contribution to this project (and also my first time
> sending a patch via email), it's possible I've made some mistakes
> along the way. Any feedback is appreciated.

Thanks.

> * src/keyboarc.c (auto_save_quiet): New variable, allows suppressing
        ^^^^^^^^

A typo.

> diff --git a/doc/emacs/files.texi b/doc/emacs/files.texi
> index a7cc57e4e9..0635aeba71 100644
> --- a/doc/emacs/files.texi
> +++ b/doc/emacs/files.texi
> @@ -1023,11 +1023,12 @@ Auto Save
>  
>    When Emacs determines that it is time for auto-saving, it considers
>  each buffer, and each is auto-saved if auto-saving is enabled for it
> -and it has been changed since the last time it was auto-saved.  The
> -message @samp{Auto-saving...} is displayed in the echo area during
> -auto-saving, if any files are actually auto-saved.  Errors occurring
> -during auto-saving are caught so that they do not interfere with the
> -execution of commands you have been typing.
> +and it has been changed since the last time it was auto-saved.  When
> +the @code{auto-save-quiet} variable is set to @code{nil}, the message
> +@samp{Auto-saving...} is displayed in the echo area during auto-saving,
> +if any files are actually auto-saved.  Errors occurring during auto-saving
> +are caught so that they do not interfere with the execution of commands
> +you have been typing.

Each variable (and function and command and macro and ...) described
in the manual must be indexed.  So please add

  @vindex auto-save-quiet

before this paragraph.

Also, this text should say what is the default of this variable.

Btw, I'd prefer to call the variable auto-save-no-message.
auto-save-quiet might not make its intent clear enough, IMO.

Thanks.

Message #22 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Federico <federicotedin <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Noam Postavsky <npostavs <at> gmail.com>, Aaron Jensen <aaronjensen <at> gmail.com>,
 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Mon, 6 Aug 2018 20:02:28 -0300

[Message part 1 (text/plain, inline)]

Noam, Eli: I've applied the fixes you have both mentioned. I ended up
using DEFVAR_BOOL to create the variable, but I'm not sure I used the
variable correctly when calling Fdo_auto_save (the function only takes
Lisp_Object). I have attached a new patch.

Regarding the copyright assignment, mine was approved one or two weeks ago.

Thanks

[auto-save-no-message.patch (text/x-diff, attachment)]

Message #25 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico <federicotedin <at> gmail.com>
Cc: npostavs <at> gmail.com, aaronjensen <at> gmail.com, 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Tue, 07 Aug 2018 17:54:39 +0300

> From: Federico <federicotedin <at> gmail.com>
> Date: Mon, 6 Aug 2018 20:02:28 -0300
> Cc: Noam Postavsky <npostavs <at> gmail.com>, Aaron Jensen <aaronjensen <at> gmail.com>, 31039 <at> debbugs.gnu.org
> 
> Noam, Eli: I've applied the fixes you have both mentioned. I ended up
> using DEFVAR_BOOL to create the variable, but I'm not sure I used the
> variable correctly when calling Fdo_auto_save (the function only takes
> Lisp_Object). I have attached a new patch.

LGTM, thanks.

> Regarding the copyright assignment, mine was approved one or two weeks ago.

I don't yet see it on file, but that doesn't have to hold this
contribution.

Message #28 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Federico <federicotedin <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Noam Postavsky <npostavs <at> gmail.com>, Aaron Jensen <aaronjensen <at> gmail.com>,
 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Tue, 7 Aug 2018 15:36:38 -0300

Great! Is anything else required on my side?

> I don't yet see it on file, but that doesn't have to hold this
> contribution.

That's strange, considering they've already signed the PDF and sent it
to me. I'll send an email to copright-clerk <at> fsf.org to see if there
have been any problems.

Message #33 received at 31039-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico <federicotedin <at> gmail.com>
Cc: 31039-done <at> debbugs.gnu.org, npostavs <at> gmail.com, aaronjensen <at> gmail.com
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Sat, 11 Aug 2018 12:31:34 +0300

> From: Federico <federicotedin <at> gmail.com>
> Date: Mon, 6 Aug 2018 20:02:28 -0300
> Cc: Noam Postavsky <npostavs <at> gmail.com>, Aaron Jensen <aaronjensen <at> gmail.com>, 31039 <at> debbugs.gnu.org
> 
> Noam, Eli: I've applied the fixes you have both mentioned. I ended up
> using DEFVAR_BOOL to create the variable, but I'm not sure I used the
> variable correctly when calling Fdo_auto_save (the function only takes
> Lisp_Object). I have attached a new patch.
> 
> Regarding the copyright assignment, mine was approved one or two weeks ago.

Thanks, pushed to the master branch.

A few minor nits for your future contributions:

  . For changes in the manuals, the name of the node where the change
    is done should be mentioned in parentheses, as if it were a
    function.
  . Please make sure the NEWS entries are filled according to the
    default setting of fill-column (use M-q to do that).
  . It is preferable to explicitly mention the new functions/variables
    in the log entries for NEWS and the manuals.

You can look at the changes I actually pushed to see how I handled
those issues in this commit.

Thank you for your contribution; your copyright assignment is now on
file.

Message #36 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Federico <federicotedin <at> gmail.com>
Cc: aaronjensen <at> gmail.com, 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Sat, 11 Aug 2018 13:11:00 +0300

> Date: Sat, 11 Aug 2018 12:31:34 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 31039-done <at> debbugs.gnu.org, npostavs <at> gmail.com, aaronjensen <at> gmail.com
> 
> A few minor nits for your future contributions:
> 
>   . For changes in the manuals, the name of the node where the change
>     is done should be mentioned in parentheses, as if it were a
>     function.
>   . Please make sure the NEWS entries are filled according to the
>     default setting of fill-column (use M-q to do that).
>   . It is preferable to explicitly mention the new functions/variables
>     in the log entries for NEWS and the manuals.

Sorry, 2 more:

  . Always mention the bug number in the log entry.
  . When you add a new customizable option, always mark it with the
    first Emacs version where the option will appear, in this case
    27.1.

Thanks.

Message #39 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Aaron Jensen <aaronjensen <at> gmail.com>
To: federicotedin <at> gmail.com
Cc: 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Sat, 11 Aug 2018 09:10:29 -0700

Thank you, Federico!

Message #42 received at 31039 <at> debbugs.gnu.org (full text, mbox):

From: Federico <federicotedin <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31039 <at> debbugs.gnu.org
Subject: Re: bug#31039: 27.0.50; allow silencing auto-save
Date: Sat, 11 Aug 2018 15:20:15 -0300

Thanks Eli, I've taken a look at the commit and noted the corrections
you listed. Also, good to know about the copyright assignment.

On Sat, Aug 11, 2018 at 7:11 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> Date: Sat, 11 Aug 2018 12:31:34 +0300
>> From: Eli Zaretskii <eliz <at> gnu.org>
>> Cc: 31039-done <at> debbugs.gnu.org, npostavs <at> gmail.com, aaronjensen <at> gmail.com
>>
>> A few minor nits for your future contributions:
>>
>>   . For changes in the manuals, the name of the node where the change
>>     is done should be mentioned in parentheses, as if it were a
>>     function.
>>   . Please make sure the NEWS entries are filled according to the
>>     default setting of fill-column (use M-q to do that).
>>   . It is preferable to explicitly mention the new functions/variables
>>     in the log entries for NEWS and the manuals.
>
> Sorry, 2 more:
>
>   . Always mention the bug number in the log entry.
>   . When you add a new customizable option, always mark it with the
>     first Emacs version where the option will appear, in this case
>     27.1.
>
> Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.