GNU bug report logs -
#30990
Should the byte compiler warn about :type mismatches?
Previous Next
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
>>>>> On Mon, 30 Sep 2019 17:45:39 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> said:
Lars> Robert Pluim <rpluim <at> gmail.com> writes:
>> (defcustom winner-boring-buffers-regexp nil
>> "`winner-undo' will not restore windows with buffers matching this regexp."
>> - :type 'string
>> + :type '(choice (string :tag "Regexp")
>> + (const :tag "Don't check" nil))
>> :version "27.1")
>>
>> Iʼm not sure those are worth fixing.
Lars> I think fixing those would be a win.
Hmm. Current attempt attached. Iʼm having trouble with
'sql-postgres-login-params', and 'sql-password-wallet', probably
because I donʼt know enough about custom, suggestions welcome.
>> I did spot what seem to be some genuine errors though (hmm, would
>> flymake-cc-command need a :version tag update as well? The existing
>> definition makes customize error out)
Lars> [...]
>> - :type 'bool
>> + :type 'boolean
Lars> etc. Looks good to me; please push.
Done. One more, which I missed because itʼs not defined from lisp. Iʼm
not so sure about mentioning U+2502 in the tag, since I have a
vague memory that nil actually means 'autodetect if the frame can
display U+2502'.
diff --git a/lisp/cus-start.el b/lisp/cus-start.el
index 15d33b43c0..6b8fa0c6c9 100644
--- a/lisp/cus-start.el
+++ b/lisp/cus-start.el
@@ -671,9 +671,11 @@ minibuffer-prompt-properties--setter
:safe (lambda (value) (or (booleanp value) (integerp value))))
(display-fill-column-indicator-character
display-fill-column-indicator
- character
+ (choice
+ (const :tag "Default (U+2502)" nil)
+ (character :tag "Character" ))
"27.1"
- :safe characterp)
+ :safe (lambda (value) (or (characterp value) (null value))))
;; xfaces.c
(scalable-fonts-allowed display boolean "22.1")
;; xfns.c
[0001-Correct-some-more-custom-type-specs.patch (text/x-patch, inline)]
From 067250e0d5addcd8b7ee9072b3eae66c0c53d7a4 Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim <at> gmail.com>
Date: Wed, 9 Oct 2019 15:28:47 +0200
Subject: [PATCH] Correct some more custom type specs
To: emacs-devel <at> gnu.org
* lisp/winner.el (winner-boring-buffers-regexp):
* lisp/progmodes/js.el (js-jsx-indent-level):
* lisp/image-dired.el (image-dired-external-viewer):
* lisp/gnus/nnir.el (nnir-notmuch-filter-group-names-function):
Correct custom type specification.
* lisp/textmodes/bibtex.el (bibtex-string-file-path):
(bibtex-file-path): Correct custom type specification and document
source of initial value.
---
lisp/gnus/nnir.el | 2 +-
lisp/image-dired.el | 4 +++-
lisp/progmodes/js.el | 3 ++-
lisp/textmodes/bibtex.el | 14 ++++++++++----
lisp/winner.el | 3 ++-
5 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/lisp/gnus/nnir.el b/lisp/gnus/nnir.el
index 1041373a05..7cb2d1615a 100644
--- a/lisp/gnus/nnir.el
+++ b/lisp/gnus/nnir.el
@@ -535,7 +535,7 @@ nnir-notmuch-filter-group-names-function
(lambda (g) (replace-regexp-in-string \"\\\\.\" \"/\" g)))"
:version "27.1"
:type '(choice function
- nil))
+ (const :tag "No" nil)))
;;; Developer Extension Variable:
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index c1c767ba78..85bc924794 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -538,7 +538,9 @@ image-dired-external-viewer
"Name of external viewer.
Including parameters. Used when displaying original image from
`image-dired-thumbnail-mode'."
- :type 'string
+ :version "27.1"
+ :type '(choice string
+ (const :tag "Not Set" nil))
:group 'image-dired)
(defcustom image-dired-main-image-directory "~/pics/"
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index 3050e8f1a7..8d457a28ec 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -650,7 +650,8 @@ js-jsx-indent-level
</element>
)"
:version "27.1"
- :type 'integer
+ :type '(choice integer
+ (const :tag "Not Set" nil))
:safe (lambda (x) (or (null x) (integerp x)))
:group 'js)
;; This is how indentation behaved out-of-the-box until Emacs 27. JSX
diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index 7e99032084..c29e963180 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -933,9 +933,12 @@ bibtex-string-files
:type '(repeat file))
(defcustom bibtex-string-file-path (getenv "BIBINPUTS")
- "Colon-separated list of paths to search for `bibtex-string-files'."
+ "Colon-separated list of paths to search for `bibtex-string-files'.
+Initialized from the BIBINPUTS environment variable."
:group 'bibtex
- :type 'string)
+ :version "27.1"
+ :type '(choice string
+ (const :tag "Not Set" nil)))
(defcustom bibtex-files nil
"List of BibTeX files that are searched for entry keys.
@@ -949,9 +952,12 @@ bibtex-files
directory file)))
(defcustom bibtex-file-path (getenv "BIBINPUTS")
- "Colon separated list of paths to search for `bibtex-files'."
+ "Colon separated list of paths to search for `bibtex-files'.
+Initialized from the BIBINPUTS environment variable."
:group 'bibtex
- :type 'string)
+ :version "27.1"
+ :type '(choice string
+ (const :tag "Not Set" nil)))
(defcustom bibtex-search-entry-globally nil
"If non-nil, interactive calls of `bibtex-search-entry' search globally.
diff --git a/lisp/winner.el b/lisp/winner.el
index dc8bde5331..fea5211d90 100644
--- a/lisp/winner.el
+++ b/lisp/winner.el
@@ -61,7 +61,8 @@ winner-boring-buffers
(defcustom winner-boring-buffers-regexp nil
"`winner-undo' will not restore windows with buffers matching this regexp."
- :type 'string
+ :type '(choice (string :tag "Regexp")
+ (const :tag "Not Set" nil))
:version "27.1")
--
2.23.0
This bug report was last modified 4 years and 238 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.