GNU bug report logs - #30990
Should the byte compiler warn about :type mismatches?

Previous Next

Full log

Message #20 received at 30990 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: alex.branham <at> gmail.com, Stefan Kangas <stefan <at> marxist.se>,
 30990 <at> debbugs.gnu.org
Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches?
Date: Mon, 30 Sep 2019 17:45:39 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

>  (defcustom winner-boring-buffers-regexp nil
>    "`winner-undo' will not restore windows with buffers matching this regexp."
> -  :type 'string
> +  :type '(choice (string :tag "Regexp")
> +                 (const :tag "Don't check" nil))
>    :version "27.1")
>
> Iʼm not sure those are worth fixing.

I think fixing those would be a win.

> I did spot what seem to be some genuine errors though (hmm, would
> flymake-cc-command need a :version tag update as well? The existing
> definition makes customize error out)

[...]

> -  :type 'bool
> +  :type 'boolean

etc.  Looks good to me; please push.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.