From unknown Wed Jun 18 23:16:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30990 <30990@debbugs.gnu.org> To: bug#30990 <30990@debbugs.gnu.org> Subject: Status: Should the byte compiler warn about :type mismatches? Reply-To: bug#30990 <30990@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:16:15 +0000 retitle 30990 Should the byte compiler warn about :type mismatches? reassign 30990 emacs submitter 30990 Alex Branham severity 30990 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 12:55:22 2018 Received: (at submit) by debbugs.gnu.org; 29 Mar 2018 16:55:22 +0000 Received: from localhost ([127.0.0.1]:58924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1ape-00078n-G6 for submit@debbugs.gnu.org; Thu, 29 Mar 2018 12:55:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1apc-00078a-Nw for submit@debbugs.gnu.org; Thu, 29 Mar 2018 12:55:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1apW-0002nj-Er for submit@debbugs.gnu.org; Thu, 29 Mar 2018 12:55:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37013) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f1apW-0002nL-4W for submit@debbugs.gnu.org; Thu, 29 Mar 2018 12:55:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1apV-0001Wd-0y for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 12:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1apR-0002jQ-UU for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 12:55:13 -0400 Received: from mail-ot0-x232.google.com ([2607:f8b0:4003:c0f::232]:42444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1apR-0002it-PZ for bug-gnu-emacs@gnu.org; Thu, 29 Mar 2018 12:55:09 -0400 Received: by mail-ot0-x232.google.com with SMTP id h55-v6so5588852ote.9 for ; Thu, 29 Mar 2018 09:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=CUdiAEiEJYmvN2fRPNGUXlaHOEX6PgVj6HB3ruQTakU=; b=V71GrTZaLhdmicI8iVaJzP/wv2vY39TDa4uhq+F7KJ+idTCwM9a945Vmlfdqwhk9xJ lccPI76Os0tNx5LLVaTcTrBeTP6I3BDu+3uZ9UK+MV+ATculZgdpTP6Pn2mQa8qYPrvp Y0IXbcLgHspmKqdRhjvfgPhaAO5Y9w4JHj9NXI5JHuiWydQf4jv4zJuVlAM8O/QIfLc7 iwggZFHTWJdrjYXvpQahnpgbuFGj30NyzTr+GmSOvO3w/YoABVh3MUneEav1o07yFbwj CB/DUVQZhcSxC8oIVY9Y16Oy3oZ7b8+xteJtcO9+7ZKphOMDTTqg9bIyvQnYy7zTkgEf W+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=CUdiAEiEJYmvN2fRPNGUXlaHOEX6PgVj6HB3ruQTakU=; b=il1ozE/SfM0pvOV0hL4hdN/n73bJtOR8DgHzQVn2VL5GGy5Xy+6qAfijiov8RYYCmT 7meRCLnm5aGVC1/57Qz7Q5hXzfWZrOBjXK2JdjMPbjUDusfO022O05x8bxUQjsHQmdii quqD3fmo7UqESp+lO9+/HVP65zZtqX03MdxRdYJpIQTvP3FdOfmWGFZIHVD87aCOFDhm ETKtXkKQ0v5CFSYFVZ2WOwtNLzy49De3X9hgGsY8XXkkbxTsKq1Z5iGWkE7tGr19CKhO HGcpTQVrPpua4jqx4y9bdzPkUh+Avl7ij09lxWSkpRzw3Y2vbLLWHrpfJa8bTZ6xZG2B j/Kw== X-Gm-Message-State: AElRT7Gp56p2p+0ySv1wuMKPcLhNE9N6bI/SLpUW4TBwqlT3pRl0rZtW cdApFkPhBeM0SbDMVySL81Hhd7rN X-Google-Smtp-Source: AIpwx4+L7OvhbcwQxea6iSIyk/jR85sODvFUge1hnfAVYDuP+RHvN3Tp9ZyBa7z4vqrZsEdnJA+SeA== X-Received: by 2002:a9d:73cc:: with SMTP id m12-v6mr5012460otk.302.1522342508664; Thu, 29 Mar 2018 09:55:08 -0700 (PDT) Received: from earth (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id 11-v6sm3594484oth.36.2018.03.29.09.55.07 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Mar 2018 09:55:07 -0700 (PDT) User-agent: mu4e 1.0; emacs 26.0.91 From: Alex Branham To: "" Subject: Should the byte compiler warn about :type mismatches? Date: Thu, 29 Mar 2018 11:55:07 -0500 Message-ID: <87woxu7rf8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) severity: wishlist Would it be possible/desirable to make the byte-compiler warn about :type mismatches with defcustoms? I've noticed that the default values for quite a few packages I use (both in Emacs [Bug#30901 for example] and not) do not match. Presumably this would be easier to catch if the compiler warned about it. In case I'm not being clear, writing something like this: (defcustom my-var t "Docs." :group 'text :type 'string) Would result in a warning during byte compilation along the lines of: "Warning: Default value for 'my-var' does not match :type". From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 13:11:17 2018 Received: (at 30990) by debbugs.gnu.org; 29 Mar 2018 17:11:17 +0000 Received: from localhost ([127.0.0.1]:58942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1b52-0007Yu-SQ for submit@debbugs.gnu.org; Thu, 29 Mar 2018 13:11:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1b51-0007Yg-12 for 30990@debbugs.gnu.org; Thu, 29 Mar 2018 13:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1b4v-0003su-5G for 30990@debbugs.gnu.org; Thu, 29 Mar 2018 13:11:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1b4o-0003kW-Tb; Thu, 29 Mar 2018 13:11:02 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1f1b4m-0005y6-TA; Thu, 29 Mar 2018 13:11:00 -0400 From: Glenn Morris To: Alex Branham Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> X-Spook: Emergency management Gulf Cartel IED White Powder X-Ran: Vk@zNQ0pb5T1UN|}J[B*XbLIozy'p?cxk("%(8-"G=Am2OE@*}95;ND,fP4Z`_YzchT1oK X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 29 Mar 2018 13:11:00 -0400 In-Reply-To: <87woxu7rf8.fsf@gmail.com> (Alex Branham's message of "Thu, 29 Mar 2018 11:55:07 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30990 Cc: 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex Branham wrote: > Would it be possible/desirable to make the byte-compiler warn about > :type mismatches with defcustoms? I think that to do this in general requires evaluating the defcustom at compile time, which probably isn't the right thing. emacs -batch -l admin/cus-test.el -f cus-test-opts all will find these mismatches. I think it should be converted to an (expensive) ert test, which would solve the problem for Emacs itself. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 15:00:42 2019 Received: (at 30990) by debbugs.gnu.org; 28 Sep 2019 19:00:42 +0000 Received: from localhost ([127.0.0.1]:51277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEHxS-000516-4U for submit@debbugs.gnu.org; Sat, 28 Sep 2019 15:00:42 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEHxP-00050r-Pe for 30990@debbugs.gnu.org; Sat, 28 Sep 2019 15:00:40 -0400 Received: by mail-pg1-f194.google.com with SMTP id z12so5145548pgp.9 for <30990@debbugs.gnu.org>; Sat, 28 Sep 2019 12:00:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ARf6kvLkTc8cJwu2z7DPBrVZcprl6XOFNIoYZFwg1nU=; b=mKKrOPLHSf2fkx6nP7JZv2PNP3+1qnXc7XMxUb0e7zVro5efh1M+Yj5kEgB7NfgGPT 3mJ5RskwIWXguQuwDvw66SXZVnsNh5x1kUpxNTT41iSST6ODeoQQMJFokrMOtr/HLjl0 xWiv+ssTuEfvpx5d5JtHiQIRCO8yFtG02phkrY4gqas4c4BzNrc7vBus/6r8tQ6g4Nz2 vllFDinAXDMpkWtS0rVJW0JI0rqUILesa1ZjyWD256UNjgO1nQla+anqY32uIooNx6H6 cN2CQr/3ve4OEfpKFvh8xLPL/Rsto6wFxXV6gORJOWXiUz29yxlV0vWPmTMOcjCw6gUr Ehrg== X-Gm-Message-State: APjAAAU0RHKiAO4rHUosIkBrPt94tBkUt8D7WnHGDoKsnO4XNZd/GHF0 Ch6zhoEBh0dSFnfv0g3RdSHJBKxTHyEcVPZg2Hg= X-Google-Smtp-Source: APXvYqw7ewL48pY2u3epDotyQZkKEl7n3CMilBerZcvR3/5sDslDwIxJg/bLjCfh1QXK+wFHiKgA/liEwnlpKH8iiu8= X-Received: by 2002:a62:e917:: with SMTP id j23mr12229157pfh.50.1569697234062; Sat, 28 Sep 2019 12:00:34 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sat, 28 Sep 2019 21:00:22 +0200 Message-ID: Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? To: Glenn Morris Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 30990 Cc: Alex Branham , 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Glenn Morris writes: > Alex Branham wrote: > >> Would it be possible/desirable to make the byte-compiler warn about >> :type mismatches with defcustoms? > > I think that to do this in general requires evaluating the defcustom at > compile time, which probably isn't the right thing. > > emacs -batch -l admin/cus-test.el -f cus-test-opts all > > will find these mismatches. I think it should be converted to an > (expensive) ert test, which would solve the problem for Emacs itself. I think that's a good idea. Running the above command in my tree, I get: The following options might have problems: sql-password-wallet tramp-default-host-alist display-fill-column-indicator-character bibtex-string-file-path js-jsx-indent-level bibtex-file-path sql-use-indent-support sql-postgres-login-params winner-boring-buffers-regexp add-log-dont-create-changelog-file nnir-notmuch-filter-group-names-function flymake-cc-command Since we're getting closer to the release of Emacs 27.1, perhaps we should sort these out. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 15:22:12 2019 Received: (at 30990) by debbugs.gnu.org; 28 Sep 2019 19:22:12 +0000 Received: from localhost ([127.0.0.1]:51287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEIIG-0005ZY-Fp for submit@debbugs.gnu.org; Sat, 28 Sep 2019 15:22:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEIIE-0005ZK-Hw for 30990@debbugs.gnu.org; Sat, 28 Sep 2019 15:22:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iEII9-0005H3-5F; Sat, 28 Sep 2019 15:22:05 -0400 Received: from [176.228.60.248] (port=2306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iEII7-00050J-Th; Sat, 28 Sep 2019 15:22:04 -0400 Date: Sat, 28 Sep 2019 22:21:55 +0300 Message-Id: <838sq8grak.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Sat, 28 Sep 2019 21:00:22 +0200) Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 30990 Cc: rgm@gnu.org, alex.branham@gmail.com, 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Sat, 28 Sep 2019 21:00:22 +0200 > Cc: Alex Branham , 30990@debbugs.gnu.org > > The following options might have problems: > sql-password-wallet > tramp-default-host-alist > display-fill-column-indicator-character > bibtex-string-file-path > js-jsx-indent-level > bibtex-file-path > sql-use-indent-support > sql-postgres-login-params > winner-boring-buffers-regexp > add-log-dont-create-changelog-file > nnir-notmuch-filter-group-names-function > flymake-cc-command > > Since we're getting closer to the release of Emacs 27.1, perhaps we > should sort these out. We should, but bugs like this can be fixed even after the emacs-27 branch is cut. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 07:49:44 2019 Received: (at 30990) by debbugs.gnu.org; 30 Sep 2019 11:49:44 +0000 Received: from localhost ([127.0.0.1]:56999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEuBS-0003Iy-E7 for submit@debbugs.gnu.org; Mon, 30 Sep 2019 07:49:44 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:44827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEuBN-0003Ii-Hg for 30990@debbugs.gnu.org; Mon, 30 Sep 2019 07:49:38 -0400 Received: by mail-wr1-f45.google.com with SMTP id i18so10902727wru.11 for <30990@debbugs.gnu.org>; Mon, 30 Sep 2019 04:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:message-id:mime-version:content-transfer-encoding; bh=Q8sUJqFR5ERQDsJf/B1b3asUS7MtKZs0Iwuj0LmrRAU=; b=dzOMk084TrL38AaHhJd4YhmhdSUWAYNpD9i6KgiVggJZeJeNcc7rwwGczlTiJl/gnN TC9QZccfYQdki/cKs2mHcS7gUuSWi5XaZzh9F0qP86UhhSfwdTdrwQLSZFbITT0KtVoi QXzKbCUPeCZonlkF5BZD8P/kYJnkoX2aTIqlTyNSQ/eWf1Ul53gLyQT+RY2WHec0SvuS dfFm84xBW89YRoriujRQ42jeRbau7+kfXSwb/CKtFrzzAfBeCCX0cb9p2E6yLWNg3wYT 7/JNErFOPH6YPx/uKssXvjVt0J88Hk4rPVZE/FgBdZGarLnIJxmezE0/UX1uaYbNXCAI bEHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:message-id:mime-version :content-transfer-encoding; bh=Q8sUJqFR5ERQDsJf/B1b3asUS7MtKZs0Iwuj0LmrRAU=; b=YXtTZlFq8Ry/spi8enhZQT/e50osFwvCZI847QlD8oy/z+Ww25K2ddMcNZ0/sjysXu hvw2by0Y2i2CJ6+aCQ+3Do7y+tVhzNeNe+d6T9a4/uPSgwk2dMvv+Bf6DaIzUuvXZYQJ pLFmLBWiJCG/BoJoKhEy0GJUEmv62IOJhcpYo6cZ2jD5DeIiNK9naUkS6k/lBAY1nQii vPWuyMolXKbNBJ8dZxFPSEaVOuV/uSqJ0C36foHnjj7Yb8G0NFDifSXPhR9U5W4EOKGG 0gF8z9uQH87SA/srjLrbBsd2p/+Jzea1tTPohEgFUZfSsYO9GH1vkFYDAqLkixC9WIi0 ttdA== X-Gm-Message-State: APjAAAXZHEep3rUM025B9OE9n+wTvs3P/tBJicML7yLtA+sr9teuqYck JaSCoB5MSiW6tPnLVw42haInpDbegtI= X-Google-Smtp-Source: APXvYqzDeihhRuZEczXT3s10Kaomt0GoWttqfpQHchXIKfyuA+pABO9K3W8kGEu35qA2V1Czme0Zkg== X-Received: by 2002:a5d:680d:: with SMTP id w13mr12610019wru.282.1569844171099; Mon, 30 Sep 2019 04:49:31 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id r65sm14706596wmr.9.2019.09.30.04.49.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 04:49:29 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 30 Sep 2019 13:49:28 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 28 Sep 2019 22:21:55 +0300, Eli Zaretskii said: >> From: Stefan Kangas >> Date: Sat, 28 Sep 2019 21:00:22 +0200 >> Cc: Alex Branham , 30990@debbugs.gnu.org >>=20 >> The following options might have problems: >> sql-password-wallet >> tramp-default-host-alist >> display-fill-column-indicator-character >> bibtex-string-file-path >> js-jsx-indent-level >> bibtex-file-path >> sql-use-indent-support >> sql-postgres-login-params >> winner-boring-buffers-regexp >> add-log-dont-create-changelog-file >> nnir-notmuch-filter-group-names-function >> flymake-cc-command >>=20 >> Since we're getting closer to the release of Emacs 27.1, perhaps we >> should sort these out. Eli> We should, but bugs like this can be fixed even after the emacs-27 Eli> branch is cut. I took a quick look, most of them are because the starting value is nil, and the type is something that can=CA=BCt be nil, which means the type should actually be something like (choice string (const nil)) an example, where nil here means "don=CA=BCt do any checking": diff --git a/lisp/winner.el b/lisp/winner.el index ec3b296489..0e5bd90966 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -71,7 +71,8 @@ winner-boring-buffers =20 (defcustom winner-boring-buffers-regexp nil "`winner-undo' will not restore windows with buffers matching this regex= p." - :type 'string + :type '(choice (string :tag "Regexp") + (const :tag "Don't check" nil)) :version "27.1") I=CA=BCm not sure those are worth fixing. I did spot what seem to be some genuine errors though (hmm, would flymake-cc-command need a :version tag update as well? The existing definition makes customize error out) diff --git i/lisp/image.el w/lisp/image.el index eaa6ed3b0e..e44330fdfa 100644 --- i/lisp/image.el +++ w/lisp/image.el @@ -148,7 +148,7 @@ image-use-external-converter support in Emacs can still be displayed if an external conversion program (like ImageMagick \"convert\", GraphicsMagick \"gm\" or \"ffmpeg\") is installed." - :type 'bool + :type 'boolean :version "27.1") =20 ;; Map put into text properties on images. diff --git i/lisp/progmodes/flymake-cc.el w/lisp/progmodes/flymake-cc.el index ecf6e648a7..7b36fcf06d 100644 --- i/lisp/progmodes/flymake-cc.el +++ w/lisp/progmodes/flymake-cc.el @@ -37,7 +37,7 @@ flymake-cc-command input and prints the result on its standard output." :type '(choice (symbol :tag "Function") - ((repeat :) string)) + (repeat :tag "Command(s)" string)) :group 'flymake-cc) =20 (defun flymake-cc--make-diagnostics (source) diff --git i/lisp/progmodes/sql.el w/lisp/progmodes/sql.el index 2d33b3130c..0e14a6e4b2 100644 --- i/lisp/progmodes/sql.el +++ w/lisp/progmodes/sql.el @@ -737,7 +737,7 @@ sql-use-indent-support The package must be available to be loaded and activated." :group 'SQL :link '(url-link "https://elpa.gnu.org/packages/sql-indent.html") - :type 'booleanp + :type 'boolean :version "27.1") =20 (defun sql-indent-enable () diff --git i/lisp/vc/add-log.el w/lisp/vc/add-log.el index 47a68167fb..5c27a65ea1 100644 --- i/lisp/vc/add-log.el +++ w/lisp/vc/add-log.el @@ -811,7 +811,7 @@ add-log-dont-create-changelog-file "If non-nil, don't create ChangeLog files for log entries. If a ChangeLog file does not already exist, a non-nil value means to put log entries in a suitably named buffer." - :type :boolean + :type 'boolean :version "27.1") =20 (put 'add-log-dont-create-changelog-file 'safe-local-variable 'booleanp) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 30 11:45:46 2019 Received: (at 30990) by debbugs.gnu.org; 30 Sep 2019 15:45:46 +0000 Received: from localhost ([127.0.0.1]:60251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iExru-0001yl-1E for submit@debbugs.gnu.org; Mon, 30 Sep 2019 11:45:46 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iExrr-0001vo-Ia for 30990@debbugs.gnu.org; Mon, 30 Sep 2019 11:45:44 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iExrn-000336-PO; Mon, 30 Sep 2019 17:45:42 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> Date: Mon, 30 Sep 2019 17:45:39 +0200 In-Reply-To: (Robert Pluim's message of "Mon, 30 Sep 2019 13:49:28 +0200") Message-ID: <87imp9aiu4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > (defcustom winner-boring-buffers-regexp nil > "`winner-undo' will not restore windows with buffers matching this regexp." > - :type 'string > + :type '(choice (string :tag "Regexp") > + (const :tag [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > (defcustom winner-boring-buffers-regexp nil > "`winner-undo' will not restore windows with buffers matching this reg= exp." > - :type 'string > + :type '(choice (string :tag "Regexp") > + (const :tag "Don't check" nil)) > :version "27.1") > > I=CA=BCm not sure those are worth fixing. I think fixing those would be a win. > I did spot what seem to be some genuine errors though (hmm, would > flymake-cc-command need a :version tag update as well? The existing > definition makes customize error out) [...] > - :type 'bool > + :type 'boolean etc. Looks good to me; please push. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 09:34:31 2019 Received: (at 30990) by debbugs.gnu.org; 9 Oct 2019 13:34:31 +0000 Received: from localhost ([127.0.0.1]:52282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIC6o-0005O3-Tg for submit@debbugs.gnu.org; Wed, 09 Oct 2019 09:34:31 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIC6n-0005Nr-D9 for 30990@debbugs.gnu.org; Wed, 09 Oct 2019 09:34:30 -0400 Received: by mail-wr1-f65.google.com with SMTP id q9so3021303wrm.8 for <30990@debbugs.gnu.org>; Wed, 09 Oct 2019 06:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:message-id:mime-version; bh=FMPS3vzbDg/T/quKVdwjSvexf2dn4KD8ERhL9Y5h5h0=; b=UhcWqAlXwjsn+dOj8pcVucFh2Yh6BT2mmT7VpbAWMYu1Fo8C7w67MP8txh4yJOzH2Y g3knGJeuYJWFBELdfR5YsZku11QlQZGtkAMEy6ay7KaR1+DEpyIwTBi4lnTRP/WbVnpl FAM0d/zyddgLRtpRKeWFyibwb92kqd/J21agSdcW3OFVQGSUr7Ebxe3PgzIE/h9B3X1+ sbY3WAdNu4muXxuA/SnQle/f8C2bhR7zxeQhodVqrMAqYMj7MYZGqoOJNkt5+SLTZ0fR HFieoIR3JBcHqFQEroQoDQ29iAtgpNH9V0jRSWCVzalFfv0IkhHo1WHkGSDWpzC4sMS+ PHaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:message-id:mime-version; bh=FMPS3vzbDg/T/quKVdwjSvexf2dn4KD8ERhL9Y5h5h0=; b=EDNmCV/cA+5jUtc4jxnJEZ56YxQntTMK15/xtpu70skJwXDqjrmzmpVfXWC3c9W4oA Lde9GxBx6/9cO3AMLSdeKqcUMEFDneRuAmJYD4yBdVobe/PyaNK+FzZpr3FP1LaUvdhp NkSdsWMpip+HTMoDjiwfrN8qvX1wDEGsGR4olP6pcholEy4lDh5VHVEulu7XP1jAo7IS 1iPFuQbM3vnqLQun/NUssekQYeIjo8RoVKJjqhO+c26MPdS4zDoltHM/WPHd9RZPnulZ 3XjEd6+HAhCwoQD5kvvvfdAIflDudUSMSbpSPI7zpcZ7E8EJ9XGdm/2lRP8YwoSfopgi wWvg== X-Gm-Message-State: APjAAAVOJp8dVmTAciLyiSNiYV0ER/cg2kZAr7G+vLbIOVLEgJak4+0l op++iAabtrtKbhMjMbIu6ECD7KYf X-Google-Smtp-Source: APXvYqy61oINuvEGUwq+ugeXRfbTcf+0ImnO1WDfY2zOE5Ie3nvOHJqxjXfy7CA30egstSZ2cMKdow== X-Received: by 2002:adf:f68f:: with SMTP id v15mr2900093wrp.234.1570628062719; Wed, 09 Oct 2019 06:34:22 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id y5sm2301002wma.14.2019.10.09.06.34.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 06:34:21 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 09 Oct 2019 15:34:20 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: 30990@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas , alex.branham@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Mon, 30 Sep 2019 17:45:39 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> (defcustom winner-boring-buffers-regexp nil >> "`winner-undo' will not restore windows with buffers matching this r= egexp." >> - :type 'string >> + :type '(choice (string :tag "Regexp") >> + (const :tag "Don't check" nil)) >> :version "27.1") >>=20 >> I=CA=BCm not sure those are worth fixing. Lars> I think fixing those would be a win. Hmm. Current attempt attached. I=CA=BCm having trouble with 'sql-postgres-login-params', and 'sql-password-wallet', probably because I don=CA=BCt know enough about custom, suggestions welcome. >> I did spot what seem to be some genuine errors though (hmm, would >> flymake-cc-command need a :version tag update as well? The existing >> definition makes customize error out) Lars> [...] >> - :type 'bool >> + :type 'boolean Lars> etc. Looks good to me; please push. Done. One more, which I missed because it=CA=BCs not defined from lisp. I= =CA=BCm not so sure about mentioning U+2502 in the tag, since I have a vague memory that nil actually means 'autodetect if the frame can display U+2502'. diff --git a/lisp/cus-start.el b/lisp/cus-start.el index 15d33b43c0..6b8fa0c6c9 100644 --- a/lisp/cus-start.el +++ b/lisp/cus-start.el @@ -671,9 +671,11 @@ minibuffer-prompt-properties--setter :safe (lambda (value) (or (booleanp value) (integerp value))= )) (display-fill-column-indicator-character display-fill-column-indicator - character + (choice + (const :tag "Default (U+2502)" nil) + (character :tag "Character" )) "27.1" - :safe characterp) + :safe (lambda (value) (or (characterp value) (null value)))) ;; xfaces.c (scalable-fonts-allowed display boolean "22.1") ;; xfns.c --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Correct-some-more-custom-type-specs.patch >From 067250e0d5addcd8b7ee9072b3eae66c0c53d7a4 Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Wed, 9 Oct 2019 15:28:47 +0200 Subject: [PATCH] Correct some more custom type specs To: emacs-devel@gnu.org * lisp/winner.el (winner-boring-buffers-regexp): * lisp/progmodes/js.el (js-jsx-indent-level): * lisp/image-dired.el (image-dired-external-viewer): * lisp/gnus/nnir.el (nnir-notmuch-filter-group-names-function): Correct custom type specification. * lisp/textmodes/bibtex.el (bibtex-string-file-path): (bibtex-file-path): Correct custom type specification and document source of initial value. --- lisp/gnus/nnir.el | 2 +- lisp/image-dired.el | 4 +++- lisp/progmodes/js.el | 3 ++- lisp/textmodes/bibtex.el | 14 ++++++++++---- lisp/winner.el | 3 ++- 5 files changed, 18 insertions(+), 8 deletions(-) diff --git a/lisp/gnus/nnir.el b/lisp/gnus/nnir.el index 1041373a05..7cb2d1615a 100644 --- a/lisp/gnus/nnir.el +++ b/lisp/gnus/nnir.el @@ -535,7 +535,7 @@ nnir-notmuch-filter-group-names-function (lambda (g) (replace-regexp-in-string \"\\\\.\" \"/\" g)))" :version "27.1" :type '(choice function - nil)) + (const :tag "No" nil))) ;;; Developer Extension Variable: diff --git a/lisp/image-dired.el b/lisp/image-dired.el index c1c767ba78..85bc924794 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -538,7 +538,9 @@ image-dired-external-viewer "Name of external viewer. Including parameters. Used when displaying original image from `image-dired-thumbnail-mode'." - :type 'string + :version "27.1" + :type '(choice string + (const :tag "Not Set" nil)) :group 'image-dired) (defcustom image-dired-main-image-directory "~/pics/" diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 3050e8f1a7..8d457a28ec 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -650,7 +650,8 @@ js-jsx-indent-level )" :version "27.1" - :type 'integer + :type '(choice integer + (const :tag "Not Set" nil)) :safe (lambda (x) (or (null x) (integerp x))) :group 'js) ;; This is how indentation behaved out-of-the-box until Emacs 27. JSX diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el index 7e99032084..c29e963180 100644 --- a/lisp/textmodes/bibtex.el +++ b/lisp/textmodes/bibtex.el @@ -933,9 +933,12 @@ bibtex-string-files :type '(repeat file)) (defcustom bibtex-string-file-path (getenv "BIBINPUTS") - "Colon-separated list of paths to search for `bibtex-string-files'." + "Colon-separated list of paths to search for `bibtex-string-files'. +Initialized from the BIBINPUTS environment variable." :group 'bibtex - :type 'string) + :version "27.1" + :type '(choice string + (const :tag "Not Set" nil))) (defcustom bibtex-files nil "List of BibTeX files that are searched for entry keys. @@ -949,9 +952,12 @@ bibtex-files directory file))) (defcustom bibtex-file-path (getenv "BIBINPUTS") - "Colon separated list of paths to search for `bibtex-files'." + "Colon separated list of paths to search for `bibtex-files'. +Initialized from the BIBINPUTS environment variable." :group 'bibtex - :type 'string) + :version "27.1" + :type '(choice string + (const :tag "Not Set" nil))) (defcustom bibtex-search-entry-globally nil "If non-nil, interactive calls of `bibtex-search-entry' search globally. diff --git a/lisp/winner.el b/lisp/winner.el index dc8bde5331..fea5211d90 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -61,7 +61,8 @@ winner-boring-buffers (defcustom winner-boring-buffers-regexp nil "`winner-undo' will not restore windows with buffers matching this regexp." - :type 'string + :type '(choice (string :tag "Regexp") + (const :tag "Not Set" nil)) :version "27.1") -- 2.23.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 13:57:29 2019 Received: (at 30990) by debbugs.gnu.org; 9 Oct 2019 17:57:29 +0000 Received: from localhost ([127.0.0.1]:54040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIGDJ-0003oy-F0 for submit@debbugs.gnu.org; Wed, 09 Oct 2019 13:57:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:40230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIGDH-0003op-Kt for 30990@debbugs.gnu.org; Wed, 09 Oct 2019 13:57:28 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIGDD-0002hR-1F; Wed, 09 Oct 2019 19:57:25 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> Date: Wed, 09 Oct 2019 19:57:22 +0200 In-Reply-To: (Robert Pluim's message of "Wed, 09 Oct 2019 15:34:20 +0200") Message-ID: <87o8yp7qf1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Hmm. Current attempt attached. Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Hmm. Current attempt attached. Looks good to me. > I=CA=BCm having trouble with > 'sql-postgres-login-params', and 'sql-password-wallet', probably > because I don=CA=BCt know enough about custom, suggestions welcome. The first one should probably not be a defcustom at all, but perhaps just... :type 'sexp The second looks like a bug: (defcustom sql-password-wallet (let (wallet w) (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) (unless wallet (setq w (locate-user-emacs-file (concat "sql-wallet" ext) (concat ".sql-wallet" ext))) (when (file-exists-p w) (setq wallet w))))) It will always be nil, won't it? My guess would be that the intention was that this should be (defcustom sql-password-wallet (let (wallet w) (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) (unless wallet (setq w (locate-user-emacs-file (concat "sql-wallet" ext) (concat ".sql-wallet" ext))) (when (file-exists-p w) (setq wallet w)))) wallet) but I'm not familiar with this at all. But if that's the case the type should be a choice between nil and `file'. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 14:44:12 2019 Received: (at 30990) by debbugs.gnu.org; 9 Oct 2019 18:44:12 +0000 Received: from localhost ([127.0.0.1]:54104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIGwW-00075a-C3 for submit@debbugs.gnu.org; Wed, 09 Oct 2019 14:44:12 -0400 Received: from mail222c50.megamailservers.eu ([91.136.10.232]:35596 helo=mail33c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIGwU-00075Q-1k for 30990@debbugs.gnu.org; Wed, 09 Oct 2019 14:44:11 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1570646647; bh=QMTDiXhn24PrAGpNLtJWU4ONsEqrWRRNR7Y0r6MDbxw=; h=From:Subject:Date:Cc:To:From; b=QvIgiRL8AiLQrlyg2gjs6L1bYAnDtfrflIZ9mNRYpM/BzzyyOjxgMAQhFtTFRAD+U L6xVtWtJlFQmiX/u8CSPDY38AJismCuXWqn5/WusTlcmOznUXwvTAwFrAcT/EGPpFZ SLu+vY18GfhV67/h7bpigU96pxrf/tVm2Bz7lQjk= Feedback-ID: mattiase@acm.or Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail33c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x99Ii44L017015; Wed, 9 Oct 2019 18:44:06 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: bug#30990: Should the byte compiler warn about :type mismatches? Message-Id: <5E7064B9-082E-45EE-90C1-108EDD4862C6@acm.org> Date: Wed, 9 Oct 2019 20:44:04 +0200 To: 30990@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0207.5D9E2A77.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=CaB2G4jl c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=AskTIkU3iwWHLuGJOYwA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 30990 Cc: alex.branham@gmail.com, Robert Pluim , Stefan Kangas , Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >- :type 'string >+ :type '(choice (string :tag "Regexp") >+ (const :tag "Not Set" nil)) Perhaps the type `regexp' would be better than `string' here? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 16:05:41 2019 Received: (at 30990) by debbugs.gnu.org; 9 Oct 2019 20:05:41 +0000 Received: from localhost ([127.0.0.1]:54167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIIDM-0000j3-Dq for submit@debbugs.gnu.org; Wed, 09 Oct 2019 16:05:41 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIIDK-0000it-BS for 30990@debbugs.gnu.org; Wed, 09 Oct 2019 16:05:38 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIIDF-0003za-N7; Wed, 09 Oct 2019 22:05:36 +0200 From: Lars Ingebrigtsen To: alex.branham@gmail.com Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> Date: Wed, 09 Oct 2019 22:05:33 +0200 In-Reply-To: (Robert Pluim's message of "Wed, 09 Oct 2019 15:34:20 +0200") Message-ID: <87imox4rci.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Oh, I missed this bit in the sql code; (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) So `wallet' is returned and the code is fine... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: 30990@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Oh, I missed this bit in the sql code; (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) So `wallet' is returned and the code is fine... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 10 09:11:29 2019 Received: (at 30990) by debbugs.gnu.org; 10 Oct 2019 13:11:29 +0000 Received: from localhost ([127.0.0.1]:55312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIYE5-0003eb-Ck for submit@debbugs.gnu.org; Thu, 10 Oct 2019 09:11:29 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIYE4-0003eO-6y for 30990@debbugs.gnu.org; Thu, 10 Oct 2019 09:11:28 -0400 Received: by mail-wm1-f42.google.com with SMTP id 3so6741153wmi.3 for <30990@debbugs.gnu.org>; Thu, 10 Oct 2019 06:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=ieUOPOsbpG2ozdby3kV544jNjKvw5R2JBSnsaEFNDO4=; b=fB/C/FmBX6HWZWpavZV0PhWJ/tS1jKMyoEA05OIoApkjNPduyQouFFWEolZBjh6aLi Sp2wYijNTnKu7zwaH5MOKixjRBHnlnUne6XoPg55+A9hEtExmZZUboFctjnYRzx978DS MC25u8MhFJsfVitFAYwUB/I+0EPMBeSrde7Ge7QO4Ujqgh6pLq823R1eK2TYwEem/AyR Z0XTL7DMGFkyNhPde+JxFW99kcoELSxDdYl7VuWxlRZONs665zYqNNlmvl3IuUqoOVbo JNvtU8614qlmPwNlmXvtTqUaU5Q9R9owKfYXMLNxhUzsS2tsMTWE1tFnS4GKXNQL0Eg5 UC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=ieUOPOsbpG2ozdby3kV544jNjKvw5R2JBSnsaEFNDO4=; b=mIo+Sr0efxD7JHjfsvuXpUW0eV7AxuFp2U6w7ysCt4H2Cds9JQ2H6F/tFHG3D9Hwxb 5hnMiZnix/qALeCR7y9NjIaEgEvIrW1xJSp7X4JCC2z1sbzJ2atoQVAWUL/bkG2GKW4G 2+ldXIaAjW1D6it6KL82I0JhIl1ctwruAnXatOkGIY9ypJXWfmkZ21HcDg3I9tyCM8d5 hmz1UYQLU6lfPfo5ILOH4pPhjFsFQlEKR4iNSQS2Pv/kBcEf+h5M2p6lIZFE8QUnEpTD XteTJrBnexRYCv7G78wosBtktC0JKDibP1WbDuoRO0OrdeaYsSQw/24ytEG7+yEalby/ xFUg== X-Gm-Message-State: APjAAAWgfNEIvhNwkYSY4al/kL12YUCTKcbZ60mFtvT2x8K/3F7lwCYf LZ0HBOlWG3HFHxp9nFUZMtU= X-Google-Smtp-Source: APXvYqwq7e5PcftpzsOTuf4hs7t8ghfhMOa0puEghlbDlcp/Sbkp1q+RgMiz2JiscYJsuqCvJ1c6Fg== X-Received: by 2002:a1c:e912:: with SMTP id q18mr7562636wmc.42.1570713082245; Thu, 10 Oct 2019 06:11:22 -0700 (PDT) Received: from rpluim-mac ([2a01:e34:ecfc:a860:44fb:6490:3ed:c3e8]) by smtp.gmail.com with ESMTPSA id b130sm8537247wmh.12.2019.10.10.06.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 06:11:21 -0700 (PDT) From: Robert Pluim To: Lars Ingebrigtsen Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 10 Oct 2019 15:11:20 +0200 In-Reply-To: <87imox4rci.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 09 Oct 2019 22:05:33 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 09 Oct 2019 22:05:33 +0200, Lars Ingebrigtsen said: Lars> Oh, I missed this bit in the sql code; Lars> (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) Lars> So `wallet' is returned and the code is fine... Except that the underlying type is '(repeat ....) so I wonder if this: (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) (unless wallet (setq w (locate-user-emacs-file (concat "sql-wallet" ext) (concat ".sql-wallet" ext))) (when (file-exists-p w) (setq wallet w))))) ; <= this returns a string should use (setq wallet (list w)) instead Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 01:54:07 2019 Received: (at 30990) by debbugs.gnu.org; 11 Oct 2019 05:54:07 +0000 Received: from localhost ([127.0.0.1]:57515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iInsN-0000tJ-4o for submit@debbugs.gnu.org; Fri, 11 Oct 2019 01:54:07 -0400 Received: from quimby.gnus.org ([80.91.231.51]:53528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iInsM-0000tB-81 for 30990@debbugs.gnu.org; Fri, 11 Oct 2019 01:54:06 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iInsH-0000tM-Cc; Fri, 11 Oct 2019 07:54:03 +0200 From: Lars Ingebrigtsen To: alex.branham@gmail.com Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> Date: Fri, 11 Oct 2019 07:54:00 +0200 In-Reply-To: (Robert Pluim's message of "Thu, 10 Oct 2019 15:11:20 +0200") Message-ID: <87y2xrq13b.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Except that the underlying type is '(repeat ....) so I wonder if this: > > (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) > (unless wallet > (setq w (locate-user-emacs-file (concat "sql-walle [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: 30990@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Except that the underlying type is '(repeat ....) so I wonder if this: > > (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) > (unless wallet > (setq w (locate-user-emacs-file (concat "sql-wallet" ext) > (concat ".sql-wallet" ext))) > (when (file-exists-p w) > (setq wallet w))))) ; <= this returns a string > > should use (setq wallet (list w)) instead Indeed. It looks like this is where it's used: (defun sql-auth-source-search-wallet (wallet product user server database port) [...] (let* ((auth-sources wallet) and auth-source-search assumes that auth-sources is a list of ... things, not a string: (cl-defun auth-source-search (&rest spec &key max require create delete &allow-other-keys) [...] (let* ((backends (mapcar #'auth-source-backend-parse auth-sources)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 11 05:31:51 2019 Received: (at 30990) by debbugs.gnu.org; 11 Oct 2019 09:31:51 +0000 Received: from localhost ([127.0.0.1]:57692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIrH4-0001Z0-S5 for submit@debbugs.gnu.org; Fri, 11 Oct 2019 05:31:51 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIrH3-0001Yg-2q for 30990@debbugs.gnu.org; Fri, 11 Oct 2019 05:31:49 -0400 Received: by mail-wr1-f53.google.com with SMTP id h4so11101552wrv.7 for <30990@debbugs.gnu.org>; Fri, 11 Oct 2019 02:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:message-id:mime-version :content-transfer-encoding; bh=+Cpu9cBQyUzqqrJU00RqX4mXSXEugri6hiR8sVbhfZ0=; b=gEVXEiETaPHoi5jpLNZN3aOpYrHrvDyidxM1Kb1h6PpByJznz7ENnor/7jN6go+7gT woE3bn3jFMqQeajq9bcOaawu7lcSr/7ywiWMIFfiTq2jyaz/kR5F++qL0MMyPcqWkS4Q Z3mvPPE2zL5c/ZO9IMVxirgEdwkdVipt++SxR5wp6tHAZgcEcn5VXlyDzhTskj4OiCmN y9G6wsQrPyPFY9d8QxbRlikGrLdL1ovLSP/HJ6P6owtkOFFtOM8KsEIYxPqwVL8IMEiI 0Jw2ZWsuAs+MyZT/tctBDqVyRdDnEYPoOPmDNYCfOpt5WEXIqjTrph5vuZtfD9i2QqWx mAjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:message-id :mime-version:content-transfer-encoding; bh=+Cpu9cBQyUzqqrJU00RqX4mXSXEugri6hiR8sVbhfZ0=; b=sRe/WKdM6ExUu2AIOlGQ+wAUKB6mDlp1DhUdu4RvRm9xvC3lCNl2DcpsemuEinQ4U2 jyiIy81jjusTSi8x2t5rFmxPmc7ULZfcqIJA3sDDmvsdOQE6Mr3BMiRFBCaURloz1LzW +ajhU7Tnz0GsCyYb1JKCXRTIZJZUNdtmt/WVCytZo3XZgNkFNiNnL2itkuXOWoFjXVj9 h2JyjevLdfncFY8Zo3tXAPJZCyGnypkh0yCX14j5vlFtgFazO+feIfAWjOwQS/nGGECV oCb1q8xiV9bc9S5cPztdgQVUlFYVGgcg+WnsujdlHJ94WW3sVSQVom0bkOa/gA5Gx4/h 0/4w== X-Gm-Message-State: APjAAAWdCa6jeIMmftTojL3Ki25rtMhq0DCuz7+ZCrhGsOxG5y+NRkiU kHoFQIOjNzLbUEPdwpblhmY= X-Google-Smtp-Source: APXvYqyzUmuwNp1TSWWqE3+iyzm/bJ3Y9BmUfuM1SCvC7CIsfhxrc7AY4EHOCS2xTGGyt0jC6PQJcw== X-Received: by 2002:a5d:6048:: with SMTP id j8mr6042373wrt.215.1570786302899; Fri, 11 Oct 2019 02:31:42 -0700 (PDT) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id f8sm8834372wmb.37.2019.10.11.02.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 02:31:42 -0700 (PDT) From: Robert Pluim To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <5E7064B9-082E-45EE-90C1-108EDD4862C6@acm.org> Date: Fri, 11 Oct 2019 11:31:41 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: alex.branham@gmail.com, 30990@debbugs.gnu.org, Stefan Kangas , Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 9 Oct 2019 20:44:04 +0200, Mattias Engdeg=C3=A5rd said: >> - :type 'string >> + :type '(choice (string :tag "Regexp") >> + (const :tag "Not Set" nil)) Mattias> Perhaps the type `regexp' would be better than `string' here? Yes, it would. Fixed. Robert From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 25 08:44:52 2020 Received: (at 30990) by debbugs.gnu.org; 25 Sep 2020 12:44:52 +0000 Received: from localhost ([127.0.0.1]:43016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLn5o-0007n7-1Q for submit@debbugs.gnu.org; Fri, 25 Sep 2020 08:44:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLn5l-0007mm-JY for 30990@debbugs.gnu.org; Fri, 25 Sep 2020 08:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9kcFAISjx5FR5lmet6EOerTu89RD7aNzH2/hpo249K0=; b=KHdgsyCqP6qaOHhHNTonMsIsH0 r25ypNW7Llys2FUDOwcVO+u2K3uH6HVb0UAIXav+sLlGJpYEaOkfQKVFJnhxXx68RNrRCX3SsHmNh fhrhv9O7OZzpaRXQQ8fOPl/f81jjYEjxkPnpyO9RtbMlVV5S2BxaC1O8vuMMzwYOKxYw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLn5b-0002MH-Ea; Fri, 25 Sep 2020 14:44:42 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> X-Now-Playing: The Human League's _Original Remixes & Rarities_: "The Lebanon (12" Extended)" Date: Fri, 25 Sep 2020 14:44:37 +0200 In-Reply-To: (Glenn Morris's message of "Thu, 29 Mar 2018 13:11:00 -0400") Message-ID: <87imc2owju.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > I think that to do this in general requires evaluating the defcustom at > compile time, which probably isn't the right thing. > > emacs -batch -l admin/cus-test.el -f cus-test-opts all > > will find [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: Alex Branham , 30990@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > I think that to do this in general requires evaluating the defcustom at > compile time, which probably isn't the right thing. > > emacs -batch -l admin/cus-test.el -f cus-test-opts all > > will find these mismatches. I think it should be converted to an > (expensive) ert test, which would solve the problem for Emacs itself. I've now done this. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 25 09:19:03 2020 Received: (at 30990) by debbugs.gnu.org; 25 Sep 2020 13:19:03 +0000 Received: from localhost ([127.0.0.1]:43039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLncs-0000EB-E2 for submit@debbugs.gnu.org; Fri, 25 Sep 2020 09:19:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLncp-0000Dg-SW for 30990@debbugs.gnu.org; Fri, 25 Sep 2020 09:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FtRMrNrjSkQcjgH9gIBdBCpM+10cxZy8Z3V2vntQKcU=; b=LTtHUPIqKiUToHM4Nj6PqgXlwZ 2A4TGrc3gVZu5jgxXUlzGHpfe9SAjhVcbL2yAQsXeadYxmfv/A82ZwLImBOPiQxgbXxxJf6A4l76f M0TE8xpirt/iqXzO1WdHOJvHqiNNMIa/nQ2Fk7alB5DOz4mwREIJj7HSDj/dH2cjfmbw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLncf-0002cD-6O; Fri, 25 Sep 2020 15:18:52 +0200 From: Lars Ingebrigtsen To: alex.branham@gmail.com, Stefan Kangas , 30990@debbugs.gnu.org Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> X-Now-Playing: Herbert's _Suddenly_: "Suddenly (Herbert Redub)" Date: Fri, 25 Sep 2020 15:18:47 +0200 In-Reply-To: (Robert Pluim's message of "Thu, 10 Oct 2019 15:11:20 +0200") Message-ID: <87d02aouyw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > Except that the underlying type is '(repeat ....) so I wonder if this: > > (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) > (unless wallet > (setq w (locate-user-emacs-file (concat "sql-walle [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Except that the underlying type is '(repeat ....) so I wonder if this: > > (dolist (ext '(".json.gpg" ".gpg" ".json" "") wallet) > (unless wallet > (setq w (locate-user-emacs-file (concat "sql-wallet" ext) > (concat ".sql-wallet" ext))) > (when (file-exists-p w) > (setq wallet w))))) ; <= this returns a string > > should use (setq wallet (list w)) instead I went ahead and fixed this along with a bunch of other warnings revealed by the test (that has snuck in after Rober fixed the last batch, I think). There's some that are rather intractable, though, like sql-postgres-login-params. These remain: whitespace-indentation-regexp whitespace-space-after-tab-regexp sql-postgres-login-params gdb-display-source-buffer-action I don't quite understand what's wrong here: (defcustom whitespace-indentation-regexp '("^\t*\\(\\( \\{%d\\}\\)+\\)[^\n\t]" . "^ *\\(\t+\\)[^\n]") [...] :type '(cons (regexp :tag "Indentation SPACEs") (regexp :tag "Indentation TABs")) :group 'whitespace) Isn't that how you specify a cons of two values? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 25 09:36:15 2020 Received: (at 30990) by debbugs.gnu.org; 25 Sep 2020 13:36:15 +0000 Received: from localhost ([127.0.0.1]:43053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLntX-0000e2-1N for submit@debbugs.gnu.org; Fri, 25 Sep 2020 09:36:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLntU-0000dm-Vj for 30990@debbugs.gnu.org; Fri, 25 Sep 2020 09:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HmzcTq75d13MOHC14AFyaR1DyaNPPqqAuJR5K5EwY3o=; b=aOqTqGzwlAxFxRWPbhH3Kv+2r9 c35IfJ5q20kL3SQkcWyBc09ZqLVsxMQSpm82oYEBNPl7/aiRZLRFFGxf6C/V6ZED3OW44Ogc2rLf2 jQrp+YcWFOXqtZOoqgHi7cPQgkLOOskAOqbtxPwAopLuR47lnJaBD3BDVGXjT4dPEXF8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLntL-0002ko-Hc; Fri, 25 Sep 2020 15:36:06 +0200 From: Lars Ingebrigtsen To: alex.branham@gmail.com Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> <87d02aouyw.fsf@gnus.org> X-Now-Playing: Stephan Mathieu's _FrequencyLib_: "Monkey" Date: Fri, 25 Sep 2020 15:36:01 +0200 In-Reply-To: <87d02aouyw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Sep 2020 15:18:47 +0200") Message-ID: <878scyou66.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I don't quite understand what's wrong here: > > (defcustom whitespace-indentation-regexp > '("^\t*\\(\\( \\{%d\\}\\)+\\)[^\n\t]" > . "^ *\\(\t+\\)[^\n]") > [...] > :type '(cons (regexp :tag "Indenta [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: 30990@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I don't quite understand what's wrong here: > > (defcustom whitespace-indentation-regexp > '("^\t*\\(\\( \\{%d\\}\\)+\\)[^\n\t]" > . "^ *\\(\t+\\)[^\n]") > [...] > :type '(cons (regexp :tag "Indentation SPACEs") > (regexp :tag "Indentation TABs")) > :group 'whitespace) > > Isn't that how you specify a cons of two values? That wasn't the problem -- the first bit here isn't really a regexp, it's a string passed to format to yield a regexp. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 25 09:43:52 2020 Received: (at 30990) by debbugs.gnu.org; 25 Sep 2020 13:43:53 +0000 Received: from localhost ([127.0.0.1]:43068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLo0u-0000pU-Nd for submit@debbugs.gnu.org; Fri, 25 Sep 2020 09:43:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLo0s-0000pF-Lv for 30990@debbugs.gnu.org; Fri, 25 Sep 2020 09:43:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S0UULNpH1JWyMKo63sYwxsSZR1vVa52tc1ZyMCOOSzk=; b=gG1GuCp9RoUJCTai4I7/JGHFrx 1MyARolwdp8fLSpC0JIw2W+Sn8lVIHkQT2uxNwRDx3jb61M9opPPzAlskZj3xUrDsmqYm2gVJFyBD DZs6BTaV/ajjLBLotzKRlrdpKV9vr2IpEk5aIMpDo7owFfVkg5P/gUEaSGm6uMpO1NzU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLo0b-0002st-Pg; Fri, 25 Sep 2020 15:43:43 +0200 From: Lars Ingebrigtsen To: alex.branham@gmail.com Subject: Re: bug#30990: Should the byte compiler warn about :type mismatches? References: <87woxu7rf8.fsf@gmail.com> <838sq8grak.fsf@gnu.org> <87imp9aiu4.fsf@gnus.org> <87imox4rci.fsf@gnus.org> <87d02aouyw.fsf@gnus.org> <878scyou66.fsf@gnus.org> X-Now-Playing: Stephan Mathieu's _FrequencyLib_: "Eyes Closed" Date: Fri, 25 Sep 2020 15:43:32 +0200 In-Reply-To: <878scyou66.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 25 Sep 2020 15:36:01 +0200") Message-ID: <874knmottn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: OK, all fixed now. But I guess the answer to "Should the byte compiler warn about :type mismatches?" is... Perhaps it's best to leave that to the linter? So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30990 Cc: 30990@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) OK, all fixed now. But I guess the answer to "Should the byte compiler warn about :type mismatches?" is... Perhaps it's best to leave that to the linter? So I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 25 09:44:01 2020 Received: (at control) by debbugs.gnu.org; 25 Sep 2020 13:44:01 +0000 Received: from localhost ([127.0.0.1]:43071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLo12-0000pq-V3 for submit@debbugs.gnu.org; Fri, 25 Sep 2020 09:44:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLo11-0000pc-7i for control@debbugs.gnu.org; Fri, 25 Sep 2020 09:43:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3UoL+LG+1QUm9ttq8gDuePlG8bDKOhC5FxnxcUyHTkQ=; b=sDiSib7+jb2Nlsxs9xIG2xmRO1 v4EUdklsEcrt3Uzp2INiQj1cTaN/LKuOb2YACRrZwOibufPsN8Yo9/Axy7q8x431rEV091FQlNsFZ yqIitFtBmqwSrEtRK5LwIyN01PQhLxJ6UDZ3Yz1oshL+0A0X+l54bULeq/8689Dv9EhI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLo0t-0002t0-GW for control@debbugs.gnu.org; Fri, 25 Sep 2020 15:43:53 +0200 Date: Fri, 25 Sep 2020 15:43:50 +0200 Message-Id: <873636ott5.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #30990 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 30990 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 30990 quit From unknown Wed Jun 18 23:16:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 24 Oct 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator