Subject: bug#30977: closed (Re: [bug#30977] [PATCH] gnu: Add duperemove.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 29 Mar 2018 12:01:02 +0000

Your bug report

#30977: [PATCH] gnu: Add duperemove.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
30977: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30977
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#30977] [PATCH] gnu: Add duperemove.
From: [email-masked] (Ludovic Courtès)
To: Vasile Dumitrascu <[email-masked]>
Cc: [email-masked]
Date: Thu, 29 Mar 2018 14:00:29 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Vasile Dumitrascu <[email-masked]> skribis:

> * gnu/packages/disk.scm (duperemove): New variable.

Applied with the following changes, mostly to placate ‘guix lint’.

Thanks,
Ludo’.

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index de829cd24..595000bf8 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -463,21 +463,23 @@ a card with a smaller capacity than stated.")
   (package
     (name "duperemove")
     (version "v0.11.beta4")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "https://github.com/markfasheh/duperemove/archive/"
-                           version ".tar.gz"))
-       (sha256
-        (base32
-         "1h5nk03kflfnzihvn2rvfz1h623x1zpkn9hp29skd7n3f2bc5k7x"))))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/markfasheh/duperemove/archive/"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "1h5nk03kflfnzihvn2rvfz1h623x1zpkn9hp29skd7n3f2bc5k7x"))
+              (file-name (string-append name "-" version ".tar.gz"))))
     (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
     (inputs
-     `(("pkg-config" ,pkg-config)
-       ("glib" ,glib)
+     `(("glib" ,glib)
        ("sqlite" ,sqlite)))
     (arguments
-     `(#:tests? #f ;no test suite
+     `(#:tests? #f                                ;no test suite
        #:phases
        (modify-phases %standard-phases
          ;; no configure script
@@ -485,18 +487,18 @@ a card with a smaller capacity than stated.")
        #:make-flags (list (string-append "PREFIX=" %output)
                           "CC=gcc")))
     (home-page "https://github.com/markfasheh/duperemove")
-    (synopsis "Tools for deduping file systems")
-    (description "Duperemove is a simple tool for finding duplicated extents and
-submitting them for deduplication. When given a list of files it will hash their
-contents on a block by block basis and compare those hashes to each other,
-finding and categorizing blocks that match each other. When given the -d option,
-duperemove will submit those extents for deduplication using the Linux kernel
-extent-same ioctl.
+    (synopsis "Tools for de-duplicating file system data")
+    (description "Duperemove is a simple tool for finding duplicated extents
+and submitting them for deduplication.  When given a list of files it will
+hash their contents on a block by block basis and compare those hashes to each
+other, finding and categorizing blocks that match each other.  When given the
+@option{-d} option, duperemove will submit those extents for deduplication
+using the Linux kernel extent-same @code{ioctl}.
 
-Duperemove can store the hashes it computes in a 'hashfile'. If given an
-existing hashfile, duperemove will only compute hashes for those files which
-have changed since the last run. Thus you can run duperemove repeatedly on your
-data as it changes, without having to re-checksum unchanged data.
+Duperemove can store the hashes it computes in a @dfn{hash file}.  If given an
+existing hash file, duperemove will only compute hashes for those files which
+have changed since the last run.  Thus you can run duperemove repeatedly on
+your data as it changes, without having to re-checksum unchanged data.
 
-Duperemove can also take input from the fdupes program.")
+Duperemove can also take input from the @command{fdupes} program.")
     (license license:gpl2)))

Subject: [PATCH] gnu: Add duperemove.
From: Vasile Dumitrascu <[email-masked]>
To: [email-masked]
Cc: Vasile Dumitrascu <[email-masked]>
Date: Wed, 28 Mar 2018 21:25:05 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/disk.scm (duperemove): New variable.
---
 gnu/packages/disk.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 96c3a56e7..de829cd24 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -9,6 +9,7 @@
 ;;; Copyright ?? 2016, 2017 Marius Bakke <[email-masked]>
 ;;; Copyright ?? 2017 Hartmut Goebel <[email-masked]>
 ;;; Copyright ?? 2017 Stefan Reich??r <[email-masked]>
+;;; Copyright ?? 2018 Vasile Dumitrascu <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -34,6 +35,7 @@
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages databases)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages glib)
@@ -456,3 +458,45 @@ a card with a smaller capacity than stated.")
 
 (define-public python2-parted
   (package-with-python2 python-parted))
+
+(define-public duperemove
+  (package
+    (name "duperemove")
+    (version "v0.11.beta4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/markfasheh/duperemove/archive/"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "1h5nk03kflfnzihvn2rvfz1h623x1zpkn9hp29skd7n3f2bc5k7x"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("pkg-config" ,pkg-config)
+       ("glib" ,glib)
+       ("sqlite" ,sqlite)))
+    (arguments
+     `(#:tests? #f ;no test suite
+       #:phases
+       (modify-phases %standard-phases
+         ;; no configure script
+         (delete 'configure))
+       #:make-flags (list (string-append "PREFIX=" %output)
+                          "CC=gcc")))
+    (home-page "https://github.com/markfasheh/duperemove")
+    (synopsis "Tools for deduping file systems")
+    (description "Duperemove is a simple tool for finding duplicated extents and
+submitting them for deduplication. When given a list of files it will hash their
+contents on a block by block basis and compare those hashes to each other,
+finding and categorizing blocks that match each other. When given the -d option,
+duperemove will submit those extents for deduplication using the Linux kernel
+extent-same ioctl.
+
+Duperemove can store the hashes it computes in a 'hashfile'. If given an
+existing hashfile, duperemove will only compute hashes for those files which
+have changed since the last run. Thus you can run duperemove repeatedly on your
+data as it changes, without having to re-checksum unchanged data.
+
+Duperemove can also take input from the fdupes program.")
+    (license license:gpl2)))
-- 
2.16.3