GNU bug report logs - #30968
[PATCH] gnu: mu: Fix tests failures triggered by DST.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: bug#30968: closed (Re: [bug#30968] [PATCH] gnu: mu: Fix tests
 failures triggered by DST.)
Date: Wed, 28 Mar 2018 15:15:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#30968: [PATCH] gnu: mu: Fix tests failures triggered by DST.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 30968 <at> debbugs.gnu.org.

-- 
30968: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30968
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 30968-done <at> debbugs.gnu.org
Subject: Re: [bug#30968] [PATCH] gnu: mu: Fix tests failures triggered by DST.
Date: Wed, 28 Mar 2018 17:14:28 +0200

[Message part 3 (text/plain, inline)]

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From b6c27eab14b678d12dd4b3b480ea88542bf096e7 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Tue, 27 Mar 2018 21:59:24 -0400
> Subject: [PATCH] gnu: mu: Fix tests failures triggered by DST.
>
> * gnu/packages/mail.scm (mu)[phases]: Add 'fix-date-tests.

Well done!  Applied with the minor changes below.

Thank you,

Ludo’.

[Message part 4 (text/x-patch, inline)]

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index dca4ffb9a..3dab1325e 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -620,11 +620,12 @@ security functionality including PGP, S/MIME, SSH, and SSL.")
              #t))
          (add-after 'patch-configure 'fix-date-tests
            ;; Loosen test tolerances to prevent failures caused by daylight
-           ;; time saving (DST).  See: https://github.com/djcb/mu/issues/1214.
+           ;; saving time (DST).  See: https://github.com/djcb/mu/issues/1214.
            (lambda _
              (substitute* "lib/parser/test-utils.cc"
                (("\\* 60 \\* 60, 1 },")
-                "* 60 * 60, 3600 + 1 },"))))
+                "* 60 * 60, 3600 + 1 },"))
+             #t))
          (add-before 'install 'fix-ffi
            (lambda* (#:key outputs #:allow-other-keys)
              (substitute* "guile/mu.scm"

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: mu: Fix tests failures triggered by DST.
Date: Tue, 27 Mar 2018 22:04:01 -0400

[Message part 6 (text/plain, inline)]

Hello!

This fixes test failures for our mu package.

Thanks!

Maxim

[0001-gnu-mu-Fix-tests-failures-triggered-by-DST.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.