GNU bug report logs - #30962
26.0.91; Encrypt message when there is a key for each recipient

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30962 in the body.
You can then email your comments to 30962 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.91; Encrypt message when there is a key for each recipient
Date: Tue, 27 Mar 2018 17:35:19 +0200

[Message part 1 (text/plain, inline)]

Attached patch adds support to automatically encrypt email messages when
the epg keyring contains a key for every recipient.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Detect-if-a-message-can-be-encrypted-and-add-an-MML-.patch (text/x-patch, attachment)]

Message #8 received at 30962 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>, 30962 <at> debbugs.gnu.org
Subject: Re: bug#30962: 26.0.91;
 Encrypt message when there is a key for each recipient
Date: Wed, 04 Apr 2018 10:34:50 +0200

[Message part 1 (text/plain, inline)]

Damien Cassou <damien <at> cassou.me> writes:

Hi Damien,

> Attached patch adds support to automatically encrypt email messages when
> the epg keyring contains a key for every recipient.

Thanks, I've been using it for a few days without any issue.

> +(defun message-recipients ()
          ^^^^^^^^^^^^^^^^^^
          Would `message-all-recipients' be a better name?
> [...]
> +(ert-deftest message-recipients ()
> +  (ert-with-test-buffer (:name "message")
> +    (insert "To: Person 1 <p1 <at> p1.org>, Person 2 <p2 <at> p2.org>\n")
> +    (insert "CC: Person 3 <p3 <at> p3.org>, Person 4 <p4 <at> p4.org>\n")
> +    (insert "BCC: Person 5 <p5 <at> p5.org>, Person 6 <p6 <at> p6.org>\n")
> +    (should (equal (message-recipients)
> +                   '(("Person 1" "p1 <at> p1.org")
> +                     ("Person 2" "p2 <at> p2.org")
> +                     ("Person 3" "p3 <at> p3.org")
> +                     ("Person 4" "p4 <at> p4.org")
> +                     ("Person 5" "p5 <at> p5.org")
> +                     ("Person 6" "p6 <at> p6.org"))))))

Could you add tests for `message-all-epg-keys-available-p' as well?

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30962 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Nicolas Petton <nicolas <at> petton.fr>, 30962 <at> debbugs.gnu.org
Subject: Re: bug#30962: 26.0.91;
 Encrypt message when there is a key for each recipient
Date: Wed, 04 Apr 2018 11:35:55 +0200

[Message part 1 (text/plain, inline)]

Nicolas Petton <nicolas <at> petton.fr> writes:
>           Would `message-all-recipients' be a better name?


renamed


> Could you add tests for `message-all-epg-keys-available-p' as well?

done.

Please find attached a new version.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Detect-if-a-message-can-be-encrypted-and-add-an-MML-.patch (text/x-patch, attachment)]

Message #14 received at 30962 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>, 30962 <at> debbugs.gnu.org
Cc: larsi <at> gnus.org
Subject: Re: bug#30962: 26.0.91;
 Encrypt message when there is a key for each recipient
Date: Wed, 04 Apr 2018 15:28:38 +0200

[Message part 1 (text/plain, inline)]

Damien Cassou <damien <at> cassou.me> writes:

> Nicolas Petton <nicolas <at> petton.fr> writes:
>>           Would `message-all-recipients' be a better name?
>
>
> renamed
>
>
>> Could you add tests for `message-all-epg-keys-available-p' as well?
>
> done.
>
> Please find attached a new version.

Thanks.

Lars, if that's ok with you, I'll install Damien's patch on master.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 30962 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: Damien Cassou <damien <at> cassou.me>, 30962 <at> debbugs.gnu.org
Subject: Re: bug#30962: 26.0.91;
 Encrypt message when there is a key for each recipient
Date: Wed, 04 Apr 2018 17:43:36 +0200

Nicolas Petton <nicolas <at> petton.fr> writes:

> Lars, if that's ok with you, I'll install Damien's patch on master.

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 30962 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Damien Cassou <damien <at> cassou.me>, 30962 <at> debbugs.gnu.org,
 30962-done <at> debbugs.gnu.org
Subject: Re: bug#30962: 26.0.91;
 Encrypt message when there is a key for each recipient
Date: Wed, 04 Apr 2018 20:35:15 +0200

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> Lars, if that's ok with you, I'll install Damien's patch on master.
>
> Looks good to me.

Ok, I installed it in master, so I'm closing this issue.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.