GNU bug report logs -
#30960
[PATCH 0/4] Switch to font-build-system
Previous Next
Reported by: Arun Isaac <arunisaac <at> systemreboot.net>
Date: Tue, 27 Mar 2018 08:50:01 UTC
Severity: normal
Tags: patch
Done: Arun Isaac <arunisaac <at> systemreboot.net>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30960 in the body.
You can then email your comments to 30960 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 08:50:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Arun Isaac <arunisaac <at> systemreboot.net>:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org.
(Tue, 27 Mar 2018 08:50:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
If someone could do a quick sanity check on these patches, I'll push.
Thanks!
Arun Isaac (4):
gnu: font-lato: Switch to font-build-system.
gnu: font-linuxlibertine: Switch to font-build-system.
gnu: culmus: Switch to font-build-system.
gnu: culmus: Rename to font-culmus.
gnu/packages/fonts.scm | 133 +++++++++++++++----------------------------------
1 file changed, 39 insertions(+), 94 deletions(-)
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 08:55:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (font-linuxlibertine): Switch to font-build-system.
[arguments]: Replace system* with invoke.
---
gnu/packages/fonts.scm | 39 +++++++++++++--------------------------
1 file changed, 13 insertions(+), 26 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 567483889..763214647 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -305,37 +305,24 @@ The Liberation Fonts are sponsored by Red Hat.")
(sha256
(base32
"0x7cz6hvhpil1rh03rax9zsfzm54bh7r4bbrq8rz673gl9h47v0v"))))
- (build-system gnu-build-system)
+ (build-system font-build-system)
(arguments
- `(#:tests? #f ; there are no tests
- #:modules ((guix build utils)
- (guix build gnu-build-system)
- (srfi srfi-1)
- (srfi srfi-26))
- #:phases
+ `(#:phases
(modify-phases %standard-phases
- (delete 'configure)
- (replace 'build
+ (add-before 'install 'build
(lambda _
(let ((compile
(lambda (name ext)
- (zero? (system*
- "fontforge" "-lang=ff"
- "-c" (string-append "Open('" name "');"
- "Generate('"
- (basename name "sfd") ext
- "')"))))))
- (every (lambda (name)
- (and (compile name "ttf")
- (compile name "otf")))
- (find-files "." "\\.sfd$")))))
- (replace 'install
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((font-dir (string-append (assoc-ref outputs "out")
- "/share/fonts/truetype")))
- (mkdir-p font-dir)
- (for-each (cut install-file <> font-dir)
- (find-files "." "\\.(otf|ttf)$"))
+ (invoke
+ "fontforge" "-lang=ff"
+ "-c" (string-append "Open('" name "');"
+ "Generate('"
+ (basename name "sfd") ext
+ "')")))))
+ (for-each (lambda (name)
+ (and (compile name "ttf")
+ (compile name "otf")))
+ (find-files "." "\\.sfd$"))
#t))))))
(native-inputs
`(("fontforge" ,fontforge)))
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 08:55:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (culmus): Rename to...
(font-culmus): ...this. Re-indent.
---
gnu/packages/fonts.scm | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index a58478d43..7cfd3318d 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1189,19 +1189,19 @@ It comes in 7 incremental weights:
ExtraLight, Light, Book, Medium, Semibold, Bold & ExtraBold")
(license license:silofl1.1)))
-(define-public culmus
+(define-public font-culmus
(package
- (name "culmus")
+ (name "font-culmus")
(version "0.132")
(source
- (origin
- (method url-fetch)
- (uri (string-append "https://sourceforge.net/projects/"
- "culmus/files/culmus/" version "/culmus-src-"
- version ".tar.gz"))
- (sha256
- (base32
- "1djxalm26r7bcq33ckmfa15xfs6pmqzvcl64d5lqa1dl01bl4j4z"))))
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://sourceforge.net/projects/"
+ "culmus/files/culmus/" version "/culmus-src-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "1djxalm26r7bcq33ckmfa15xfs6pmqzvcl64d5lqa1dl01bl4j4z"))))
(build-system font-build-system)
(arguments
`(#:phases
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 08:55:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (culmus): Switch to font-build-system.
[arguments]: Replace system* with invoke.
---
gnu/packages/fonts.scm | 52 +++++++++++++++-----------------------------------
1 file changed, 15 insertions(+), 37 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 763214647..a58478d43 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1202,49 +1202,27 @@ ExtraLight, Light, Book, Medium, Semibold, Bold & ExtraBold")
(sha256
(base32
"1djxalm26r7bcq33ckmfa15xfs6pmqzvcl64d5lqa1dl01bl4j4z"))))
- (build-system gnu-build-system)
+ (build-system font-build-system)
(arguments
- `(#:tests? #f ; no tests
- #:modules ((guix build utils)
- (guix build gnu-build-system)
- (srfi srfi-1)
- (srfi srfi-26))
- #:phases
+ `(#:phases
(modify-phases %standard-phases
- (delete 'configure)
- (replace 'build
+ (add-before 'install 'build
(lambda _
(let ((compile
(lambda (name ext)
- (zero? (system*
- "fontforge" "-lang=ff"
- "-c" (string-append "Open('" name "');"
- "Generate('"
- (basename name "sfd") ext
- "')"))))))
+ (invoke
+ "fontforge" "-lang=ff"
+ "-c" (string-append "Open('" name "');"
+ "Generate('"
+ (basename name "sfd") ext
+ "')")))))
;; This part based on the fonts shipped in the non-source package.
- (every (lambda (name)
- (compile name "ttf"))
- (find-files "." "^[^Nachlieli].*\\.sfd$"))
- (every (lambda (name)
- (compile name "otf"))
- (find-files "." "^Nachlieli.*\\.sfd$"))
- #t)))
- (replace 'install
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref %outputs "out"))
- (ttf (string-append out "/share/fonts/truetype"))
- (otf (string-append out "/share/fonts/opentype"))
- (license (string-append out "/share/doc/" ,name)))
- (for-each (lambda (file)
- (install-file file ttf))
- (find-files "." "\\.ttf$"))
- (for-each (lambda (file)
- (install-file file otf))
- (find-files "." "\\.otf$"))
- (for-each (lambda (file)
- (install-file file license))
- '("GNU-GPL" "LICENSE" "LICENSE-BITSTREAM"))
+ (for-each (lambda (name)
+ (compile name "ttf"))
+ (find-files "." "^[^Nachlieli].*\\.sfd$"))
+ (for-each (lambda (name)
+ (compile name "otf"))
+ (find-files "." "^Nachlieli.*\\.sfd$"))
#t))))))
(native-inputs
`(("fontforge" ,fontforge)))
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 08:55:03 GMT)
Full text and
rfc822 format available.
Message #17 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (font-lato): Switch to font-build-system.
---
gnu/packages/fonts.scm | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index f57d5114a..567483889 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -202,27 +202,7 @@ sans-serif designed for on-screen reading. It is used by GNOME <at> tie{}3.")
(sha256
(base32
"1f5540g0ja1nx3ddd3ywn77xc81ssrxpq8n3gyb9sabyq2b4xda2"))))
- (build-system trivial-build-system)
- (arguments
- `(#:modules ((guix build utils))
- #:builder (begin
- (use-modules (guix build utils)
- (srfi srfi-26))
-
- (let ((PATH (string-append (assoc-ref %build-inputs
- "unzip")
- "/bin"))
- (font-dir (string-append %output
- "/share/fonts/truetype")))
- (setenv "PATH" PATH)
- (system* "unzip" (assoc-ref %build-inputs "source"))
-
- (mkdir-p font-dir)
- (for-each (lambda (ttf)
- (install-file ttf font-dir))
- (find-files "." "\\.ttf$"))))))
-
- (native-inputs `(("unzip" ,unzip)))
+ (build-system font-build-system)
(home-page "http://www.latofonts.com/lato-free-fonts/")
(synopsis "Lato sans-serif typeface")
(description
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 09:08:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 30960 <at> debbugs.gnu.org (full text, mbox):
Arun Isaac transcribed 430 bytes:
> If someone could do a quick sanity check on these patches, I'll push.
What does that mean? Did you not build them? Or just a simple request
for review?
I know I had my reasons for not using font-build-system with lato, but
maybe you succeeded.
> Thanks!
>
> Arun Isaac (4):
> gnu: font-lato: Switch to font-build-system.
> gnu: font-linuxlibertine: Switch to font-build-system.
> gnu: culmus: Switch to font-build-system.
> gnu: culmus: Rename to font-culmus.
>
> gnu/packages/fonts.scm | 133 +++++++++++++++----------------------------------
> 1 file changed, 39 insertions(+), 94 deletions(-)
>
> --
> 2.15.1
>
>
>
>
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 12:19:02 GMT)
Full text and
rfc822 format available.
Message #23 received at 30960 <at> debbugs.gnu.org (full text, mbox):
ng0 <ng0 <at> n0.is> writes:
> Arun Isaac transcribed 430 bytes:
>> If someone could do a quick sanity check on these patches, I'll push.
>
> What does that mean? Did you not build them? Or just a simple request
> for review?
I built all packages successfully. This is just a request to check
commit messages, point out any simple typos, etc.
> I know I had my reasons for not using font-build-system with lato, but
> maybe you succeeded.
Yes, I was able to build font-lato using the font-build-system. If you
have an issue with using the font-build-system, do let me know.
Thanks!
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 13:48:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 30960 <at> debbugs.gnu.org (full text, mbox):
Arun Isaac transcribed 585 bytes:
> ng0 <ng0 <at> n0.is> writes:
>
> > Arun Isaac transcribed 430 bytes:
> >> If someone could do a quick sanity check on these patches, I'll push.
> >
> > What does that mean? Did you not build them? Or just a simple request
> > for review?
>
> I built all packages successfully. This is just a request to check
> commit messages, point out any simple typos, etc.
Okay
> > I know I had my reasons for not using font-build-system with lato, but
> > maybe you succeeded.
>
> Yes, I was able to build font-lato using the font-build-system. If you
> have an issue with using the font-build-system, do let me know.
So I applied all your patches, all except lato built without errors.
Lato:
...
phase `install-license-files' succeeded after 0.0 seconds
starting phase `reset-gzip-timestamps'
find-files: /gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010: No such file or directory
phase `reset-gzip-timestamps' succeeded after 0.0 seconds
starting phase `compress-documentation'
phase `compress-documentation' succeeded after 0.0 seconds
builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
@ build-failed /gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv - 1 builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
guix build: error: build failed: build of `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed
Which could be what I experienced when I first tried to build it with the font-build-system
and then switched to what it uses now in master.
> Thanks!
>
>
>
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:13:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 30960 <at> debbugs.gnu.org (full text, mbox):
> phase `install-license-files' succeeded after 0.0 seconds
> starting phase `reset-gzip-timestamps'
> find-files: /gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010: No such file or directory
> phase `reset-gzip-timestamps' succeeded after 0.0 seconds
> starting phase `compress-documentation'
> phase `compress-documentation' succeeded after 0.0 seconds
> builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> @ build-failed /gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv - 1 builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> guix build: error: build failed: build of `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed
>
> Which could be what I experienced when I first tried to build it with the font-build-system
> and then switched to what it uses now in master.
I tried building font-lato again on my machine, and it worked. I suspect
this problem you are facing is due to the __MACOSX folders in the zip
archive. I'm sending in a new patchset with url-fetch/zipbomb instead of
url-fetch. Let me know if it works.
Thanks.
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:16:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (culmus): Switch to font-build-system.
[arguments]: Replace system* with invoke.
---
gnu/packages/fonts.scm | 52 +++++++++++++++-----------------------------------
1 file changed, 15 insertions(+), 37 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 8252c1d72..dfa96b148 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1202,49 +1202,27 @@ ExtraLight, Light, Book, Medium, Semibold, Bold & ExtraBold")
(sha256
(base32
"1djxalm26r7bcq33ckmfa15xfs6pmqzvcl64d5lqa1dl01bl4j4z"))))
- (build-system gnu-build-system)
+ (build-system font-build-system)
(arguments
- `(#:tests? #f ; no tests
- #:modules ((guix build utils)
- (guix build gnu-build-system)
- (srfi srfi-1)
- (srfi srfi-26))
- #:phases
+ `(#:phases
(modify-phases %standard-phases
- (delete 'configure)
- (replace 'build
+ (add-before 'install 'build
(lambda _
(let ((compile
(lambda (name ext)
- (zero? (system*
- "fontforge" "-lang=ff"
- "-c" (string-append "Open('" name "');"
- "Generate('"
- (basename name "sfd") ext
- "')"))))))
+ (invoke
+ "fontforge" "-lang=ff"
+ "-c" (string-append "Open('" name "');"
+ "Generate('"
+ (basename name "sfd") ext
+ "')")))))
;; This part based on the fonts shipped in the non-source package.
- (every (lambda (name)
- (compile name "ttf"))
- (find-files "." "^[^Nachlieli].*\\.sfd$"))
- (every (lambda (name)
- (compile name "otf"))
- (find-files "." "^Nachlieli.*\\.sfd$"))
- #t)))
- (replace 'install
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref %outputs "out"))
- (ttf (string-append out "/share/fonts/truetype"))
- (otf (string-append out "/share/fonts/opentype"))
- (license (string-append out "/share/doc/" ,name)))
- (for-each (lambda (file)
- (install-file file ttf))
- (find-files "." "\\.ttf$"))
- (for-each (lambda (file)
- (install-file file otf))
- (find-files "." "\\.otf$"))
- (for-each (lambda (file)
- (install-file file license))
- '("GNU-GPL" "LICENSE" "LICENSE-BITSTREAM"))
+ (for-each (lambda (name)
+ (compile name "ttf"))
+ (find-files "." "^[^Nachlieli].*\\.sfd$"))
+ (for-each (lambda (name)
+ (compile name "otf"))
+ (find-files "." "^Nachlieli.*\\.sfd$"))
#t))))))
(native-inputs
`(("fontforge" ,fontforge)))
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:16:04 GMT)
Full text and
rfc822 format available.
Message #35 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (culmus): Rename to...
(font-culmus): ...this. Re-indent.
---
gnu/packages/fonts.scm | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index dfa96b148..8e892da27 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1189,19 +1189,19 @@ It comes in 7 incremental weights:
ExtraLight, Light, Book, Medium, Semibold, Bold & ExtraBold")
(license license:silofl1.1)))
-(define-public culmus
+(define-public font-culmus
(package
- (name "culmus")
+ (name "font-culmus")
(version "0.132")
(source
- (origin
- (method url-fetch)
- (uri (string-append "https://sourceforge.net/projects/"
- "culmus/files/culmus/" version "/culmus-src-"
- version ".tar.gz"))
- (sha256
- (base32
- "1djxalm26r7bcq33ckmfa15xfs6pmqzvcl64d5lqa1dl01bl4j4z"))))
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://sourceforge.net/projects/"
+ "culmus/files/culmus/" version "/culmus-src-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "1djxalm26r7bcq33ckmfa15xfs6pmqzvcl64d5lqa1dl01bl4j4z"))))
(build-system font-build-system)
(arguments
`(#:phases
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:16:04 GMT)
Full text and
rfc822 format available.
Message #38 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (font-lato): Switch to font-build-system.
[source]: Use url-fetch/zipbomb.
---
gnu/packages/fonts.scm | 24 ++----------------------
1 file changed, 2 insertions(+), 22 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index f57d5114a..8ab3cdcf8 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -197,32 +197,12 @@ sans-serif designed for on-screen reading. It is used by GNOME <at> tie{}3.")
(name "font-lato")
(version "2.010")
(source (origin
- (method url-fetch)
+ (method url-fetch/zipbomb)
(uri (string-append "http://www.latofonts.com/download/Lato2OFL.zip"))
(sha256
(base32
"1f5540g0ja1nx3ddd3ywn77xc81ssrxpq8n3gyb9sabyq2b4xda2"))))
- (build-system trivial-build-system)
- (arguments
- `(#:modules ((guix build utils))
- #:builder (begin
- (use-modules (guix build utils)
- (srfi srfi-26))
-
- (let ((PATH (string-append (assoc-ref %build-inputs
- "unzip")
- "/bin"))
- (font-dir (string-append %output
- "/share/fonts/truetype")))
- (setenv "PATH" PATH)
- (system* "unzip" (assoc-ref %build-inputs "source"))
-
- (mkdir-p font-dir)
- (for-each (lambda (ttf)
- (install-file ttf font-dir))
- (find-files "." "\\.ttf$"))))))
-
- (native-inputs `(("unzip" ,unzip)))
+ (build-system font-build-system)
(home-page "http://www.latofonts.com/lato-free-fonts/")
(synopsis "Lato sans-serif typeface")
(description
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:16:05 GMT)
Full text and
rfc822 format available.
Message #41 received at 30960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/fonts.scm (font-linuxlibertine): Switch to font-build-system.
[arguments]: Replace system* with invoke.
---
gnu/packages/fonts.scm | 39 +++++++++++++--------------------------
1 file changed, 13 insertions(+), 26 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 8ab3cdcf8..8252c1d72 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -305,37 +305,24 @@ The Liberation Fonts are sponsored by Red Hat.")
(sha256
(base32
"0x7cz6hvhpil1rh03rax9zsfzm54bh7r4bbrq8rz673gl9h47v0v"))))
- (build-system gnu-build-system)
+ (build-system font-build-system)
(arguments
- `(#:tests? #f ; there are no tests
- #:modules ((guix build utils)
- (guix build gnu-build-system)
- (srfi srfi-1)
- (srfi srfi-26))
- #:phases
+ `(#:phases
(modify-phases %standard-phases
- (delete 'configure)
- (replace 'build
+ (add-before 'install 'build
(lambda _
(let ((compile
(lambda (name ext)
- (zero? (system*
- "fontforge" "-lang=ff"
- "-c" (string-append "Open('" name "');"
- "Generate('"
- (basename name "sfd") ext
- "')"))))))
- (every (lambda (name)
- (and (compile name "ttf")
- (compile name "otf")))
- (find-files "." "\\.sfd$")))))
- (replace 'install
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((font-dir (string-append (assoc-ref outputs "out")
- "/share/fonts/truetype")))
- (mkdir-p font-dir)
- (for-each (cut install-file <> font-dir)
- (find-files "." "\\.(otf|ttf)$"))
+ (invoke
+ "fontforge" "-lang=ff"
+ "-c" (string-append "Open('" name "');"
+ "Generate('"
+ (basename name "sfd") ext
+ "')")))))
+ (for-each (lambda (name)
+ (and (compile name "ttf")
+ (compile name "otf")))
+ (find-files "." "\\.sfd$"))
#t))))))
(native-inputs
`(("fontforge" ,fontforge)))
--
2.15.1
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:31:01 GMT)
Full text and
rfc822 format available.
Message #44 received at 30960 <at> debbugs.gnu.org (full text, mbox):
Arun Isaac transcribed 1.3K bytes:
>
> > phase `install-license-files' succeeded after 0.0 seconds
> > starting phase `reset-gzip-timestamps'
> > find-files: /gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010: No such file or directory
> > phase `reset-gzip-timestamps' succeeded after 0.0 seconds
> > starting phase `compress-documentation'
> > phase `compress-documentation' succeeded after 0.0 seconds
> > builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> > @ build-failed /gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv - 1 builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> > guix build: error: build failed: build of `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed
> >
> > Which could be what I experienced when I first tried to build it with the font-build-system
> > and then switched to what it uses now in master.
>
> I tried building font-lato again on my machine, and it worked. I suspect
> this problem you are facing is due to the __MACOSX folders in the zip
Out of scope of this patchset, but:
Those aren't really necessary in the use. Couldn't we just instruct the font-build-system
to ignore and/or delete them?
> archive. I'm sending in a new patchset with url-fetch/zipbomb instead of
> url-fetch. Let me know if it works.
>
> Thanks.
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:34:02 GMT)
Full text and
rfc822 format available.
Message #47 received at 30960 <at> debbugs.gnu.org (full text, mbox):
ng0 transcribed 1.5K bytes:
> Arun Isaac transcribed 1.3K bytes:
> >
> > > phase `install-license-files' succeeded after 0.0 seconds
> > > starting phase `reset-gzip-timestamps'
> > > find-files: /gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010: No such file or directory
> > > phase `reset-gzip-timestamps' succeeded after 0.0 seconds
> > > starting phase `compress-documentation'
> > > phase `compress-documentation' succeeded after 0.0 seconds
> > > builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> > > @ build-failed /gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv - 1 builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> > > guix build: error: build failed: build of `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed
> > >
> > > Which could be what I experienced when I first tried to build it with the font-build-system
> > > and then switched to what it uses now in master.
> >
> > I tried building font-lato again on my machine, and it worked. I suspect
> > this problem you are facing is due to the __MACOSX folders in the zip
>
> Out of scope of this patchset, but:
> Those aren't really necessary in the use. Couldn't we just instruct the font-build-system
> to ignore and/or delete them?
>
> > archive. I'm sending in a new patchset with url-fetch/zipbomb instead of
> > url-fetch. Let me know if it works.
New patch-series lato build without problems.
> > Thanks.
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 14:36:02 GMT)
Full text and
rfc822 format available.
Message #50 received at 30960 <at> debbugs.gnu.org (full text, mbox):
ng0 transcribed 1.5K bytes:
> Arun Isaac transcribed 1.3K bytes:
> >
> > > phase `install-license-files' succeeded after 0.0 seconds
> > > starting phase `reset-gzip-timestamps'
> > > find-files: /gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010: No such file or directory
> > > phase `reset-gzip-timestamps' succeeded after 0.0 seconds
> > > starting phase `compress-documentation'
> > > phase `compress-documentation' succeeded after 0.0 seconds
> > > builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> > > @ build-failed /gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv - 1 builder for `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed to produce output path `/gnu/store/8zr56l7gh1rh76l8gdyy2j5hn84r56nv-font-lato-2.010'
> > > guix build: error: build failed: build of `/gnu/store/85xg1bvd3xq79y41f7rvasy73jzpkcba-font-lato-2.010.drv' failed
> > >
> > > Which could be what I experienced when I first tried to build it with the font-build-system
> > > and then switched to what it uses now in master.
> >
> > I tried building font-lato again on my machine, and it worked. I suspect
> > this problem you are facing is due to the __MACOSX folders in the zip
>
> Out of scope of this patchset, but:
> Those aren't really necessary in the use. Couldn't we just instruct the font-build-system
> to ignore and/or delete them?
>
> > archive. I'm sending in a new patchset with url-fetch/zipbomb instead of
> > url-fetch. Let me know if it works.
Yes, it does. New patch series LGTM.
> > Thanks.
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 15:45:02 GMT)
Full text and
rfc822 format available.
Message #53 received at 30960 <at> debbugs.gnu.org (full text, mbox):
>> I tried building font-lato again on my machine, and it worked. I suspect
>> this problem you are facing is due to the __MACOSX folders in the zip
>
> Out of scope of this patchset, but:
> Those aren't really necessary in the use. Couldn't we just instruct the font-build-system
> to ignore and/or delete them?
This problem is general to all zip archives. Therefore, I don't think
font-build-system is the place to delete them. This should probably go
into the unpack phase of the gnu-build-system, which is what handles
unpacking of all archives. WDYT?
Information forwarded
to
guix-patches <at> gnu.org:
bug#30960; Package
guix-patches.
(Tue, 27 Mar 2018 16:44:01 GMT)
Full text and
rfc822 format available.
Message #56 received at 30960 <at> debbugs.gnu.org (full text, mbox):
Arun Isaac transcribed 558 bytes:
>
> >> I tried building font-lato again on my machine, and it worked. I suspect
> >> this problem you are facing is due to the __MACOSX folders in the zip
> >
> > Out of scope of this patchset, but:
> > Those aren't really necessary in the use. Couldn't we just instruct the font-build-system
> > to ignore and/or delete them?
>
> This problem is general to all zip archives. Therefore, I don't think
> font-build-system is the place to delete them. This should probably go
> into the unpack phase of the gnu-build-system, which is what handles
> unpacking of all archives. WDYT?
Okay, sounds good.
Reply sent
to
Arun Isaac <arunisaac <at> systemreboot.net>:
You have taken responsibility.
(Wed, 28 Mar 2018 09:52:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Arun Isaac <arunisaac <at> systemreboot.net>:
bug acknowledged by developer.
(Wed, 28 Mar 2018 09:52:02 GMT)
Full text and
rfc822 format available.
Message #61 received at 30960-done <at> debbugs.gnu.org (full text, mbox):
> New patch series LGTM.
Pushed, thanks!
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Wed, 25 Apr 2018 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 7 years and 141 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.