GNU bug report logs - #30940
[PATCH] gnu: Add twitchy.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30940 in the body.
You can then email your comments to 30940 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add twitchy.
Date: Sun, 25 Mar 2018 21:41:25 +0300

* gnu/packages/video.scm (twitchy): New public variable.
---
 gnu/packages/video.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index f7f82df07..1d073f328 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1782,6 +1782,38 @@ from sites like Twitch.tv and pipes them into a video player of choice.")
 (define-public livestreamer
   (deprecated-package "livestreamer" streamlink))
 
+(define-public twitchy
+  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
+    (package
+      (name "twitchy")
+      (version (git-version "3.2" "1" commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/BasioMeusPuga/twitchy.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))
+      (build-system python-build-system)
+      (arguments
+       '(#:phases
+         (modify-phases %standard-phases
+           (add-before 'check 'check-setup
+             (lambda _
+               (setenv "HOME" (getcwd)) ;Needs to write to ‘$HOME’.
+               #t)))))
+      (inputs
+       `(("python-requests" ,python-requests)
+         ("streamlink" ,streamlink)))
+      (home-page "https://github.com/BasioMeusPuga/twitchy")
+      (synopsis "Command-line interface for Twitch.tv")
+      (description
+       "This package provides a command-line interface for Twitch.tv")
+      (license license:gpl3+))))
+
 (define-public mlt
   (package
     (name "mlt")
-- 
2.16.2

Message #8 received at 30940 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 30940 <at> debbugs.gnu.org
Subject: Re: [bug#30940] [PATCH] gnu: Add twitchy.
Date: Mon, 26 Mar 2018 20:06:17 +0200

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> * gnu/packages/video.scm (twitchy): New public variable.

[...]
  
> +(define-public twitchy
> +  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
> +    (package
> +      (name "twitchy")
> +      (version (git-version "3.2" "1" commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/BasioMeusPuga/twitchy.git")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32
> +           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))

Can you add a comment about why a git checkout is necessary?

Apart from that LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30940 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30940 <at> debbugs.gnu.org, 30940-done <at> debbugs.gnu.org
Subject: Re: [bug#30940] [PATCH] gnu: Add twitchy.
Date: Mon, 26 Mar 2018 22:50:48 +0300

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>
>> * gnu/packages/video.scm (twitchy): New public variable.
>
> [...]
>   
>> +(define-public twitchy
>> +  (let ((commit "0c0f925b9c7ff2aed4a3b0046561cb794143c398"))
>> +    (package
>> +      (name "twitchy")
>> +      (version (git-version "3.2" "1" commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://github.com/BasioMeusPuga/twitchy.git")
>> +               (commit commit)))
>> +         (file-name (git-file-name name version))
>> +         (sha256
>> +          (base32
>> +           "02aizvsr744sh8bdqvwwsmp2qpczlzn8fy76h5dyd3517n9nlcz9"))))
>
> Can you add a comment about why a git checkout is necessary?

OK.  Thank you for a review.

Pushed as e5e5eb1fcf4c0aab10e2d6ed7fa34257a3c87e58

I'll close the bug report.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.