GNU bug report logs - #30933
[PATCH 0/2] gnu: translate-shell: Update to 0.9.6.7-1.bb9f32d.

Previous Next

Full log

Message #20 received at 30933 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30933 <at> debbugs.gnu.org, 30933-done <at> debbugs.gnu.org
Subject: Re: [bug#30933] [PATCH 2/2] gnu: translate-shell: Update to
 0.9.6.7-1.bb9f32d.
Date: Mon, 26 Mar 2018 22:50:51 +0300

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>
>> * gnu/packages/dictionaries.scm (translate-shell): Update to
>> 0.9.6.7-1.bb9f32d.
>> [arguments](make-flags): Add "NETWORK_ACCESS=no test".
>> [phases]: Add 'change-file-permissions' phase.

[…]

>> +      (version (git-version "0.9.6.7" "1" commit))
>
> There are only five commits since this version.  I assume the git
> checkout is because of the patch that adds "NETWORK_ACCESS"?
>
> The patch itself is smaller than the reindent from the let binding, so I
> would prefer to simply add it.

OK.  Thank you for a review.

Pushe as 196c8b3739d16241da73c78536ce86aaab948677

I'll close the bug report.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.