Subject: Re: [bug#30933] [PATCH 2/2] gnu: translate-shell: Update to 0.9.6.7-1.bb9f32d.

From: Marius Bakke <[email-masked]>
Date: Mon, 26 Mar 2018 20:03:18 +0200

Oleg Pykhalov <[email-masked]> writes:

> * gnu/packages/dictionaries.scm (translate-shell): Update to
> 0.9.6.7-1.bb9f32d.
> [arguments](make-flags): Add "NETWORK_ACCESS=no test".
> [phases]: Add 'change-file-permissions' phase.

[...]
  
>  (define-public translate-shell
> -  (package
> -    (name "translate-shell")
> -    (version "0.9.6.4")
> -    (source
> -      (origin
> -        (method url-fetch)
> -        (uri (string-append "https://github.com/soimort/" name "/archive/v"
> -                            version ".tar.gz"))
> -        (sha256
> -         (base32
> -          "1fg6nf1plvgimc57fsdr9rcjbf7jvmk5jrlj5ya509vpdcdgvj2s"))
> -        (file-name (string-append name "-" version ".tar.gz"))))
> -    (build-system gnu-build-system)
> -    (arguments
> -     `(#:phases
> -       (modify-phases %standard-phases
> -         (delete 'configure) ; no configure phase
> -         (add-after 'install 'emacs-install
> -           (lambda* (#:key inputs outputs #:allow-other-keys)
> -             (let* ((out   (assoc-ref outputs "out"))
> -                    (dest  (string-append out "/share/emacs/site-lisp"))
> -                    (emacs (string-append (assoc-ref inputs "emacs") "/bin/emacs")))
> -               (install-file "google-translate-mode.el" dest)
> -               (emacs-generate-autoloads ,name dest)))))
> -       #:make-flags (list (string-append "PREFIX=" %output))
> -       #:imported-modules (,@%gnu-build-system-modules (guix build emacs-utils))
> -       #:modules ((guix build gnu-build-system)
> -                  (guix build emacs-utils)
> -                  (guix build utils))
> -       #:test-target "test"))
> -    (propagated-inputs
> -     `(("curl" ,curl)
> -       ("fribidi" ,fribidi)
> -       ("rlwrap" ,rlwrap)))
> -    (native-inputs
> -     `(("emacs" ,emacs-minimal)
> -       ("util-linux" ,util-linux))) ; hexdump, for the test
> -    (home-page "https://www.soimort.org/translate-shell/")
> -    (synopsis "Translations from the command line")
> -    (description
> -     "Translate Shell (formerly Google Translate CLI) is a command-line
> +  (let ((commit "bb9f32d3145125ba664b6b05bf0a2fd34108e9d2"))
> +    (package
> +      (name "translate-shell")
> +      (version (git-version "0.9.6.7" "1" commit))

There are only five commits since this version.  I assume the git
checkout is because of the patch that adds "NETWORK_ACCESS"?

The patch itself is smaller than the reindent from the let binding, so I
would prefer to simply add it.