GNU bug report logs - #30925
[PATCH] gnu: Add emacs-puppet-mode.

Previous Next

Full log

Message #8 received at 30925 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 30925 <at> debbugs.gnu.org
Subject: Re: [bug#30925] [PATCH] gnu: Add emacs-puppet-mode.
Date: Mon, 26 Mar 2018 19:54:05 +0200

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> * gnu/packages/emacs.scm (emacs-puppet-mode): New variable.

[...]
  
> +(define-public emacs-puppet-mode
> +  (let ((commit "b3ed5057166a4f49dfa9be638523a348b55a2fd2")
> +        (revision "1"))
> +    (package
> +      (name "emacs-puppet-mode")
> +      (version (git-version "0.3" revision commit))

Maybe mention why we can't take the 0.3 tag?

> +      (source
> +       (origin
> +         (method url-fetch)
> +         (uri (string-append
> +               "https://raw.githubusercontent.com/voxpupuli/puppet-mode/"
> +               commit "/puppet-mode.el"))

It would be nice to install the README too, but no strong opinion.

> +         (sha256
> +          (base32
> +           "1indycxawsl0p2aqqg754f6735q3cmah9vd886rpn0ncc3ipi1xm"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://github.com/voxpupuli/puppet-mode")
> +      (synopsis "Emacs major mode for the Puppet configuration language")
> +      (description
> +       "This package provides support for the Puppet configuration language,
> +including syntax highlighting, indentation of expressions and statements,
> +linting of manifests and integration with Puppet Debugger.")
> +      (license license:gpl3+))))

Perhaps mention in a comment that it includes ASL code, as mentioned in
puppet-mode.el.

LGTM otherwise.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.