Subject: Re: [bug#30924] [PATCH] gnu: Add cloud-foundry-cli.

From: Marius Bakke <[email-masked]>
Date: Mon, 26 Mar 2018 19:55:54 +0200

Christopher Baines <[email-masked]> writes:

> * gnu/packages/cloud-foundry.scm: New file.

[...]

> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "code.cloudfoundry.org/cli"
> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; This should be redundant once the vendor directory is removed from
> +         ;; this package
> +         (add-before 'reset-gzip-timestamps 'remove-readonly-gzip-files
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (for-each delete-file
> +                       (find-files
> +                        (assoc-ref outputs "out")
> +                        ".*\\.gz"))))

'for-each' has an unspecified return value, so please add #t here.

> +         (add-after 'install 'rename-binary
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (rename-file (string-append out "/bin/cli")
> +                            (string-append out "/bin/cf"))))))))

Ditto for 'rename-file'.