GNU bug report logs - #30918
mv: don't use syscall() to call renameat2()

Previous Next

Full log

View this message in rfc822 format

From: Ross Burton <ross <at> burtonini.com>
To: 30918 <at> debbugs.gnu.org, clint <at> debian.org
Subject: bug#30918: Don't use syscall() to call renameat2()
Date: Fri, 23 Mar 2018 17:38:25 +0000

[Message part 1 (text/plain, inline)]

mv.c uses gnulib/renameat2.c to call renameat2(), which if the glibc
wrapper isn't available will just invoke syscall(SYS_renameat2). This may
seem like a good idea but considering a number of major distributions use
LD_PRELOAD to build as a pretend root user[1] these mv calls won't be
intercepted, and building will break in strange and interesting ways (such
as binaries not being owned by root:root anymore).  Please consider
changing renameat2.c so that it doesn't hit syscall() if the wrapper isn't
available.

Ross

[1] Debian and derivatives using fakeroot, OpenEmbedded derivatives using
pseudo, etc.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.