From unknown Thu Jun 19 14:02:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30909 <30909@debbugs.gnu.org> To: bug#30909 <30909@debbugs.gnu.org> Subject: Status: 27.0.50; Testcover error on vector containing dotted pair Reply-To: bug#30909 <30909@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:02:55 +0000 retitle 30909 27.0.50; Testcover error on vector containing dotted pair reassign 30909 emacs submitter 30909 Gemini Lasswell severity 30909 normal tag 30909 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 14:54:30 2018 Received: (at submit) by debbugs.gnu.org; 22 Mar 2018 18:54:30 +0000 Received: from localhost ([127.0.0.1]:48143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez5M6-0002qX-C0 for submit@debbugs.gnu.org; Thu, 22 Mar 2018 14:54:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez5M3-0002qJ-QC for submit@debbugs.gnu.org; Thu, 22 Mar 2018 14:54:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez5Lx-0003S3-9P for submit@debbugs.gnu.org; Thu, 22 Mar 2018 14:54:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58795) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ez5Lx-0003Rt-4O for submit@debbugs.gnu.org; Thu, 22 Mar 2018 14:54:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez5Lv-000833-CI for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 14:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez5Ls-0003Mm-8o for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 14:54:19 -0400 Received: from aibo.runbox.com ([91.220.196.211]:34966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ez5Lr-0003Kp-Rz for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 14:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=+T1KXHsRGSjWaYnAiqWA/ZFO9VuY4CKK/Cbd+/mktNk=; b=PahWbvQaupEnH5agr62csT6ER X27HQR0VBiXOUDzkvwLQ7//n6D4pHdVvCKHqTs8YEaFrQ5kIyLgZHw101NIm4jFd5knGI+oa2gwoX 2RaUYIJLn422fMS3P7E51DAKrAlX2tTCgOx5hs3GNGp88zD1mdWXr6cWAxqv6rAxJng4URaR8qGva aHO9ggi71IftMpXmgXi2ba3VgrGd2zaRf5xYkojR4R+OC9xALMVtd2FjSMFvhhQeeBo6zY0h8rBaP kDhBCysfeybJzu+gf6vgfj4vwYxG7jCfuVews9374IULlDYJ6rVlpiSTnRWppzgT4A1EmzILf7z70 uynzvCeaw==; Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1ez5Lo-0005JD-Lq for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 19:54:12 +0100 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront10.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1ez5Li-0005pC-Kc for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 19:54:07 +0100 From: Gemini Lasswell To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Testcover error on vector containing dotted pair Date: Thu, 22 Mar 2018 11:54:04 -0700 Message-ID: <87k1u454c3.fsf@runbox.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain When you ask Testcover to cover code containing a vector which contains a dotted pair, it results in an error. I introduced this bug when I rewrote Testcover last year. To reproduce first save this snippet in a file called bug.el: (defun my-func () (equal (vector '(8 . "xxx")) [(8 . "xxx")])) Then: M-x testcover-start RET bug.el RET Result: Wrong type argument: listp, "xxx" Here's a patch to fix this. While I was adding a test for it, I noticed that the docstrings for all of Testcover's tests still mention reinstrumenting, but Testcover now analyzes code instead of reinstrumenting it, so I also updated the docstrings. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=0001-Fix-bug-in-Testcover-s-handling-of-vectors-containin.patch >From a8dfe700d7c2e9c0fbf3f2b400309b2a92a9d401 Mon Sep 17 00:00:00 2001 From: Gemini Lasswell Date: Sun, 18 Mar 2018 13:07:02 -0700 Subject: [PATCH] Fix bug in Testcover's handling of vectors containing dotted lists * lisp/emacs-lisp/testcover.el (testcover-analyze-coverage-compose): Handle dotted lists. * test/lisp/emacs-lisp/testcover-resources/testcases.el: (dotted-list-in-vector-bug): New test case. (quotes-within-backquotes-bug-25316, dotted-backquote) (quoted-backquote, backquoted-vector-bug-25316) (vector-in-macro-spec-bug, backquoted-dotted-alist): Change docstrings to mention analyzing code instead of reinstrumenting it. --- lisp/emacs-lisp/testcover.el | 8 +++++--- test/lisp/emacs-lisp/testcover-resources/testcases.el | 19 +++++++++++++------ 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/lisp/emacs-lisp/testcover.el b/lisp/emacs-lisp/testcover.el index e0d2797c0c..d48c79cd77 100644 --- a/lisp/emacs-lisp/testcover.el +++ b/lisp/emacs-lisp/testcover.el @@ -644,9 +644,11 @@ testcover-analyze-coverage-compose "Analyze a list of FORMS for code coverage using FUNC. The list is 1valued if all of its constituent elements are also 1valued." (let ((result '1value)) - (dolist (form forms) - (let ((val (funcall func form))) - (setq result (testcover-coverage-combine result val)))) + (while (consp forms) + (setq result (testcover-coverage-combine result (funcall func (car forms)))) + (setq forms (cdr forms))) + (when forms + (setq result (testcover-coverage-combine result (funcall func forms)))) result)) (defun testcover-analyze-coverage-backquote (bq-list) diff --git a/test/lisp/emacs-lisp/testcover-resources/testcases.el b/test/lisp/emacs-lisp/testcover-resources/testcases.el index c9703b03de..510c735e99 100644 --- a/test/lisp/emacs-lisp/testcover-resources/testcases.el +++ b/test/lisp/emacs-lisp/testcover-resources/testcases.el @@ -226,7 +226,7 @@ testcover-testcase-cc (should-not (testcover-testcase-cc nil)) ;; ==== quotes-within-backquotes-bug-25316 ==== -"Forms to instrument are found within quotes within backquotes." +"Forms to analyze are found within quotes within backquotes." ;; ==== (defun testcover-testcase-make-list () (list 'defun 'defvar)) @@ -377,7 +377,7 @@ testcover-testcase-thing (should-error (testcover-testcase-thing 3)) ;; ==== dotted-backquote ==== -"Testcover correctly instruments dotted backquoted lists." +"Testcover can analyze code inside dotted backquoted lists." ;; ==== (defun testcover-testcase-dotted-bq (flag extras) (let* ((bq @@ -388,7 +388,7 @@ testcover-testcase-dotted-bq (should (equal '(a b c d e) (testcover-testcase-dotted-bq t '(d e)))) ;; ==== quoted-backquote ==== -"Testcover correctly instruments the quoted backquote symbol." +"Testcover correctly handles the quoted backquote symbol." ;; ==== (defun testcover-testcase-special-symbols () (list '\` '\, '\,@)) @@ -396,7 +396,7 @@ testcover-testcase-special-symbols (should (equal '(\` \, \,@) (testcover-testcase-special-symbols))) ;; ==== backquoted-vector-bug-25316 ==== -"Testcover reinstruments within backquoted vectors." +"Testcover can analyze code within backquoted vectors." ;; ==== (defun testcover-testcase-vec (a b c) `[,a%%% ,(list b%%% c%%%)%%%]%%%) @@ -411,8 +411,15 @@ testcover-testcase-vec-arg (should (equal '([[4 5] 6]) (testcover-testcase-vec-in-list 4 5 6))) (should (equal '([100]) (testcover-testcase-vec-arg 100))) +;; ==== dotted-list-in-vector-bug ==== +"Testcover can analyze dotted pairs within vectors." +;; ==== +(defun testcover-testcase-vectors-with-dotted-pairs () + (equal [(1 . "x")] [(1 2 . "y")])%%%) +(should-not (testcover-testcase-vectors-with-dotted-pairs)) + ;; ==== vector-in-macro-spec-bug-25316 ==== -"Testcover reinstruments within vectors." +"Testcover can analyze code inside vectors." ;; ==== (defmacro testcover-testcase-nth-case (arg vec) (declare (indent 1) @@ -466,7 +473,7 @@ testcover-testcase-use-thing (should (equal (testcover-testcase-use-thing) 15)) ;; ==== backquoted-dotted-alist ==== -"Testcover can instrument a dotted alist constructed with backquote." +"Testcover can analyze a dotted alist constructed with backquote." ;; ==== (defun testcover-testcase-make-alist (expr entries) `((0 . ,expr%%%) . ,entries%%%)%%%) -- 2.15.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 02 14:12:19 2018 Received: (at 30909) by debbugs.gnu.org; 2 Apr 2018 18:12:19 +0000 Received: from localhost ([127.0.0.1]:35376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f33wJ-0007uU-Ao for submit@debbugs.gnu.org; Mon, 02 Apr 2018 14:12:19 -0400 Received: from aibo.runbox.com ([91.220.196.211]:38792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f33wH-0007uC-1N; Mon, 02 Apr 2018 14:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:To:From; bh=Kecm6egpMVQtaMyt6sZBu9fkRuBHDFeRVNXEIMRC2Pk=; b=j7xG/hUAcfCz3Ojjty3hIdS1EmkxwA8zp/6B58erBcTyCk2Cr+/sVf94Hq4sjmb0QKTb8jvlL9 AZDirfRVfOps+V5h0WeQpsdZ3xaRNHjZ68rWbmo4VJ5U6PZLM1hdd+dU+VWfyqKWE/ZHb6dms8kob vq0y9QXAzjX1ChKA9KAT5/RF524HRUf072ANrphxegdpmXnytuUZdNYa7/R3Kdh6a5nDXweQgoxkz yBrY6wWNp2Rw2I9AC4lZ30l49/lNbddlqwSCZ4BVuoyLJ75MTj4e72EJKSeAzi2gWnhrxm9orlZmZ hSyo7pyiJh88syNwtn7jb5H8MwFib8TRrniBw==; Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1f33wF-0003LI-K0; Mon, 02 Apr 2018 20:12:15 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1f33w1-0003GP-5m; Mon, 02 Apr 2018 20:12:01 +0200 From: Gemini Lasswell To: 30909@debbugs.gnu.org Subject: Re: bug#30909: 27.0.50; Testcover error on vector containing dotted pair References: <87k1u454c3.fsf@runbox.com> Date: Mon, 02 Apr 2018 11:11:58 -0700 In-Reply-To: <87k1u454c3.fsf@runbox.com> (Gemini Lasswell's message of "Thu, 22 Mar 2018 11:54:04 -0700") Message-ID: <874lkt32c1.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30909 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 30909 fixed close 30909 27.1 quit Fixed in master, e3525385a8. From unknown Thu Jun 19 14:02:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 May 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator