GNU bug report logs - #30908
woman2-roff-buffer fails to restore set-text-properties, etc. on error

Previous Next

Package: emacs;

Reported by: Ivan Shmakov <ivan <at> siamics.net>

Date: Thu, 22 Mar 2018 18:13:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 25.1.1

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 30908 <at> debbugs.gnu.org
Subject: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error
Date: Thu, 22 Mar 2018 20:52:01 -0400

Ivan Shmakov <ivan <at> siamics.net> writes:

> --- woman.el.~1~	2017-11-05 15:00:52.696647297 +0000
> +++ woman.el	2018-03-22 17:47:44.014986089 +0000
> @@ -3710,13 +3710,14 @@ defun woman2-roff-buffer ()

> +      (unwind-protect
> +          (if (not (eobp))             ; This should not happen, but ...
> +              (woman2-format-paragraphs (copy-marker (point-max) t)
> +                                        woman-left-margin))
> +        (fset 'canonically-space-region canonically-space-region)
> +        (fset 'set-text-properties set-text-properties)
> +        (fset 'insert-and-inherit insert-and-inherit)
> +        (set-marker to nil)))))

Shouldn't this rather be combined into the existing unwind-protect
around the while?
This bug report was last modified 7 years and 26 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.