GNU bug report logs - #30908
woman2-roff-buffer fails to restore set-text-properties, etc. on error

Previous Next

Package: emacs;

Reported by: Ivan Shmakov <ivan <at> siamics.net>

Date: Thu, 22 Mar 2018 18:13:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 25.1.1

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 30908 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 30908 <at> debbugs.gnu.org
Subject: Re: bug#30908: woman2-roff-buffer fails to restore
 set-text-properties, etc. on error
Date: Fri, 23 Mar 2018 06:20:57 -0400

Ivan Shmakov <ivan <at> siamics.net> writes:

>  > Shouldn’t this rather be combined into the existing unwind-protect
>  > around the while?
>
> 	Due to the (not (eobp)) guard, I’ve assumed that the
> 	woman2-format-paragraphs call in the ‘unwind’ branch is for some
> 	sort of fallback processing (in the case the while loop fails.)

Hmm, looking at this again, I'm not sure.  That is, it's clearly
fallback processing in case the loop ends before going through the whole
buffer.  But does it also make sense as fallback processing when some
kind of error was signaled in the loop?  I don't know.
This bug report was last modified 7 years and 26 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.