From unknown Wed Jun 18 23:10:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30908 <30908@debbugs.gnu.org> To: bug#30908 <30908@debbugs.gnu.org> Subject: Status: woman2-roff-buffer fails to restore set-text-properties, etc. on error Reply-To: bug#30908 <30908@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:10:13 +0000 retitle 30908 woman2-roff-buffer fails to restore set-text-properties, etc.= on error=20 reassign 30908 emacs submitter 30908 Ivan Shmakov severity 30908 normal tag 30908 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 14:12:57 2018 Received: (at submit) by debbugs.gnu.org; 22 Mar 2018 18:12:57 +0000 Received: from localhost ([127.0.0.1]:48116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez4ht-0001js-A1 for submit@debbugs.gnu.org; Thu, 22 Mar 2018 14:12:57 -0400 Received: from fely.am-1.org ([78.47.74.50]:47292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez4hp-0001ji-8i for submit@debbugs.gnu.org; Thu, 22 Mar 2018 14:12:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net ; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:Sender:X-License:To :Subject:From:Content-Transfer-Encoding:In-Reply-To:References:Reply-To:Cc: Content-ID:Content-Description; bh=YZbUrQA/3yVyQ6qRSVhsp91hVLroGqv7q/BRASPWO3w=; b=Ud1G9ZPNW3DS8MUyS01ov/b3gq eiwAzhwkV0bWsjwI100iiPI3f78025LMFh/8o1654Td0+fmFbfPAOCA4Mr7O06yChACUigcQ37wQy heGX1YKIXBAeaJr6VzFMI166+9OHJZJjssk9vzp+sUa6+Ysfz3Tk82N63JKwszJUETwg=; Received: from oneingray-1-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:1eb::2] helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ez4hn-00067Y-DG for submit@debbugs.gnu.org; Thu, 22 Mar 2018 18:12:51 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.84_2) (envelope-from ) id 1ez4hm-0008Uy-5Q for submit@debbugs.gnu.org; Thu, 22 Mar 2018 18:12:50 +0000 From: Ivan Shmakov Subject: woman2-roff-buffer fails to restore set-text-properties, etc. on error To: submit@debbugs.gnu.org X-License: CC-BY-SA-3.0+ (original contributions only) Date: Thu, 22 Mar 2018 18:12:49 +0000 Message-ID: <87o9jg568u.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Version: 25.1.1 Tags: patch The woman2-roff-buffer function uses unwind-protect to restore the canonically-space-region, insert-and-inherit and set-text-properties functions it temporarily overrides. Unfortunately, the first thing (conditionally) called in the =E2=80=98unwind=E2=80=99 branch is the woman2-format-paragraphs function, = which may result in error, thus precluding said restoration, leading to: set-text-properties is an alias for =E2=80=98ignore=E2=80=99. (set-text-properties &rest IGNORE) Do nothing and return nil. This function accepts any number of arguments, but ignores them. Please thus consider the patch MIMEd. --=20 FSF associate member #7257 np. Sacred Armor of Antiriad =E2=80=94 Traxer --=-=-= Content-Type: text/diff Content-Disposition: inline --- woman.el.~1~ 2017-11-05 15:00:52.696647297 +0000 +++ woman.el 2018-03-22 17:47:44.014986089 +0000 @@ -3710,13 +3710,14 @@ defun woman2-roff-buffer () (set-marker to (woman-find-next-control-line))) ;; Call the appropriate function: (funcall fn to))) - (if (not (eobp)) ; This should not happen, but ... - (woman2-format-paragraphs (copy-marker (point-max) t) - woman-left-margin)) - (fset 'canonically-space-region canonically-space-region) - (fset 'set-text-properties set-text-properties) - (fset 'insert-and-inherit insert-and-inherit) - (set-marker to nil)))) + (unwind-protect + (if (not (eobp)) ; This should not happen, but ... + (woman2-format-paragraphs (copy-marker (point-max) t) + woman-left-margin)) + (fset 'canonically-space-region canonically-space-region) + (fset 'set-text-properties set-text-properties) + (fset 'insert-and-inherit insert-and-inherit) + (set-marker to nil))))) (defun woman-find-next-control-line (&optional pat) "Find and return start of next control line. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 20:52:12 2018 Received: (at 30908) by debbugs.gnu.org; 23 Mar 2018 00:52:12 +0000 Received: from localhost ([127.0.0.1]:48280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezAwF-0006at-HO for submit@debbugs.gnu.org; Thu, 22 Mar 2018 20:52:12 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:35254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezAwD-0006ag-34 for 30908@debbugs.gnu.org; Thu, 22 Mar 2018 20:52:09 -0400 Received: by mail-it0-f44.google.com with SMTP id v194-v6so606977itb.0 for <30908@debbugs.gnu.org>; Thu, 22 Mar 2018 17:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XmZm0pZ8rBj1XGxqkJa59zB1y74htWIjABOHwONRSZI=; b=m9l851n9yh5hKqjioPO/N9W+7TDI88pi/2HCVVjjf4OvsUNPZFR8+IdzOyDR4uerzx 4uZ72QFQ/eKTc3cDFbEXec5+j8S0DZLD+7AUAff34zHeMesqRv09whEXIg0BGVgQ7IAy eqoD+FFV8/y87pEQYQ3aXrXkg9Llx/2+DmW9dwWmKGy9cLW0aL0DdYCmR4ebPtIPcmP7 bqUgmvcYzeHSdzxwRgmKvUpboAXf/JRxxoh4JQ+B0R0dmYwya1YyVdfLHrMvXI2YeZz/ 0/N28iQu1wW5wCxse7CiosA45TVRBwuprECYuVsMoAQcqnzr4E7gf13yIUYC7s6MMlRW zVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XmZm0pZ8rBj1XGxqkJa59zB1y74htWIjABOHwONRSZI=; b=GQHzrK94Oz5p8zCtA9Zwin1gYVtIT/FF48Y+yt0JZlDHzNNtrmmhV0gnK9No3Lg2oC wLYW0LZkYBDzDqCjbrov6fPFwOSg2BE1VKD4pOWHlE7a81Ol0dbKuanlgg4Fq19mgIo7 Tbz7XZL/0CTbhIhr10tbf/UMs1zDd+tHXvMa3H0uX5C+0nbeFX2slUaxswaCW8vByNjO UKH9Kj7TORicTVDpNz8D7sIj23qb80ncb3ZdXSMpUxaqkOgPNkrPgFHxp1xsaeg2OmDn yiriO0eS6UsHQ6Z/f2YYiiCb/Q9ipGZ8fFfySQ3qviDahQ5pGUWH3gavGIO0nEpXGR08 Lvig== X-Gm-Message-State: AElRT7GWvoT2cUMMgePTT0onT4IWPz99+/Asfik5Gl5UYlabzU7Se0Gm SkICghbE+KwnviW5FHkoX95C7w== X-Google-Smtp-Source: AG47ELu55rjHXryivn9hghnU/19QE+iRAhu7BiKVgzuqqAiZNKKjznTnQ02S+J3xhgzJ0URqHDe/yQ== X-Received: by 2002:a24:5d41:: with SMTP id w62-v6mr11619610ita.15.1521766323324; Thu, 22 Mar 2018 17:52:03 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q21-v6sm4985134itb.2.2018.03.22.17.52.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 17:52:02 -0700 (PDT) From: Noam Postavsky To: Ivan Shmakov Subject: Re: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error References: <87o9jg568u.fsf@violet.siamics.net> Date: Thu, 22 Mar 2018 20:52:01 -0400 In-Reply-To: <87o9jg568u.fsf@violet.siamics.net> (Ivan Shmakov's message of "Thu, 22 Mar 2018 18:12:49 +0000") Message-ID: <87bmffsjf2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30908 Cc: 30908@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ivan Shmakov writes: > --- woman.el.~1~ 2017-11-05 15:00:52.696647297 +0000 > +++ woman.el 2018-03-22 17:47:44.014986089 +0000 > @@ -3710,13 +3710,14 @@ defun woman2-roff-buffer () > + (unwind-protect > + (if (not (eobp)) ; This should not happen, but ... > + (woman2-format-paragraphs (copy-marker (point-max) t) > + woman-left-margin)) > + (fset 'canonically-space-region canonically-space-region) > + (fset 'set-text-properties set-text-properties) > + (fset 'insert-and-inherit insert-and-inherit) > + (set-marker to nil))))) Shouldn't this rather be combined into the existing unwind-protect around the while? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 23:24:23 2018 Received: (at 30908) by debbugs.gnu.org; 23 Mar 2018 03:24:24 +0000 Received: from localhost ([127.0.0.1]:48400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezDJX-0001qN-Fm for submit@debbugs.gnu.org; Thu, 22 Mar 2018 23:24:23 -0400 Received: from fely.am-1.org ([78.47.74.50]:47418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezDJV-0001qC-Qv for 30908@debbugs.gnu.org; Thu, 22 Mar 2018 23:24:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net ; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender: References:X-License:Cc:To:Subject:From:Content-Transfer-Encoding:Reply-To: Content-ID:Content-Description; bh=w/ATy6UM0Gajw0C34NuGYhJHwYXC92FlJ9qlpKXKpwQ=; b=G6e9bqbAHUNltse9SukoSV10ks 9cQIIohlfanJdQb2KMG5l0oyudaqdtUfoAn1yjgeZ+gfcwRHZJ73jGX400tyPTNbAvIhx/KWfq0xy h+fs7cL6ZHWHx9zwSx2ReRvL9jOn+SJMRSv1r3BiFzu2DV9a/n2MJd3QLmvV6yLrBl/Q=; Received: from oneingray-1-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:1eb::2] helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ezDJT-00035D-6o; Fri, 23 Mar 2018 03:24:19 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.84_2) (envelope-from ) id 1ezDJR-0006j9-CC; Fri, 23 Mar 2018 03:24:17 +0000 From: Ivan Shmakov Subject: Re: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error To: 30908@debbugs.gnu.org X-License: CC-BY-SA-3.0+ (original contributions only) References: <87o9jg568u.fsf@violet.siamics.net> <87bmffsjf2.fsf@gmail.com> Date: Fri, 23 Mar 2018 03:24:17 +0000 In-Reply-To: <87bmffsjf2.fsf@gmail.com> (Noam Postavsky's message of "Thu, 22 Mar 2018 20:52:01 -0400") Message-ID: <87fu4r5va6.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30908 Cc: Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Noam Postavsky writes: >>>>> Ivan Shmakov writes: >> @@ -3710,13 +3710,14 @@ defun woman2-roff-buffer () >> + (unwind-protect >> + (if (not (eobp)) ; This should not happen, but .= .. >> + (woman2-format-paragraphs (copy-marker (point-max) t) >> + woman-left-margin)) >> + (fset 'canonically-space-region canonically-space-region) >> + (fset 'set-text-properties set-text-properties) >> + (fset 'insert-and-inherit insert-and-inherit) >> + (set-marker to nil))))) > Shouldn=E2=80=99t this rather be combined into the existing unwind-prote= ct > around the while? Due to the (not (eobp)) guard, I=E2=80=99ve assumed that the woman2-format-paragraphs call in the =E2=80=98unwind=E2=80=99 branch is fo= r some sort of fallback processing (in the case the while loop fails.) If the call ended up there by mistake, indeed a progn should be used, as per the updated patch MIMEd. --=20 FSF associate member #7257 http://am-1.org/~ivan/ --=-=-= Content-Type: text/diff Content-Disposition: inline --- - 2018-03-23 02:20:53.907229515 +0000 +++ 81FOuhEi.el 2018-03-23 02:20:39.083966234 +0000 @@ -3673,46 +3673,47 @@ (fset 'insert-and-inherit (symbol-function 'insert)) (fset 'set-text-properties 'ignore) (unwind-protect - (while - ;; Find next control line: - (re-search-forward woman-request-regexp nil t) - (cond - ;; Construct woman function to call: - ((setq fn (intern-soft - (concat "woman2-" - (setq woman-request (match-string 1))))) - ;; Delete request or macro name: - (woman-delete-match 0)) - ;; Unrecognized request: - ((prog1 nil - ;; (WoMan-warn ".%s request ignored!" woman-request) - (WoMan-warn-ignored woman-request "ignored!") - ;; (setq fn 'woman2-LP) - ;; AVOID LEAVING A BLANK LINE! - ;; (setq fn 'woman2-format-paragraphs) - )) - ;; .LP assumes it is at eol and leaves a (blank) line, - ;; so leave point at end of line before paragraph: - ((or (looking-at "[ \t]*$") ; no argument - woman-ignore) ; ignore all - ;; (beginning-of-line) (kill-line) - ;; AVOID LEAVING A BLANK LINE! - (beginning-of-line) (woman-delete-line 1)) - (t (end-of-line) (insert ?\n)) - ) - (if (not (or fn - (and (not (memq (following-char) '(?. ?'))) - (setq fn 'woman2-format-paragraphs)))) - () - ;; Find next control line: - (if (equal woman-request "TS") - (set-marker to (woman-find-next-control-line "TE")) - (set-marker to (woman-find-next-control-line))) - ;; Call the appropriate function: - (funcall fn to))) - (if (not (eobp)) ; This should not happen, but ... - (woman2-format-paragraphs (copy-marker (point-max) t) - woman-left-margin)) + (progn + (while + ;; Find next control line: + (re-search-forward woman-request-regexp nil t) + (cond + ;; Construct woman function to call: + ((setq fn (intern-soft + (concat "woman2-" + (setq woman-request (match-string 1))))) + ;; Delete request or macro name: + (woman-delete-match 0)) + ;; Unrecognized request: + ((prog1 nil + ;; (WoMan-warn ".%s request ignored!" woman-request) + (WoMan-warn-ignored woman-request "ignored!") + ;; (setq fn 'woman2-LP) + ;; AVOID LEAVING A BLANK LINE! + ;; (setq fn 'woman2-format-paragraphs) + )) + ;; .LP assumes it is at eol and leaves a (blank) line, + ;; so leave point at end of line before paragraph: + ((or (looking-at "[ \t]*$") ; no argument + woman-ignore) ; ignore all + ;; (beginning-of-line) (kill-line) + ;; AVOID LEAVING A BLANK LINE! + (beginning-of-line) (woman-delete-line 1)) + (t (end-of-line) (insert ?\n)) + ) + (if (not (or fn + (and (not (memq (following-char) '(?. ?'))) + (setq fn 'woman2-format-paragraphs)))) + () + ;; Find next control line: + (if (equal woman-request "TS") + (set-marker to (woman-find-next-control-line "TE")) + (set-marker to (woman-find-next-control-line))) + ;; Call the appropriate function: + (funcall fn to))) + (if (not (eobp)) ; This should not happen, but ... + (woman2-format-paragraphs (copy-marker (point-max) t) + woman-left-margin))) (fset 'canonically-space-region canonically-space-region) (fset 'set-text-properties set-text-properties) (fset 'insert-and-inherit insert-and-inherit) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 06:21:08 2018 Received: (at 30908) by debbugs.gnu.org; 23 Mar 2018 10:21:08 +0000 Received: from localhost ([127.0.0.1]:48691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezJop-0003W2-VT for submit@debbugs.gnu.org; Fri, 23 Mar 2018 06:21:08 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:44239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezJon-0003V2-HZ for 30908@debbugs.gnu.org; Fri, 23 Mar 2018 06:21:06 -0400 Received: by mail-io0-f170.google.com with SMTP id h23so14529061iob.11 for <30908@debbugs.gnu.org>; Fri, 23 Mar 2018 03:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=lGsB8cITK6BkLT44kWKoDtmNCzzT66qJHIWCdp20Vck=; b=l8WxnRmPV8c4bVBu6VNj4fUalrvW1euGkVfWILsoI3lz+l0XIjX5wwbPbQsQJX53zM SiJeVBtMkI2MEtVS72LyL1N1jvNIV5cbsb6J0qour+T5UNhl6Cz0RXLWZWQhL+F+eK/b bGq0KS0vs2RaorllVsm6Dmg4ILObCX1+R/bLnmXZvwnhZWF9QIH5hEkh+z5qmEgeSFB0 jM37flHkRd7/e+FZi10s9X/7MvCoao4zn3/igskW9gcsk37lzI+XXREqWoWyg9MWMjOE Dx9pcWOolm+ECVFU3aY3DJN7kEA3H7XU6yALDsUiOuD3exqWfdSC2ogGp7R8N5xxyyMB EBwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=lGsB8cITK6BkLT44kWKoDtmNCzzT66qJHIWCdp20Vck=; b=aDRFirtB2TsGc030WxA2vMcxmsaaGsKP2RH4YNkwkldkKGDSPazZmXfUiRSXtMchdB H+I1AWh9qnQHnm9ceLUEjx2RCYofHkWSiaJDb0qfVCZpBZcgGZwyIA1KEuDrXxuT/HY/ m3JfuVRPza7P3xUrJrO9JNNIfAqTf593dUBq1DDTiWGQJQUNSnfBBzAxeyJuyt3nFIrP 6q/zPZdqib63EIZPbFFahj1T3guNZNtHU7ySJVXsa9CBA2gDjtNPxewCX4zuRbPcjcAV cCemlphGdufAPsmluWh1SaUMkUxLFWSYndMHP6zJw4yGyLU8/VRGY8ejzP+aKD054LKu uhMA== X-Gm-Message-State: AElRT7EHMPp1FETFrammljbCGaaBpD0/bBckPlvIFpo/ouFsHN16spoM QpfSBEmhnQaUixeqRHyMx3CaIw== X-Google-Smtp-Source: AG47ELtaZfJjQa0GapzQda5JioH2reEM8hxAeB2otuPDVzEaC/f1TVlfXR3XYw1ZCkV/CKTCgsjvLw== X-Received: by 10.107.55.133 with SMTP id e127mr27872248ioa.138.1521800459657; Fri, 23 Mar 2018 03:20:59 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q99sm6381530ioi.40.2018.03.23.03.20.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Mar 2018 03:20:58 -0700 (PDT) From: Noam Postavsky To: Ivan Shmakov Subject: Re: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error References: <87o9jg568u.fsf@violet.siamics.net> <87bmffsjf2.fsf@gmail.com> <87fu4r5va6.fsf@violet.siamics.net> Date: Fri, 23 Mar 2018 06:20:57 -0400 In-Reply-To: <87fu4r5va6.fsf@violet.siamics.net> (Ivan Shmakov's message of "Fri, 23 Mar 2018 03:24:17 +0000") Message-ID: <874ll7rt2u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30908 Cc: 30908@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ivan Shmakov writes: > > Shouldn=E2=80=99t this rather be combined into the existing unwind-pro= tect > > around the while? > > Due to the (not (eobp)) guard, I=E2=80=99ve assumed that the > woman2-format-paragraphs call in the =E2=80=98unwind=E2=80=99 branch is = for some > sort of fallback processing (in the case the while loop fails.) Hmm, looking at this again, I'm not sure. That is, it's clearly fallback processing in case the loop ends before going through the whole buffer. But does it also make sense as fallback processing when some kind of error was signaled in the loop? I don't know. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 26 08:01:42 2018 Received: (at 30908) by debbugs.gnu.org; 26 Apr 2018 12:01:42 +0000 Received: from localhost ([127.0.0.1]:40044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBfao-0007gV-GJ for submit@debbugs.gnu.org; Thu, 26 Apr 2018 08:01:42 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:50306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fBfam-0007gB-HC; Thu, 26 Apr 2018 08:01:40 -0400 Received: by mail-it0-f44.google.com with SMTP id p3-v6so23539408itc.0; Thu, 26 Apr 2018 05:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fQFkLDOaDb9JbtEQzlrO/P0qVZI8jggQoZWrYLTA/6E=; b=EbXcDlgvc2H9hgz0xvvqTXCS+jjVh30VZNUToV6OWrcMxtVWASWBxbssiynjfaqafo yBJRcVAqZ6JYU9xlprBWCffFX0GjA9yLWwsiz7PRoPH7Zew8pHUi9/GpQ5lIDSz7dAyD AScN6ipfUbe0VfAPflfN1ltX6RcqLCNbHKLvipzR8n1t14sVGcMMBD0B/8TDaObSQiBi 6DoGQ8rjMrFhoHcc9ohIHyGT/H/A2WQNfejmxz/6bFuGRXPebixHo1S32TfC9rgVjo4J FHIqn0Pbgt1xWynMJ5SA7fQsHSliWR9+vebWciRA1HefvF1tjIdmyi3HtKTJz/kZRMdw Auqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fQFkLDOaDb9JbtEQzlrO/P0qVZI8jggQoZWrYLTA/6E=; b=HWSPU+VndfEA77RHdmt/wDUWhdvApJisXqp0jsf8/hGZ8FvcIHCS3wtBlQQ5qsBU8C af6Ak/qg8d0kvn5OUBEA3KZi0at1Br9wk4SQmfQmUPCCqJL3WzbmkMU5nSHLXaOHzRS+ MfuPw+wElaTcctPlGASopvcy2TDUb537IDvUuCzrAEO8wtI+6s98SwQmZVrcz99uh9Mn b4QjmAdkwHTIjRBl0Y2JxUmzy6uCdyU9PL9g8U7nWgQ/ryD/qos7e8Zt5eDpIjcv7C1Q cNppKxkYafyNxTUsWSzvQKCzH4nB2CRn+tkXtNzFfe5qnZGerlm34VTrAmgAeiBmET6e qPHw== X-Gm-Message-State: ALQs6tAFGpXN0JVEJGnLKv/zljR2/RgWabqxX8xIFxsk1UPfgJdBHLfk 092s/WhXspMATyypyXYlS1nXVg== X-Google-Smtp-Source: AB8JxZqcKRxwDutNnwiwqAaEsd4U3cTOldXveT+BlqM5EiAlZ15QwpB/oMBHnFyfdQ9AfHVldelbJA== X-Received: by 2002:a24:478b:: with SMTP id t133-v6mr568350itb.145.1524744094704; Thu, 26 Apr 2018 05:01:34 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i12-v6sm3523349iod.85.2018.04.26.05.01.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Apr 2018 05:01:33 -0700 (PDT) From: Noam Postavsky To: Ivan Shmakov Subject: Re: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error References: <87o9jg568u.fsf@violet.siamics.net> <87bmffsjf2.fsf@gmail.com> <87fu4r5va6.fsf@violet.siamics.net> <874ll7rt2u.fsf@gmail.com> Date: Thu, 26 Apr 2018 08:01:32 -0400 In-Reply-To: <874ll7rt2u.fsf@gmail.com> (Noam Postavsky's message of "Fri, 23 Mar 2018 06:20:57 -0400") Message-ID: <87d0ymqiqr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30908 Cc: 30908@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30908 fixed close 30908 27.1 quit Noam Postavsky writes: > Ivan Shmakov writes: > >> > Shouldn=E2=80=99t this rather be combined into the existing unwind-pr= otect >> > around the while? >> >> Due to the (not (eobp)) guard, I=E2=80=99ve assumed that the >> woman2-format-paragraphs call in the =E2=80=98unwind=E2=80=99 branch is= for some >> sort of fallback processing (in the case the while loop fails.) > > Hmm, looking at this again, I'm not sure. That is, it's clearly > fallback processing in case the loop ends before going through the whole > buffer. But does it also make sense as fallback processing when some > kind of error was signaled in the loop? I don't know. I've decided that it doesn't make sense to do any further processing once we've hit an error. [1: 66dbb787a2]: 2018-04-26 07:37:48 -0400 Ensure woman2-roff-buffer restores functions on error (Bug#30908) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D66dbb787a22d4ae1= d513a3ee27e22eed395f5676 From unknown Wed Jun 18 23:10:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 May 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator