Subject: Re: bug#30908: woman2-roff-buffer fails to restore set-text-properties, etc. on error

From: Noam Postavsky <[email-masked]>
Date: Thu, 22 Mar 2018 20:52:01 -0400

Ivan Shmakov <[email-masked]> writes:

> --- woman.el.~1~	2017-11-05 15:00:52.696647297 +0000
> +++ woman.el	2018-03-22 17:47:44.014986089 +0000
> @@ -3710,13 +3710,14 @@ defun woman2-roff-buffer ()

> +      (unwind-protect
> +          (if (not (eobp))             ; This should not happen, but ...
> +              (woman2-format-paragraphs (copy-marker (point-max) t)
> +                                        woman-left-margin))
> +        (fset 'canonically-space-region canonically-space-region)
> +        (fset 'set-text-properties set-text-properties)
> +        (fset 'insert-and-inherit insert-and-inherit)
> +        (set-marker to nil)))))

Shouldn't this rather be combined into the existing unwind-protect
around the while?