From unknown Sat Jun 21 03:12:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30905: Add tests for buffer-base-buffer function Resent-From: Shanavas M Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2018 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30905@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152173234316879 (code B ref -1); Thu, 22 Mar 2018 15:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Mar 2018 15:25:43 +0000 Received: from localhost ([127.0.0.1]:48022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez263-0004O8-1d for submit@debbugs.gnu.org; Thu, 22 Mar 2018 11:25:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eywWu-0000DI-Aj for submit@debbugs.gnu.org; Thu, 22 Mar 2018 05:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eywWl-0000IZ-AJ for submit@debbugs.gnu.org; Thu, 22 Mar 2018 05:28:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46168) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eywWl-0000IV-6p for submit@debbugs.gnu.org; Thu, 22 Mar 2018 05:28:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eywWh-0003qZ-Mq for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 05:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eywWc-0000Fx-2E for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 05:28:51 -0400 Received: from knopi.disroot.org ([178.21.23.139]:47960 helo=disroot.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eywWb-0000FN-NM for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 05:28:45 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5FBBD2CBE0 for ; Thu, 22 Mar 2018 10:28:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1521710923; bh=/7xElI1j6Vqf7OjAl0IJrqPrpDS7DFblDJKLzZSJC+k=; h=To:From:Subject:Date; b=GiKDN1cysHtEwNX4u7XcBqsVFcpsrBH5ZZThRKPc9VusHxiq3x94+O/R/TGLnPh3t y4SJRcTVvbUyEKZJHMY+t/m088l4YGoYWW0mPXUzceVLoU4OpDhy3eHhgJOS1vEbEV xdOBgUtWCJetr02vQkXrFPS1CmyhMc1h21lKHSxgKA2jZ948kBTVoAG0OdrnB6/rTa fgktJYefnveZEok3KEi4OtlzFq9vx96upXkaK2gnFGJfr/TPExgbwjP89VMPuzxiE6 RANlue63zcFdhubkWEHaRXXqUXgQSnfqY2LYv57ci7gEnvMCPQuOHMiqd/35Scf83C BdqRd0/YhAlpA== X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from disroot.org ([127.0.0.1]) by localhost (mail01.disroot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TFdB0zjvhPao for ; Thu, 22 Mar 2018 10:28:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1521710921; bh=/7xElI1j6Vqf7OjAl0IJrqPrpDS7DFblDJKLzZSJC+k=; h=To:From:Subject:Date; b=Q2LmKUq9bBOUupYjjBKVWBS7bqSHhb/n7bjKHvHgLg0lMztIE6Rt93Lgxe+G27eJ7 zCJTJtkwkArlTL7uDogBGBL554jbhy1vrBxF81U1WFkNWpvVCBzBRabY8q7r0WFm9r GnnGrJPDVexuacdpaev+LSKVXSIPc9vCL8CpXqGGM+6sJ44CHgPju0SMAd5MxT+BSZ l1UdIb8Bi8w0G8TyMtO8ZlkzAs4zv7dzbqdXg0olVSCr/EUW+HNKXbYCn3F0pTZL9n q+Lx9A4850ZLdsquHDiwuErL3GyxtwKxgKB/ROQ/o5l6M4SNlLzOFdp5YUrXoQr1MT Gxl6OeyzRbn2g== From: Shanavas M Message-ID: Date: Thu, 22 Mar 2018 12:28:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------CF93936C66110918A2CE29AB" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Thu, 22 Mar 2018 11:25:40 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is a multi-part message in MIME format. --------------CF93936C66110918A2CE29AB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit This patch adds two tests for buffer-base-buffer function -- Shanavas M --------------CF93936C66110918A2CE29AB Content-Type: text/x-patch; name="Add-tests-for-buffer-base-buffer-function.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="Add-tests-for-buffer-base-buffer-function.patch" >From a8db56897545f6414f180a35d51ea8e17e15d525 Mon Sep 17 00:00:00 2001 From: Shanavas M Date: Thu, 22 Mar 2018 12:20:22 +0300 Subject: [PATCH] Add tests for buffer-base-buffer function --- test/src/buffer-tests.el | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/src/buffer-tests.el b/test/src/buffer-tests.el index f9c477fbfd..170e3a5656 100644 --- a/test/src/buffer-tests.el +++ b/test/src/buffer-tests.el @@ -50,4 +50,13 @@ (progn (get-buffer-create "nil") (generate-new-buffer-name "nil"))))) +(ert-deftest test-buffer-base-buffer-indirect () + (let* ((base (get-buffer-create "base") + (ind-buf (make-indirect-buffer base "indbuf")))) + (should (eq (buffer-base-buffer ind-buf) base)))) + +(ert-deftest test-buffer-base-buffer-non-indirect () + (let ((buf (get-buffer-create "buf"))) + (should (eq (buffer-base-buffer buf) nil)))) + ;;; buffer-tests.el ends here -- 2.11.0 --------------CF93936C66110918A2CE29AB-- From unknown Sat Jun 21 03:12:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30905: Add tests for buffer-base-buffer function Resent-From: Shanavas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Mar 2018 11:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30905@debbugs.gnu.org Received: via spool by 30905-submit@debbugs.gnu.org id=B30905.152197706228163 (code B ref 30905); Sun, 25 Mar 2018 11:25:02 +0000 Received: (at 30905) by debbugs.gnu.org; 25 Mar 2018 11:24:22 +0000 Received: from localhost ([127.0.0.1]:52146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f03l8-0007KB-4w for submit@debbugs.gnu.org; Sun, 25 Mar 2018 07:24:22 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56560 helo=disroot.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f03l6-0007Jv-3c for 30905@debbugs.gnu.org; Sun, 25 Mar 2018 07:24:20 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id A25AB2CD4C for <30905@debbugs.gnu.org>; Sun, 25 Mar 2018 13:24:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1521977053; bh=29vDjN+PsdRNZpE1LfZhnrn2tkLevrBGAF/yjQxqvDk=; h=Date:In-Reply-To:References:Subject:To:From; b=Kx0p2ST8H5SRL4r3+A19HNImqPbna7VMF4aU4BVx4MiC51CCSxwZIQP2h0jdZ7AWd U3lrrRWo283P4Z8ND8ntfQ3BDMiBnX1T4aPI87K7WvstR6HFZoXSyd0RGcTtFuj01x 8b2BhreeV0SxZR0GlDvulbPFrAVFGNxkq67btouzDuTMsrKHkDuRxrNgEvlhHDLUXG wby3iAcApjFVZ3/4CtRgvKQv4U9TtedNSM1pT2nmqPoiwI8LY8FvOkcKbr9NIBeyEE Ubv71YE4nsMvxdUdico7GY1fSe1mytBYDDy6tOfuRSCjvzanbLXngB0LkgnCzQ8Uks js4cjvdhHjs3w== X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from disroot.org ([127.0.0.1]) by localhost (mail01.disroot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4BZTZKW5_pQ7 for <30905@debbugs.gnu.org>; Sun, 25 Mar 2018 13:24:11 +0200 (CEST) Date: Sun, 25 Mar 2018 14:22:25 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1521977037; bh=29vDjN+PsdRNZpE1LfZhnrn2tkLevrBGAF/yjQxqvDk=; h=Date:In-Reply-To:References:Subject:To:From; b=fWFqLF3XaPybYU/kce4SgpiW2FWAZG8A6cevXC+xizJifhPWC3CJT/p1YDYepFYTG kTUfb+/SwwL236Nu+fu8UTkZ1jp+R7BhtRhX7cRO+NuwzhnT0BQwBimDE/N37bJ3AP cs2UPC1IF2KdlumC+WmwmmrFhdYoVNC8aL0y+TEvSKGDDyGSAxIsSMWFlo7edd/wsp gkL7HhTzC7/eXXy9kctBasd/RFG/SWxjftHN9U8uaMVtibO91P5FxWyF4ZOrX9caBs STe27gSRZJXMc5we3l0M9lbJKKHoyCvL9XMar8BpIOorVQbtVSsFU7Oc2sdGMHh3zq a0hEppIYuJzLg== User-Agent: K-9 Mail for Android In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Shanavas Message-ID: <311E1CBF-963A-4429-B69D-4C62B01D0178@disroot.org> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On March 22, 2018 12:28:39 PM GMT+03:00, Shanavas M = wrote: >This patch adds two tests for buffer-base-buffer function > > >-- > >Shanavas M This is my first contribution to emacs=2E Is this patch ready to go or Am = I missing something?? --=20 Shanavas M From unknown Sat Jun 21 03:12:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30905: Add tests for buffer-base-buffer function Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Mar 2018 11:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Shanavas Cc: 30905@debbugs.gnu.org Received: via spool by 30905-submit@debbugs.gnu.org id=B30905.15219781355024 (code B ref 30905); Sun, 25 Mar 2018 11:43:02 +0000 Received: (at 30905) by debbugs.gnu.org; 25 Mar 2018 11:42:15 +0000 Received: from localhost ([127.0.0.1]:52158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f042Q-0001Is-N3 for submit@debbugs.gnu.org; Sun, 25 Mar 2018 07:42:14 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:46010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f042O-0001IU-AO; Sun, 25 Mar 2018 07:42:12 -0400 Received: by mail-io0-f182.google.com with SMTP id 141so20002753iou.12; Sun, 25 Mar 2018 04:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xNBNgLI8WJTuXpPpdekY7hm1rL2o3chLq6YMPLmLHv8=; b=cIaLGBfd5uHMYF/93uPg5BtWL4RofTTv14tVRFmPQJDrtnOWkxjtIBsfbxgJgM6xVs tfJ1HYwSOXTOUzLBmqLcpZTB/oydt7Bgs1eAK9H4x/GNjlscwG2OjNoDDbu3MDUrq6kd hx1ywK6+W4e0Y39NZRgpSzdLzyJCmdA0c59ZfMW7KGYXv3k9sxwuyrK65/LJ4cLb/by5 lhchqXiErWrG1SzRKml60L/DrxAwiYynCaNSVlnd7KViM2vlYsDWLLeFVlgGbv1AevKX WwDqgMDgvWwY5cJifRvcl5kSVKBxHnQqZyIlCws7bO5vAH/G6h6mPH9Z+/oBqnQHB+zL 9AeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xNBNgLI8WJTuXpPpdekY7hm1rL2o3chLq6YMPLmLHv8=; b=pp12dge4u7OCqBecVQpjtI9BxiHqB4Kub2Gea00zQ17YL40oFNCmdVFljz7y3BW9uh eXB/0ifZHEiJzphZa1t+7ySoG5yEkf1npFi57IP3JDpQIkrNYKJHtV3UwHQ1t7tEBK1G ICS4b6IQLPINNdTf+hgLKsPbaWTZef+BztKbpfWdh0SIdpyhfY4dYQr8VzzRJq/w6AT6 V/vEchQ18Jg8jQLlXEG/9VVuzXPjtI1v1ZdqYqvNlhWyhIuG+IxbNLpTQUJXKR0m+VAN dX/rc2dCBlwHuy3ftc5dcEX8m4cpdiH1nXiG6PX17skpPdqmX+yZyBLSs49k4eDIacOu 1y4Q== X-Gm-Message-State: AElRT7Fxt0qC/0luihFxDfJaI2fua6wVmNlVEd9XZ0CTdWcKyxgA2WXf FDsjKPxLEDpZWpmKOOK2riZI6w== X-Google-Smtp-Source: AG47ELtOOHKEJRT0DRUQ8rOs7DvH0nms9S6mq9KCZ+wpteB+OFg6WWyOqXjtSd+ko+4jjGoNS8WQjw== X-Received: by 10.107.131.207 with SMTP id n76mr33698278ioi.158.1521978126616; Sun, 25 Mar 2018 04:42:06 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i15-v6sm8555366ita.32.2018.03.25.04.42.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Mar 2018 04:42:06 -0700 (PDT) From: Noam Postavsky References: <311E1CBF-963A-4429-B69D-4C62B01D0178@disroot.org> Date: Sun, 25 Mar 2018 07:42:04 -0400 In-Reply-To: <311E1CBF-963A-4429-B69D-4C62B01D0178@disroot.org> (Shanavas's message of "Sun, 25 Mar 2018 14:22:25 +0300") Message-ID: <87po3sqt4j.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) severity 30905 wishlist quit Shanavas writes: > > This is my first contribution to emacs. Is this patch ready to go or Am I missing something?? A couple of things. Have assigned copyright for Emacs? (the change is small enough to install regardless, but note that we only accept up to 15 lines worth of unassigned code per person). > Subject: [PATCH] Add tests for buffer-base-buffer function > > --- You should add a ChangeLog style entry to the commit message, as described in CONTRIBUTE. > +(ert-deftest test-buffer-base-buffer-indirect () > + (let* ((base (get-buffer-create "base") You should rather use with-temp-buffer, so that the test will not interfere with anything else (same for the second test). From unknown Sat Jun 21 03:12:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30905: Add tests for buffer-base-buffer function Resent-From: Shanavas M Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Mar 2018 14:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30905@debbugs.gnu.org Received: via spool by 30905-submit@debbugs.gnu.org id=B30905.152224886522713 (code B ref 30905); Wed, 28 Mar 2018 14:55:03 +0000 Received: (at 30905) by debbugs.gnu.org; 28 Mar 2018 14:54:25 +0000 Received: from localhost ([127.0.0.1]:57486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1CT2-0005uG-Gf for submit@debbugs.gnu.org; Wed, 28 Mar 2018 10:54:25 -0400 Received: from knopi.disroot.org ([178.21.23.139]:38742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f17ag-0004wq-Ca for 30905@debbugs.gnu.org; Wed, 28 Mar 2018 05:41:58 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 31D212CFC3 for <30905@debbugs.gnu.org>; Wed, 28 Mar 2018 11:41:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1522230112; bh=BkuaTsO6qo55+67jfxrt8kXkZzEvtPvQ4WbRFHaufYE=; h=Subject:To:References:From:Date:In-Reply-To; b=AGYOUXRwpz39XIwJSeZwLMw5ieLE8VPLiAorXrEX40yupT8AaOU/0OTl7AjqWPIei jSwRPobxdwbjR6Jn5uF3/niO4uphu0Dn16doNOPrBt6TlqtU2Ghw9qUMqG7+GFyuPO Kr3lWbcni9WLT0rzNnT9f9d2C5EEuOMq1+CHqRpntclQN/A46tI0koJmvkX7xvmljB NwNreNVUHS1duPpYLf/dK7OnJ4T5PVIXKyKmxmyn/GB5Hcwa6jn9pkbcK5bw7HLrj8 /zHn2gR8aVGAlXoV9bxXRsztZibu2IrU1fQnMH490o9HjukdUQYXEeTtJnO9eXQ89h qwaKy0dnT/ZqA== X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (mail01.disroot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jpleCeJU2qXn for <30905@debbugs.gnu.org>; Wed, 28 Mar 2018 11:41:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1522230110; bh=BkuaTsO6qo55+67jfxrt8kXkZzEvtPvQ4WbRFHaufYE=; h=Subject:To:References:From:Date:In-Reply-To; b=ecWIS+G/5ynxXpPCdHA+GDTUqyjAfoljR3PRQmMsv/upB4aEzy/dA7VHc3lbverQJ n51kkKqDPJtb2ykiqcoArPof+vBQisc3n1IxWN8WE3bUTAMD1ylL9YKlO48v8mMUgW GUA/GhP8OpGbUPIl3P00s1UR+kYoEB1GYWtrssUQdQauQmVpYch7+cPzLb5dBQHj0f zFSccdxFEvQUz7GbfiBrbWjhH1GmXdtjxuLOxchgwui31oL88XzHUAt6MNYjmw5hG0 FI4QdfkeBkkpZmFg9Eu82X3aRRCPT86XKTk31MpR30doceLLxNJyvCYHCIHPAxLrqv yZIg3jQiIQ8ng== References: <311E1CBF-963A-4429-B69D-4C62B01D0178@disroot.org> <87po3sqt4j.fsf@gmail.com> From: Shanavas M Message-ID: Date: Wed, 28 Mar 2018 12:41:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Mime-Version: 1.0 In-Reply-To: <87po3sqt4j.fsf@gmail.com> Content-Type: multipart/mixed; boundary="------------77F8BC8BD43CB957758312AA" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Wed, 28 Mar 2018 10:54:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------77F8BC8BD43CB957758312AA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On Sunday 25 March 2018 02:42 PM, Noam Postavsky wrote: > A couple of things. > > Have assigned copyright for Emacs? (the change is small enough to > install regardless, but note that we only accept up to 15 lines worth of > unassigned code per person). I have send the request. Waiting for reply. > You should add a ChangeLog style entry to the commit message, as > described in CONTRIBUTE. Updated > >> +(ert-deftest test-buffer-base-buffer-indirect () >> + (let* ((base (get-buffer-create "base") > You should rather use with-temp-buffer, so that the test will not > interfere with anything else (same for the second test). > Updated. > --------------77F8BC8BD43CB957758312AA Content-Type: text/x-patch; name="0001-Add-tests-for-buffer-base-buffer-function.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Add-tests-for-buffer-base-buffer-function.patch" >From c1627cb453a6aceba36305417d5ac6b1e63e7021 Mon Sep 17 00:00:00 2001 From: Shanavas M Date: Thu, 22 Mar 2018 12:20:22 +0300 Subject: [PATCH] Add tests for buffer-base-buffer function * test/src/buffer-tests.el (test-buffer-base-buffer-indirect) (test-buffer-base-buffer-non-indirect): Add tests for `buffer-base-buffer' --- test/src/buffer-tests.el | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/src/buffer-tests.el b/test/src/buffer-tests.el index f9c477fbfd..d115e66817 100644 --- a/test/src/buffer-tests.el +++ b/test/src/buffer-tests.el @@ -50,4 +50,14 @@ (progn (get-buffer-create "nil") (generate-new-buffer-name "nil"))))) +(ert-deftest test-buffer-base-buffer-indirect () + (with-temp-buffer + (let* ((ind-buf-name (generate-new-buffer-name "indbuf")) + (ind-buf (make-indirect-buffer (current-buffer) ind-buf-name))) + (should (eq (buffer-base-buffer ind-buf) (current-buffer)))))) + +(ert-deftest test-buffer-base-buffer-non-indirect () + (with-temp-buffer + (should (eq (buffer-base-buffer (current-buffer)) nil)))) + ;;; buffer-tests.el ends here -- 2.11.0 --------------77F8BC8BD43CB957758312AA-- From unknown Sat Jun 21 03:12:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30905: Add tests for buffer-base-buffer function References: In-Reply-To: Resent-From: Shanavas M Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Apr 2018 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30905@debbugs.gnu.org Received: via spool by 30905-submit@debbugs.gnu.org id=B30905.1523431059654 (code B ref 30905); Wed, 11 Apr 2018 07:18:02 +0000 Received: (at 30905) by debbugs.gnu.org; 11 Apr 2018 07:17:39 +0000 Received: from localhost ([127.0.0.1]:45646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6A0g-0000AU-Nq for submit@debbugs.gnu.org; Wed, 11 Apr 2018 03:17:38 -0400 Received: from knopi.disroot.org ([178.21.23.139]:44532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6A0e-0000AC-M2 for 30905@debbugs.gnu.org; Wed, 11 Apr 2018 03:17:38 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 369392D906 for <30905@debbugs.gnu.org>; Wed, 11 Apr 2018 09:17:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1523431050; bh=+XCqBHWLSl7ZOpMkJJdjtnosp07IixT1mdREhFGN5Uw=; h=Date:Subject:To:From; b=adSRKcCmJyDtGTcy53fWFOCjYzOEGiSSnljjOKXnGzs0reQMLO0w7UFzJjxlF+CYa ZNFjefx+lPYVYvklSTseWqWnk2wRhbwv+Xdxl7B1rdbUiF1Oh8TGQJKA1QAuWrnOnx JEFvIseCZ392S6BzXle8qSBSmVSMotPLuKObQO3iOahAmHix5lb9nDG4lQKSvepMI5 H2nqcmwZ6J/5z6wENKyiydjbKn+pnzs3hO1U/5C/FqyBt7wgdsIBCq0Ocv/nZGMP4U 9Ad7a/yTaProlpE1uJikBKN7S3h4Rhi8qo1foiFoNMyvhc15jX4rJHAE5Yx50wxyMk eurvoPf8BxT1w== X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (mail01.disroot.lan [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dF9JjH53d3VY for <30905@debbugs.gnu.org>; Wed, 11 Apr 2018 09:17:28 +0200 (CEST) Date: Wed, 11 Apr 2018 10:17:25 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1523431048; bh=+XCqBHWLSl7ZOpMkJJdjtnosp07IixT1mdREhFGN5Uw=; h=Date:Subject:To:From; b=WGBStGtEV+rJwev00lDaEuZPH2XXKqbsixp70+j7l4W0WNX/x2SxCWzkcQnDrWhKk y65F4IQikixDyGgPSHkvTwVjWgCuLvCaNAvdu6c4zhJYWM41UK+Ij5SMOADp8WzWsP R9CNflq/jEHuZLv+yudtF6mp1urWiV3kOQfq9DnSGQWMt4t9Zk0ZGVUsO7oUaQkd/g 38IA0R8yw0e0UOL0iUXVDJ6YhNXVylsdByDcTYOXbhvWoGNcbHQPp3wYuEcvagLrJO DXx/riCqYfXc5D6dYqETi2T8o724BEtl91jSTjgW2j44YJCtQp+c3g+8nk/bjebhLn rBQbQ/P5bEseg== User-Agent: K-9 Mail for Android Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----3FSEI1GCDDJKCCEYZ7PBCW29F7PQNP" Content-Transfer-Encoding: 7bit From: Shanavas M Message-ID: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------3FSEI1GCDDJKCCEYZ7PBCW29F7PQNP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I have completed the copyright assignment=2E Hope this patch is ready to go=2E --=20 Shanavas M ------3FSEI1GCDDJKCCEYZ7PBCW29F7PQNP Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I have completed the copyright assignment=2E

Hope this patch is ready to go=2E
--
Shanavas M ------3FSEI1GCDDJKCCEYZ7PBCW29F7PQNP-- From unknown Sat Jun 21 03:12:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30905: Add tests for buffer-base-buffer function Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2018 01:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Shanavas M Cc: 30905@debbugs.gnu.org Received: via spool by 30905-submit@debbugs.gnu.org id=B30905.152349595313471 (code B ref 30905); Thu, 12 Apr 2018 01:20:01 +0000 Received: (at 30905) by debbugs.gnu.org; 12 Apr 2018 01:19:13 +0000 Received: from localhost ([127.0.0.1]:46860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6QtN-0003V8-IC for submit@debbugs.gnu.org; Wed, 11 Apr 2018 21:19:13 -0400 Received: from mail-it0-f42.google.com ([209.85.214.42]:51946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6QtL-0003Uk-LY; Wed, 11 Apr 2018 21:19:11 -0400 Received: by mail-it0-f42.google.com with SMTP id b5-v6so5277580itj.1; Wed, 11 Apr 2018 18:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=l5HaYEL6rJZ4Umqswy1mfiUXF/RFDnWmC3CTdUisfvk=; b=d8YLrXwdSu7EbRDx+wWV3baHlq8Uj40dEkqLDR3yepP3vsKyam1FSQPyEalQa4qkxd FY3CE/wt5LAyGd22/VmcS6yTUWhbWR8L0QTWPtED/iwqY4ze0aKxBOTZjid8d4jYl4JJ JqOJsJL3rLX8e7I7RiWgMURpZmb/DSy4Gz76lhdFklzo8xq0647s7oWc9Ce9AhdDhNn3 OXj4eFdcxgKtnm0WsA1GNOAIgTi5TyPrs7GLAuQR7blOfSul+Ez5aXBl8PRqahyq+QFG BXg6pqK7JqIlxoOCmfWhUZH2hL7uMXe7ofOjjFxEFNLtQQOI4qILkYUTm6ZjbiZckif6 mnvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=l5HaYEL6rJZ4Umqswy1mfiUXF/RFDnWmC3CTdUisfvk=; b=jYGxOQUfS8lhYmQ3t4fBLwBGus3t1dTW/xQ7dQc9fBeE+44kIJQYBson6C54Mdv6MK JeecArOFgKInM0W2L29SApURD5iyrNg7jibUAVj24O7f+NKiaT+gvpCNx33on7aRE62g 3T0o6tPwm5gCZspnyWLxOsJh2qwRXimUT8IA+YE9K9hUXEdmXHJYVM6DhrZcmr4lS+pS K38rAPcdPkVdIz/auZMppLO2rlYDHfqtSQwXB1cgyDjv280wzW0C4SNlZCbN9ZbwYTfD IGRX0BQm/HLzgQ6LDOYD2IZ9teTGTTBdRQGhacvwVFk2v7GTnSR+HeiS1egkRH+8Q1JQ 3ZyA== X-Gm-Message-State: ALQs6tAdnQJDA7uOX3GF1NlCALVCWsEMfx9h4OYQf+DdE9NjXs2pWnrc wr9lXkd5Jh4RdoI6gbMOJOLHFw== X-Google-Smtp-Source: AIpwx4/TBawy6RSg5BHpO99jYhP9vMxren8hXQ1tApTH6Xjcepq4J27SnsvylQq3Hg7JJFK+36vucQ== X-Received: by 2002:a24:d3cd:: with SMTP id n196-v6mr6213536itg.123.1523495946103; Wed, 11 Apr 2018 18:19:06 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u66-v6sm1353782itd.9.2018.04.11.18.19.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Apr 2018 18:19:05 -0700 (PDT) From: Noam Postavsky References: <311E1CBF-963A-4429-B69D-4C62B01D0178@disroot.org> <87po3sqt4j.fsf@gmail.com> Date: Wed, 11 Apr 2018 21:19:03 -0400 In-Reply-To: (Shanavas M.'s message of "Wed, 28 Mar 2018 12:41:40 +0300") Message-ID: <87y3htkyrc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 30905 fixed close 30905 27.1 quit Shanavas M writes: >>>From c1627cb453a6aceba36305417d5ac6b1e63e7021 Mon Sep 17 00:00:00 2001 > From: Shanavas M > Date: Thu, 22 Mar 2018 12:20:22 +0300 > Subject: [PATCH] Add tests for buffer-base-buffer function Pushed to master. [1: 10f5f4361b]: 2018-04-11 21:16:49 -0400 Add tests for buffer-base-buffer function (Bug#30905) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=10f5f4361b9783f1cc4a683cca31ab3192fe179d