From unknown Sun Jun 22 00:45:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#30904: 26.0.91; tramp.el: Outdated docstring of tramp-dissect-file-name Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Mar 2018 06:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30904 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 30904@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.152169970515216 (code B ref -1); Thu, 22 Mar 2018 06:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Mar 2018 06:21:45 +0000 Received: from localhost ([127.0.0.1]:46625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eytbd-0003xL-Kp for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eytbb-0003x8-Mq for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eytbV-0001p6-Pw for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eytbV-0001oy-MB for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eytbU-0003fU-Dg for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 02:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eytbR-0001jv-9u for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 02:21:36 -0400 Received: from mail-it0-x22d.google.com ([2607:f8b0:4001:c0b::22d]:50450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eytbR-0001ig-40 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 02:21:33 -0400 Received: by mail-it0-x22d.google.com with SMTP id d13-v6so9923819itf.0 for ; Wed, 21 Mar 2018 23:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=kIOf2B3mg1lcKyQ3ukK5VcvejBaoG+pd3TKA92PJTKQ=; b=UWLt6iQfvJL5TC0nTRjLLBWFNlO3qUdk/fY+EfYULidHAJS80buDbdJmRfpPn+KSQy 4lj3nLm0McPcpfczPo6bHrd9wyRjO4PGKLOFnwQ6XVD5+ZNVmRyv808C6fjDaoPJjlNB xWzU1RjmvycLNhfMYqZmZO2/spd51EMx6QP7BXUUkUb4tdkDT2MthOVGQ9jeCwbezilc /XjV6Q6grENr/pcVefZoELAwJ1ChRFK7GeBbTyTYnz27bu8NmTE6Fv4mA+wZp/mPuKOX +ITVhTpR47V+7/Z+KxmwnYD1HTU13c6AIJnsUzydBvJdD30dKB/fpuQUE4xY23MXxKGf xkRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=kIOf2B3mg1lcKyQ3ukK5VcvejBaoG+pd3TKA92PJTKQ=; b=ShA+SxJpajtReMr7xYHnt1jG17QPbwlyHUCWBbAmuwlhDOh7qV4laoreOpWgguy4O4 Qp/1abEhrXOvDxaniGDGSUx0aEMR71xqG8JEolNMFmaB5V8b9IfDTYvsyqLLmdoNeSkf 0CZHhsTd7gSImSY1iB2woqmXqqvP2QC86wwBw7CIsdyYxSBHuFFK3Mj01So6UkkpXXi4 5F8IWZuSD0dAcZ2CkTNlBBL1vCA1ZnqQuCKBZc7WSZsCYOYh1VApgOzUWPaIMtxuiiVm 6Fj3EktJ59LQy2e6iKhpSp0Cr0cQu7J/gxuEHsU+fKVzTHSYDehxznZNVLWOEYsPEPME NOxw== X-Gm-Message-State: AElRT7Hxuy4lkxEsjvtLAbfEkN6YhQlfT9XobN//3KmlY55mQ9B7X59A VduNX+nWAZ1ti0vYXU82VHO3mw== X-Google-Smtp-Source: AIpwx4+DKaQAc1vOiakbn6plaFDAXhJOSkQo0AjNv/K5ybdwuO9QImiM1iscQcdl9HLutrpDLeyyjQ== X-Received: by 2002:a24:580f:: with SMTP id f15-v6mr7224935itb.129.1521699691873; Wed, 21 Mar 2018 23:21:31 -0700 (PDT) Received: from mimimi ([116.75.246.100]) by smtp.gmail.com with ESMTPSA id p68-v6sm4135867itc.13.2018.03.21.23.21.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Mar 2018 23:21:31 -0700 (PDT) User-agent: mu4e 1.0; emacs 26.0.91 From: Pierre Neidhardt Date: Thu, 22 Mar 2018 11:51:28 +0530 Message-ID: <87tvt88wbb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) On the one hand, tramp-make-tramp-file-name documents the new DOMAIN and PORT arguments: > tramp-make-tramp-file-name is a compiled Lisp function in =E2=80=98tramp.= el=E2=80=99. >=20 > (tramp-make-tramp-file-name METHOD USER DOMAIN HOST PORT LOCALNAME &optio= nal > HOP) >=20 > Constructs a Tramp file name from METHOD, USER, HOST and LOCALNAME. > When not nil, optional DOMAIN, PORT and HOP are used. On the other hand, tramp-dissect-file-name fails to reference them: > tramp-dissect-file-name is a compiled Lisp function in =E2=80=98tramp.el= =E2=80=99. >=20 > (tramp-dissect-file-name NAME &optional NODEFAULT) >=20 > Return a =E2=80=98tramp-file-name=E2=80=99 structure. > The structure consists of remote method, remote user, remote host, > localname (file name on remote host) and hop. If NODEFAULT is > non-nil, the file name parts are not expanded to their default > values. I think we should mention DOMAIN and PORT in the dissect function docstring. The code actually handles them. In GNU Emacs 26.0.91 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2018-03-03 built on mimimi Repository revision: 752fba992b793a74d202c9cfc3e1a92fd458e748 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Void Linux From unknown Sun Jun 22 00:45:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pierre Neidhardt Subject: bug#30904: closed (Re: bug#30904: 26.0.91; tramp.el: Outdated docstring of tramp-dissect-file-name) Message-ID: References: <87d0zwjx7n.fsf@gmx.de> <87tvt88wbb.fsf@gmail.com> X-Gnu-PR-Message: they-closed 30904 X-Gnu-PR-Package: emacs Reply-To: 30904@debbugs.gnu.org Date: Thu, 22 Mar 2018 09:07:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1521709621-31084-1" This is a multi-part message in MIME format... ------------=_1521709621-31084-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #30904: 26.0.91; tramp.el: Outdated docstring of tramp-dissect-file-name which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 30904@debbugs.gnu.org. --=20 30904: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30904 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1521709621-31084-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 30904-done) by debbugs.gnu.org; 22 Mar 2018 09:06:47 +0000 Received: from localhost ([127.0.0.1]:46732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eywBL-00084w-71 for submit@debbugs.gnu.org; Thu, 22 Mar 2018 05:06:47 -0400 Received: from mout.gmx.net ([212.227.15.18]:36795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eywBJ-00084i-2U for 30904-done@debbugs.gnu.org; Thu, 22 Mar 2018 05:06:45 -0400 Received: from detlef.gmx.de ([217.70.140.244]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MOf5S-1ev4Yd3r9i-0068Gt; Thu, 22 Mar 2018 10:06:38 +0100 From: Michael Albinus To: Pierre Neidhardt Subject: Re: bug#30904: 26.0.91; tramp.el: Outdated docstring of tramp-dissect-file-name References: <87tvt88wbb.fsf@gmail.com> Date: Thu, 22 Mar 2018 10:06:36 +0100 In-Reply-To: <87tvt88wbb.fsf@gmail.com> (Pierre Neidhardt's message of "Thu, 22 Mar 2018 11:51:28 +0530") Message-ID: <87d0zwjx7n.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:8C7TEdaEMHPuIpfCujc+jfnSTWjRxAQgekdAQB1ul5ixNZTjX4p xHPqwuWiBKP/vj9jHRXxTzc2zhW/1Ukzy8SBgjmpDt9yQ52KHPFMIu6A49/P64FZZhP604q ABnF/xR+ch5TASzMrUEy0RISLxqApzs7aZ3GUgWjZjrbJ3XN5WuNXUjhx9mJtIGHE00MGmi +eiMwuKLgyHCPpMlB1Ndw== X-UI-Out-Filterresults: notjunk:1;V01:K0:rUgJ5IRsrwE=:u/XR9bXytDA9t37Hqfij9U wORWdqPMaQ4tXjqHffYmnO3EFVu8jhGIjuwo8yv1ikQBM5DMYFPtp8vKuHniUT5dTqgOc7Eez IUNYObjcRQKatP5Irs1Vb0MzYo1fheiJtWcN+8DdObyhXGEXpzcpy0CMOwuOU6akQDHMZKDKs bPy/BuRWHGcnRq0fLqbNSW9KunNLo3afjT3QWSTwxZCuBfm3hir1Q/V0Yo/JKFkn4o4TOo5c2 Itb+lg0OPjRAXdE+pH87TuHhM/3bDQ17MnwLMN3/jIKBSrUMVeubzUgncDWQtijY53AqgAU+L nUY5FTGF6T9MmNwuTEbNyGtDo6ulZWi4OAIwtnyn2C7GoDRxomdaUPsMMkiJ1QeG+YHpKZTU3 TFvumUiBDwcfMMxtEzUt5akjj/e67diJ6cMsEQ4vykMEj670sCJ/h9mYNE6/Oo2THPt+GfGJX DSRXg90vTfM6V1W+wZtRhUGtz7Z46Zz+65tuk4jKUc2UwZ1yY32xlqSHnaS6QEgNOZyF8puHv coSn/V+/xf13lq61SYF/PKHdP5RfsfSaTlg74t2PlNSndV1LMLHgvNo4XVG3haJ/3wpsXlKr0 wfsB3/CiRvRQZBjq44207gMraAlT11D2dWQNkC3NG6WB7QqqTWnoq/WxhckxiPu5/5hjXrWGz E/73UacXln59utuEr4z1svnWLjWtPrVi1orYvbx/M3u5sM2T78+ATvN4yo8kCEkRH5bABbiGl MflgUsFvpS5R6wPF64JYu69lHRiwsX/H1WEAte6el7cfybKtIxjnDW9f00103J35y9CpDF7Px EbNEV+V1c3PlN3GNW8Xep27OzptG45/Zax35m1wM3oTfG77ffU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 30904-done Cc: 30904-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 27.1 Pierre Neidhardt writes: Hi Pierre, > I think we should mention DOMAIN and PORT in the dissect function docstring. > The code actually handles them. Thanks for the report. I've fixed this in both Emacs and Tramp repositories, master branch. I do not want to commit this to the emacs-26 branch just now, short before the Emacs 26.1 release. It is not critical. I have fixed this also in the Tramp repository, branch-2-3-stable. This will be merged into the Emacs repository, emacs-26 branch, after Emacs 26.1 is out. So it will appear also in a later Emacs 26.2. Closing the bug. Best regards, Michael. ------------=_1521709621-31084-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Mar 2018 06:21:45 +0000 Received: from localhost ([127.0.0.1]:46625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eytbd-0003xL-Kp for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eytbb-0003x8-Mq for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eytbV-0001p6-Pw for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41201) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eytbV-0001oy-MB for submit@debbugs.gnu.org; Thu, 22 Mar 2018 02:21:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44967) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eytbU-0003fU-Dg for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 02:21:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eytbR-0001jv-9u for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 02:21:36 -0400 Received: from mail-it0-x22d.google.com ([2607:f8b0:4001:c0b::22d]:50450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eytbR-0001ig-40 for bug-gnu-emacs@gnu.org; Thu, 22 Mar 2018 02:21:33 -0400 Received: by mail-it0-x22d.google.com with SMTP id d13-v6so9923819itf.0 for ; Wed, 21 Mar 2018 23:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=kIOf2B3mg1lcKyQ3ukK5VcvejBaoG+pd3TKA92PJTKQ=; b=UWLt6iQfvJL5TC0nTRjLLBWFNlO3qUdk/fY+EfYULidHAJS80buDbdJmRfpPn+KSQy 4lj3nLm0McPcpfczPo6bHrd9wyRjO4PGKLOFnwQ6XVD5+ZNVmRyv808C6fjDaoPJjlNB xWzU1RjmvycLNhfMYqZmZO2/spd51EMx6QP7BXUUkUb4tdkDT2MthOVGQ9jeCwbezilc /XjV6Q6grENr/pcVefZoELAwJ1ChRFK7GeBbTyTYnz27bu8NmTE6Fv4mA+wZp/mPuKOX +ITVhTpR47V+7/Z+KxmwnYD1HTU13c6AIJnsUzydBvJdD30dKB/fpuQUE4xY23MXxKGf xkRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=kIOf2B3mg1lcKyQ3ukK5VcvejBaoG+pd3TKA92PJTKQ=; b=ShA+SxJpajtReMr7xYHnt1jG17QPbwlyHUCWBbAmuwlhDOh7qV4laoreOpWgguy4O4 Qp/1abEhrXOvDxaniGDGSUx0aEMR71xqG8JEolNMFmaB5V8b9IfDTYvsyqLLmdoNeSkf 0CZHhsTd7gSImSY1iB2woqmXqqvP2QC86wwBw7CIsdyYxSBHuFFK3Mj01So6UkkpXXi4 5F8IWZuSD0dAcZ2CkTNlBBL1vCA1ZnqQuCKBZc7WSZsCYOYh1VApgOzUWPaIMtxuiiVm 6Fj3EktJ59LQy2e6iKhpSp0Cr0cQu7J/gxuEHsU+fKVzTHSYDehxznZNVLWOEYsPEPME NOxw== X-Gm-Message-State: AElRT7Hxuy4lkxEsjvtLAbfEkN6YhQlfT9XobN//3KmlY55mQ9B7X59A VduNX+nWAZ1ti0vYXU82VHO3mw== X-Google-Smtp-Source: AIpwx4+DKaQAc1vOiakbn6plaFDAXhJOSkQo0AjNv/K5ybdwuO9QImiM1iscQcdl9HLutrpDLeyyjQ== X-Received: by 2002:a24:580f:: with SMTP id f15-v6mr7224935itb.129.1521699691873; Wed, 21 Mar 2018 23:21:31 -0700 (PDT) Received: from mimimi ([116.75.246.100]) by smtp.gmail.com with ESMTPSA id p68-v6sm4135867itc.13.2018.03.21.23.21.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Mar 2018 23:21:31 -0700 (PDT) User-agent: mu4e 1.0; emacs 26.0.91 From: Pierre Neidhardt To: bug-gnu-emacs@gnu.org Subject: 26.0.91; tramp.el: Outdated docstring of tramp-dissect-file-name Date: Thu, 22 Mar 2018 11:51:28 +0530 Message-ID: <87tvt88wbb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) On the one hand, tramp-make-tramp-file-name documents the new DOMAIN and PORT arguments: > tramp-make-tramp-file-name is a compiled Lisp function in =E2=80=98tramp.= el=E2=80=99. >=20 > (tramp-make-tramp-file-name METHOD USER DOMAIN HOST PORT LOCALNAME &optio= nal > HOP) >=20 > Constructs a Tramp file name from METHOD, USER, HOST and LOCALNAME. > When not nil, optional DOMAIN, PORT and HOP are used. On the other hand, tramp-dissect-file-name fails to reference them: > tramp-dissect-file-name is a compiled Lisp function in =E2=80=98tramp.el= =E2=80=99. >=20 > (tramp-dissect-file-name NAME &optional NODEFAULT) >=20 > Return a =E2=80=98tramp-file-name=E2=80=99 structure. > The structure consists of remote method, remote user, remote host, > localname (file name on remote host) and hop. If NODEFAULT is > non-nil, the file name parts are not expanded to their default > values. I think we should mention DOMAIN and PORT in the dissect function docstring. The code actually handles them. In GNU Emacs 26.0.91 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.26) of 2018-03-03 built on mimimi Repository revision: 752fba992b793a74d202c9cfc3e1a92fd458e748 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Void Linux ------------=_1521709621-31084-1--