From unknown Fri Jun 20 05:24:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#30894 <30894@debbugs.gnu.org> To: bug#30894 <30894@debbugs.gnu.org> Subject: Status: Submission of patch for Add r-abc Reply-To: bug#30894 <30894@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:24:11 +0000 retitle 30894 Submission of patch for Add r-abc reassign 30894 guix-patches submitter 30894 Sahithi Yarlagadda severity 30894 normal tag 30894 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 21 07:16:08 2018 Received: (at submit) by debbugs.gnu.org; 21 Mar 2018 11:16:08 +0000 Received: from localhost ([127.0.0.1]:44933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eybix-0000eB-87 for submit@debbugs.gnu.org; Wed, 21 Mar 2018 07:16:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eybiu-0000dQ-P3 for submit@debbugs.gnu.org; Wed, 21 Mar 2018 07:16:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eybio-0002bM-IF for submit@debbugs.gnu.org; Wed, 21 Mar 2018 07:15:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36035) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eybio-0002bI-Dn for submit@debbugs.gnu.org; Wed, 21 Mar 2018 07:15:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eybin-0001Xe-4e for guix-patches@gnu.org; Wed, 21 Mar 2018 07:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eybii-0002Zg-0p for guix-patches@gnu.org; Wed, 21 Mar 2018 07:15:57 -0400 Received: from swecha.net ([136.243.177.181]:55142) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eybih-0002KZ-MC for guix-patches@gnu.org; Wed, 21 Mar 2018 07:15:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=swecha.net; s=default; h=Content-Type:MIME-Version:Date:Message-ID:Subject:From:Cc:To: Sender:Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zrG/oOOTUfF2l2LfihyR+1rN3+G7JpJZ7VlaMGI4Ccc=; b=j8Mcia3k+FhVsx6lXhndKHjQf4 By5SEbt1AgihGqdaAgMvnEcksCzWnpVAI2UwmQ5VbxfQ2qTlhTlByJ/iJeDHsg33GdidcfyZ/8tBA +2mYMtRPsWX5TPhpHOXMwK2tkmCfElDmAxPQsqJ39lsusUzyByxNieqR+hYoDGn9fmf5e0muOmdA6 lvajmrX1YarzEz4HNSlObg1VscCwAGXxHIZ+nvtQgpES15kMRV1KneDeQOU/x+/Urq7BFXsHqMcHj yLuoePQ3ybJy9FjHaPWVd7OnZmfNew6yW+hIyqjnRROq/15D0LNIT6wCy6vTETUlYjIB0YWLM3yPJ SERVXY5Q==; Received: from [103.206.105.70] (port=30568 helo=[10.46.199.84]) by server.amistadraising.in with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1eybhy-003Nza-Ik; Wed, 21 Mar 2018 16:45:08 +0530 To: guix-patches@gnu.org From: Sahithi Yarlagadda Subject: Submission of patch for Add r-abc Message-ID: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> Date: Wed, 21 Mar 2018 16:44:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6D748C4971760DEC1FC4580C" Content-Language: en-US X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.amistadraising.in X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - swecha.net X-Get-Message-Sender-Via: server.amistadraising.in: authenticated_id: sahi@swecha.net X-Authenticated-Sender: server.amistadraising.in: sahi@swecha.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------6D748C4971760DEC1FC4580C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi, I am submitting a patch for r-abc. Please review. -- Regards Sahithi --------------6D748C4971760DEC1FC4580C Content-Type: text/x-patch; name="0001-gnu-Add-r-abc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-r-abc.patch" >From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001 From: Sahithi Yarlagadda Date: Wed, 21 Mar 2018 16:30:18 +0530 Subject: [PATCH] gnu: Add r-abc. * gnu/packages/cran.scm (r-abc): New variable. --- gnu/packages/cran.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index ce09c22c5..6aecd0f8e 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -3295,3 +3295,33 @@ Dependencies of the distribution of the specified variable (response variable) to other variables (explanatory variables) are derived and evaluated by the @dfn{Akaike Information Criterion} (AIC).") (license license:gpl2+))) + +(define-public r-abc + (package + (name "r-abc") + (version "2.1") + (source + (origin + (method url-fetch) + (uri (cran-uri "abc" version)) + (sha256 + (base32 + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) + (build-system r-build-system) + (propagated-inputs + `(("r-abc-data" ,r-abc-data) + ("r-locfit" ,r-locfit) + ("r-mass" ,r-mass) + ("r-nnet" ,r-nnet) + ("r-quantreg" ,r-quantreg))) + (home-page + "http://cran.r-project.org/web/packages/abc") + (synopsis + "Tools for approximate bayesian computation (ABC)") + (description + "Implements several ABC algorithms for performing parameter estimation, +model selection, and goodness-of-fit. Cross-validation tools are also +available for measuring the accuracy of ABC estimates, and to calculate the +misclassification probabilities of different models.") + (license license:gpl3+))) + -- 2.16.2 --------------6D748C4971760DEC1FC4580C-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 21 17:28:06 2018 Received: (at 30894) by debbugs.gnu.org; 21 Mar 2018 21:28:06 +0000 Received: from localhost ([127.0.0.1]:46340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eylHB-0004Da-KI for submit@debbugs.gnu.org; Wed, 21 Mar 2018 17:28:05 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eylH8-0004DG-Hb for 30894@debbugs.gnu.org; Wed, 21 Mar 2018 17:28:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1521667672; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=2841; bh=XkwlPHEDwPlea/GMgV7BpsEEJwPw0ZYq93qpYJrdcME=; b=YqUUlNw8xGcaWopRZzszrcEPpeK+zuioZ1iK6z1hEr+UwGMnisSV+Diih34dRP+6 Gmptvy15eQ0R1zuGrIxygZ+30eQ84iB14CDneOJwlp3NbvRKQOH26lYwJAKIqb+f5Od 5ieiGuLgVxzmz6/QNj0P4UYFUtAtkEHivEagFpR0= Received: from localhost (port-92-200-42-42.dynamic.qsc.de [92.200.42.42]) by mx.zohomail.com with SMTPS id 1521667672301432.38300232694235; Wed, 21 Mar 2018 14:27:52 -0700 (PDT) References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus To: Sahithi Yarlagadda Subject: Re: Submission of patch for Add r-abc In-reply-to: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 21 Mar 2018 22:27:49 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87tvt9azl6.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Sahithi, > I am submitting a patch for r-abc. Please review. Thank you for the patch! What follows is a short review that includes things I could change myself before applying the patch, but for the sake of learning I explicitly point out in this message. I hope you don=E2=80=99t mind that I= =E2=80=99m focusing on what may seem like minor details. > From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001 > From: Sahithi Yarlagadda > Date: Wed, 21 Mar 2018 16:30:18 +0530 > Subject: [PATCH] gnu: Add r-abc. > > * gnu/packages/cran.scm (r-abc): New variable. Nitpick: please don=E2=80=99t indent this line. The asterisk should be the first character in this line. > + > +(define-public r-abc > + (package > + (name "r-abc") > + (version "2.1") > + (source > + (origin > + (method url-fetch) > + (uri (cran-uri "abc" version)) > + (sha256 > + (base32 > + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) > + (build-system r-build-system) > + (propagated-inputs > + `(("r-abc-data" ,r-abc-data) > + ("r-locfit" ,r-locfit) > + ("r-mass" ,r-mass) > + ("r-nnet" ,r-nnet) > + ("r-quantreg" ,r-quantreg))) > + (home-page > + "http://cran.r-project.org/web/packages/abc") Please pull this onto the previous line and use =E2=80=9Chttps=E2=80=9D. > + (synopsis > + "Tools for approximate bayesian computation (ABC)") Please combine this line with the previous line. > + (description > + "Implements several ABC algorithms for performing parameter estima= tion, > +model selection, and goodness-of-fit. Cross-validation tools are also > +available for measuring the accuracy of ABC estimates, and to calculate = the > +misclassification probabilities of different models.") Please use full sentences. For CRAN packages the official description usually provides only a sentence fragment in place of the first sentence. Please also use =E2=80=9C@dfn{Approximate Bayesian Computation} (ABC)=E2=80=9D the first time =E2=80=9CABC=E2=80=9D is mentioned. All thoughout the indentation is a bit off (that=E2=80=99s expected as the importer is very simple and doesn=E2=80=99t know about the expected indentation). If you=E2=80=99re using Emacs you can easily adjust it with = M-C-q (also known as =E2=80=9Cindent-sexp=E2=80=9D); otherwise please use =E2=80=9Cetc/indent-code.el=E2=80=9D. Have you built this package with Guix? Finally, please rebase this patch so that it can be applied independently from the other patch you=E2=80=99ve sent, which cannot curren= tly be applied due to problems in building the defined package. Rebasing this patch ensures that it can be merged even if the other patch is stuck. Thanks! -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 28 15:45:28 2018 Received: (at 30894) by debbugs.gnu.org; 28 Mar 2018 19:45:28 +0000 Received: from localhost ([127.0.0.1]:57661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1H0i-0006DO-9K for submit@debbugs.gnu.org; Wed, 28 Mar 2018 15:45:28 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1H0g-0006DG-G5 for 30894@debbugs.gnu.org; Wed, 28 Mar 2018 15:45:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1522266268; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=3025; bh=EHA1jL82LK9F8E5skKjazMEtwPARdHtWUKhe49NsgeA=; b=i458Lc03TLXYJfnUl8giDgSWw/Qog0++DaZgvEuTHUTisIRA1kP8DIZCwuUJW7Ii 84UOYSMSp4QD89h7BBJCTKGqChcr8TPR8U9xPkjG5ViHh6X2/n37cdn/2/eGck0IJcN aIqcnEgtUwXGCWNW6wN+LKJBdnhLvW4ff1vlsmt4= Received: from localhost (port-92-200-78-30.dynamic.qsc.de [92.200.78.30]) by mx.zohomail.com with SMTPS id 1522266268735246.11472835285872; Wed, 28 Mar 2018 12:44:28 -0700 (PDT) References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus To: Sahithi Yarlagadda Subject: Re: [bug#30894] Submission of patch for Add r-abc In-reply-to: <87tvt9azl6.fsf@elephly.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 28 Mar 2018 21:44:26 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87vadgdlyd.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Sahiti, have you been able to look at my review below? Please let me know if anything is unclear. ~~ Ricardo Ricardo Wurmus writes: > Hi Sahithi, > >> I am submitting a patch for r-abc. Please review. > > Thank you for the patch! > > What follows is a short review that includes things I could change > myself before applying the patch, but for the sake of learning I > explicitly point out in this message. I hope you don=E2=80=99t mind that= I=E2=80=99m > focusing on what may seem like minor details. > >> From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001 >> From: Sahithi Yarlagadda >> Date: Wed, 21 Mar 2018 16:30:18 +0530 >> Subject: [PATCH] gnu: Add r-abc. >> >> * gnu/packages/cran.scm (r-abc): New variable. > > Nitpick: please don=E2=80=99t indent this line. The asterisk should be t= he > first character in this line. > >> + >> +(define-public r-abc >> + (package >> + (name "r-abc") >> + (version "2.1") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (cran-uri "abc" version)) >> + (sha256 >> + (base32 >> + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) >> + (build-system r-build-system) >> + (propagated-inputs >> + `(("r-abc-data" ,r-abc-data) >> + ("r-locfit" ,r-locfit) >> + ("r-mass" ,r-mass) >> + ("r-nnet" ,r-nnet) >> + ("r-quantreg" ,r-quantreg))) >> + (home-page >> + "http://cran.r-project.org/web/packages/abc") > > Please pull this onto the previous line and use =E2=80=9Chttps=E2=80=9D. > >> + (synopsis >> + "Tools for approximate bayesian computation (ABC)") > > Please combine this line with the previous line. > >> + (description >> + "Implements several ABC algorithms for performing parameter estim= ation, >> +model selection, and goodness-of-fit. Cross-validation tools are also >> +available for measuring the accuracy of ABC estimates, and to calculate= the >> +misclassification probabilities of different models.") > > Please use full sentences. For CRAN packages the official description > usually provides only a sentence fragment in place of the first > sentence. Please also use =E2=80=9C@dfn{Approximate Bayesian Computation= } > (ABC)=E2=80=9D the first time =E2=80=9CABC=E2=80=9D is mentioned. > > All thoughout the indentation is a bit off (that=E2=80=99s expected as th= e > importer is very simple and doesn=E2=80=99t know about the expected > indentation). If you=E2=80=99re using Emacs you can easily adjust it wit= h M-C-q > (also known as =E2=80=9Cindent-sexp=E2=80=9D); otherwise please use > =E2=80=9Cetc/indent-code.el=E2=80=9D. > > Have you built this package with Guix? > > Finally, please rebase this patch so that it can be applied > independently from the other patch you=E2=80=99ve sent, which cannot curr= ently > be applied due to problems in building the defined package. Rebasing > this patch ensures that it can be merged even if the other patch is > stuck. > > Thanks! From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 28 15:51:35 2018 Received: (at control) by debbugs.gnu.org; 28 Mar 2018 19:51:35 +0000 Received: from localhost ([127.0.0.1]:57671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1H6d-0006MD-Dw for submit@debbugs.gnu.org; Wed, 28 Mar 2018 15:51:35 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1H6b-0006M5-Ki for control@debbugs.gnu.org; Wed, 28 Mar 2018 15:51:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1522266685; s=zoho; d=elephly.net; i=rekado@elephly.net; h=Date:To:From:Subject; l=21; bh=NpFESCjPnf7HmUBiVgWsexMmRMBi1XaOH/VXfGZtnls=; b=dsd1+IuHsFG8VG1+VpXpwZgMSiWI8pY2zOjJp8+L87SVk1EpHyYM4zasy8AgJrNB 8F1jocOLZnntVTR09/ydPnZ1x7owGDkrJzrCiQQewYRxCAKHsFTpFAxnphtlbHlmeMm D2nTTpZBibhP6Shuu5WVpTcJe20El98vveIFtSJc= Received: from localhost (port-92-200-78-30.dynamic.qsc.de [92.200.78.30]) by mx.zohomail.com with SMTPS id 1522266685822301.82284892491407; Wed, 28 Mar 2018 12:51:25 -0700 (PDT) Date: Wed, 28 Mar 2018 21:51:23 +0200 To: control@debbugs.gnu.org From: Ricardo Wurmus Subject: control message for bug #30894 X-ZohoMailClient: External X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: -0.0 (/) tags 30894 moreinfo From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 06:15:32 2018 Received: (at 30894) by debbugs.gnu.org; 29 Mar 2018 10:15:32 +0000 Received: from localhost ([127.0.0.1]:57978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1Uah-0003a7-DU for submit@debbugs.gnu.org; Thu, 29 Mar 2018 06:15:31 -0400 Received: from swecha.net ([136.243.177.181]:51016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1Uaf-0003Zy-4U for 30894@debbugs.gnu.org; Thu, 29 Mar 2018 06:15:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=swecha.net; s=default; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=hfGwxfC3OAX3K4c3EPRyJsewcPhbtK+KZG2xoO8BcMA=; b=G/KebSVRFVEOUQT+SNiLPeDJzx +xtmmZNmGtjwdWQejq3kd6uqSp7EzlEmT7CDGmesFsYMMtEz4VHi9lvpPbYpVKiay+9R+l7C7WZDA D6TSXisRICYfjvqf+VpLtFS7gwk9gXw0w+Eu0ZP3K+9+88VJqnezfAzdp0342HvltQsTEHJrhylna 5qprmLz7KiWZuDaarpOinPgcCZdf2wX8fxRyQohFiJap9YPlu/PU1Mu165vFfs69zi360ayzRkv5n HJc/pA11E8u/qikgykOZ7xBHTNixs5Echa/ULHo/x8joCN3T/JozYlPXmeVV9hmtGvsBS08PwGkPH nbhVFMRA==; Received: from [103.206.105.70] (port=43396 helo=[10.46.198.193]) by server.amistadraising.in with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1f1Uad-0048WG-3r; Thu, 29 Mar 2018 15:45:27 +0530 Subject: Re: [bug#30894] Submission of patch for Add r-abc To: Ricardo Wurmus References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> <87vadgdlyd.fsf@elephly.net> From: Sahithi Yarlagadda Message-ID: <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> Date: Thu, 29 Mar 2018 15:45:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87vadgdlyd.fsf@elephly.net> Content-Type: multipart/alternative; boundary="------------22CF07FF15739B868F03AF52" Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.amistadraising.in X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - swecha.net X-Get-Message-Sender-Via: server.amistadraising.in: authenticated_id: sahi@swecha.net X-Authenticated-Sender: server.amistadraising.in: sahi@swecha.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------22CF07FF15739B868F03AF52 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi Ricardo I have a small doubt regarding the build. Let me explain the process i am doing the build. 1) Cloning the Source 2) Running guix environment guix 3) ./bootstrap 4) ./configure --localstatedir=/var 5) make 6) Make Changes to the cran.scm file 7) Build using  ./pre-inst-env guix build 8) If build is success, format the patch and submit the patch *When i am planning to write a different package description, i am following this* 9) rebasing the patch 10) Pull for any changes 11) running the process from (2) Am i doing the right way, I hope i have to compile everytime and then make changes each Package Description. Because when i tired to just make changes and build on old one, i got many errors and warning saying the .go file is older than the .scm. Please suggest me. On Thursday 29 March 2018 01:14 AM, Ricardo Wurmus wrote: > Hi Sahiti, > > have you been able to look at my review below? > Please let me know if anything is unclear. > > ~~ Ricardo > > Ricardo Wurmus writes: > >> Hi Sahithi, >> >>> I am submitting a patch for r-abc. Please review. >> Thank you for the patch! >> >> What follows is a short review that includes things I could change >> myself before applying the patch, but for the sake of learning I >> explicitly point out in this message. I hope you don’t mind that I’m >> focusing on what may seem like minor details. >> >>> From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001 >>> From: Sahithi Yarlagadda >>> Date: Wed, 21 Mar 2018 16:30:18 +0530 >>> Subject: [PATCH] gnu: Add r-abc. >>> >>> * gnu/packages/cran.scm (r-abc): New variable. >> Nitpick: please don’t indent this line. The asterisk should be the >> first character in this line. >> >>> + >>> +(define-public r-abc >>> + (package >>> + (name "r-abc") >>> + (version "2.1") >>> + (source >>> + (origin >>> + (method url-fetch) >>> + (uri (cran-uri "abc" version)) >>> + (sha256 >>> + (base32 >>> + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) >>> + (build-system r-build-system) >>> + (propagated-inputs >>> + `(("r-abc-data" ,r-abc-data) >>> + ("r-locfit" ,r-locfit) >>> + ("r-mass" ,r-mass) >>> + ("r-nnet" ,r-nnet) >>> + ("r-quantreg" ,r-quantreg))) >>> + (home-page >>> + "http://cran.r-project.org/web/packages/abc") >> Please pull this onto the previous line and use “https”. >> >>> + (synopsis >>> + "Tools for approximate bayesian computation (ABC)") >> Please combine this line with the previous line. >> >>> + (description >>> + "Implements several ABC algorithms for performing parameter estimation, >>> +model selection, and goodness-of-fit. Cross-validation tools are also >>> +available for measuring the accuracy of ABC estimates, and to calculate the >>> +misclassification probabilities of different models.") >> Please use full sentences. For CRAN packages the official description >> usually provides only a sentence fragment in place of the first >> sentence. Please also use “@dfn{Approximate Bayesian Computation} >> (ABC)” the first time “ABC” is mentioned. >> >> All thoughout the indentation is a bit off (that’s expected as the >> importer is very simple and doesn’t know about the expected >> indentation). If you’re using Emacs you can easily adjust it with M-C-q >> (also known as “indent-sexp”); otherwise please use >> “etc/indent-code.el”. >> >> Have you built this package with Guix? >> >> Finally, please rebase this patch so that it can be applied >> independently from the other patch you’ve sent, which cannot currently >> be applied due to problems in building the defined package. Rebasing >> this patch ensures that it can be merged even if the other patch is >> stuck. >> >> Thanks! > > -- Regards Sahithi --------------22CF07FF15739B868F03AF52 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi Ricardo


I have a small doubt regarding the build. Let me explain the process i am doing the build.

1) Cloning the Source

2) Running guix environment guix

3) ./bootstrap

4) ./configure --localstatedir=/var

5) make

6) Make Changes to the cran.scm file

7) Build using  ./pre-inst-env guix build <package>

8) If build is success, format the patch and submit the patch

When i am planning to write a different package description, i am following this

9) rebasing the patch

10) Pull for any changes

11) running the process from (2)


Am i doing the right way, I hope i have to compile everytime and then make changes each Package Description. Because when i tired to just make changes and build on old one, i got many errors and warning saying the .go file is older than the .scm.


Please suggest me.


On Thursday 29 March 2018 01:14 AM, Ricardo Wurmus wrote:
Hi Sahiti,

have you been able to look at my review below?

Please let me know if anything is unclear.

~~ Ricardo

Ricardo Wurmus <rekado@elephly.net> writes:


Hi Sahithi,


I am submitting a patch for r-abc. Please review.

Thank you for the patch!

What follows is a short review that includes things I could change
myself before applying the patch, but for the sake of learning I
explicitly point out in this message.  I hope you don’t mind that I’m
focusing on what may seem like minor details.


From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001
From: Sahithi Yarlagadda <sahi@swecha.net>
Date: Wed, 21 Mar 2018 16:30:18 +0530
Subject: [PATCH] gnu: Add r-abc.

    * gnu/packages/cran.scm (r-abc): New variable.

Nitpick: please don’t indent this line.  The asterisk should be the
first character in this line.


+
+(define-public r-abc
+  (package
+    (name "r-abc")
+    (version "2.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "abc" version))
+        (sha256
+          (base32
+            "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb"))))
+    (build-system r-build-system)
+    (propagated-inputs
+      `(("r-abc-data" ,r-abc-data)
+        ("r-locfit" ,r-locfit)
+        ("r-mass" ,r-mass)
+        ("r-nnet" ,r-nnet)
+        ("r-quantreg" ,r-quantreg)))
+    (home-page
+      "http://cran.r-project.org/web/packages/abc")

Please pull this onto the previous line and use “https”.


+    (synopsis
+      "Tools for approximate bayesian computation (ABC)")

Please combine this line with the previous line.


+    (description
+      "Implements several ABC algorithms for performing parameter estimation,
+model selection, and goodness-of-fit.  Cross-validation tools are also
+available for measuring the accuracy of ABC estimates, and to calculate the
+misclassification probabilities of different models.")

Please use full sentences.  For CRAN packages the official description
usually provides only a sentence fragment in place of the first
sentence.  Please also use “@dfn{Approximate Bayesian Computation}
(ABC)” the first time “ABC” is mentioned.

All thoughout the indentation is a bit off (that’s expected as the
importer is very simple and doesn’t know about the expected
indentation).  If you’re using Emacs you can easily adjust it with M-C-q
(also known as “indent-sexp”); otherwise please use
“etc/indent-code.el”.

Have you built this package with Guix?

Finally, please rebase this patch so that it can be applied
independently from the other patch you’ve sent, which cannot currently
be applied due to problems in building the defined package.  Rebasing
this patch ensures that it can be merged even if the other patch is
stuck.

Thanks!





-- 
Regards
Sahithi
--------------22CF07FF15739B868F03AF52-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 06:33:27 2018 Received: (at 30894) by debbugs.gnu.org; 29 Mar 2018 10:33:27 +0000 Received: from localhost ([127.0.0.1]:57988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1Us3-000445-2e for submit@debbugs.gnu.org; Thu, 29 Mar 2018 06:33:27 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1Us2-00043x-2q for 30894@debbugs.gnu.org; Thu, 29 Mar 2018 06:33:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1522319548; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=1295; bh=ERBLKIIKsZ6+0QLOe84NjMcA0qzj1Me/NAFgDmtni+A=; b=HDJZWHCW6gsm+kFAeSzG+xcaoD76oCKfAwFFYfyuyYGu/kVALSJEvijFJp+ho6D2 zsDnGLBDEaFu9JOZDryJLGlG8PQHcQuM/s4VPfFqT8/AFu01Am9IEOrq4Mm449oeWce +GPL4gYv6MYyam2xsJh5x7LQ/aKrxTAoauQKpiiI= Received: from localhost (port-92-200-56-56.dynamic.qsc.de [92.200.56.56]) by mx.zohomail.com with SMTPS id 15223195488091006.1644343179897; Thu, 29 Mar 2018 03:32:28 -0700 (PDT) References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> <87vadgdlyd.fsf@elephly.net> <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus To: Sahithi Yarlagadda Subject: Re: [bug#30894] Submission of patch for Add r-abc In-reply-to: <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 29 Mar 2018 12:32:25 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87lgebdveu.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Sahithi, > 1) Cloning the Source > > 2) Running guix environment guix > > 3) ./bootstrap > > 4) ./configure --localstatedir=3D/var You need to perform these steps only once. > 5) make > > 6) Make Changes to the cran.scm file > > 7) Build using ./pre-inst-env guix build > > 8) If build is success, format the patch and submit the patch I suggest running make again after making changes to any file in the Guix source tree. This way you can avoid the =E2=80=9C.go file is older th= an the .scm=E2=80=9D messages. > *When i am planning to write a different package description, i am > following this* > > 9) rebasing the patch > > 10) Pull for any changes > > 11) running the process from (2) I=E2=80=99d do this instead: git fetch origin # fetch any upstream changes git stash # hide my uncommitted local changes git rebase origin/master # rebase my local commits on top of upstream git stash pop # apply my uncommitted local changes make # compile .scm to .go Note that you should be inside of a suitable environment when running =E2=80=9Cmake=E2=80=9D, so better do all of this after =E2=80=9Cguix enviro= nment guix=E2=80=9D. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 06:51:09 2018 Received: (at 30894) by debbugs.gnu.org; 29 Mar 2018 10:51:09 +0000 Received: from localhost ([127.0.0.1]:58001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1V9B-0004Sk-5A for submit@debbugs.gnu.org; Thu, 29 Mar 2018 06:51:09 -0400 Received: from swecha.net ([136.243.177.181]:38182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1V98-0004Sc-Uy for 30894@debbugs.gnu.org; Thu, 29 Mar 2018 06:51:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=swecha.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version :Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GTgfTX8DY4v6mwO4OcluvPdkWbs9hx4i2UlV/g9ZHA8=; b=GLdK47eyxg0QPRuhUmEsC0tNi8 vMKsHhBKaHyLM3AG5Ubi+afj1m3Wsi7d7QHO7kJg1DTPgqKDzsT/Uga7nkLe5ctaBu+qBfABhekX9 2pXT/pWURiNzeRl/bLrG/lgNA7dL7OXIyy5X3qibjCrHIXi6/MpU6TM7rhRJTaqbhIfKXoYTpkoC6 HW4L/UJJv/4y78ADvy+KUGFuXoRkmmO/4cCouDDHzNoCurvNB7DyMIMkwlqnxtDCqyDO27WFZiIR+ NgNoGNHfowF+OP5oH2zSEp6K9u89kMxJkSPQl5Wg10AqIkg46TVy+6xR/ufLHj+PoM8M46I+dZfZ1 cMrM8Meg==; Received: from [103.206.105.70] (port=9785 helo=[10.46.198.193]) by server.amistadraising.in with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1f1V97-004B0x-5p; Thu, 29 Mar 2018 16:21:05 +0530 Subject: Re: [bug#30894] Submission of patch for Add r-abc To: Ricardo Wurmus References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> <87vadgdlyd.fsf@elephly.net> <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> <87lgebdveu.fsf@elephly.net> From: Sahithi Yarlagadda Message-ID: Date: Thu, 29 Mar 2018 16:20:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <87lgebdveu.fsf@elephly.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.amistadraising.in X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - swecha.net X-Get-Message-Sender-Via: server.amistadraising.in: authenticated_id: sahi@swecha.net X-Authenticated-Sender: server.amistadraising.in: sahi@swecha.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks Ricardo When i am building r-abc  I found errors with the following.   (propagated-inputs      `(("r-abc-data" ,r-abc-data) abc.data is the upstream name of abc-data. I am figuring out how to use it. I have searched for various package description to compare the usage, but in vain. Can u help me what attribute is to be given to make it work. On Thursday 29 March 2018 04:02 PM, Ricardo Wurmus wrote: > Hi Sahithi, > >> 1) Cloning the Source >> >> 2) Running guix environment guix >> >> 3) ./bootstrap >> >> 4) ./configure --localstatedir=/var > You need to perform these steps only once. > >> 5) make >> >> 6) Make Changes to the cran.scm file >> >> 7) Build using ./pre-inst-env guix build >> >> 8) If build is success, format the patch and submit the patch > I suggest running make again after making changes to any file in the > Guix source tree. This way you can avoid the “.go file is older than > the .scm” messages. > >> *When i am planning to write a different package description, i am >> following this* >> >> 9) rebasing the patch >> >> 10) Pull for any changes >> >> 11) running the process from (2) > I’d do this instead: > > git fetch origin # fetch any upstream changes > git stash # hide my uncommitted local changes > git rebase origin/master # rebase my local commits on top of upstream > git stash pop # apply my uncommitted local changes > make # compile .scm to .go > > Note that you should be inside of a suitable environment when running > “make”, so better do all of this after “guix environment guix”. > > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > > > -- Regards Sahithi From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 07:00:57 2018 Received: (at 30894) by debbugs.gnu.org; 29 Mar 2018 11:00:57 +0000 Received: from localhost ([127.0.0.1]:58007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1VIf-0004hH-3p for submit@debbugs.gnu.org; Thu, 29 Mar 2018 07:00:57 -0400 Received: from swecha.net ([136.243.177.181]:49007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1VIc-0004h8-Ht for 30894@debbugs.gnu.org; Thu, 29 Mar 2018 07:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=swecha.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version :Date:Message-ID:References:Cc:To:From:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Vv25EhAfkDZD7x80wngOINTiMXy0/DsDAEvv3QyoRes=; b=c+6nCDVLOMS3KWHEsLEjHPFO0y aQYXsH2q2NWGQfXGoP1Q4RvPg3d/Bqzu7/7zAwYcgaF5O7NMgxGN1SZvjHjid66zkGt27zDh0uo9Z FVCpMJQRWiBlr1hZaKxV/Wlgv/AgzqUv72DrNDykKQgaCErw2cXwq+SCPrtPQsEJAvsVMmTGFrMlF 9k/XVomzMOEQxdab/2XWCk09Pkl8RP+/nTNvjBnUwP94mThgpRqdPER73ufgEOGFN0DTDqVTUeddX /AqSo8ndARA/GpQM2eo5euZjZRLVHzNK3SkNqkFMvPzntz9I3fQylBsAJcc7gch8zsf/8dxRKtLAB fJUKXz8Q==; Received: from [103.206.105.70] (port=51986 helo=[10.46.198.193]) by server.amistadraising.in with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1f1VIa-004BpV-RJ; Thu, 29 Mar 2018 16:30:53 +0530 Subject: Re: [bug#30894] Submission of patch for Add r-abc From: Sahithi Yarlagadda To: Ricardo Wurmus References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> <87vadgdlyd.fsf@elephly.net> <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> <87lgebdveu.fsf@elephly.net> Message-ID: <53d2dd04-03cd-4069-5aee-e4ff3d1f865d@swecha.net> Date: Thu, 29 Mar 2018 16:30:48 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.amistadraising.in X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - swecha.net X-Get-Message-Sender-Via: server.amistadraising.in: authenticated_id: sahi@swecha.net X-Authenticated-Sender: server.amistadraising.in: sahi@swecha.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi I am planning to do this. I will submit the Package Description for r-abc-data. Which builds and create a derivative in gnu/store. Later i will send the abc package description, where the build finds necessary data and does a successful build. On Thursday 29 March 2018 04:20 PM, Sahithi Yarlagadda wrote: > Thanks Ricardo > > When i am building r-abc  I found errors with the following. > >   (propagated-inputs >      `(("r-abc-data" ,r-abc-data) > > > abc.data is the upstream name of abc-data. I am figuring out how to use > it. I have searched for various package description to compare the > usage, but in vain. Can u help me what attribute is to be given to make > it work. > > > > On Thursday 29 March 2018 04:02 PM, Ricardo Wurmus wrote: >> Hi Sahithi, >> >>> 1) Cloning the Source >>> >>> 2) Running guix environment guix >>> >>> 3) ./bootstrap >>> >>> 4) ./configure --localstatedir=/var >> You need to perform these steps only once. >> >>> 5) make >>> >>> 6) Make Changes to the cran.scm file >>> >>> 7) Build using ./pre-inst-env guix build >>> >>> 8) If build is success, format the patch and submit the patch >> I suggest running make again after making changes to any file in the >> Guix source tree. This way you can avoid the “.go file is older than >> the .scm” messages. >> >>> *When i am planning to write a different package description, i am >>> following this* >>> >>> 9) rebasing the patch >>> >>> 10) Pull for any changes >>> >>> 11) running the process from (2) >> I’d do this instead: >> >> git fetch origin # fetch any upstream changes >> git stash # hide my uncommitted local changes >> git rebase origin/master # rebase my local commits on top of upstream >> git stash pop # apply my uncommitted local changes >> make # compile .scm to .go >> >> Note that you should be inside of a suitable environment when running >> “make”, so better do all of this after “guix environment guix”. >> >> -- >> Ricardo >> >> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC >> https://elephly.net >> >> >> -- Regards Sahithi From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 29 07:29:14 2018 Received: (at 30894) by debbugs.gnu.org; 29 Mar 2018 11:29:14 +0000 Received: from localhost ([127.0.0.1]:58044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1Vk0-0005PM-4f for submit@debbugs.gnu.org; Thu, 29 Mar 2018 07:29:12 -0400 Received: from swecha.net ([136.243.177.181]:34744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1Vjy-0005PE-De for 30894@debbugs.gnu.org; Thu, 29 Mar 2018 07:29:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=swecha.net; s=default; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID: References:Cc:To:From:Subject:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ex4ATF4ltXYfFlwEnFHL0fnhuPYo86PjnIrTwcJCK58=; b=Oqrch5Z/2azeQG2b47y6Sq3MCn BqkVMNclvEhEe4LxGIoRsxO12a+fA4ZaOG8XU4MANx6xw6O6kPjjcW3CBoPKU3CJBGUL+FbBXWvOw ZfxGV2Aqg7LLZZWDmy2evs75i56E5n5ILDbQHqVVDUwCnXf73hhAATSDqMWq9np3yWRUc4lrdE3LE h8vr1zjXTFNWmq75G3nOyGQwoKyKQCDcNSX0I8pGZkEJMoa4HG3nMzAR7MtaVW1FfC3hvOtvwR0pW lS6jdLyhnsKKgGE6QdqbcWVDGX1gS++CHX3FtJdQe2qe35pQXKz7KhjzETGZnMqeH5A0nfBSV/7Dx XKJXzxcA==; Received: from [103.206.105.70] (port=7441 helo=[10.46.198.193]) by server.amistadraising.in with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1f1Vjw-004Dpt-G6; Thu, 29 Mar 2018 16:59:08 +0530 Subject: Re: [bug#30894] Submission of patch for Add r-abc From: Sahithi Yarlagadda To: Ricardo Wurmus References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> <87vadgdlyd.fsf@elephly.net> <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> <87lgebdveu.fsf@elephly.net> <53d2dd04-03cd-4069-5aee-e4ff3d1f865d@swecha.net> Message-ID: <9fb9be96-8bc2-fd88-4528-0141cbdb323d@swecha.net> Date: Thu, 29 Mar 2018 16:58:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <53d2dd04-03cd-4069-5aee-e4ff3d1f865d@swecha.net> Content-Type: multipart/mixed; boundary="------------6604F6590555DBE1B083ACDB" Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.amistadraising.in X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - swecha.net X-Get-Message-Sender-Via: server.amistadraising.in: authenticated_id: sahi@swecha.net X-Authenticated-Sender: server.amistadraising.in: sahi@swecha.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894 Cc: 30894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------6604F6590555DBE1B083ACDB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Hi On Thursday 29 March 2018 04:30 PM, Sahithi Yarlagadda wrote: > Hi > > I am planning to do this. > > I will submit the Package Description for r-abc-data. Which builds and > create a derivative in gnu/store. Later i will send the abc package > description, where the build finds necessary data and does a successful > build. Submitted a Patch file for r-abc-data which is a dependency for r-abc http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30983 Then, Re-based the source git fetch origin # fetch any upstream changes git stash # hide my uncommitted local changes git rebase origin/master # rebase my local commits on top of upstream git stash pop # apply my uncommitted local changes make # compile .scm to .go I have done adding r-abc. And the build was success.  ( I am still unsure whether i did it right. Fingers Crossed !!!! ... Waiting for your comment) Its a great experience while learning with each contribution. Each Package Description have a different things to look into carefully and contribute. Ricardo have been of great help in this process. Created a Patch (I sense something's not right here!!!).  Submitting for the review. > > On Thursday 29 March 2018 04:20 PM, Sahithi Yarlagadda wrote: >> Thanks Ricardo >> >> When i am building r-abc  I found errors with the following. >> >>   (propagated-inputs >>      `(("r-abc-data" ,r-abc-data) >> >> >> abc.data is the upstream name of abc-data. I am figuring out how to use >> it. I have searched for various package description to compare the >> usage, but in vain. Can u help me what attribute is to be given to make >> it work. >> >> >> >> On Thursday 29 March 2018 04:02 PM, Ricardo Wurmus wrote: >>> Hi Sahithi, >>> >>>> 1) Cloning the Source >>>> >>>> 2) Running guix environment guix >>>> >>>> 3) ./bootstrap >>>> >>>> 4) ./configure --localstatedir=/var >>> You need to perform these steps only once. >>> >>>> 5) make >>>> >>>> 6) Make Changes to the cran.scm file >>>> >>>> 7) Build using ./pre-inst-env guix build >>>> >>>> 8) If build is success, format the patch and submit the patch >>> I suggest running make again after making changes to any file in the >>> Guix source tree. This way you can avoid the “.go file is older than >>> the .scm” messages. >>> >>>> *When i am planning to write a different package description, i am >>>> following this* >>>> >>>> 9) rebasing the patch >>>> >>>> 10) Pull for any changes >>>> >>>> 11) running the process from (2) >>> I’d do this instead: >>> >>> git fetch origin # fetch any upstream changes >>> git stash # hide my uncommitted local changes >>> git rebase origin/master # rebase my local commits on top of upstream >>> git stash pop # apply my uncommitted local changes >>> make # compile .scm to .go >>> >>> Note that you should be inside of a suitable environment when running >>> “make”, so better do all of this after “guix environment guix”. >>> >>> -- >>> Ricardo >>> >>> GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC >>> https://elephly.net >>> >>> >>> -- Regards Sahithi --------------6604F6590555DBE1B083ACDB Content-Type: text/x-patch; name="0001-gnu-Add-r-abc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gnu-Add-r-abc.patch" >From 0f248126c47882a0d8b866787577a7335de0a735 Mon Sep 17 00:00:00 2001 From: Sahithi Yarlagadda Date: Thu, 29 Mar 2018 16:42:18 +0530 Subject: [PATCH] gnu: Add r-abc. * gnu/packages/cran.scm (r-abc): New variable. --- gnu/packages/cran.scm | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 8602a7d87..70551507a 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -3593,3 +3593,32 @@ implements several @dfn{Approximate Bayesian Computation} (ABC) algorithms for performing parameter estimation, model selection, and goodness-of-fit.") (license license:gpl3))) +(define-public r-abc + (package + (name "r-abc") + (version "2.1") + (source + (origin + (method url-fetch) + (uri (cran-uri "abc" version)) + (sha256 + (base32 + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb")))) + (build-system r-build-system) + (propagated-inputs + `(("r-abc-data" ,r-abc-data) + ("r-locfit" ,r-locfit) + ("r-mass" ,r-mass) + ("r-nnet" ,r-nnet) + ("r-quantreg" ,r-quantreg))) + (home-page "https://cran.r-project.org/web/packages/abc") + (synopsis "Tools for approximate bayesian computation (ABC)") + (description + "Implements several @dfn{Approximate Bayesian Computation} (ABC) +algorithms for performing parameter estimation, model selection, and +goodness-of-fit. Cross-validation tools are also available for +measuring the accuracy of ABC estimates, and to calculate the +misclassification probabilities of different models.") + (license license:gpl3))) + + -- 2.16.2 --------------6604F6590555DBE1B083ACDB-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 02 17:27:14 2018 Received: (at 30894-done) by debbugs.gnu.org; 2 Apr 2018 21:27:14 +0000 Received: from localhost ([127.0.0.1]:35493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f36yw-0005sG-5H for submit@debbugs.gnu.org; Mon, 02 Apr 2018 17:27:14 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f36yu-0005s8-6Y for 30894-done@debbugs.gnu.org; Mon, 02 Apr 2018 17:27:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1522704374; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=452; bh=r53ZM4yEE9Xg+dolxxTITJdPM2xCFMKK5WaB6bYzTVw=; b=M4GkJ6l1dIX98stsCXSXgkJWj6lGpNnNd7o7TxeromlhZ/IZxU/b/eH1PUS2aDoG bOQyAamDfvh1A6PF04fe2R5HbZJxb7BjFn9gg/a1/8g9oum/kI8Yz9MBROieNsBJEJI rQM/JD9yvohGjP/DiMAkSeu1F2mia66AQ6a40+L8= Received: from localhost (port-92-200-100-9.dynamic.qsc.de [92.200.100.9]) by mx.zohomail.com with SMTPS id 1522704374384533.4909917714979; Mon, 2 Apr 2018 14:26:14 -0700 (PDT) References: <071fa29f-107d-2097-586c-ce2f1eb91c23@swecha.net> <87tvt9azl6.fsf@elephly.net> <87vadgdlyd.fsf@elephly.net> <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> <87lgebdveu.fsf@elephly.net> <53d2dd04-03cd-4069-5aee-e4ff3d1f865d@swecha.net> <9fb9be96-8bc2-fd88-4528-0141cbdb323d@swecha.net> User-agent: mu4e 1.0; emacs 25.3.1 From: Ricardo Wurmus To: Sahithi Yarlagadda Subject: Re: [bug#30894] Submission of patch for Add r-abc In-reply-to: <9fb9be96-8bc2-fd88-4528-0141cbdb323d@swecha.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 02 Apr 2018 23:26:11 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87woxpcnbg.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30894-done Cc: 30894-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Sahithi, > I have done adding r-abc. And the build was success. Excellent! I also built it without problems. I couldn=E2=80=99t apply it cleanly after making modifications to r-abc-dat= a, but that=E2=80=99s not your problem. I performed these minor changes: * changed license from gpl3 to gpl3+ * added a beginning to the description. Pushed the patch to the master branch with commit 82c8e0ae0. Thanks again! ~~ Ricardo From unknown Fri Jun 20 05:24:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 May 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator