Subject: Re: [bug#30894] Submission of patch for Add r-abc

From: Sahithi Yarlagadda <[email-masked]>
Date: Thu, 29 Mar 2018 16:58:59 +0530

Hi

On Thursday 29 March 2018 04:30 PM, Sahithi Yarlagadda wrote:
> Hi
>
> I am planning to do this.
>
> I will submit the Package Description for r-abc-data. Which builds and
> create a derivative in gnu/store. Later i will send the abc package
> description, where the build finds necessary data and does a successful
> build.

Submitted a Patch file for r-abc-data which is a dependency for r-abc

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30983

Then,
Re-based the source

    git fetch origin  # fetch any upstream changes
    git stash         # hide my uncommitted local changes
    git rebase origin/master # rebase my local commits on top of upstream
    git stash pop     # apply my uncommitted local changes
    make              # compile .scm to .go

I have done adding r-abc. And the build was success.

 ( I am still unsure whether i did it right. Fingers Crossed !!!! ...
Waiting for your comment)

Its a great experience while learning with each contribution. Each
Package Description have a different things to look into carefully and
contribute.

Ricardo have been of great help in this process.

Created a Patch (I sense something's not right here!!!). 
Submitting for the review.

>
> On Thursday 29 March 2018 04:20 PM, Sahithi Yarlagadda wrote:
>> Thanks Ricardo
>>
>> When i am building r-abc  I found errors with the following.
>>
>>   (propagated-inputs
>>      `(("r-abc-data" ,r-abc-data)
>>
>>
>> abc.data is the upstream name of abc-data. I am figuring out how to use
>> it. I have searched for various package description to compare the
>> usage, but in vain. Can u help me what attribute is to be given to make
>> it work.
>>
>>
>>
>> On Thursday 29 March 2018 04:02 PM, Ricardo Wurmus wrote:
>>> Hi Sahithi,
>>>
>>>> 1) Cloning the Source
>>>>
>>>> 2) Running guix environment guix
>>>>
>>>> 3) ./bootstrap
>>>>
>>>> 4) ./configure --localstatedir=/var
>>> You need to perform these steps only once.
>>>
>>>> 5) make
>>>>
>>>> 6) Make Changes to the cran.scm file
>>>>
>>>> 7) Build using ./pre-inst-env guix build <package>
>>>>
>>>> 8) If build is success, format the patch and submit the patch
>>> I suggest running make again after making changes to any file in the
>>> Guix source tree.  This way you can avoid the “.go file is older than
>>> the .scm” messages.
>>>
>>>> *When i am planning to write a different package description, i am
>>>> following this*
>>>>
>>>> 9) rebasing the patch
>>>>
>>>> 10) Pull for any changes
>>>>
>>>> 11) running the process from (2)
>>> I’d do this instead:
>>>
>>>     git fetch origin  # fetch any upstream changes
>>>     git stash         # hide my uncommitted local changes
>>>     git rebase origin/master # rebase my local commits on top of upstream
>>>     git stash pop     # apply my uncommitted local changes
>>>     make              # compile .scm to .go
>>>
>>> Note that you should be inside of a suitable environment when running
>>> “make”, so better do all of this after “guix environment guix”.
>>>
>>> --
>>> Ricardo
>>>
>>> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>>> https://elephly.net
>>>
>>>
>>>

-- 
Regards
Sahithi

>From 0f248126c47882a0d8b866787577a7335de0a735 Mon Sep 17 00:00:00 2001
From: Sahithi Yarlagadda <[email-masked]>
Date: Thu, 29 Mar 2018 16:42:18 +0530
Subject: [PATCH] gnu: Add r-abc.

* gnu/packages/cran.scm (r-abc): New variable.
---
 gnu/packages/cran.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 8602a7d87..70551507a 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -3593,3 +3593,32 @@ implements several @dfn{Approximate Bayesian Computation} (ABC) algorithms
 for performing parameter estimation, model selection, and goodness-of-fit.")
     (license license:gpl3)))
 
+(define-public r-abc
+  (package
+    (name "r-abc")
+    (version "2.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "abc" version))
+       (sha256
+        (base32
+         "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-abc-data" ,r-abc-data)
+       ("r-locfit" ,r-locfit)
+       ("r-mass" ,r-mass)
+       ("r-nnet" ,r-nnet)
+       ("r-quantreg" ,r-quantreg)))
+    (home-page "https://cran.r-project.org/web/packages/abc")
+    (synopsis "Tools for approximate bayesian computation (ABC)")
+    (description
+     "Implements several @dfn{Approximate Bayesian Computation} (ABC) 
+algorithms for performing parameter estimation, model selection, and 
+goodness-of-fit.  Cross-validation tools are also available for 
+measuring the accuracy of ABC estimates, and to calculate the
+misclassification probabilities of different models.")
+    (license license:gpl3)))
+
+
-- 
2.16.2