GNU bug report logs - #30887
27.0.50; fortune-message occupys two lines of height for one line message

Previous Next

Package: emacs;

Reported by: Xu Chunyang <mail <at> xuchunyang.me>

Date: Tue, 20 Mar 2018 19:16:02 UTC

Severity: minor

Found in version 27.0.50

Fixed in version 27.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Xu Chunyang <mail <at> xuchunyang.me>
Subject: bug#30887: closed (Re: bug#30887: 27.0.50; fortune-message
 occupys two lines of height for one line message)
Date: Wed, 21 Mar 2018 18:17:02 +0000

[Message part 1 (text/plain, inline)]
Your bug report

#30887: 27.0.50; fortune-message occupys two lines of height for one line message

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 30887 <at> debbugs.gnu.org.

-- 
30887: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30887
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 30887-done <at> debbugs.gnu.org
Subject: Re: bug#30887: 27.0.50;
 fortune-message occupys two lines of height for one line message
Date: Wed, 21 Mar 2018 14:16:10 -0400

Version: 27.1

commit 03a27fa
Date:   Wed Mar 21 14:10:05 2018 -0400

    * lisp/play/fortune.el (fortune-message):
    Avoid trailing newline.  (Bug#30887)

diff --git a/lisp/play/fortune.el b/lisp/play/fortune.el
index 74ace06..740f436 100644
--- a/lisp/play/fortune.el
+++ b/lisp/play/fortune.el
@@ -313,6 +313,8 @@ fortune-message
   (with-temp-buffer
     (let ((fortune-buffer-name (current-buffer)))
       (fortune-in-buffer t file)
+      ;; Avoid trailing newline.
+      (if (bolp) (delete-char -1))
       (message "%s" (buffer-string)))))
 
 ;;;###autoload


[Message part 3 (message/rfc822, inline)]
From: Xu Chunyang <mail <at> xuchunyang.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50;
 fortune-message occupys two lines of height for one line message
Date: Wed, 21 Mar 2018 03:14:44 +0800

For a very simple message such as "You now have Asian Flu.", M-x
fortune-message shows it in two lines of height

> You now have Asian Flu.
>

It is annoying because it changes the height of minibuffer/echo area.
The final newline is really unnecessary at least for message.
This bug report was last modified 7 years and 120 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.