From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 20 15:15:03 2018 Received: (at submit) by debbugs.gnu.org; 20 Mar 2018 19:15:03 +0000 Received: from localhost ([127.0.0.1]:44273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyMis-0003ks-SG for submit@debbugs.gnu.org; Tue, 20 Mar 2018 15:15:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyMir-0003k4-Dy for submit@debbugs.gnu.org; Tue, 20 Mar 2018 15:15:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyMil-00036v-I4 for submit@debbugs.gnu.org; Tue, 20 Mar 2018 15:14:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39164) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyMil-00036l-Ej for submit@debbugs.gnu.org; Tue, 20 Mar 2018 15:14:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyMik-0001bM-FG for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 15:14:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyMij-00035j-Ef for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 15:14:54 -0400 Received: from forward104p.mail.yandex.net ([2a02:6b8:0:1472:2741:0:8b7:107]:60944) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyMij-00034P-6O for bug-gnu-emacs@gnu.org; Tue, 20 Mar 2018 15:14:53 -0400 Received: from mxback10j.mail.yandex.net (mxback10j.mail.yandex.net [IPv6:2a02:6b8:0:1619::113]) by forward104p.mail.yandex.net (Yandex) with ESMTP id 3B30718533B for ; Tue, 20 Mar 2018 22:14:49 +0300 (MSK) Received: from smtp4j.mail.yandex.net (smtp4j.mail.yandex.net [2a02:6b8:0:1619::15:6]) by mxback10j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id QeDI3RLaZ1-En8iPp0N; Tue, 20 Mar 2018 22:14:49 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xuchunyang.me; s=mail; t=1521573289; bh=DGQ1d7BVQWaSUBynueO+VAMD/9N3AhEMWGWJl2ASFEk=; h=From:To:Subject:Date:Message-ID; b=EyOu/pSEkBOwtso4OX7njmQ3Z4h4WTp1MT984SW7H4+QLtIkHtsiC1hBbUV4dgKJi afHY3X+bmfqoic1JsY/zsiqgwkCutReU/BCcQ+pr9syHyUEBD6SqOu95BieDznsMbQ Hu36ccODopMrjUZtPpPclOuT9eM6T6a/SDEGAtSU= Received: by smtp4j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 2mYhsjwyQX-ElAuUuC3; Tue, 20 Mar 2018 22:14:48 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xuchunyang.me; s=mail; t=1521573288; bh=DGQ1d7BVQWaSUBynueO+VAMD/9N3AhEMWGWJl2ASFEk=; h=From:To:Subject:Date:Message-ID; b=H5xF9oIxYdvhd+8brtA0d+FpgJutv/OWX8c35K6xUFwMZuLcpiI0+JzQCT3MOlvNE axCsOn0AS9f7mkBXi/Cp/XyAYwZash7BzJRIBMMqkxkfO7yupzNU5X4vGepzylJZ02 BP2pqfhCaOPIMqVhHlry1C3zGSWI2aapJxTFkOMQ= Authentication-Results: smtp4j.mail.yandex.net; dkim=pass header.i=@xuchunyang.me From: Xu Chunyang To: bug-gnu-emacs@gnu.org Subject: 27.0.50; fortune-message occupys two lines of height for one line message Date: Wed, 21 Mar 2018 03:14:44 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) For a very simple message such as "You now have Asian Flu.", M-x fortune-message shows it in two lines of height > You now have Asian Flu. > It is annoying because it changes the height of minibuffer/echo area. The final newline is really unnecessary at least for message. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 21 14:16:19 2018 Received: (at 30887-done) by debbugs.gnu.org; 21 Mar 2018 18:16:19 +0000 Received: from localhost ([127.0.0.1]:46188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyiHb-0006BG-Cv for submit@debbugs.gnu.org; Wed, 21 Mar 2018 14:16:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyiHa-0006B5-66 for 30887-done@debbugs.gnu.org; Wed, 21 Mar 2018 14:16:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyiHT-0002SQ-Qy for 30887-done@debbugs.gnu.org; Wed, 21 Mar 2018 14:16:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyiHT-0002SL-Me for 30887-done@debbugs.gnu.org; Wed, 21 Mar 2018 14:16:11 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eyiHS-00038D-Uw; Wed, 21 Mar 2018 14:16:11 -0400 From: Glenn Morris To: 30887-done@debbugs.gnu.org Subject: Re: bug#30887: 27.0.50; fortune-message occupys two lines of height for one line message References: X-Spook: George W. Bush Fundamentalism White Powder USCOI Ansar X-Ran: @Zu;m)TD9IMM&Tm@4)k$k4FntapV&-26ZeReiouU}6\9/9t*?{a]Qc~wg~W)V@wEFdnjce X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 21 Mar 2018 14:16:10 -0400 In-Reply-To: (Xu Chunyang's message of "Wed, 21 Mar 2018 03:14:44 +0800") Message-ID: <2plgelcn11.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30887-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 27.1 commit 03a27fa Date: Wed Mar 21 14:10:05 2018 -0400 * lisp/play/fortune.el (fortune-message): Avoid trailing newline. (Bug#30887) diff --git a/lisp/play/fortune.el b/lisp/play/fortune.el index 74ace06..740f436 100644 --- a/lisp/play/fortune.el +++ b/lisp/play/fortune.el @@ -313,6 +313,8 @@ fortune-message (with-temp-buffer (let ((fortune-buffer-name (current-buffer))) (fortune-in-buffer t file) + ;; Avoid trailing newline. + (if (bolp) (delete-char -1)) (message "%s" (buffer-string))))) ;;;###autoload From unknown Fri Aug 15 17:19:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator