Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN package

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 21 Mar 2018 07:36:11 +0100

Hi Sahithi,

thanks for the patch!

> +
> +(define-public r-catdap
> +  (package
> +    (name "r-catdap")
> +    (version "1.3.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "catdap" version))
> +       (sha256
> +        (base32
> +         "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2"))))
> +    (build-system r-build-system)
> +    (home-page "https://cran.r-project.org/web/packages/catdap/")
> +    (synopsis "Categorical data analysis program package")
> +    (description
> +     "Categorical data analysis by AIC.  The methodology is described in
> +Sakamoto (1992) @url{https://www.springer.com/in/book/9780792314295}")

Please use full sentences in the description.  In this case I went to
the home page and downloaded the reference manual, which contains this
sentence:

    “This package provides functions for analyzing multivariate
     data. Dependencies of the distribution of specified variable
     (response variable) to other variables (explanatory variables) are
     derived and evaluated by AIC (Akaike Information Criterion).”

This is a better description based on that sentence:

    This package provides functions for analyzing multivariate data.
    Dependencies of the distribution of the specified variable (response
    variable) to other variables (explanatory variables) are derived and
    evaluated by the @dfn{Akaike Information Criterion} (AIC).

“@dfn” is used for definitions.

> +    ;; Any GPL version.
> +    (license license:gpl2+)))

The comment is incorrect.  The home page says:

    License:	GPL-2 | GPL-3 [expanded from: GPL (≥ 2)]

This means it is actually GPLv2+.

> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +

Please don’t add so many empty lines at the end :)

Could you please send an updated patch as a reply to this message?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net