GNU bug report logs - #30885
Submitting Patch File for r-catdap Package Description for CRAN package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30885 in the body.
You can then email your comments to 30885 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sahithi Yarlagadda <sahi <at> swecha.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Tue, 20 Mar 2018 22:18:31 +0530

[Message part 1 (text/plain, inline)]

Hi

Submitting the patch file for Creating Package Description for r-catdap
package under CRAN.

-- 
Regards
Sahithi

[0001-gnu-Add-r-catdap.patch (text/x-patch, attachment)]

Message #8 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Sahithi Yarlagadda <sahi <at> swecha.net>
Cc: 30885 <at> debbugs.gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Wed, 21 Mar 2018 07:36:11 +0100

Hi Sahithi,

thanks for the patch!

> +
> +(define-public r-catdap
> +  (package
> +    (name "r-catdap")
> +    (version "1.3.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "catdap" version))
> +       (sha256
> +        (base32
> +         "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2"))))
> +    (build-system r-build-system)
> +    (home-page "https://cran.r-project.org/web/packages/catdap/")
> +    (synopsis "Categorical data analysis program package")
> +    (description
> +     "Categorical data analysis by AIC.  The methodology is described in
> +Sakamoto (1992) @url{https://www.springer.com/in/book/9780792314295}")

Please use full sentences in the description.  In this case I went to
the home page and downloaded the reference manual, which contains this
sentence:

    “This package provides functions for analyzing multivariate
     data. Dependencies of the distribution of specified variable
     (response variable) to other variables (explanatory variables) are
     derived and evaluated by AIC (Akaike Information Criterion).”

This is a better description based on that sentence:

    This package provides functions for analyzing multivariate data.
    Dependencies of the distribution of the specified variable (response
    variable) to other variables (explanatory variables) are derived and
    evaluated by the @dfn{Akaike Information Criterion} (AIC).

“@dfn” is used for definitions.

> +    ;; Any GPL version.
> +    (license license:gpl2+)))

The comment is incorrect.  The home page says:

    License:	GPL-2 | GPL-3 [expanded from: GPL (≥ 2)]

This means it is actually GPLv2+.

> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +

Please don’t add so many empty lines at the end :)

Could you please send an updated patch as a reply to this message?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #11 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Sahithi Yarlagadda <sahi <at> swecha.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 30885 <at> debbugs.gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Wed, 21 Mar 2018 16:00:00 +0530

[Message part 1 (text/plain, inline)]

Hi

I resending the patch. Bear with my mistakes, im learning things.
Hopefully Ill make sure my next patch would be perfect.


On Wednesday 21 March 2018 12:06 PM, Ricardo Wurmus wrote:
> Hi Sahithi,
>
> thanks for the patch!
>
>> +
>> +(define-public r-catdap
>> +  (package
>> +    (name "r-catdap")
>> +    (version "1.3.4")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (cran-uri "catdap" version))
>> +       (sha256
>> +        (base32
>> +         "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2"))))
>> +    (build-system r-build-system)
>> +    (home-page "https://cran.r-project.org/web/packages/catdap/")
>> +    (synopsis "Categorical data analysis program package")
>> +    (description
>> +     "Categorical data analysis by AIC.  The methodology is described in
>> +Sakamoto (1992) @url{https://www.springer.com/in/book/9780792314295}")
> Please use full sentences in the description.  In this case I went to
> the home page and downloaded the reference manual, which contains this
> sentence:
>
>     “This package provides functions for analyzing multivariate
>      data. Dependencies of the distribution of specified variable
>      (response variable) to other variables (explanatory variables) are
>      derived and evaluated by AIC (Akaike Information Criterion).”
>
> This is a better description based on that sentence:
>
>     This package provides functions for analyzing multivariate data.
>     Dependencies of the distribution of the specified variable (response
>     variable) to other variables (explanatory variables) are derived and
>     evaluated by the @dfn{Akaike Information Criterion} (AIC).
>
> “@dfn” is used for definitions.
>
>> +    ;; Any GPL version.
>> +    (license license:gpl2+)))
> The comment is incorrect.  The home page says:
>
>     License:	GPL-2 | GPL-3 [expanded from: GPL (≥ 2)]
>
> This means it is actually GPLv2+.
>
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
>> +
> Please don’t add so many empty lines at the end :)
>
> Could you please send an updated patch as a reply to this message?
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>
>
>

-- 
Regards
Sahithi

[0001-gnu-Add-r-catdap.patch (text/x-patch, attachment)]

Message #14 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Sahithi Yarlagadda <sahi <at> swecha.net>
Cc: 30885 <at> debbugs.gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Wed, 21 Mar 2018 22:08:36 +0100

Hi Sahithi,

> I resending the patch. Bear with my mistakes, im learning things.
> Hopefully Ill make sure my next patch would be perfect.

Thank you for persevering :)

This looks a lot better, but I’ve just tried to build it and failed.
Have you tried building the package?

Looking at the error message can you figure out what might be wrong
here?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #17 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Sahithi Yarlagadda <sahi <at> swecha.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 30885 <at> debbugs.gnu.org, help-guix <at> gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Thu, 22 Mar 2018 19:05:53 +0530

Hi

I made changes to gnu/packages/cran.scm file and tried to build by
cloning the source and then

./bootstrap

./configure --localstatedir=/var

make

and then did this

./pre-inst-env guix build r-catdap

Got this error while building the package

starting phase `install'
* installing *source* package ?catdap? ...
** package ?catdap? successfully unpacked and MD5 sums checked
** libs
gfortran   -fpic  -g -O2  -c catdap1f.f -o catdap1f.o
/gnu/store/icz3hd36aqpjz5slyp4hhr8wsfbgiml1-bash-minimal-4.4.12/bin/bash:
gfortran: command not found
make: ***
[/gnu/store/af15vbzfw211mh278h3n2lbfrpxkps14-r-minimal-3.4.3/lib/R/etc/Makeconf:182:
catdap1f.o] Error 127
ERROR: compilation failed for package ?catdap?
* removing
?/gnu/store/amhlp36iaihivvcb1qddrbm8jfn55nyw-r-catdap-1.3.4/site-library/catdap?
phase `install' failed after 0.4 seconds
builder for
`/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv' failed
with exit code 1
@ build-failed
/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv - 1
builder for
`/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv' failed
with exit code 1
guix build: error: build failed: build of
`/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv' failed

Please help me resolve this.


On Thursday 22 March 2018 02:38 AM, Ricardo Wurmus wrote:
> Hi Sahithi,
>
>> I resending the patch. Bear with my mistakes, im learning things.
>> Hopefully Ill make sure my next patch would be perfect.
> Thank you for persevering :)
>
> This looks a lot better, but I’ve just tried to build it and failed.
> Have you tried building the package?
>
> Looking at the error message can you figure out what might be wrong
> here?
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>
>
>

-- 
Regards
Sahithi

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: julien lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: Re: [bug#30885] Submitting Patch File for r-catdap Package
 Description for CRAN package
Date: Thu, 22 Mar 2018 14:56:06 +0100

Hi Sahithi,

Le 2018-03-22 14:35, Sahithi Yarlagadda a écrit :
> Hi
> 
> I made changes to gnu/packages/cran.scm file and tried to build by
> cloning the source and then
> 
> ./bootstrap
> 
> ./configure --localstatedir=/var
> 
> make

Well done :)

> 
> and then did this
> 
> ./pre-inst-env guix build r-catdap
> 
> Got this error while building the package
> 
> starting phase `install'
> * installing *source* package ?catdap? ...
> ** package ?catdap? successfully unpacked and MD5 sums checked
> ** libs
> gfortran   -fpic  -g -O2  -c catdap1f.f -o catdap1f.o
> /gnu/store/icz3hd36aqpjz5slyp4hhr8wsfbgiml1-bash-minimal-4.4.12/bin/bash:
> gfortran: command not found
  ^^^^
This error comes from the build itself and tells you that gfortran is 
not
present in the build environment. Although I don't know why the error
happens only in the install phase, you probably need to add gfortran in
the list of native-inputs (native-inputs because gfortran is a compiler
and is (I think) not required at runtime).

> make: ***
> [/gnu/store/af15vbzfw211mh278h3n2lbfrpxkps14-r-minimal-3.4.3/lib/R/etc/Makeconf:182:
> catdap1f.o] Error 127
> ERROR: compilation failed for package ?catdap?
> * removing
> ?/gnu/store/amhlp36iaihivvcb1qddrbm8jfn55nyw-r-catdap-1.3.4/site-library/catdap?
> phase `install' failed after 0.4 seconds
> builder for
> `/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv' failed
> with exit code 1
> @ build-failed
> /gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv - 1
> builder for
> `/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv' failed
> with exit code 1
> guix build: error: build failed: build of
> `/gnu/store/v5l6i88p5xq8czgcnigwzwkcg9gz7qka-r-catdap-1.3.4.drv' failed
> 
> Please help me resolve this.
> 
> 
> On Thursday 22 March 2018 02:38 AM, Ricardo Wurmus wrote:
>> Hi Sahithi,
>> 
>>> I resending the patch. Bear with my mistakes, im learning things.
>>> Hopefully Ill make sure my next patch would be perfect.
>> Thank you for persevering :)
>> 
>> This looks a lot better, but I’ve just tried to build it and failed.
>> Have you tried building the package?
>> 
>> Looking at the error message can you figure out what might be wrong
>> here?
>> 
>> --
>> Ricardo
>> 
>> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>> https://elephly.net
>> 
>> 
>> 

Message #23 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Sahithi Yarlagadda <sahi <at> swecha.net>
Cc: 30885 <at> debbugs.gnu.org, help-guix <at> gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Thu, 22 Mar 2018 15:11:04 +0100

Hi Sahithi,

> ./pre-inst-env guix build r-catdap
>
> Got this error while building the package
>
> starting phase `install'
> * installing *source* package ?catdap? ...
> ** package ?catdap? successfully unpacked and MD5 sums checked
> ** libs
> gfortran -fpic -g -O2 -c catdap1f.f -o catdap1f.o
> /gnu/store/icz3hd36aqpjz5slyp4hhr8wsfbgiml1-bash-minimal-4.4.12/bin/bash:
> gfortran: command not found

It says that it couldn’t find gfortran.  That’s because the package
definition does not include gfortran among its (native-)inputs.

Try adding it.  Hint: there are other packages in cran.scm that use
gfortran.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #26 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Sahithi Yarlagadda <sahi <at> swecha.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 30885 <at> debbugs.gnu.org, help-guix <at> gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Thu, 22 Mar 2018 21:18:38 +0530

[Message part 1 (text/plain, inline)]

Hi Ricardo

The build was success after adding native input as gfortran.
Unfortunately it was not listed in the project website

https://cran.r-project.org/web/packages/catdap/


I am submitting the patch.



On Thursday 22 March 2018 07:41 PM, Ricardo Wurmus wrote:
> Hi Sahithi,
>
>> ./pre-inst-env guix build r-catdap
>>
>> Got this error while building the package
>>
>> starting phase `install'
>> * installing *source* package ?catdap? ...
>> ** package ?catdap? successfully unpacked and MD5 sums checked
>> ** libs
>> gfortran -fpic -g -O2 -c catdap1f.f -o catdap1f.o
>> /gnu/store/icz3hd36aqpjz5slyp4hhr8wsfbgiml1-bash-minimal-4.4.12/bin/bash:
>> gfortran: command not found
> It says that it couldn’t find gfortran.  That’s because the package
> definition does not include gfortran among its (native-)inputs.
>
> Try adding it.  Hint: there are other packages in cran.scm that use
> gfortran.
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>
>
>

-- 
Regards
Sahithi

[0001-gnu-Add-r-catdap.patch (text/x-patch, attachment)]

Message #29 received at 30885 <at> debbugs.gnu.org (full text, mbox):

From: Sahithi Yarlagadda <sahi <at> swecha.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 30885 <at> debbugs.gnu.org, help-guix <at> gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Sat, 24 Mar 2018 01:36:55 +0530

[Message part 1 (text/plain, inline)]

Hi

Submission of the patch was done. Can you merge this to the source. 


Regards

Sahithi


On Thursday 22 March 2018 09:18 PM, Sahithi Yarlagadda wrote:
> Hi Ricardo
>
> The build was success after adding native input as gfortran.
> Unfortunately it was not listed in the project website
>
> https://cran.r-project.org/web/packages/catdap/
>
>
> I am submitting the patch.
>
>
>
> On Thursday 22 March 2018 07:41 PM, Ricardo Wurmus wrote:
>> Hi Sahithi,
>>
>>> ./pre-inst-env guix build r-catdap
>>>
>>> Got this error while building the package
>>>
>>> starting phase `install'
>>> * installing *source* package ?catdap? ...
>>> ** package ?catdap? successfully unpacked and MD5 sums checked
>>> ** libs
>>> gfortran -fpic -g -O2 -c catdap1f.f -o catdap1f.o
>>> /gnu/store/icz3hd36aqpjz5slyp4hhr8wsfbgiml1-bash-minimal-4.4.12/bin/bash:
>>> gfortran: command not found
>> It says that it couldn’t find gfortran.  That’s because the package
>> definition does not include gfortran among its (native-)inputs.
>>
>> Try adding it.  Hint: there are other packages in cran.scm that use
>> gfortran.
>>
>> --
>> Ricardo
>>
>> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
>> https://elephly.net
>>
>>
>>

-- 
Regards
Sahithi

[0001-gnu-Add-r-catdap.patch (text/x-patch, attachment)]

Message #34 received at 30885-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Sahithi Yarlagadda <sahi <at> swecha.net>
Cc: 30885-done <at> debbugs.gnu.org
Subject: Re: Submitting Patch File for r-catdap Package Description for CRAN
 package
Date: Fri, 23 Mar 2018 21:57:39 +0100

Hi Sahithi,

thanks for the updated patch.  I’ve pushed it to the master branch with
commit 24fa6bcac after minor changes:

* fixed the indentation
* reworded the synopsis

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.