GNU bug report logs - #30872
incorrect byte-compile of closure called from local funcalled function

Previous Next

Full log

Message #29 received at 30872 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Aaron Jensen <aaronjensen <at> gmail.com>, 30872 <at> debbugs.gnu.org
Subject: Re: bug#30872: incorrect byte-compile of closure called from local
 funcalled function
Date: Mon, 11 Jun 2018 08:36:25 -0400

[Message part 1 (text/plain, inline)]

tags 30872 + patch
quit

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

> Looks sane, thank you.  Even better would be to try and share this code
> rather than duplicate it.  Please try and add some comment in the code,
> tho: it's rather dry (and yes, I know I'm largely to blame for it).

It seemed pretty okay to me; I was confused by the

    (if (assq arg env) (push `(,arg) env))

for a bit, so I added a mention of the nil case to the cconv-convert
docstring.

> Also don't forget to add a corresponding testcase.

Right, here it is.  Should this go to emacs-26?  It looks fairly safe to
me, but since I'm new to this code, I don't want to put too much weight
on my assessment.

[0001-Don-t-forget-to-analyse-args-of-lambda-lifted-functi.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.