From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 09:11:00 2018 Received: (at submit) by debbugs.gnu.org; 18 Mar 2018 13:11:01 +0000 Received: from localhost ([127.0.0.1]:39252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exY5U-0004fn-GN for submit@debbugs.gnu.org; Sun, 18 Mar 2018 09:11:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exY5S-0004fa-59 for submit@debbugs.gnu.org; Sun, 18 Mar 2018 09:10:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exY5L-0005w8-F1 for submit@debbugs.gnu.org; Sun, 18 Mar 2018 09:10:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57079) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1exY5L-0005w4-8e for submit@debbugs.gnu.org; Sun, 18 Mar 2018 09:10:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exY5J-0003E4-Gd for bug-gnu-emacs@gnu.org; Sun, 18 Mar 2018 09:10:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exY5F-0005qz-DC for bug-gnu-emacs@gnu.org; Sun, 18 Mar 2018 09:10:49 -0400 Received: from mail-it0-x231.google.com ([2607:f8b0:4001:c0b::231]:51832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exY5F-0005qR-3V for bug-gnu-emacs@gnu.org; Sun, 18 Mar 2018 09:10:45 -0400 Received: by mail-it0-x231.google.com with SMTP id j137-v6so30906ita.1 for ; Sun, 18 Mar 2018 06:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=A/He14mPB3Tll3L82qAq0V2IofhseW45Vw+zQ55Xp14=; b=e/pOTaRekLV2neiTwdbvaB/VrlKVhAo7p03Spsjk0Bl2l7IobhhmM94INa3wS2M3qQ 40M3nIilByoQ9150Eyeh8PZcL56akBviMn7ZV34QUkTuajQJ/LQD0FpI9pZVANC8Or8D xL3CAKb3MiDYtdQ7Yu+VBZwctKlce8t6F4Jo7rDJln7C5dsp0CB+mevx21DLP6lZ+Ld8 X7FJWXbxDxExmJJtZ2cLRMNtk6sTAiNiCNXen40Qdy5RH78obPQE3S42k+0UZbBkp1HB a+KaE+JGSPIWKK/RkdiQ/lexd7lmFZFW5T/hgIqB156paos+Bq9mXk5B7lL/Q6vEO17Q lZmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=A/He14mPB3Tll3L82qAq0V2IofhseW45Vw+zQ55Xp14=; b=Ja14nyKgbaEn0ogHJOBmtMk05F6npZ9t9KR2g/+EH88+DAQIVQwth3tBUFXVt+I3Tu GUhbvpVwdtzntsOjtB8ukfBmKIKTOgRey2Yv/qByKIC23+Y+ZuXs9alTiTzzCz5o0t12 Uowa3D/7sSkbvtwlH7f2JCfjQCme2jG9Iy7u2Tvn2bfJOTLOWXgmo0gAMyvqpbcjestg IuK8jCQrTh/s+KIlT5GESWZ/l1CLGCRfGzSjMaqxzsit8e01Dguai8CNoGtt9Uq8q7gr CT9f6C7Ai47q7pZQdeCWwOf/cYnq8pHbJuResMKYJFvLuJenCh89XK411x3VBBgwHqYY nfQA== X-Gm-Message-State: AElRT7Eh6jnH3+me+HpxbWhfVSbwvzniXAOdSKFVa1Ia//UffFtLLjAx 9z8C8vJdIyJPCzz26PLAmbSmsg== X-Google-Smtp-Source: AG47ELsPATdSwEEgTQLHmWWrw+j2p7X9MU7HSL6cMSgUrDTiloeF8Z76pg9OMV81fsfDAGexeH1jFg== X-Received: by 2002:a24:6c3:: with SMTP id 186-v6mr9474483itv.44.1521378644270; Sun, 18 Mar 2018 06:10:44 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u67sm1417331ioe.12.2018.03.18.06.10.42 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 06:10:43 -0700 (PDT) From: Noam Postavsky To: bug-gnu-emacs@gnu.org Subject: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Date: Sun, 18 Mar 2018 09:10:41 -0400 Message-ID: <87sh8xttpq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Evaluate the following from 'emacs -Q': (setq-local foo 1) ;; Simulate (debug-watch 'foo) + continue from *Backtrace* (add-variable-watcher 'foo (lambda (symbol newval operation where) (with-temp-buffer (kill-all-local-variables)))) (fundamental-mode) This results in ../../src/data.c:98: Emacs fatal error: assertion failed: found == !EQ (blv->defcell, blv->valcell) Backtrace attached. I guess it has something to do with the recursive `kill-all-local-variables' call, although I'm not familiar enough with the local variable machinery to say more about it. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=assert-fail-backtrace.log Content-Description: gdb backtrace #0 terminate_due_to_signal (sig=6, backtrace_limit=2147483647) at ../../src/emacs.c:364 #1 0x0000000000614655 in die (msg=0x75e788 "found == !EQ (blv->defcell, blv->valcell)", file=0x75e738 "../../src/data.c", line=98) at ../../src/alloc.c:7419 #2 0x0000000000614d5e in set_blv_found (blv=0x2e794b0, found=0) at ../../src/data.c:98 #3 0x0000000000619694 in Fmake_local_variable (variable=XIL(0xba4a0)) at ../../src/data.c:1963 #4 0x000000000063c8da in funcall_subr (subr=0xd750e0 , numargs=1, args=0x7fffffff9880) at ../../src/eval.c:2844 #5 0x000000000063c419 in Ffuncall (nargs=2, args=0x7fffffff9878) at ../../src/eval.c:2769 #6 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xaecfd4), vector=XIL(0xaecff5), maxdepth=make_number(5), args_template=XIL(0), nargs=0, args=0x0) at ../../src/bytecode.c:629 #7 0x000000000063d500 in funcall_lambda (fun=XIL(0xaecfa5), nargs=1, arg_vector=0xaecff5 ) at ../../src/eval.c:3052 #8 0x000000000063c45d in Ffuncall (nargs=2, args=0x7fffffff9d78) at ../../src/eval.c:2771 #9 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xaecd84), vector=XIL(0xaecda5), maxdepth=make_number(5), args_template=XIL(0), nargs=0, args=0x0) at ../../src/bytecode.c:629 #10 0x000000000063d500 in funcall_lambda (fun=XIL(0xaecd45), nargs=0, arg_vector=0xaecda5 ) at ../../src/eval.c:3052 #11 0x000000000063c45d in Ffuncall (nargs=1, args=0x7fffffffa298) at ../../src/eval.c:2771 #12 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xaed084), vector=XIL(0xaed0a5), maxdepth=make_number(1), args_template=XIL(0), nargs=0, args=0x0) at ../../src/bytecode.c:629 #13 0x000000000063d500 in funcall_lambda (fun=XIL(0xaed055), nargs=0, arg_vector=0xaed0a5 ) at ../../src/eval.c:3052 #14 0x000000000063c45d in Ffuncall (nargs=1, args=0x7fffffffa728) at ../../src/eval.c:2771 #15 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xaed314), vector=XIL(0xaed335), maxdepth=make_number(2), args_template=XIL(0), nargs=0, args=0x0) at ../../src/bytecode.c:629 #16 0x000000000063d500 in funcall_lambda (fun=XIL(0xaed2e5), nargs=0, arg_vector=0xaed335 ) at ../../src/eval.c:3052 #17 0x000000000063c45d in Ffuncall (nargs=1, args=0x7fffffffabd8) at ../../src/eval.c:2771 #18 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xaed634), vector=XIL(0xaed655), maxdepth=make_number(3), args_template=XIL(0), nargs=0, args=0x0) at ../../src/bytecode.c:629 #19 0x000000000063d500 in funcall_lambda (fun=XIL(0xaed605), nargs=0, arg_vector=0xaed655 ) at ../../src/eval.c:3052 #20 0x000000000063c45d in Ffuncall (nargs=1, args=0x7fffffffb148) at ../../src/eval.c:2771 #21 0x000000000063b6aa in funcall_nil (nargs=1, args=0x7fffffffb148) at ../../src/eval.c:2400 #22 0x000000000063bbb2 in run_hook_with_args (nargs=1, args=0x7fffffffb148, funcall=0x63b687 ) at ../../src/eval.c:2577 #23 0x000000000063b730 in Frun_hook_with_args (nargs=1, args=0x7fffffffb148) at ../../src/eval.c:2442 #24 0x000000000063bc43 in run_hook (hook=XIL(0x9f47b0)) at ../../src/eval.c:2590 #25 0x000000000063b6eb in Frun_hooks (nargs=1, args=0x7fffffffb298) at ../../src/eval.c:2424 #26 0x000000000063c7d3 in funcall_subr (subr=0xd77a60 , numargs=1, args=0x7fffffffb298) at ../../src/eval.c:2824 #27 0x000000000063c419 in Ffuncall (nargs=2, args=0x7fffffffb290) at ../../src/eval.c:2769 #28 0x000000000068d994 in exec_byte_code (bytestr=XIL(0x9ed45c), vector=XIL(0x9ed47d), maxdepth=make_number(5), args_template=make_number(128), nargs=0, args=0x7fffffffb790) at ../../src/bytecode.c:629 #29 0x000000000063d04a in funcall_lambda (fun=XIL(0x9ed42d), nargs=0, arg_vector=0x7fffffffb790) at ../../src/eval.c:2970 #30 0x000000000063c45d in Ffuncall (nargs=1, args=0x7fffffffb788) at ../../src/eval.c:2771 #31 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xa2bbac), vector=XIL(0xa9050d), maxdepth=make_number(1), args_template=make_number(0), nargs=0, args=0x7fffffffbbb0) at ../../src/bytecode.c:629 #32 0x000000000063d04a in funcall_lambda (fun=XIL(0xa904cd), nargs=0, arg_vector=0x7fffffffbbb0) at ../../src/eval.c:2970 #33 0x000000000063cc84 in apply_lambda (fun=XIL(0xa904cd), args=XIL(0), count=39) at ../../src/eval.c:2906 #34 0x000000000063ae85 in eval_sub (form=XIL(0x1756233)) at ../../src/eval.c:2279 #35 0x00000000006721fc in readevalloop_eager_expand_eval (val=XIL(0x1756233), macroexpand=XIL(0xd9ac0)) at ../../src/lread.c:1850 #36 0x0000000000672b7d in readevalloop (readcharfun=XIL(0x2e50995), infile0=0x0, sourcename=XIL(0x2eb84e4), printflag=false, unibyte=XIL(0), readfun=XIL(0), start=XIL(0), end=XIL(0)) at ../../src/lread.c:2036 #37 0x0000000000672f97 in Feval_buffer (buffer=XIL(0x2e50995), printflag=XIL(0), filename=XIL(0x3069604), unibyte=XIL(0), do_allow_print=XIL(0xc090)) at ../../src/lread.c:2103 #38 0x000000000063c9a0 in funcall_subr (subr=0xd7a4a0 , numargs=5, args=0x7fffffffbfd0) at ../../src/eval.c:2856 #39 0x000000000063c419 in Ffuncall (nargs=6, args=0x7fffffffbfc8) at ../../src/eval.c:2769 #40 0x000000000068d994 in exec_byte_code (bytestr=XIL(0x9fb57c), vector=XIL(0x9fb59d), maxdepth=make_number(6), args_template=XIL(0), nargs=0, args=0x0) at ../../src/bytecode.c:629 #41 0x000000000063d500 in funcall_lambda (fun=XIL(0x9fb4fd), nargs=4, arg_vector=0x9fb59d ) at ../../src/eval.c:3052 #42 0x000000000063c45d in Ffuncall (nargs=5, args=0x7fffffffc550) at ../../src/eval.c:2771 #43 0x000000000063be16 in call4 (fn=XIL(0x43abe0), arg1=XIL(0x3069604), arg2=XIL(0x3069604), arg3=XIL(0), arg4=XIL(0xc090)) at ../../src/eval.c:2645 #44 0x0000000000670c38 in Fload (file=XIL(0x3068ff4), noerror=XIL(0), nomessage=XIL(0xc090), nosuffix=XIL(0), must_suffix=XIL(0)) at ../../src/lread.c:1365 #45 0x000000000063c9a0 in funcall_subr (subr=0xd7a420 , numargs=3, args=0x7fffffffc938) at ../../src/eval.c:2856 #46 0x000000000063c419 in Ffuncall (nargs=4, args=0x7fffffffc930) at ../../src/eval.c:2769 #47 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xadcc2c), vector=XIL(0xadcc4d), maxdepth=make_number(23), args_template=make_number(257), nargs=1, args=0x7fffffffd298) at ../../src/bytecode.c:629 #48 0x000000000063d04a in funcall_lambda (fun=XIL(0xadcbfd), nargs=1, arg_vector=0x7fffffffd290) at ../../src/eval.c:2970 #49 0x000000000063c45d in Ffuncall (nargs=2, args=0x7fffffffd288) at ../../src/eval.c:2771 #50 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xad7424), vector=XIL(0xad7445), maxdepth=make_number(21), args_template=make_number(0), nargs=0, args=0x7fffffffdea8) at ../../src/bytecode.c:629 #51 0x000000000063d04a in funcall_lambda (fun=XIL(0xad73f5), nargs=0, arg_vector=0x7fffffffdea8) at ../../src/eval.c:2970 #52 0x000000000063c45d in Ffuncall (nargs=1, args=0x7fffffffdea0) at ../../src/eval.c:2771 #53 0x000000000068d994 in exec_byte_code (bytestr=XIL(0xad6614), vector=XIL(0xad6635), maxdepth=make_number(12), args_template=make_number(0), nargs=0, args=0x7fffffffe4d0) at ../../src/bytecode.c:629 #54 0x000000000063d04a in funcall_lambda (fun=XIL(0xad65e5), nargs=0, arg_vector=0x7fffffffe4d0) at ../../src/eval.c:2970 #55 0x000000000063cc84 in apply_lambda (fun=XIL(0xad65e5), args=XIL(0), count=4) at ../../src/eval.c:2906 #56 0x000000000063ae85 in eval_sub (form=XIL(0x149a8e3)) at ../../src/eval.c:2279 #57 0x000000000063a1fa in Feval (form=XIL(0x149a8e3), lexical=XIL(0)) at ../../src/eval.c:2054 #58 0x000000000058156a in top_level_2 () at ../../src/keyboard.c:1119 #59 0x0000000000638529 in internal_condition_case (bfun=0x581547 , handlers=XIL(0x5250), hfun=0x580f4c ) at ../../src/eval.c:1332 #60 0x00000000005815af in top_level_1 (ignore=XIL(0)) at ../../src/keyboard.c:1127 #61 0x0000000000637a32 in internal_catch (tag=XIL(0xc6f0), func=0x58156c , arg=XIL(0)) at ../../src/eval.c:1097 #62 0x0000000000581499 in command_loop () at ../../src/keyboard.c:1088 #63 0x0000000000580a36 in recursive_edit_1 () at ../../src/keyboard.c:695 #64 0x0000000000580c2b in Frecursive_edit () at ../../src/keyboard.c:766 #65 0x000000000057e7c6 in main (argc=4, argv=0x7fffffffea38) at ../../src/emacs.c:1713 Lisp Backtrace: "make-local-variable" (0xffff9880) "font-lock-default-function" (0xffff9d80) "font-lock-mode" (0xffffa2a0) "turn-on-font-lock" (0xffffa730) "turn-on-font-lock-if-desired" (0xffffabe0) "global-font-lock-mode-enable-in-buffers" (0xffffb150) "run-hooks" (0xffffb298) "run-mode-hooks" (0xffffb790) "fundamental-mode" (0xffffbbb0) "eval-buffer" (0xffffbfd0) "load-with-code-conversion" (0xffffc558) "load" (0xffffc938) "command-line-1" (0xffffd290) "command-line" (0xffffdea8) "normal-top-level" (0xffffe4d0) --=-=-= Content-Type: text/plain In GNU Emacs 26.0.91 (build 54, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2018-03-18 built on zebian Repository revision: 10bd3b3af8acfc226acadc654298865cffc19cc9 Configured using: 'configure --cache-file=../../debug-config.cache 'CC=ccache gcc' 'CFLAGS=-O0 -g3 -march=native' --enable-checking=yes --enable-check-lisp-object-type --with-x-toolkit=lucid --with-toolkit-scroll-bars --with-gif=no --with-jpeg=no' --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 10:05:42 2018 Received: (at 30846) by debbugs.gnu.org; 18 Mar 2018 14:05:42 +0000 Received: from localhost ([127.0.0.1]:40245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exYwP-0006Dg-R7 for submit@debbugs.gnu.org; Sun, 18 Mar 2018 10:05:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exYwO-0006DS-DO for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:05:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exYwF-0001O4-T3 for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:05:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exYwF-0001O0-Ok; Sun, 18 Mar 2018 10:05:31 -0400 Received: from [176.228.60.248] (port=4970 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1exYwF-0000hX-8z; Sun, 18 Mar 2018 10:05:31 -0400 Date: Sun, 18 Mar 2018 16:05:37 +0200 Message-Id: <838tappjgu.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87sh8xttpq.fsf@gmail.com> (message from Noam Postavsky on Sun, 18 Mar 2018 09:10:41 -0400) Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Sun, 18 Mar 2018 09:10:41 -0400 > > Evaluate the following from 'emacs -Q': > > (setq-local foo 1) > > ;; Simulate (debug-watch 'foo) + continue from *Backtrace* > (add-variable-watcher 'foo (lambda (symbol newval operation where) > (with-temp-buffer > (kill-all-local-variables)))) > (fundamental-mode) > > This results in > > ../../src/data.c:98: Emacs fatal error: assertion failed: found == !EQ (blv->defcell, blv->valcell) > > Backtrace attached. I guess it has something to do with the recursive > `kill-all-local-variables' call, although I'm not familiar enough with > the local variable machinery to say more about it. Do you mean that the inner call to kill-all-local-variables steps on toes of the outer call, and thus corrupts the local values or something? If so, do you see any signs of such a corruption? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 10:07:36 2018 Received: (at 30846) by debbugs.gnu.org; 18 Mar 2018 14:07:36 +0000 Received: from localhost ([127.0.0.1]:40249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exYyG-0006Gq-5y for submit@debbugs.gnu.org; Sun, 18 Mar 2018 10:07:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exYyE-0006Gc-Rg for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:07:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exYy6-00033f-Me for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:07:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exYy6-00033T-IK; Sun, 18 Mar 2018 10:07:26 -0400 Received: from [176.228.60.248] (port=4971 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1exYy6-00037S-17; Sun, 18 Mar 2018 10:07:26 -0400 Date: Sun, 18 Mar 2018 16:07:33 +0200 Message-Id: <837eq9pjdm.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87sh8xttpq.fsf@gmail.com> (message from Noam Postavsky on Sun, 18 Mar 2018 09:10:41 -0400) Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Sun, 18 Mar 2018 09:10:41 -0400 > > Evaluate the following from 'emacs -Q': > > (setq-local foo 1) > > ;; Simulate (debug-watch 'foo) + continue from *Backtrace* > (add-variable-watcher 'foo (lambda (symbol newval operation where) > (with-temp-buffer > (kill-all-local-variables)))) > (fundamental-mode) > > This results in > > ../../src/data.c:98: Emacs fatal error: assertion failed: found == !EQ (blv->defcell, blv->valcell) > > Backtrace attached. I guess it has something to do with the recursive > `kill-all-local-variables' call, although I'm not familiar enough with > the local variable machinery to say more about it. Do you mean that the inner call to kill-all-local-variables steps on toes of the outer call, and thus corrupts the local values or something? If so, do you see any signs of such a corruption? Because otherwise maybe the assertion is wrong? From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 10:21:04 2018 Received: (at 30846) by debbugs.gnu.org; 18 Mar 2018 14:21:04 +0000 Received: from localhost ([127.0.0.1]:40255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exZBI-0006cD-FB for submit@debbugs.gnu.org; Sun, 18 Mar 2018 10:21:04 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:37536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exZBG-0006bJ-4V for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:21:02 -0400 Received: by mail-it0-f49.google.com with SMTP id k79-v6so7256007ita.2 for <30846@debbugs.gnu.org>; Sun, 18 Mar 2018 07:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4iVNkg1Emji2m9MmIpJ/pMRNEhmax33z/m+/48J7BnM=; b=UY+6d/pE3tEAURInXqMh0RAqo/FxYPon3d0UQcZ7DaU9bwtYRy97GuTM7B3jbpL7Wz jVINQ2M0XPyiiCOHMSJ7BoE2pV+A8FJrzdc1PztMepkXL+F9LAlwFInOlVbeQGwrOJI/ sNace/SwtoFO6jWv+EkvGWggaQgNav03dJLoWijsefhM37RBHPEM3X3vHHO7grFvW6EU i3E+Q6KKEDHGNZXn8wTuy+ZBjpxeQhXKMTCwoX7XucsYOARYqaG3hwhlZW0X7cD0CNb0 PIY7JPxuaEmh4b5oQGlhZYUV+PWosfeKBnn9hXwlIxsA5Jc/ie/7NnRAlFjpOYfz2RnW 79Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4iVNkg1Emji2m9MmIpJ/pMRNEhmax33z/m+/48J7BnM=; b=DVsLg9172ier+1CGqLb5yme4X6JUjnPaFu+HdC2XSQGIGs85zCeG6UkJvbmTlnJUnC WoLWhHrlZs22feLSgYVPh5OdBfT9TcMXYODNr5e1IjvC6G9AdAdXgx3OZ+TgqHUqYo5u M8zG7UsfTQBjTzkGWUrAoHYbKo3RXOzf35QMtt5AGm4Lop7AVf8BTZ72tNQbI2NxzLZk GR+idrj2v4sisK2ZGKwQBt0dQM0eV8ISfiEIuMvSVwQuqOSJdEs+dMbaT8in62lrxpoy dCBd1qXZcpXO5ofGFdIb1IGfDbZ1c3VYRV9B4lSe/xzFS1WXnuQIpPyfuUKNG/gTDKhl 2oAQ== X-Gm-Message-State: AElRT7HgmZkUiW/NWos1MT11bYXUIHViy3IPEJWeS9kgL2RAYiuqilUV ogBkrk7TFEDU1lqlo6wGFL6kPQ== X-Google-Smtp-Source: AG47ELtA103BuIS+z9JUwWYn7HG5CED9tf40J6QaEl74txJdkOwDBSB0Tw7RD4a5aF/aWhvkPnktnA== X-Received: by 2002:a24:545:: with SMTP id 66-v6mr856166itl.1.1521382856311; Sun, 18 Mar 2018 07:20:56 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e142-v6sm2409181ite.3.2018.03.18.07.20.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Mar 2018 07:20:55 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> <837eq9pjdm.fsf@gnu.org> Date: Sun, 18 Mar 2018 10:20:54 -0400 In-Reply-To: <837eq9pjdm.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Mar 2018 16:07:33 +0200") Message-ID: <87po41tqgp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Sun, 18 Mar 2018 09:10:41 -0400 >> >> Evaluate the following from 'emacs -Q': >> >> (setq-local foo 1) >> >> ;; Simulate (debug-watch 'foo) + continue from *Backtrace* >> (add-variable-watcher 'foo (lambda (symbol newval operation where) >> (with-temp-buffer >> (kill-all-local-variables)))) >> (fundamental-mode) >> >> This results in >> >> ../../src/data.c:98: Emacs fatal error: assertion failed: found == !EQ (blv->defcell, blv->valcell) >> >> Backtrace attached. I guess it has something to do with the recursive >> `kill-all-local-variables' call, although I'm not familiar enough with >> the local variable machinery to say more about it. > > Do you mean that the inner call to kill-all-local-variables steps on > toes of the outer call, and thus corrupts the local values or > something? If so, do you see any signs of such a corruption? Because > otherwise maybe the assertion is wrong? No, I haven't seen any signs of corrupted values, though I'm not sure exactly where to look. It's possible the assertion is wrong (or more precisely, that the variable watcher breaks the assertion without breaking anything else). I don't really understand what the assertion is testing, at a high level (that is, why does it expect 'defcell' and 'valcell' to have that relation). From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 18 10:38:18 2018 Received: (at 30846) by debbugs.gnu.org; 18 Mar 2018 14:38:18 +0000 Received: from localhost ([127.0.0.1]:40268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exZRy-00071s-7B for submit@debbugs.gnu.org; Sun, 18 Mar 2018 10:38:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1exZRv-00071e-Rq for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exZRn-0004Rr-Dy for 30846@debbugs.gnu.org; Sun, 18 Mar 2018 10:38:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exZRn-0004Ra-A7; Sun, 18 Mar 2018 10:38:07 -0400 Received: from [176.228.60.248] (port=1106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1exZRm-0002Yn-OB; Sun, 18 Mar 2018 10:38:07 -0400 Date: Sun, 18 Mar 2018 16:38:13 +0200 Message-Id: <83605tphyi.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87po41tqgp.fsf@gmail.com> (message from Noam Postavsky on Sun, 18 Mar 2018 10:20:54 -0400) Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> <837eq9pjdm.fsf@gnu.org> <87po41tqgp.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Cc: 30846@debbugs.gnu.org > Date: Sun, 18 Mar 2018 10:20:54 -0400 > > I don't really understand what the assertion is testing, at a high > level (that is, why does it expect 'defcell' and 'valcell' to have > that relation). Yes, the 'found' member could use a better documentation. (Btw, all calls to set_blv_found seem to use the last argument of zero.) I hope Stefan can comment on this. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 20 20:48:59 2018 Received: (at 30846) by debbugs.gnu.org; 21 Mar 2018 00:49:00 +0000 Received: from localhost ([127.0.0.1]:44448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRw3-0002SX-NP for submit@debbugs.gnu.org; Tue, 20 Mar 2018 20:48:59 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:52405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyRw1-0002SI-V2 for 30846@debbugs.gnu.org; Tue, 20 Mar 2018 20:48:58 -0400 Received: by mail-it0-f51.google.com with SMTP id k135-v6so4798000ite.2 for <30846@debbugs.gnu.org>; Tue, 20 Mar 2018 17:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1rMtHfb0lFYolTPmW6Gp+z7ZZb5WX37C3KrHKUZ3gE8=; b=Xifk1vqRh2EWxiGw5z14lxSW/cgxSVNitLVmd158tTq+5N8LUWQWNonym20BUHVg1s fm1FWqfB2pjvnY8FH+hSh7BEfSMuKtDnjCoJ/FomNEkGwxCNL4N7VEthZNpPa1PLoofV AWwgZMsZn3u2eCswzG81/sZbGClDPZ4OlZVdzJNxiPPLQ7CcvHJPOPJv4BS2oh1M5/4f vBRMurCUoWRk+6AOofAI8hkFyizQlJ8PgElK22MEW8k2tddr1n7Lr6DhbOJnDDBC0ElT HImQ5C/ephRWEEsGC+kfO13yrih4SAkAxpd0aDwvjKrS1RdRsXY5gJaqj9RcmNWIUD2H ft7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1rMtHfb0lFYolTPmW6Gp+z7ZZb5WX37C3KrHKUZ3gE8=; b=MGmTV0IPJxcFboSe1o5fyfE3kTO8YOknSGHq+jT/G2eY/zcsIjakPjCR/uL2r7iHBO w/W2kNKBpgk4S15wAeilqHnAaH46lGd5ropzz2HE/vYPFDSAPVIPuugDts7x6sn9t9qH 0P4CWjxR8mWxdXhWT8K9hpT/8JzeLcWGcGNAhvvUqUsEWv3D/SDThAVUnQN8PsbN5mUR 9oqXBeUgHSZN2u3EbdqWfG+aZAY+ykOmQ2PH7g7zM1Fb1QAlaOr1V6wqXxr5EWIS9CCA iK3ly9mzr7tOdQ3MDMg/POAY30B4BXBl4zwM3jmwjAkENvsyQaULJZODhxm1w3S4gtZ0 pqmQ== X-Gm-Message-State: AElRT7GSwfqytboIdcTVz11enLePs1841JrJpqBegwDp1o7PAn7nwnxR qjqV3i6H3+y7btnHgx/3Ugg= X-Google-Smtp-Source: AG47ELttUB357ePBjK+ZJ5Rpwzj3F71UR30sjyB3fmxzUt+zPz7fYP0OjNhdGTCY1Ssy0e67rT+hQQ== X-Received: by 2002:a24:cec3:: with SMTP id v186-v6mr2061951itg.53.1521593332501; Tue, 20 Mar 2018 17:48:52 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d14-v6sm2006112iti.16.2018.03.20.17.48.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Mar 2018 17:48:51 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> <837eq9pjdm.fsf@gnu.org> <87po41tqgp.fsf@gmail.com> <83605tphyi.fsf@gnu.org> Date: Tue, 20 Mar 2018 20:48:50 -0400 In-Reply-To: <83605tphyi.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Mar 2018 16:38:13 +0200") Message-ID: <871sgetfrh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 30846 Cc: Stefan Monnier , 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: 30846@debbugs.gnu.org >> Date: Sun, 18 Mar 2018 10:20:54 -0400 >> >> I don't really understand what the assertion is testing, at a high >> level (that is, why does it expect 'defcell' and 'valcell' to have >> that relation). > > Yes, the 'found' member could use a better documentation. (Btw, all > calls to set_blv_found seem to use the last argument of zero.) > > I hope Stefan can comment on this. I'll add him to Cc then, I think he's not subscribed to the bug list. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 21 09:04:14 2018 Received: (at 30846) by debbugs.gnu.org; 21 Mar 2018 13:04:14 +0000 Received: from localhost ([127.0.0.1]:44983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eydPa-00059b-BW for submit@debbugs.gnu.org; Wed, 21 Mar 2018 09:04:14 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eydPZ-00059R-1k for 30846@debbugs.gnu.org; Wed, 21 Mar 2018 09:04:13 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2LD4AkH018620; Wed, 21 Mar 2018 09:04:10 -0400 Received: by pastel.home (Postfix, from userid 20848) id 03F2560477; Wed, 21 Mar 2018 09:04:10 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Message-ID: References: <87sh8xttpq.fsf@gmail.com> <837eq9pjdm.fsf@gnu.org> <87po41tqgp.fsf@gmail.com> <83605tphyi.fsf@gnu.org> <871sgetfrh.fsf@gmail.com> Date: Wed, 21 Mar 2018 09:04:09 -0400 In-Reply-To: <871sgetfrh.fsf@gmail.com> (Noam Postavsky's message of "Tue, 20 Mar 2018 20:48:50 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.3 X-NAI-Spam-Rules: 4 Rules triggered LNG_SB_1=0.2, GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6247=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6247> : inlines <6509> : streams <1781840> : uri <2612219> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30846 Cc: Eli Zaretskii , 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > I'll add him to Cc then, I think he's not subscribed to the bug list. Indeed, I'm not, thanks. I think there's a real bug in there (kill-local-variable may leave valcell pointing to the old (now used) cell), let me take a closer look. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 11:45:37 2018 Received: (at 30846) by debbugs.gnu.org; 22 Mar 2018 15:45:38 +0000 Received: from localhost ([127.0.0.1]:48033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez2PJ-0004rE-Dt for submit@debbugs.gnu.org; Thu, 22 Mar 2018 11:45:37 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:55406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez2PG-0004r4-9G for 30846@debbugs.gnu.org; Thu, 22 Mar 2018 11:45:35 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2MFjWu2006466; Thu, 22 Mar 2018 11:45:32 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1BAB5604C8; Thu, 22 Mar 2018 11:45:32 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Message-ID: References: <87sh8xttpq.fsf@gmail.com> Date: Thu, 22 Mar 2018 11:45:32 -0400 In-Reply-To: <87sh8xttpq.fsf@gmail.com> (Noam Postavsky's message of "Sun, 18 Mar 2018 09:10:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered LNG_SB_1=0.2, EDT_SA_DN_PASS=0, RV6248=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6248> : inlines <6514> : streams <1781946> : uri <2612879> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > This results in > > ../../src/data.c:98: Emacs fatal error: assertion failed: found == !EQ (blv->defcell, blv->valcell) OK, I found the culprit: in kill-all-local-variables, we first change all the (relevant) symbols to point to their global value (with swap_in_global_binding called from swap_out_buffer_local_variables), then go and kill them one by one (in reset_buffer_local_variables). This worked fine in the past, but now that we run watchers while we kill the vars, the act of running the watchers may undo the effect of swap_in_global_binding, so we can't kill them quite in the same way. The patch below against emacs-26 seems to fix the problem (it mostly merges the code of swap_out_buffer_local_variables into that of reset_buffer_local_variables so that the swap_in_global_binding is done just before we actually kill the var, with no opportunity for watchers to undo the effect). The patch doesn't only fix this problem, it also changes the time at which we run the watcher: in the current emacs-26 code, kill-all-local-variables runs the watcher *after* killing the corresponding var, whereas usually the watchers are run *before* the var is modified. I can split the patch into two, if you want and/or only apply the part that actually fixes this bug. If you feel this is too risky for emacs-26, I wouldn't blame you (this is pretty tricky code): while the assertion crashes Emacs, a normal build without assertions will likely not notice the problem at all. I came up with a test case that catches the problem, but I think that in "real" life it's very unlikely to cause a problem. It applies unchanged to master (and while looking at this bug I found a whole bunch of other minor changes that I plan to install into master anyway). Stefan diff --git a/src/buffer.c b/src/buffer.c index 9b54e4b778..b0cee71703 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -108,7 +108,6 @@ int last_per_buffer_idx; static void call_overlay_mod_hooks (Lisp_Object list, Lisp_Object overlay, bool after, Lisp_Object arg1, Lisp_Object arg2, Lisp_Object arg3); -static void swap_out_buffer_local_variables (struct buffer *b); static void reset_buffer_local_variables (struct buffer *, bool); /* Alist of all buffer names vs the buffers. This used to be @@ -991,10 +990,29 @@ reset_buffer_local_variables (struct buffer *b, bool permanent_too) else { Lisp_Object tmp, last = Qnil; + Lisp_Object buffer; + XSETBUFFER (buffer, b); + for (tmp = BVAR (b, local_var_alist); CONSP (tmp); tmp = XCDR (tmp)) { Lisp_Object local_var = XCAR (XCAR (tmp)); Lisp_Object prop = Fget (local_var, Qpermanent_local); + Lisp_Object sym = local_var; + + /* Watchers are run *before* modifying the var. */ + if (XSYMBOL (local_var)->u.s.trapped_write == SYMBOL_TRAPPED_WRITE) + notify_variable_watchers (local_var, Qnil, + Qmakunbound, Fcurrent_buffer ()); + + eassert (XSYMBOL (sym)->u.s.redirect == SYMBOL_LOCALIZED); + /* Need not do anything if some other buffer's binding is + now cached. */ + if (EQ (SYMBOL_BLV (XSYMBOL (sym))->where, buffer)) + { + /* Symbol is set up for this buffer's old local value: + swap it out! */ + swap_in_global_binding (XSYMBOL (sym)); + } if (!NILP (prop)) { @@ -1034,10 +1052,6 @@ reset_buffer_local_variables (struct buffer *b, bool permanent_too) bset_local_var_alist (b, XCDR (tmp)); else XSETCDR (last, XCDR (tmp)); - - if (XSYMBOL (local_var)->u.s.trapped_write == SYMBOL_TRAPPED_WRITE) - notify_variable_watchers (local_var, Qnil, - Qmakunbound, Fcurrent_buffer ()); } } @@ -1867,7 +1881,6 @@ cleaning up all windows currently displaying the buffer to be killed. */) won't be protected from GC. They would be protected if they happened to remain cached in their symbols. This gets rid of them for certain. */ - swap_out_buffer_local_variables (b); reset_buffer_local_variables (b, 1); bset_name (b, Qnil); @@ -2737,11 +2750,6 @@ the normal hook `change-major-mode-hook'. */) { run_hook (Qchange_major_mode_hook); - /* Make sure none of the bindings in local_var_alist - remain swapped in, in their symbols. */ - - swap_out_buffer_local_variables (current_buffer); - /* Actually eliminate all local bindings of this buffer. */ reset_buffer_local_variables (current_buffer, 0); @@ -2753,31 +2761,6 @@ the normal hook `change-major-mode-hook'. */) return Qnil; } -/* Make sure no local variables remain set up with buffer B - for their current values. */ - -static void -swap_out_buffer_local_variables (struct buffer *b) -{ - Lisp_Object oalist, alist, buffer; - - XSETBUFFER (buffer, b); - oalist = BVAR (b, local_var_alist); - - for (alist = oalist; CONSP (alist); alist = XCDR (alist)) - { - Lisp_Object sym = XCAR (XCAR (alist)); - eassert (XSYMBOL (sym)->u.s.redirect == SYMBOL_LOCALIZED); - /* Need not do anything if some other buffer's binding is - now cached. */ - if (EQ (SYMBOL_BLV (XSYMBOL (sym))->where, buffer)) - { - /* Symbol is set up for this buffer's old local value: - swap it out! */ - swap_in_global_binding (XSYMBOL (sym)); - } - } -} /* Find all the overlays in the current buffer that contain position POS. Return the number found, and store them in a vector in *VEC_PTR. diff --git a/test/src/data-tests.el b/test/src/data-tests.el index dda1278b6d..34637e4bfb 100644 --- a/test/src/data-tests.el +++ b/test/src/data-tests.el @@ -1,4 +1,4 @@ -;;; data-tests.el --- tests for src/data.c +;;; data-tests.el --- tests for src/data.c -*- lexical-binding:t -*- ;; Copyright (C) 2013-2018 Free Software Foundation, Inc. @@ -484,3 +484,20 @@ binding-test-some-local (remove-variable-watcher 'data-tests-lvar collect-watch-data) (setq data-tests-lvar 6) (should (null watch-data))))) + +(ert-deftest data-tests-kill-all-local-variables () ;bug#30846 + (with-temp-buffer + (setq-local data-tests-foo1 1) + (setq-local data-tests-foo2 2) + (setq-local data-tests-foo3 3) + (let ((oldfoo2 nil)) + (add-variable-watcher 'data-tests-foo2 + (lambda (&rest _) + (setq oldfoo2 (bound-and-true-p data-tests-foo2)))) + (kill-all-local-variables) + (should (equal oldfoo2 '2)) ;Watcher is run before changing the var. + (should (not (or (bound-and-true-p data-tests-foo1) + (bound-and-true-p data-tests-foo2) + (bound-and-true-p data-tests-foo3))))))) + +;;; data-tests.el ends here From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 11:53:35 2018 Received: (at 30846) by debbugs.gnu.org; 22 Mar 2018 15:53:35 +0000 Received: from localhost ([127.0.0.1]:48054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez2X1-00053b-Jo for submit@debbugs.gnu.org; Thu, 22 Mar 2018 11:53:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ez2X0-00053O-45 for 30846@debbugs.gnu.org; Thu, 22 Mar 2018 11:53:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ez2Wp-0004Sf-6O for 30846@debbugs.gnu.org; Thu, 22 Mar 2018 11:53:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ez2Wp-0004Sb-2o; Thu, 22 Mar 2018 11:53:23 -0400 Received: from [176.228.60.248] (port=4522 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ez2Wo-0005SA-Fr; Thu, 22 Mar 2018 11:53:22 -0400 Date: Thu, 22 Mar 2018 17:53:22 +0200 Message-Id: <83sh8shzt9.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Thu, 22 Mar 2018 11:45:32 -0400) Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30846 Cc: npostavs@gmail.com, 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Date: Thu, 22 Mar 2018 11:45:32 -0400 > Cc: 30846@debbugs.gnu.org > > If you feel this is too risky for emacs-26, I wouldn't blame you (this > is pretty tricky code): while the assertion crashes Emacs, a normal > build without assertions will likely not notice the problem at all. > I came up with a test case that catches the problem, but I think that in > "real" life it's very unlikely to cause a problem. > > It applies unchanged to master (and while looking at this bug I found > a whole bunch of other minor changes that I plan to install into master > anyway). I indeed prefer to install this on master, not on the release branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 20:20:22 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 00:20:22 +0000 Received: from localhost ([127.0.0.1]:48260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezARS-0005sE-Ct for submit@debbugs.gnu.org; Thu, 22 Mar 2018 20:20:22 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:38110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezARQ-0005s1-Vn for 30846@debbugs.gnu.org; Thu, 22 Mar 2018 20:20:21 -0400 Received: by mail-io0-f169.google.com with SMTP id b20so13145865iof.5 for <30846@debbugs.gnu.org>; Thu, 22 Mar 2018 17:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0OY3cyIufeP0+0ENLTCPg0u8fwNfbI/Y8fwtr8QVk2I=; b=bl8hd591JcLPB0FEu4qUvQqgX5y1qhuUsrnjN3FscqteM2ty2VZ9LzMCpzRiJmweu/ 74AUVirw3LV3l4grjYEA6ICUkUEhEtJY8rxeCmvaF/AliO60MAYWqQZB1rhMnGEUH4J6 iwjkmkHfj6PRcQGtcmBsRD99ovFDah37YKr1D6i6sTqTDt8mBvu3I2AG1C1D1MSvEslO JYXAjYZgvlky1FSm4ge139tR2nSzjtJQchLO42PV4vnK7639UN+3GJjucn00xaZd9JLW yh1JUEATjpZMlJyzAAoFZ1QT3y22NIEnQ6U6WgAZf/j91K31/zdUwzQL0sCghpK+Of03 xkMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0OY3cyIufeP0+0ENLTCPg0u8fwNfbI/Y8fwtr8QVk2I=; b=WKYsvrOWBnQe2GLzEdx4R2u+GXw4WNCZZMkKaZFpm7Bt16yvXH8INScX3d4r4Nfve0 wT+3tKEw/ZQ01Lu3/JaDeARW6EKpYHr7ykAacysJ52d9bFLIF4eBUYwr1WH4/RVp9K5f DTn+5ZcvBmaErp7kESxAEDW08vM5PIEk+0xw0ejD96X5Amjvj4hzGKGHH04Vl/bLsxDc ImIthJL69m16NhK67P/2le3Bmnz/splFG4+pIA0aY9M0j2W/pvx1krEmTrCjn4kN0EBp aDEz66zA7Y6M+bv8hoEEjNazlo/9PliAA/vH9gEbJKCy7z2d3NPdvMAK+tQVFzKDx5MU Ia+Q== X-Gm-Message-State: AElRT7Gbne1fmowWzdBlKyHHj7Rb3tQhmwULo+gi1NwYCNs6tHNgDtiD pJwwX++VEB2IfHu0re6ZDXbjTg== X-Google-Smtp-Source: AG47ELv0FNhVkWGLMxlmNfgrX1H4cKJ1P8EqyEhO70NUxyTN7UfwKUm2z0fQM91lvCC0zec2uK2/UQ== X-Received: by 10.107.29.84 with SMTP id d81mr29052176iod.59.1521764415237; Thu, 22 Mar 2018 17:20:15 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id q21-v6sm4961531itb.2.2018.03.22.17.20.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Mar 2018 17:20:14 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> Date: Thu, 22 Mar 2018 20:20:13 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 11:45:32 -0400") Message-ID: <87in9nskw2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > If you feel this is too risky for emacs-26, I wouldn't blame you (this > is pretty tricky code): while the assertion crashes Emacs, a normal > build without assertions will likely not notice the problem at all. > I came up with a test case that catches the problem, but I think that in > "real" life it's very unlikely to cause a problem. Should we disable the assertion in emacs-26 then? And would the diff below updating comments on struct Lisp_Buffer_Local_Value be correct? --- i/src/lisp.h +++ w/src/lisp.h @@ -2593,10 +2593,10 @@ XUSER_PTR (Lisp_Object a) variable, you must first make sure the right binding is loaded; then you can access the value in (or through) `realvalue'. - `buffer' and `frame' are the buffer and frame for which the loaded - binding was found. If those have changed, to make sure the right + `where' is the buffer for which the loaded + binding was found. If it has changed, to make sure the right binding is loaded it is necessary to find which binding goes with - the current buffer and selected frame, then load it. To load it, + the current buffer, then load it. To load it, first unload the previous binding, then copy the value of the new binding into `realvalue' (or through it). Also update LOADED-BINDING to point to the newly loaded binding. @@ -2615,14 +2615,14 @@ XUSER_PTR (Lisp_Object a) bool_bf found : 1; /* If non-NULL, a forwarding to the C var where it should also be set. */ union Lisp_Fwd *fwd; /* Should never be (Buffer|Kboard)_Objfwd. */ - /* The buffer or frame for which the loaded binding was found. */ + /* The buffer for which the loaded binding was found. */ Lisp_Object where; /* A cons cell that holds the default value. It has the form (SYMBOL . DEFAULT-VALUE). */ Lisp_Object defcell; /* The cons cell from `where's parameter alist. It always has the form (SYMBOL . VALUE) - Note that if `forward' is non-nil, VALUE may be out of date. + Note that if `fwd' is non-NULL, VALUE may be out of date. Also if the currently loaded binding is the default binding, then this is `eq'ual to defcell. */ Lisp_Object valcell; From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 22 21:22:22 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 01:22:22 +0000 Received: from localhost ([127.0.0.1]:48296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezBPS-0007HU-Ca for submit@debbugs.gnu.org; Thu, 22 Mar 2018 21:22:22 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezBPQ-0007HL-J7 for 30846@debbugs.gnu.org; Thu, 22 Mar 2018 21:22:21 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2N1MJIe017823; Thu, 22 Mar 2018 21:22:19 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 14AF36643F; Thu, 22 Mar 2018 21:22:19 -0400 (EDT) From: Stefan Monnier To: Noam Postavsky Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Message-ID: References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> Date: Thu, 22 Mar 2018 21:22:19 -0400 In-Reply-To: <87in9nskw2.fsf@gmail.com> (Noam Postavsky's message of "Thu, 22 Mar 2018 20:20:13 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered LNG_SB_1=0.2, EDT_SA_DN_PASS=0, RV6248=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6248> : inlines <6514> : streams <1781984> : uri <2613106> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > Should we disable the assertion in emacs-26 then? I don't have an opinion on this. > And would the diff below updating comments on struct > Lisp_Buffer_Local_Value be correct? Yes. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 04:12:27 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 08:12:27 +0000 Received: from localhost ([127.0.0.1]:48624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezHoJ-0000UM-Jq for submit@debbugs.gnu.org; Fri, 23 Mar 2018 04:12:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezHoH-0000UA-On for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 04:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezHo8-0001bk-Oj for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 04:12:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezHo8-0001bd-Kn; Fri, 23 Mar 2018 04:12:16 -0400 Received: from [176.228.60.248] (port=1527 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ezHo8-0002tX-4h; Fri, 23 Mar 2018 04:12:16 -0400 Date: Fri, 23 Mar 2018 11:12:18 +0300 Message-Id: <83muyzi525.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87in9nskw2.fsf@gmail.com> (message from Noam Postavsky on Thu, 22 Mar 2018 20:20:13 -0400) Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30846 Cc: monnier@IRO.UMontreal.CA, 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Thu, 22 Mar 2018 20:20:13 -0400 > Cc: 30846@debbugs.gnu.org > > Stefan Monnier writes: > > > If you feel this is too risky for emacs-26, I wouldn't blame you (this > > is pretty tricky code): while the assertion crashes Emacs, a normal > > build without assertions will likely not notice the problem at all. > > I came up with a test case that catches the problem, but I think that in > > "real" life it's very unlikely to cause a problem. > > Should we disable the assertion in emacs-26 then? Do we believe people build a production version with --enable-checking? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 08:25:30 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 12:25:31 +0000 Received: from localhost ([127.0.0.1]:48785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLlC-0000KB-H6 for submit@debbugs.gnu.org; Fri, 23 Mar 2018 08:25:30 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:40059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezLl8-0000Jt-7b for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 08:25:26 -0400 Received: by mail-io0-f182.google.com with SMTP id e79so14927291ioi.7 for <30846@debbugs.gnu.org>; Fri, 23 Mar 2018 05:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6xBpCLyZFRR9GAw8sc32JR6UmMTnhgRoSCqFBhHVqC8=; b=RiMc5ul+eaBde6crEHTYBQH95RRDW7/9GqdZK6ToMInDoPKmgNf+gq6jvfHLD+O8u7 GaJ1652Y4YqOjphMRpUk3bAkmtRSFH97xUwbTp0DxlgneedVGSRUVURsWVhSdm54akwx Bs456eF2iQPzp7YQbdvBzoSgpXRabOxHwqgiZlZSCcMvM0BfXxCKK24FcNsDmM2aOdCt AjlWgQVCfCdEJ13s48cvlW9ewKVJvh8i1bqFWiYJd23nbG7z27fBQBrHWPz1Fmx369GS 9eBajfyH8e1nhvkruAAH9gyDmskpVgw5MzimbRYgh2zdQKYtvTw1UmF51ctm4VDb+uFh lHjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6xBpCLyZFRR9GAw8sc32JR6UmMTnhgRoSCqFBhHVqC8=; b=aiS9s3WmP8yjAvz+0n2rLp94bNrhphSUC3I7YzvpdlccOkp9RlyycTnKsg4UwH7d2b zvDyZZs+WhfDoUN86NndOV9sWhTkpQtNkhxAbyeBMEIYqsQRi0okxbpjPOingTSrEmZ7 OaWLzgYoddAm78ABwx99Q4Xc7O+veHDUHFOxJmM1ZAtbyLBxXUyCr24ajEdQtM/tiMVo qpGmqKgejYOi63BIY7mRms7/SxgZxfcD3+0r77Gt1MVu20E/t01SNY5tNGj/xhz+dNNR RnTsjKwt/TUKnN/wuQCDt0kRQVklXa3KCCyQkxug6vCBsqLEd8Mg3RL8u4uL2uhXmeMK XmHg== X-Gm-Message-State: AElRT7F3YFl1Rchgo90mG2XV9qoOxgOL6E6ClmIxQFkJxgD/4USPADqu Ziz6i5D6wdts/7C+p85eIkkowA== X-Google-Smtp-Source: AG47ELv3zE0y/6r6GPotm135Lcklg+Liz+9EkX5rAbzz6vS0wyYJcrPpAJVE2LkDGxkmx/tSgBhEOw== X-Received: by 10.107.129.148 with SMTP id l20mr30123878ioi.140.1521807920763; Fri, 23 Mar 2018 05:25:20 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 199-v6sm7141929itl.1.2018.03.23.05.25.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Mar 2018 05:25:20 -0700 (PDT) From: Noam Postavsky To: Stefan Monnier Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> Date: Fri, 23 Mar 2018 08:25:19 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 21:22:19 -0400") Message-ID: <87y3ijq8r4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 30846 Cc: 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> And would the diff below updating comments on struct >> Lisp_Buffer_Local_Value be correct? > > Yes. Pushed to emacs-26 [1: b8ebf5fb64]. Eli Zaretskii writes: >> Should we disable the assertion in emacs-26 then? > Do we believe people build a production version with --enable-checking? Hmm, no, probably not. [1: b8ebf5fb64]: 2018-03-23 08:19:42 -0400 * src/lisp.h (struct Lisp_Buffer_Local_Value): Update commentary. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b8ebf5fb64dbf261315bfdb281a8b0a119e7cc2b From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 08:57:16 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 12:57:17 +0000 Received: from localhost ([127.0.0.1]:48803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezMFw-00031T-MY for submit@debbugs.gnu.org; Fri, 23 Mar 2018 08:57:16 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:41508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezMFv-00031L-0t for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 08:57:15 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2NCvDYu023075; Fri, 23 Mar 2018 08:57:13 -0400 Received: by pastel.home (Postfix, from userid 20848) id 74B4760223; Fri, 23 Mar 2018 08:57:13 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Message-ID: References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> <83muyzi525.fsf@gnu.org> Date: Fri, 23 Mar 2018 08:57:13 -0400 In-Reply-To: <83muyzi525.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Mar 2018 11:12:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 3 Rules triggered LNG_SB_1=0.2, EDT_SA_DN_PASS=0, RV6249=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6249> : inlines <6514> : streams <1782030> : uri <2613394> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30846 Cc: Noam Postavsky , 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> > If you feel this is too risky for emacs-26, I wouldn't blame you (this >> > is pretty tricky code): while the assertion crashes Emacs, a normal >> > build without assertions will likely not notice the problem at all. >> > I came up with a test case that catches the problem, but I think that in >> > "real" life it's very unlikely to cause a problem. >> Should we disable the assertion in emacs-26 then? > Do we believe people build a production version with --enable-checking? Does that mean you'd rather not install my patch into emacs-26 or are you still undecided? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 10:23:22 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 14:23:22 +0000 Received: from localhost ([127.0.0.1]:49841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNbG-0005HK-Je for submit@debbugs.gnu.org; Fri, 23 Mar 2018 10:23:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNbF-0005H8-Bi for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 10:23:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezNb6-0004uS-IW for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 10:23:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezNb6-0004uJ-Eb; Fri, 23 Mar 2018 10:23:12 -0400 Received: from [176.228.60.248] (port=2536 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ezNb5-0001Zk-UH; Fri, 23 Mar 2018 10:23:12 -0400 Date: Fri, 23 Mar 2018 17:23:14 +0300 Message-Id: <83605mj2gd.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 23 Mar 2018 08:57:13 -0400) Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> <83muyzi525.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 30846 Cc: npostavs@gmail.com, 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: Noam Postavsky , 30846@debbugs.gnu.org > Date: Fri, 23 Mar 2018 08:57:13 -0400 > > >> > If you feel this is too risky for emacs-26, I wouldn't blame you (this > >> > is pretty tricky code): while the assertion crashes Emacs, a normal > >> > build without assertions will likely not notice the problem at all. > >> > I came up with a test case that catches the problem, but I think that in > >> > "real" life it's very unlikely to cause a problem. > >> Should we disable the assertion in emacs-26 then? > > Do we believe people build a production version with --enable-checking? > > Does that mean you'd rather not install my patch into emacs-26 or are > you still undecided? I'm quite sure we shouldn't put this on emacs-26, I was just replying to Noam's suggestion to remove the assertion. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 10:42:04 2018 Received: (at 30846) by debbugs.gnu.org; 23 Mar 2018 14:42:04 +0000 Received: from localhost ([127.0.0.1]:49847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNtM-0005h3-8k for submit@debbugs.gnu.org; Fri, 23 Mar 2018 10:42:04 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:59862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezNtK-0005gt-KP for 30846@debbugs.gnu.org; Fri, 23 Mar 2018 10:42:02 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2NEg04T008069; Fri, 23 Mar 2018 10:42:00 -0400 Received: by pastel.home (Postfix, from userid 20848) id 46FD360223; Fri, 23 Mar 2018 10:42:00 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Message-ID: References: <87sh8xttpq.fsf@gmail.com> <87in9nskw2.fsf@gmail.com> <83muyzi525.fsf@gnu.org> <83605mj2gd.fsf@gnu.org> Date: Fri, 23 Mar 2018 10:42:00 -0400 In-Reply-To: <83605mj2gd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Mar 2018 17:23:14 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.3 X-NAI-Spam-Rules: 4 Rules triggered LNG_SB_1=0.2, GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6249=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6249> : inlines <6516> : streams <1782037> : uri <2613439> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30846 Cc: npostavs@gmail.com, 30846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> Does that mean you'd rather not install my patch into emacs-26 or are >> you still undecided? > I'm quite sure we shouldn't put this on emacs-26, I was just replying > to Noam's suggestion to remove the assertion. OK, thanks, I'll prepare my patch for master, then. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 11:29:59 2018 Received: (at 30846-done) by debbugs.gnu.org; 23 Mar 2018 15:29:59 +0000 Received: from localhost ([127.0.0.1]:49910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezOdj-0006mt-Mf for submit@debbugs.gnu.org; Fri, 23 Mar 2018 11:29:59 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:42629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ezOdh-0006ml-Jj for 30846-done@debbugs.gnu.org; Fri, 23 Mar 2018 11:29:57 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2NFTtqv017892; Fri, 23 Mar 2018 11:29:56 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5EF5D60223; Fri, 23 Mar 2018 11:29:55 -0400 (EDT) From: Stefan Monnier To: 30846-done@debbugs.gnu.org Subject: Re: bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' Message-ID: References: <87sh8xttpq.fsf@gmail.com> Date: Fri, 23 Mar 2018 11:29:55 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 22 Mar 2018 11:45:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.3 X-NAI-Spam-Rules: 4 Rules triggered LNG_SB_1=0.2, GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6249=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6249> : inlines <6516> : streams <1782040> : uri <2613459> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 30846-done Cc: Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Version: 27.1 > The patch doesn't only fix this problem, it also changes the time at > which we run the watcher: in the current emacs-26 code, Installed into master, Stefan From unknown Fri Jun 13 06:12:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 04 05:21:54 2018 Received: (at control) by debbugs.gnu.org; 4 Jun 2018 09:21:54 +0000 Received: from localhost ([127.0.0.1]:60860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPlgY-0000FF-DY for submit@debbugs.gnu.org; Mon, 04 Jun 2018 05:21:54 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:34769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPlgX-0000F2-LK for control@debbugs.gnu.org; Mon, 04 Jun 2018 05:21:53 -0400 Received: by mail-it0-f54.google.com with SMTP id y127-v6so9832208itd.1 for ; Mon, 04 Jun 2018 02:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=kuqcw+eVA2C2Dc+sqA1a6LhpDpbZTyBb96L8cBsMfpA=; b=Ujk6gA//BEOMKVTB72eAGDjv5ZObFw2m5yCa061eqg1f2Tu+GYh0blzmLC7l0GcrrS UCBGwSks1L7fUnlyU/zU/uqqTc8zy4nn0ppnbkU/+a+4IVw2jjrUhkKekPP+61n40dP7 ZEBkJNZW7i7iIOYTIxkN/1AOORS+YXBGbJid28DHVGxSm+4UY0nWCUXlv3aM/tPo6ynJ RrcchvOKn70PIGUt8A2D2MNvMGueXqIJIigu22hQNL3vRec6ZBtGFKJ0kA8Wz9ENNZ8i hgHS2kanAyXuX+CJg4wh6qcFwuUm3o0XtIo8129ImY9+1Vb+32lkyJUTDjvtGkEedywy sYAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=kuqcw+eVA2C2Dc+sqA1a6LhpDpbZTyBb96L8cBsMfpA=; b=EMH6Q056c2Bh1lXslSSoL4xFmbON2TZmAwW2cZDuGXPeD6gly9l4YU2DzlRW9AHJp8 si/LH9UCfHG1ysUILheNbrFSlmAN7++wBgpesTynbd34YPjCBm7DObHyKijSGGx35SqN m14ACw/GCfJzRX4kWQ7+27ZqOtHWMJ+Aj6hPu+uOqf+CZ6tESofn0fFPYWkGs3D2A2wZ 1j95CrXu67ZrHnznJxrADGfvYfhHEPwdf85Z8tR1BKU8yr6WRC/poyXCKtEd7FgKzLL2 SOtWY1UNFlXRXS7RDbw5QPsUR2cIWtW7v+09YthoyPv+TaT4rEEAVP/vuCfFRhDuLv5X eP9A== X-Gm-Message-State: ALKqPwdrx91mQvAK6+B9vzwhjxr24iiWDQuYKtS+yttNRGkVFmWGCB3a WiQ0LfrjliWmN2lZZPMK1alB/A== X-Google-Smtp-Source: ADUXVKL1s1JzpRyksr02DKBTkec7Fpjk6a5wacrr4NZZpTWvoM2+bQOKdIE11XmUzwGFO8h5mQ/3YA== X-Received: by 2002:a24:4563:: with SMTP id y96-v6mr13638496ita.112.1528104107828; Mon, 04 Jun 2018 02:21:47 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y33-v6sm4280568ita.24.2018.06.04.02.21.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 02:21:47 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for 26.2 backports Date: Mon, 04 Jun 2018 05:21:46 -0400 Message-ID: <87h8mi9aad.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # [1: 9a14b4d1ce]: 2018-06-03 12:55:40 -0400 # ; Merge: backports from master # https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9a14b4d1ce84e5e0739572729670b8f10d234097 unarchve 30931 fixed 30931 26.2 unarchve 30995 fixed 30995 26.2 unarchve 27656 fixed 27656 26.2 unarchve 30846 fixed 30846 26.2 unarchve 31146 fixed 31146 26.2 unarchve 30363 fixed 30363 26.2 unarchve 28323 fixed 28323 26.2 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 04 05:27:14 2018 Received: (at control) by debbugs.gnu.org; 4 Jun 2018 09:27:14 +0000 Received: from localhost ([127.0.0.1]:60865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPlli-0000Oh-0T for submit@debbugs.gnu.org; Mon, 04 Jun 2018 05:27:14 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:39257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPllg-0000OT-Lm for control@debbugs.gnu.org; Mon, 04 Jun 2018 05:27:13 -0400 Received: by mail-it0-f44.google.com with SMTP id p185-v6so4938369itp.4 for ; Mon, 04 Jun 2018 02:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=ZoBoLN/ncQpSLxaQ8mitAzLDNsJCRKB58uNvdiGDnr8=; b=qKxOMVZSweXX1WjBUIpDN+5X9lOrmPEVdUzKt0/O5FMw4Ad8jcNJRbliibpuHvpc/R R2OLjkr+54135Llg5Gf0lLf2TTX/O6MpHw7QQl1aJHqrxeMpwYlBTbqzUSjtYPSUNIrs c49I7xZIT/LI/U8oTCGgT4SzYF+LfkAtEmcdQB8b9jP66JPzyA58ZR2Xvf6gmXi2SD8p gUsHEI8WEOYCr4kjiUsq9NjqRCTma/zwZ0azuGP2JszKhUoTsytF92J3JfQOg0Ue7x7D gTOq4+Cqh7jzHn1gb01gQJRWVh2LG9Cu6WLt5yppZFNWQbPPC7L6UQ1D5dFlR3aptm0e NMBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ZoBoLN/ncQpSLxaQ8mitAzLDNsJCRKB58uNvdiGDnr8=; b=QgyAeQZ0Jih7K1+5JczEipF3ccftwxLLop8BGJIQTvG3ImSQ8WxgvmiegCzORDGw9b XhDJ5pw/wnlsii+XT8BhkNvvl/Qoub+o5AnUTzN75hP0699nCj4mum/u9yJxldKcm9U9 aweiwy6CvEBo3aY/SrVbGZIinOzQNytzIY3WXm+Cf6zohq113Atfa5oNB0O1JAZq3dlT yKPZTXRxCS5XB7rhwcWnYT1bhMlO2L0pvPKR63f2+EYdHu4LHNv96EdAy3RBN+7s9VWw K4VO6Uq7LMGgSanysM1ei01Y+Zjmx5D9z3Yva3As+ydw0HNBuhVB3dcE4tiC4o7AxN8a /qgg== X-Gm-Message-State: APt69E1n5nMClEGgYGzzFDaBKE+y3QONUahMky2kGDJbEXQYJOBjAHDc 6oQ1TweVV6Zi2WbADA2UXnZ/8A== X-Google-Smtp-Source: ADUXVKL2T7Nrl44pZAxmERwdnAi4prpbWayjWRoe6wzZZUeoPhXPTlnPbbqehtdsqZE6tJCOhK317g== X-Received: by 2002:a24:e84:: with SMTP id 126-v6mr13384571ite.148.1528104426970; Mon, 04 Jun 2018 02:27:06 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i76-v6sm4005634ita.33.2018.06.04.02.27.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 02:27:06 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for 26.2 backports (2nd try) Date: Mon, 04 Jun 2018 05:27:05 -0400 Message-ID: <87fu229a1i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # [1: 9a14b4d1ce]: 2018-06-03 12:55:40 -0400 # ; Merge: backports from master # https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9a14b4d1ce84e5e0739572729670b8f10d234097 unarchive 30931 fixed 30931 26.2 unarchive 30995 fixed 30995 26.2 unarchive 27656 fixed 27656 26.2 unarchive 30846 fixed 30846 26.2 unarchive 31146 fixed 31146 26.2 unarchive 30363 fixed 30363 26.2 unarchive 28323 fixed 28323 26.2 quit From unknown Fri Jun 13 06:12:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 02 Jul 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator