Subject: Re: [bug#30845] [PATCH 08/82] gnu: Add java-jakarta-oro.

From: Björn Höfling <[email-masked]>
Date: Tue, 20 Mar 2018 19:13:02 +0100

On Sun, 18 Mar 2018 14:05:28 +0100
Julien Lepiller <[email-masked]> wrote:

> * gnu/packages/java.scm (java-jakarta-oro): New variable.
> ---
>  gnu/packages/java.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 0ee4ade95..37eeda0a6 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -9515,3 +9515,35 @@ different file systems.  It presents a uniform
> view of the files from various different sources, such as the files
> on local disk, on an HTTP server, or inside a Zip archive.")
>      (license license:asl2.0)))
> +
> +(define-public java-jakarta-oro
> +  (package
> +    (name "java-jakarta-oro")
> +    (version "2.0.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "https://archive.apache.org/dist/jakarta/oro/"
> +                                  "jakarta-oro-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "0rpmnsskiwmsy8r0sckz5n5dbvh3vkxx8hpm177c754r8xy3qksc"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:build-target "package"
> +       #:tests? #f; tests are run as part of the build process
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'remove-bin
> +           (lambda _
> +             (delete-file (string-append "jakarta-oro-" ,version
> ".jar"))))

This needs to be a snippet, not part of a phase. Only then the
binaries/jars are removed from the result of "guix build -S".

[..]

> +    (license license:asl2.0)))

File "LICENSE" and some  example java-files I checked say it's ASL 1.1.

Otherwise, LGTM.

Björn