GNU bug report logs - #30833
[PATCH] git-download: Fix recursive checkouts.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30833 in the body.
You can then email your comments to 30833 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] git-download: Fix recursive checkouts.
Date: Thu, 15 Mar 2018 23:28:07 -0500

[Message part 1 (text/plain, inline)]

Hello Guix,

The attached patch fixes a regression in recursive git checkouts of
package source, which I believe was introduced in
6dff905e51202bbdebbad8811b6509584d12a796 (2017-09-05!)

This would have only affected 6 packages:

scheme@(guile-user)> (format #t "~{~a~%~}"
  (fold-packages
   (lambda (p r) 
     (if (and=> (package-source p)
                (lambda (s) 
                  (and (git-reference? (origin-uri s))
                       (git-reference-recursive? (origin-uri s))))) 
       (cons p r)
       r))
   '())
#<package brotli <at> 0.1-1.e992cce gnu/packages/compression.scm:912 2928000>
#<package aseba <at> 1.6.0-0.3b35de8 gnu/packages/robotics.scm:79 3199e40>
#<package cool-retro-term <at> 1.0.1-1.dd799cf gnu/packages/terminals.scm:446 2e28b40>
#<package termite <at> 13 gnu/packages/terminals.scm:102 2e25240>
#<package wget2 <at> 1.0.0 gnu/packages/wget.scm:126 2728900>
#<package zile-on-guile <at> 2.4.14-0.fd09781 gnu/packages/zile.scm:83 3c660c0>
$8 = #t

`~Eric

[0001-git-download-Fix-recursive-checkouts.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at 30833 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 30833 <at> debbugs.gnu.org
Subject: Re: [bug#30833] [PATCH] git-download: Fix recursive checkouts.
Date: Sat, 17 Mar 2018 22:24:51 +0100

Hi Eric,

Eric Bavier <ericbavier <at> centurylink.net> skribis:

> The attached patch fixes a regression in recursive git checkouts of
> package source, which I believe was introduced in
> 6dff905e51202bbdebbad8811b6509584d12a796 (2017-09-05!)

Indeed, good catch!

> From 7798ecb3e61b042e4af3c0501f32d6b8888c1a13 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier <at> member.fsf.org>
> Date: Thu, 15 Mar 2018 23:25:01 -0500
> Subject: [PATCH] git-download: Fix recursive checkouts.
>
> * guix/git-download.scm (git-fetch)<build>: Fix match on INPUTS, which may
> contain package outputs.

LGTM, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.