GNU bug report logs - #30812
Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit-Claudel <clement.pitclaudel <at> live.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Perl syntax highlighting regression in fix for #27613?
 (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Date: Tue, 13 Mar 2018 19:14:56 -0400

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: jeffersoncarpenter2 <at> gmail.com

Hi all,

I think the following commit was a bit too enthusiastic, as variables like @temp are now highlighted in font-lock-type-face.

diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -181,4 +181,5 @@
      ;;
-     ;; Fontify local and my keywords as types.
-     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
+     ;; Fontify declarators and prefixes as types.
+     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
+     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
      ;;

Am I missing something? (I don't speak Perl, so I noticed this in a regression test)

Clément.

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.